commit 7aa2c6c30fa407dc2bad994c8ba8143adcd64c3b
author Lorne Mitchell <lomitch@microsoft.com> Wed Apr 03 03:50:10 2019 +0000
committer Commit Bot <commit-bot@chromium.org> Wed Apr 03 03:50:10 2019 +0000
tree 5ead15ddc8c6131f78f582cecd76f478a6272224
parent 85d37f05a9d3ee7bb57996ef668255521e146f0d

DevTools: Enabled check_localization presubmit script

* Enabled the check_localization presubmit script.
* Fixed localization issues caught by the check_localization presubmit script.
* Updated the check_localization script to allow contatenation of non-alphabetic strings with localized strings.
  * For example, ls`Status Code` + ": " is a valid concatenation. This allows for decorations to be concatenated with localized strings.

Change-Id: I741940c9ebdac363ac0ccad3f7de20d508204e2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544878
Auto-Submit: Lorne Mitchell <lomitch@microsoft.com>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#647134}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7a329cb73b0b5d5cddb89a34fd7da6cb1a3c87dd

PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 5fadb7a..68de82a 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -202,7 +202,7 @@
     results = []
     results.extend(_CheckBuildGN(input_api, output_api))
     results.extend(_CheckFormat(input_api, output_api))
-    # results.extend(_CheckDevtoolsLocalization(input_api, output_api))
+    results.extend(_CheckDevtoolsLocalization(input_api, output_api))
     results.extend(_CheckDevtoolsStyle(input_api, output_api))
     results.extend(_CompileDevtoolsFrontend(input_api, output_api))
     results.extend(_CheckConvertSVGToPNGHashes(input_api, output_api))