Gitiles
Code Review Sign In
gerrit.openfyde.cn / chromium.googlesource.com / devtools / devtools-frontend / 7a19b64c0a03cb739ec195fde5c47d10e82f576d
commit7a19b64c0a03cb739ec195fde5c47d10e82f576d[log] [tgz]
authorAndrés Olivares <andoli@chromium.org>Wed Feb 08 09:43:21 2023 +0000
committerDevtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Feb 09 15:29:58 2023 +0000
treea417c7cc21412d1e80eca6fa7c313f84d61ff7c6
parent6b45419a60e369ab2c150026bf6e0958df0e9d55 [diff]
[RPP] Refactor the `draw` function into multiple functions for simplicity

The `draw` function in the FlameChart class draws the perf panel flame
chart into the canvas. Due to the complexity of the data being drawn and
little use of helper functions, the function was too long and hard to
understand.

This CL splits the function into multiple helper functions, aiming to
improve readability. Each function is also documented with a short
description.

Bug: 1386091
Change-Id: I24b5325b4d1ed133d4ae81bd5c4c54149e59fc8b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4231014
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Nancy Li <nancyly@chromium.org>
1 file changed
tree: a417c7cc21412d1e80eca6fa7c313f84d61ff7c6
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. front_end/
  7. inspector_overlay/
  8. node_modules/
  9. scripts/
  10. test/
  11. third_party/
  12. v8/
  13. .clang-format
  14. .editorconfig
  15. .eslintignore
  16. .eslintrc.js
  17. .gitattributes
  18. .gitignore
  19. .gn
  20. .mailmap
  21. .npmignore
  22. .npmrc
  23. .style.yapf
  24. .stylelintignore
  25. .stylelintrc.json
  26. AUTHORS
  27. BUILD.gn
  28. codereview.settings
  29. DEPS
  30. LICENSE
  31. OWNERS
  32. package-lock.json
  33. package.json
  34. PRESUBMIT.py
  35. README.md
  36. tsconfig.json
  37. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Project documentation

Check out the project documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch