Only lint changed CSS files
Previously, we'd always lint all CSS files, even the unchanged ones,
because the --files switch was missing in the call to
run_lint_check_css.js, so it would fall back to the **/*.css glob.
Another drive-by is that it corrects two typos, one of them introduced
in my last CL, the other preventing a full lint in case a stylelint
source file or configuration file was changed.
Bug: chromium:1166108
Change-Id: Ia574d77a0fcacddc82238fe5b51a02b375aaa457
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692146
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 97ffbbd..382a6f8 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -281,22 +281,21 @@
input_api.os_path.join(input_api.PresubmitLocalPath(),
'.stylelintignore'),
input_api.os_path.join(scripts_directory, 'test',
- 'run_lint_check_css.py'),
+ 'run_lint_check_css.js'),
]
lint_config_files = _getAffectedFiles(input_api, stylelint_related_files,
- [],
- ['.json', '.py', '.stylelintignore'])
+ [], [])
css_should_bail_out, css_files_to_lint = _getFilesToLint(
input_api, output_api, lint_config_files, default_linted_directories,
['.css'], results)
if not css_should_bail_out:
- script_args = ["--syntax", "html", "--files"] + ts_files_to_lint
+ script_args = ["--files"] + css_files_to_lint
results.extend(
_checkWithNodeScript(input_api, output_api, lint_path,
- css_files_to_lint))
+ script_args))
ts_should_bail_out, ts_files_to_lint = _getFilesToLint(
input_api, output_api, lint_config_files, default_linted_directories,