commit 609679bdac7a69dc0aea39fc822669a2d4026b4e
author Mandy Chen <mandy.chen@microsoft.com> Tue Sep 10 16:04:08 2019 +0000
committer Commit Bot <commit-bot@chromium.org> Tue Sep 10 16:04:08 2019 +0000
tree 862424998fe749fb0593f49fe5816e1932bd5749
parent ef16e33abb218e753c7b39870aecb70d6c5edb48

DevTools: Localize geolocations

The city names in settings are not localized because the localization
parser doesn't know about them. Modify the parser to recognize these
strings.

Bug: 941561
Change-Id: If1974dd471b3d646c900dea6932f427a273c19f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769300
Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Mandy Chen <mandy.chen@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#695189}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6c93ef31f05965de3b56da700067b57890cfd1ef

scripts/localization_utils/check_localized_strings.js

diff --git a/scripts/localization_utils/check_localized_strings.js b/scripts/localization_utils/check_localized_strings.js
index 148740e..d2ac8e6 100644
--- a/scripts/localization_utils/check_localized_strings.js
+++ b/scripts/localization_utils/check_localized_strings.js
@@ -115,6 +115,11 @@
           if (option.text !== undefined)
             addString(option.text, option.text, filePath);
         }
+      } else if (key === 'defaultValue' && Array.isArray(extension[key])) {
+        for (const defaultVal of extension[key]) {
+          if (defaultVal.title)
+            addString(defaultVal.title, defaultVal.title, filePath);
+        }
       }
     }
   }