Fix presubmit check to always run when generated files change
We are changing the build output in the generated file, but were not
properly checking that these were changed, as the presubmit check
was ignoring files in the `front_end/generated` folder.
Also fix the issue where the InspectorBackendCommands.js would be
changed to not emit the typedef.
R=szuend@chromium.org
Bug: 1011811
Change-Id: I2e09bce9cae69f4191d93de177b5ab5bb7da46c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2115630
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 73e742a..c33ef30 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -210,6 +210,7 @@
blink_directory_path = input_api.os_path.join(input_api.PresubmitLocalPath(), 'third_party', 'blink')
protocol_location = input_api.os_path.join(blink_directory_path, 'public', 'devtools_protocol')
scripts_build_path = input_api.os_path.join(input_api.PresubmitLocalPath(), 'scripts', 'build')
+ scripts_generated_output_path = input_api.os_path.join(input_api.PresubmitLocalPath(), 'front_end', 'generated')
generated_aria_path = input_api.os_path.join(scripts_build_path, 'generate_aria.py')
generated_supported_css_path = input_api.os_path.join(scripts_build_path, 'generate_supported_css.py')
@@ -225,7 +226,8 @@
generated_supported_css_path,
concatenate_protocols_path,
generated_protocol_path,
- ], [], ['.pdl', '.json5', '.py'])
+ scripts_generated_output_path,
+ ], [], ['.pdl', '.json5', '.py', '.js'])
if len(affected_files) == 0:
return []