commit 5c46b7e37a955256a3a2142a104ab50685611f75
author cjamcl@google.com <cjamcl@google.com> Tue Dec 04 14:44:47 2018 +0000
committer Commit Bot <commit-bot@chromium.org> Tue Dec 04 14:44:47 2018 +0000
tree d16f2ec80215fd159a6d19092da028ebf3c582b9
parent ef3555df96dcdea8f92d285730fbd9ac64902398

[DevTools] Audits: Fix broken DOM node revealing

Bug: 911402
Change-Id: I095e52915fd8fafb00c2e0adfbded2d35eb51ff3
Reviewed-on: https://chromium-review.googlesource.com/c/1359856
Commit-Queue: Connor Clark <cjamcl@google.com>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613545}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a3ea44603d0ea32e222f5d03d4677867558502a9

front_end/audits2/Audits2ReportRenderer.js

diff --git a/front_end/audits2/Audits2ReportRenderer.js b/front_end/audits2/Audits2ReportRenderer.js
index 1110290..24030c4 100644
--- a/front_end/audits2/Audits2ReportRenderer.js
+++ b/front_end/audits2/Audits2ReportRenderer.js
@@ -40,15 +40,15 @@
       /** @type {!DetailsRenderer.NodeDetailsJSON} */
       const detailsItem = origElement.dataset;
       if (!detailsItem.path)
-        return;
+        continue;
 
       const nodeId = await domModel.pushNodeByPathToFrontend(detailsItem.path);
 
       if (!nodeId)
-        return;
+        continue;
       const node = domModel.nodeForId(nodeId);
       if (!node)
-        return;
+        continue;
 
       const element =
           await Common.Linkifier.linkify(node, /** @type {!Common.Linkifier.Options} */ ({title: detailsItem.snippet}));