Reland "Add script that checks license headers of JavaScript files"
This reverts commit 27f15d113aa302bb3f93421ab1ff62f1734b9c36.
Reason for revert: script is fixed on Windows
Original change's description:
> Revert "Add script that checks license headers of JavaScript files"
>
> This reverts commit 6122ebd2f94da85ec430709dea158e2395610a55.
>
> Reason for revert: Presubmit fails on windows due to relative
> path comparison with excluded files
>
> Original change's description:
> > Add script that checks license headers of JavaScript files
> >
> > The script checks if the license header is the BSD-3 license header that
> > DevTools is licensed under. It excludes files that have license headers
> > that reference non-Google/non-Chromium authors or are third_party
> > bundles that are checked into a non-third_party folder.
> >
> > Change-Id: I35f78036b48d3d7b7dcb9db1e070691282e27a02
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2016747
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> > Reviewed-by: Liviu Rau <liviurau@chromium.org>
> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
>
> TBR=bmeurer@chromium.org,aerotwist@chromium.org,tvanderlippe@chromium.org,liviurau@chromium.org
>
> Change-Id: Idc27e9b78d5ac314176c71f8f4a7a2257da08be9
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2019019
> Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
> Reviewed-by: Brandon Goddard <brgoddar@microsoft.com>
> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
TBR=bmeurer@chromium.org,aerotwist@chromium.org,lomitch@microsoft.com,brgoddar@microsoft.com,tvanderlippe@chromium.org,liviurau@chromium.org
Change-Id: I191665c8e3fdbee7f3c5c312b5ba00513502e080
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2019021
Reviewed-by: Fabio Rocha <fabio.rocha@microsoft.com>
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 4d2046a..f8a8a45 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -88,6 +88,11 @@
return _checkWithNodeScript(input_api, output_api, script_path)
+def _CheckLicenses(input_api, output_api):
+ script_path = input_api.os_path.join(input_api.PresubmitLocalPath(), 'scripts', 'test', 'run_license_header_check.js')
+ return _checkWithNodeScript(input_api, output_api, script_path)
+
+
def _CheckUnitTests(input_api, output_api):
unittest_root = input_api.os_path.join(input_api.PresubmitLocalPath(), 'test')
affected_unittest_files = _getAffectedFiles(input_api, [unittest_root], ['D'], ['.ts'])
@@ -243,6 +248,7 @@
results.extend(input_api.canned_checks.CheckGenderNeutral(input_api, output_api))
results.extend(_CheckBuildGN(input_api, output_api))
results.extend(_CheckJSON(input_api, output_api))
+ results.extend(_CheckLicenses(input_api, output_api))
results.extend(_CheckDevtoolsStyle(input_api, output_api))
results.extend(_CheckFormat(input_api, output_api))
results.extend(_CheckOptimizeSVGHashes(input_api, output_api))