commit 51474196c064bb27ace486155996ba7405161f16
author Paul Lewis <aerotwist@chromium.org> Thu Jan 09 16:02:22 2020 +0000
committer Commit Bot <commit-bot@chromium.org> Thu Jan 09 17:12:21 2020 +0000
tree 19f090ede8fc68bcaf8924208c665a975cfbfb48
parent b4e2a0741b9fb4ed9577478d7659d6cb0e84aed8

Migrates audits/ to ESM internally

Bug: 1006759
Change-Id: I8a8d88f00c2c039dd9effe8335f3e7c1bc5bb4a4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1993343
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

front_end/audits/AuditsController.js

diff --git a/front_end/audits/AuditsController.js b/front_end/audits/AuditsController.js
index cf15210..fd1f5fe 100644
--- a/front_end/audits/AuditsController.js
+++ b/front_end/audits/AuditsController.js
@@ -6,14 +6,14 @@
  * @implements {SDK.SDKModelObserver<!SDK.ServiceWorkerManager>}
  * @unrestricted
  */
-class AuditController extends Common.Object {
+export class AuditController extends Common.Object {
   constructor(protocolService) {
     super();
 
     protocolService.registerStatusCallback(
-        message => this.dispatchEventToListeners(Audits.Events.AuditProgressChanged, {message}));
+        message => this.dispatchEventToListeners(Events.AuditProgressChanged, {message}));
 
-    for (const preset of Audits.Presets) {
+    for (const preset of Presets) {
       preset.setting.addChangeListener(this.recomputePageAuditability.bind(this));
     }
 
@@ -90,7 +90,7 @@
    * @return {boolean}
    */
   _hasAtLeastOneCategory() {
-    return Audits.Presets.some(preset => preset.setting.get());
+    return Presets.some(preset => preset.setting.get());
   }
 
   /**
@@ -155,7 +155,7 @@
       // DevTools handles all the emulation. This tells Lighthouse to not bother with emulation.
       internalDisableDeviceScreenEmulation: true
     };
-    for (const runtimeSetting of Audits.RuntimeSettings) {
+    for (const runtimeSetting of RuntimeSettings) {
       runtimeSetting.setFlags(flags, runtimeSetting.setting.get());
     }
     return flags;
@@ -166,7 +166,7 @@
    */
   getCategoryIDs() {
     const categoryIDs = [];
-    for (const preset of Audits.Presets) {
+    for (const preset of Presets) {
       if (preset.setting.get()) {
         categoryIDs.push(preset.configID);
       }
@@ -200,7 +200,7 @@
       helpText = unauditablePageMessage;
     }
 
-    this.dispatchEventToListeners(Audits.Events.PageAuditabilityChanged, {helpText});
+    this.dispatchEventToListeners(Events.PageAuditabilityChanged, {helpText});
   }
 }
 
@@ -287,28 +287,3 @@
   RequestAuditStart: Symbol('RequestAuditStart'),
   RequestAuditCancel: Symbol('RequestAuditCancel'),
 };
-
-/* Legacy exported object */
-self.Audits = self.Audits || {};
-
-/* Legacy exported object */
-Audits = Audits || {};
-
-/**
- * @constructor
- */
-Audits.AuditController = AuditController;
-
-/** @typedef {{setting: !Common.Setting, configID: string, title: string, description: string}} */
-Audits.Preset;
-
-Audits.Events = Events;
-
-/** @typedef {{setting: !Common.Setting, description: string, setFlags: function(!Object, string), options: (!Array|undefined), title: (string|undefined)}} */
-Audits.RuntimeSetting;
-
-/** @type {!Array.<!Audits.RuntimeSetting>} */
-Audits.RuntimeSettings = RuntimeSettings;
-
-/** @type {!Array.<!Audits.Preset>} */
-Audits.Presets = Presets;