commit 4fd355cc40e2392987a17339663fa86d3c472a8d
author Yang Guo <yangguo@google.com> Thu Sep 19 10:59:03 2019 +0200
committer Yang Guo <yangguo@google.com> Mon Oct 21 08:08:56 2019 +0200
tree 2f07426c181e067eb1df3d1a66d618505193d542
parent d638d21ae7e6d2ec9d06122ebe18cdbac6cb30f2

Switch to new repository

PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 5c3c6ae..f674eff 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -173,15 +173,24 @@
                 results.append(output_api.PresubmitError(("%s:%d uses ::shadow selector") % (f.LocalPath(), line_number)))
     return results
 
+def _CommonChecks(input_api, output_api):
+  """Checks common to both upload and commit."""
+  results = []
+  results.extend(input_api.canned_checks.CheckOwnersFormat(input_api, output_api))
+  results.extend(input_api.canned_checks.CheckOwners(input_api, output_api))
+  results.extend(input_api.canned_checks.CheckChangeHasNoCrAndHasOnlyOneEol(input_api, output_api))
+  results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace(input_api, output_api))
+  results.extend(input_api.canned_checks.CheckGenderNeutral(input_api, output_api))
+  results.extend(_CheckDevtoolsLocalizableResources(input_api, output_api))
+  results.extend(_CheckDevtoolsLocalization(input_api, output_api))
+  return results
 
 def CheckChangeOnUpload(input_api, output_api):
     results = []
+    results.extend(_CommonChecks(input_api, output_api))
     results.extend(_CheckBuildGN(input_api, output_api))
     results.extend(_CheckFormat(input_api, output_api))
-    results.extend(_CheckDevtoolsLocalizableResources(input_api, output_api))
-    results.extend(_CheckDevtoolsLocalization(input_api, output_api))
     results.extend(_CheckDevtoolsStyle(input_api, output_api))
-    results.extend(_CompileDevtoolsFrontend(input_api, output_api))
     results.extend(_CheckOptimizeSVGHashes(input_api, output_api))
     results.extend(_CheckCSSViolations(input_api, output_api))
     return results
@@ -189,8 +198,9 @@
 
 def CheckChangeOnCommit(input_api, output_api):
     results = []
-    results.extend(_CheckDevtoolsLocalizableResources(input_api, output_api))
-    results.extend(_CheckDevtoolsLocalization(input_api, output_api))
+    results.extend(_CommonChecks(input_api, output_api))
+    results.extend(input_api.canned_checks.CheckChangeHasDescription(
+      input_api, output_api))
     return results