commit 3f7003495f3a8451c5c127e96a236652efa6de63
author Connor Clark <cjamcl@google.com> Thu Jul 25 02:10:41 2019 +0000
committer Commit Bot <commit-bot@chromium.org> Thu Jul 25 02:10:41 2019 +0000
tree c9055bd2691c6a7f7cbf2dea4cc1e697b149402d
parent 820354768ba5abf14045ba1796f7bf4ea59b23aa

DevTools: [Audits] Roll Lighthouse 5.2.0

https://github.com/GoogleChrome/lighthouse/releases/tag/v5.2.0

Bug: 772558

Change-Id: I38d7869d2f70c5e04d99f8d04565aa755b5b725a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717591
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#680705}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8b464bafc4baba3c5636f2459101656f9e52dc62

front_end/audits/AuditsController.js

diff --git a/front_end/audits/AuditsController.js b/front_end/audits/AuditsController.js
index a1c3600..1ab901a 100644
--- a/front_end/audits/AuditsController.js
+++ b/front_end/audits/AuditsController.js
@@ -142,7 +142,10 @@
    * @return {!Object}
    */
   getFlags() {
-    const flags = {};
+    const flags = {
+      // DevTools handles all the emulation. This tells Lighthouse to not bother with emulation.
+      deviceScreenEmulationMethod: 'provided'
+    };
     for (const runtimeSetting of Audits.RuntimeSettings)
       runtimeSetting.setFlags(flags, runtimeSetting.setting.get());
     return flags;
@@ -237,9 +240,8 @@
     setting: Common.settings.createSetting('audits.device_type', 'mobile'),
     description: ls`Apply mobile emulation during auditing`,
     setFlags: (flags, value) => {
-      flags._devtoolsEmulationType = value;
       // See Audits.AuditsPanel._setupEmulationAndProtocolConnection()
-      flags.emulatedFormFactor = 'none';
+      flags.emulatedFormFactor = value;
     },
     options: [
       {label: ls`Mobile`, value: 'mobile'},