Audits: Roll Lighthouse 5.7.0. Introduces community plugins and pub ads.
Lighthouse master has breaking pre-6.0 changes, so we are cherry-picking a few things on top of 5.6.0.
Cherry-picks from master:
- d53284cf12e680cbe6a12429cc1c6c4219e7ef43 icu error
- 466bd6f79e57950d736de5edfa9642a40f1100fd verbose i18n
- 7c16d346593d86b33945d75a996829e1a25b4fed flatten
PRs not yet in master, but merged into 5.7.0::
- https://github.com/GoogleChrome/lighthouse/pull/9377 internalDisableDeviceScreenEmulation
- https://github.com/GoogleChrome/lighthouse/pull/9936 Bundling pubads
Screenshot: https://imgur.com/a/XuHkgWk
Bug: 772558
Change-Id: I4a03965ec879119a88faf40dbdca471a9a33e794
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1900472
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
diff --git a/front_end/audits/AuditsController.js b/front_end/audits/AuditsController.js
index 9d48c88..2f0be02 100644
--- a/front_end/audits/AuditsController.js
+++ b/front_end/audits/AuditsController.js
@@ -153,7 +153,7 @@
getFlags() {
const flags = {
// DevTools handles all the emulation. This tells Lighthouse to not bother with emulation.
- deviceScreenEmulationMethod: 'provided'
+ internalDisableDeviceScreenEmulation: true
};
for (const runtimeSetting of Audits.RuntimeSettings) {
runtimeSetting.setFlags(flags, runtimeSetting.setting.get());
@@ -241,6 +241,13 @@
title: ls`SEO`,
description: ls`Is this page optimized for search engine results ranking`
},
+ {
+ setting: Common.settings.createSetting('audits.cat_pubads', false),
+ plugin: true,
+ configID: 'lighthouse-plugin-publisher-ads',
+ title: ls`Publisher Ads`,
+ description: ls`Is this page optimized for ad speed and quality`
+ },
];
/** @typedef {{setting: !Common.Setting, description: string, setFlags: function(!Object, string), options: (!Array|undefined), title: (string|undefined)}} */