DevTools: Fix strings in the Audits frontpage to use localization function
Some strings in Audits page are not localizable. This patch fixes these issues
by wrapping the strings with `ls` template literal.
Change-Id: I0a4a8a3594ecb46c13e51d324d3300f21d1a11c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600375
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#657894}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 14664049ff2109695272cecc20057ed55aa3e185
diff --git a/front_end/audits2/Audits2Controller.js b/front_end/audits2/Audits2Controller.js
index d2ea2f8..92835a3 100644
--- a/front_end/audits2/Audits2Controller.js
+++ b/front_end/audits2/Audits2Controller.js
@@ -199,32 +199,32 @@
{
setting: Common.settings.createSetting('audits2.cat_perf', true),
configID: 'performance',
- title: 'Performance',
- description: 'How long does this app take to show content and become usable'
+ title: ls`Performance`,
+ description: ls`How long does this app take to show content and become usable`
},
{
setting: Common.settings.createSetting('audits2.cat_pwa', true),
configID: 'pwa',
- title: 'Progressive Web App',
- description: 'Does this page meet the standard of a Progressive Web App'
+ title: ls`Progressive Web App`,
+ description: ls`Does this page meet the standard of a Progressive Web App`
},
{
setting: Common.settings.createSetting('audits2.cat_best_practices', true),
configID: 'best-practices',
- title: 'Best practices',
- description: 'Does this page follow best practices for modern web development'
+ title: ls`Best practices`,
+ description: ls`Does this page follow best practices for modern web development`
},
{
setting: Common.settings.createSetting('audits2.cat_a11y', true),
configID: 'accessibility',
- title: 'Accessibility',
- description: 'Is this page usable by people with disabilities or impairments'
+ title: ls`Accessibility`,
+ description: ls`Is this page usable by people with disabilities or impairments`
},
{
setting: Common.settings.createSetting('audits2.cat_seo', true),
configID: 'seo',
- title: 'SEO',
- description: 'Is this page optimized for search engine results ranking'
+ title: ls`SEO`,
+ description: ls`Is this page optimized for search engine results ranking`
},
];
@@ -262,17 +262,17 @@
{
label: ls`Simulated Slow 4G, 4x CPU Slowdown`,
value: 'default',
- title: 'Throttling is simulated, resulting in faster audit runs with similar measurement accuracy'
+ title: ls`Throttling is simulated, resulting in faster audit runs with similar measurement accuracy`
},
{
label: ls`Applied Slow 4G, 4x CPU Slowdown`,
value: 'devtools',
- title: 'Typical DevTools throttling, with actual traffic shaping and CPU slowdown applied'
+ title: ls`Typical DevTools throttling, with actual traffic shaping and CPU slowdown applied`
},
{
label: ls`No throttling`,
value: 'off',
- title: 'No network or CPU throttling used. (Useful when not evaluating performance)'
+ title: ls`No network or CPU throttling used. (Useful when not evaluating performance)`
},
],
},