Auto-generate deprecation info from rolled blink file
We now roll a "deprecation.json5" file from blink into DevTools that
serves as the canonical source for deprecations: It contains the
english message + note for translators as well as additional
metadata such as milestone and chrome feature number.
To use the .json5 in a somewhat type-safe way, we generate
TypeScript that is type-checked against the DeprecationIssueType
from CDP.
Note that we also generate a standard UIStrings structure that
we'll import in "DeprecationIssue.ts". An alternative would be to
collect to strings directly from the .json5 but that would
complicate "npm run collect-strings" as we'd have to teach those
scripts how to parse the .json5.
DISABLE_THIRD_PARTY_CHECK=Add newly generated file
R=alexrudenko@chromium.org
Bug: 1411444
Change-Id: Ifcfd4291ebfc3a70c100ba4a5fbefc485d4a5493
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4227691
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index c161748..c75ed43 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -440,6 +440,8 @@
generated_aria_path = input_api.os_path.join(scripts_build_path, 'generate_aria.py')
generated_supported_css_path = input_api.os_path.join(scripts_build_path, 'generate_supported_css.py')
+ generated_deprecation_path = input_api.os_path.join(
+ scripts_build_path, 'generate_deprecations.py')
generated_protocol_path = input_api.os_path.join(scripts_build_path, 'code_generator_frontend.py')
generated_protocol_typescript_path = input_api.os_path.join(
input_api.PresubmitLocalPath(), 'scripts', 'protocol_typescript')
@@ -453,6 +455,7 @@
'pyjson5'),
generated_aria_path,
generated_supported_css_path,
+ generated_deprecation_path,
concatenate_protocols_path,
generated_protocol_path,
scripts_generated_output_path,