Revert "Cleanup path handling in collect-strings"
This reverts commit 7b72fbf5d6af5c59645b222d4c151290eeb1768d.
Reason for revert: speculative revert based on https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_win64/b8843551589142089360/overview
Original change's description:
> Cleanup path handling in collect-strings
>
> While reading through this script I spotted a lot of duplication
> of `front_end` in its path handling. Since we assume that all
> strings are collected from `front_end/`, we can pass in that
> path and use that, cleaning up most of the path concatenation
> in the script.
>
> DISABLE_THIRD_PARTY_CHECK=Path handling fixes in collect-strings
> R=szuend@chromium.org
>
> Bug: none
> Change-Id: I0e7d004ad4d1d16f92cd88f3fed94dfe4c4108b0
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2982134
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Bug: none
Change-Id: I6e1ac7046950f78aa7339efb21559ff60f3d50f7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2982147
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 76735f0..4891379 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -455,9 +455,7 @@
]
script_path = input_api.os_path.join(devtools_root, 'third_party', 'i18n',
'collect-strings.js')
- results.extend(
- _checkWithNodeScript(input_api, output_api, script_path,
- [devtools_front_end]))
+ results.extend(_checkWithNodeScript(input_api, output_api, script_path))
results.append(
output_api.PresubmitNotifyResult(
'Please commit en-US.json/en-XL.json if changes are generated.'))