commit 1d6e57a0e314d709029cac52b98898b828f45a12
author Tim van der Lippe <tvanderlippe@chromium.org> Mon Sep 30 11:55:34 2019 +0000
committer Commit Bot <commit-bot@chromium.org> Mon Sep 30 11:55:34 2019 +0000
tree 597a15659e3845a97779af856addeeb3fbb9f68e
parent 9278806591e64473315401707afdba6a774a109d

Always add braces to single-line if-statements

The Chromium/Google style guides does not enforce curly braces for
single-line if-statements, but does strongly recommend doing so. Adding
braces will improve code readability, by visually separating code
blocks. This will also prevent issues where accidental additions are
pushed to the "else"-clause instead of in the if-block.

This CL also updates the presubmit `eslint` to run the fix with the
correct configuration. It will now fix all issues it can fix.

Change-Id: I4b616f21a99393f168dec743c0bcbdc7f5db04a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821526
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jeff Fisher <jeffish@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#701070}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7e0bdbe2d7f9fc2386bfaefda3cc29c66ccc18f9

front_end/audits/AuditsController.js

diff --git a/front_end/audits/AuditsController.js b/front_end/audits/AuditsController.js
index 1ab901a..23b2b99 100644
--- a/front_end/audits/AuditsController.js
+++ b/front_end/audits/AuditsController.js
@@ -13,8 +13,9 @@
     protocolService.registerStatusCallback(
         message => this.dispatchEventToListeners(Audits.Events.AuditProgressChanged, {message}));
 
-    for (const preset of Audits.Presets)
+    for (const preset of Audits.Presets) {
       preset.setting.addChangeListener(this.recomputePageAuditability.bind(this));
+    }
 
     SDK.targetManager.observeModels(SDK.ServiceWorkerManager, this);
     SDK.targetManager.addEventListener(
@@ -26,8 +27,9 @@
    * @param {!SDK.ServiceWorkerManager} serviceWorkerManager
    */
   modelAdded(serviceWorkerManager) {
-    if (this._manager)
+    if (this._manager) {
       return;
+    }
 
     this._manager = serviceWorkerManager;
     this._serviceWorkerListeners = [
@@ -45,8 +47,9 @@
    * @param {!SDK.ServiceWorkerManager} serviceWorkerManager
    */
   modelRemoved(serviceWorkerManager) {
-    if (this._manager !== serviceWorkerManager)
+    if (this._manager !== serviceWorkerManager) {
       return;
+    }
 
     Common.EventTarget.removeEventListeners(this._serviceWorkerListeners);
     this._manager = null;
@@ -57,22 +60,26 @@
    * @return {boolean}
    */
   _hasActiveServiceWorker() {
-    if (!this._manager)
+    if (!this._manager) {
       return false;
+    }
 
     const mainTarget = this._manager.target();
-    if (!mainTarget)
+    if (!mainTarget) {
       return false;
+    }
 
     const inspectedURL = mainTarget.inspectedURL().asParsedURL();
     const inspectedOrigin = inspectedURL && inspectedURL.securityOrigin();
     for (const registration of this._manager.registrations().values()) {
-      if (registration.securityOrigin !== inspectedOrigin)
+      if (registration.securityOrigin !== inspectedOrigin) {
         continue;
+      }
 
       for (const version of registration.versions.values()) {
-        if (version.controlledClients.length > 1)
+        if (version.controlledClients.length > 1) {
           return true;
+        }
       }
     }
 
@@ -90,8 +97,9 @@
    * @return {?string}
    */
   _unauditablePageMessage() {
-    if (!this._manager)
+    if (!this._manager) {
       return null;
+    }
 
     const mainTarget = this._manager.target();
     const inspectedURL = mainTarget && mainTarget.inspectedURL();
@@ -111,8 +119,9 @@
     const runtimeModel = mainTarget.model(SDK.RuntimeModel);
     const executionContext = runtimeModel && runtimeModel.defaultExecutionContext();
     let inspectedURL = mainTarget.inspectedURL();
-    if (!executionContext)
+    if (!executionContext) {
       return inspectedURL;
+    }
 
     // Evaluate location.href for a more specific URL than inspectedURL provides so that SPA hash navigation routes
     // will be respected and audited.
@@ -146,8 +155,9 @@
       // DevTools handles all the emulation. This tells Lighthouse to not bother with emulation.
       deviceScreenEmulationMethod: 'provided'
     };
-    for (const runtimeSetting of Audits.RuntimeSettings)
+    for (const runtimeSetting of Audits.RuntimeSettings) {
       runtimeSetting.setFlags(flags, runtimeSetting.setting.get());
+    }
     return flags;
   }
 
@@ -157,8 +167,9 @@
   getCategoryIDs() {
     const categoryIDs = [];
     for (const preset of Audits.Presets) {
-      if (preset.setting.get())
+      if (preset.setting.get()) {
         categoryIDs.push(preset.configID);
+      }
     }
     return categoryIDs;
   }
@@ -168,8 +179,9 @@
    * @return {!Promise<string>}
    */
   async getInspectedURL(options) {
-    if (options && options.force || !this._inspectedURL)
+    if (options && options.force || !this._inspectedURL) {
       this._inspectedURL = await this._evaluateInspectedURL();
+    }
     return this._inspectedURL;
   }