Reland "Reland "Update stylelint to 14.0.1""
This reverts commit 2b4a9df2d922bb9d183fe2f816da40dda2e87790.
Reason for revert: subsequent presubmit uploads should be fixed now.
Original change's description:
> Revert "Reland "Update stylelint to 14.0.1""
>
> This reverts commit f2ea2c940dd62b3295047e03959c89c237e216c8.
>
> Reason for revert: https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8831129368825517985/overview
>
> Original change's description:
> > Reland "Update stylelint to 14.0.1"
> >
> > This reverts commit 6c0f161c95acd70706aeed4e1167ab1c28f88eee.
> >
> > Reason for revert: the prerequisite CL (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259703) has landed
> >
> > Original change's description:
> > > Revert "Update stylelint to 14.0.1"
> > >
> > > This reverts commit 1e08ee816bab192a7d295d2f457be97bd88c09c1.
> > >
> > > Reason for revert: tree is closed due to errors https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/8169/overview
> > >
> > > Original change's description:
> > > > Update stylelint to 14.0.1
> > > >
> > > > This also upgrades PostCSS to 8.3.11.
> > > >
> > > > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
> > > > R=szuend@chromium.org
> > > >
> > > > Bug: none
> > > > Change-Id: I606540b03509d7c6e73f3d490327cd4174e03d31
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259541
> > > > Reviewed-by: Simon Zünd <szuend@chromium.org>
> > > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> > >
> > > Bug: none
> > > Change-Id: Icb1c02b41dbccc3b4fc5760f5dd0b78eca078b61
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263399
> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > Owners-Override: Alex Rudenko <alexrudenko@chromium.org>
> > > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
> >
> > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
> >
> > Bug: none
> > Change-Id: If132a67ee4253d27114caedd66c5ee61c774a6c7
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264206
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
> > Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
>
> Bug: none
> Change-Id: Idc6c9f5cc1e225c752799461eb0344e94b4ad1e5
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264222
> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
Bug: none
Change-Id: I609941d48b46bfcf454b03dcc75a76d460fbe674
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264223
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
diff --git a/node_modules/stylelint/lib/utils/isStandardSyntaxDeclaration.js b/node_modules/stylelint/lib/utils/isStandardSyntaxDeclaration.js
index 7362513..89894bd 100644
--- a/node_modules/stylelint/lib/utils/isStandardSyntaxDeclaration.js
+++ b/node_modules/stylelint/lib/utils/isStandardSyntaxDeclaration.js
@@ -1,7 +1,7 @@
'use strict';
const isScssVariable = require('./isScssVariable');
-const { isRoot } = require('./typeGuards');
+const { isRoot, isRule } = require('./typeGuards');
/**
* @param {string} [lang]
@@ -18,13 +18,15 @@
module.exports = function (decl) {
const prop = decl.prop;
const parent = decl.parent;
+ const value = decl.value;
// Declarations belong in a declaration block or standard CSS source
if (
+ parent &&
isRoot(parent) &&
parent.source &&
!isStandardSyntaxLang(
- /** @type {import('postcss').NodeSource & {lang?: string}} */ (parent.source).lang,
+ /** @type {import('postcss').Source & {lang?: string}} */ (parent.source).lang,
)
) {
return false;
@@ -35,18 +37,27 @@
return false;
}
+ // SCSS map and list declarations
+ if (value.startsWith('(') && value.endsWith(')')) {
+ return false;
+ }
+
// Less var (e.g. @var: x), but exclude variable interpolation (e.g. @{var})
if (prop[0] === '@' && prop[1] !== '{') {
return false;
}
+ // Less map declaration
+ if (parent && parent.type === 'atrule' && parent.raws.afterName === ':') {
+ return false;
+ }
+
// Sass nested properties (e.g. border: { style: solid; color: red; })
if (
- // @ts-ignore TODO TYPES selector does not exists
+ parent &&
+ isRule(parent) &&
parent.selector &&
- // @ts-ignore
parent.selector[parent.selector.length - 1] === ':' &&
- // @ts-ignore
parent.selector.substring(0, 2) !== '--'
) {
return false;