Fixes string interpolation in exclusive changes dir
Change-Id: I2a06155b184e197b25ed97a6f3f1e09595af97a2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1946475
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 7eb165f..044d37f 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -59,6 +59,7 @@
affected_files = input_api.LocalPaths()
num_affected = len(affected_files)
for dirs in EXCLUSIVE_CHANGE_DIRECTORIES:
+ dir_list = ', '.join(dirs)
affected_in_dir = filter(lambda f: FileIsInDir(f, dirs), affected_files)
num_in_dir = len(affected_in_dir)
if num_in_dir == 0:
@@ -69,9 +70,8 @@
if num_in_dir < num_affected:
return [
output_api
- .PresubmitError('CLs that affect files in "%s" should be limited to these files/directories.' +
- ' You can disable this check by adding DISABLE_THIRD_PARTY_CHECK=<reason> to your commit message' %
- ', '.join(dirs))
+ .PresubmitError(('CLs that affect files in "%s" should be limited to these files/directories.' % dir_list) +
+ ' You can disable this check by adding DISABLE_THIRD_PARTY_CHECK=<reason> to your commit message')
]
return []