commit 05c18ce6636a5dcc62e86a7cf42ed6aaa73d3194
author Patrick Hulce <phulce@chromium.org> Thu May 24 00:34:56 2018 +0000
committer Commit Bot <commit-bot@chromium.org> Thu May 24 00:34:56 2018 +0000
tree 68887e176fe39e393a7ebb0fc03682d6779f1668
parent 5eb776bb75dec1974492ca906a454b8b5a6611d3

DevTools: Audits2 UI Polish

- Convert dropdowns to radio/checkbox inputs
- Resize icons/line height/padding
- Overlay size fix
- Minor typographic adjustments
- Disable start audit button when on active view

BUG=844331,844334,844374,844352,844324,844318

Change-Id: Ieb87ce0994031c69a260bddf83f8ad995c8ea70c
Reviewed-on: https://chromium-review.googlesource.com/1066302
Commit-Queue: Patrick Hulce <phulce@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#561332}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d59f3187f7909c54af5b971d92415461a24faeb5

front_end/audits2/Audits2Controller.js

diff --git a/front_end/audits2/Audits2Controller.js b/front_end/audits2/Audits2Controller.js
index 6a58490..a33681c 100644
--- a/front_end/audits2/Audits2Controller.js
+++ b/front_end/audits2/Audits2Controller.js
@@ -198,7 +198,7 @@
 };
 
 
-/** @typedef {{type: string, setting: !Common.Setting, configID: string, title: string, description: string}} */
+/** @typedef {{setting: !Common.Setting, configID: string, title: string, description: string}} */
 Audits2.Preset;
 
 /** @type {!Array.<!Audits2.Preset>} */
@@ -236,44 +236,41 @@
   },
 ];
 
-/** @typedef {{setting: !Common.Setting, description: string, setFlags: function(!Object, string), options: !Array}} */
+/** @typedef {{setting: !Common.Setting, description: string, setFlags: function(!Object, string), options: (!Array|undefined), title: (string|undefined)}} */
 Audits2.RuntimeSetting;
 
 /** @type {!Array.<!Audits2.RuntimeSetting>} */
 Audits2.RuntimeSettings = [
   {
     setting: Common.settings.createSetting('audits2.device_type', 'mobile'),
-    description: Common.UIString('Apply mobile emulation during auditing'),
+    description: ls`Apply mobile emulation during auditing`,
     setFlags: (flags, value) => {
       flags.disableDeviceEmulation = value === 'desktop';
     },
     options: [
-      {label: Common.UIString('Mobile'), value: 'mobile'},
-      {label: Common.UIString('Desktop'), value: 'desktop'},
+      {label: ls`Mobile`, value: 'mobile'},
+      {label: ls`Desktop`, value: 'desktop'},
     ],
   },
   {
     setting: Common.settings.createSetting('audits2.throttling', 'default'),
-    description: Common.UIString('Apply network and CPU throttling during performance auditing'),
+    description: ls`Apply network and CPU throttling during performance auditing`,
     setFlags: (flags, value) => {
       flags.disableNetworkThrottling = value === 'off';
       flags.disableCpuThrottling = value === 'off';
     },
     options: [
-      {label: Common.UIString('3G w/ CPU slowdown'), value: 'default'},
-      {label: Common.UIString('No throttling'), value: 'off'},
+      {label: ls`Fast 3G with 4x CPU Slowdown`, value: 'default'},
+      {label: ls`No throttling`, value: 'off'},
     ],
   },
   {
-    setting: Common.settings.createSetting('audits2.storage_reset', 'on'),
-    description: Common.UIString('Reset storage (localStorage, IndexedDB, etc) to a clean baseline before auditing'),
+    setting: Common.settings.createSetting('audits2.clear_storage', true),
+    title: ls`Clear storage`,
+    description: ls`Reset storage (localStorage, IndexedDB, etc) to a clean baseline before auditing`,
     setFlags: (flags, value) => {
-      flags.disableStorageReset = value === 'off';
+      flags.disableStorageReset = !value;
     },
-    options: [
-      {label: Common.UIString('Clear storage'), value: 'on'},
-      {label: Common.UIString('Preserve storage'), value: 'off'},
-    ],
   },
 ];