CHROMIUM: upstart: Hack out the "re-exec" feature
Upstart has a feature where if you send a TERM to the `init` process
that it will cause upstart to re-exec. We have no use for this feature
in the normal running of the system and, in the very least, it's found
that sending a TERM to `init` during the reboot process causes upstart
to crash and the kernel to panic (claiming "Attempted to kill init").
Let's just hack this change out of upstart. We won't do a full
deletion of all code related to re-exec because (presumably) that
would be harder to resolve with any other upstream changes (if there
are any).
NOTE that this means that anyone deploying a new version of upstart
needs to reboot for it to take effect vs trying to get the new version
to load by `kill -TERM 1`. This is probably a better test anyway
(you're not testing in a special re-exec mode) and luckily reboot is
very fast on Chromebooks.
BUG=b:261373856
TEST=Hacking a `kill -TERM 1` into chromeos_shutdown doesn't crash
Change-Id: I1cbd0225e79b406f18074285393c78045d12437b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/upstart/+/4206718
Reviewed-by: Sarthak Kukreti <sarthakkukreti@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Douglas Anderson <dianders@chromium.org>
Commit-Queue: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>
1 file changed