blob: f24285ddac68b4fa32ba0b5751e58114ae0cfe0f [file] [log] [blame]
Jörg Thalheim3e67e5c2017-05-01 02:26:56 +02001#!/usr/bin/env python3
Zbigniew Jędrzejewski-Szmek35df7442017-11-18 17:32:46 +01002# SPDX-License-Identifier: LGPL-2.1+
3#
Martin Pittb2ad12e2010-09-21 12:45:52 +02004# Simple udev rules syntax checker
5#
6# (C) 2010 Canonical Ltd.
7# Author: Martin Pitt <martin.pitt@ubuntu.com>
8#
Kay Sievers0228a7e2013-08-14 22:55:40 +02009# systemd is free software; you can redistribute it and/or modify it
10# under the terms of the GNU Lesser General Public License as published by
11# the Free Software Foundation; either version 2.1 of the License, or
Martin Pittb2ad12e2010-09-21 12:45:52 +020012# (at your option) any later version.
Kay Sievers0228a7e2013-08-14 22:55:40 +020013
14# systemd is distributed in the hope that it will be useful, but
15# WITHOUT ANY WARRANTY; without even the implied warranty of
16# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
17# Lesser General Public License for more details.
Martin Pittb2ad12e2010-09-21 12:45:52 +020018#
Kay Sievers0228a7e2013-08-14 22:55:40 +020019# You should have received a copy of the GNU Lesser General Public License
20# along with systemd; If not, see <http://www.gnu.org/licenses/>.
Martin Pittb2ad12e2010-09-21 12:45:52 +020021
22import re
23import sys
Martin Pitte8015e62015-01-20 20:50:35 +010024import os
25from glob import glob
Martin Pittb2ad12e2010-09-21 12:45:52 +020026
Zbigniew Jędrzejewski-Szmek6b97bf22017-11-22 12:42:28 +010027rules_files = sys.argv[1:]
28if not rules_files:
29 sys.exit('Specify files to test as arguments')
Martin Pittb2ad12e2010-09-21 12:45:52 +020030
Franck Bui905ca722018-02-23 16:54:40 +010031no_args_tests = re.compile(r'(ACTION|DEVPATH|KERNELS?|NAME|SYMLINK|SUBSYSTEMS?|DRIVERS?|TAG|PROGRAM|RESULT|TEST)\s*(?:=|!)=\s*"([^"]*)"$')
Zbigniew Jędrzejewski-Szmekcda39972016-12-01 18:29:54 -050032args_tests = re.compile(r'(ATTRS?|ENV|TEST){([a-zA-Z0-9/_.*%-]+)}\s*(?:=|!)=\s*"([^"]*)"$')
Franck Bui905ca722018-02-23 16:54:40 +010033no_args_assign = re.compile(r'(NAME|SYMLINK|OWNER|GROUP|MODE|TAG|RUN|LABEL|GOTO|OPTIONS|IMPORT)\s*(?:\+=|:=|=)\s*"([^"]*)"$')
Zbigniew Jędrzejewski-Szmekcda39972016-12-01 18:29:54 -050034args_assign = re.compile(r'(ATTR|ENV|IMPORT|RUN){([a-zA-Z0-9/_.*%-]+)}\s*(=|\+=)\s*"([^"]*)"$')
Martin Pittb2ad12e2010-09-21 12:45:52 +020035
36result = 0
37buffer = ''
Martin Pitte8015e62015-01-20 20:50:35 +010038for path in rules_files:
Zbigniew Jędrzejewski-Szmek29563952017-11-22 12:29:46 +010039 print('# looking at {}'.format(path))
Martin Pittb2ad12e2010-09-21 12:45:52 +020040 lineno = 0
41 for line in open(path):
42 lineno += 1
43
44 # handle line continuation
45 if line.endswith('\\\n'):
46 buffer += line[:-2]
47 continue
48 else:
49 line = buffer + line
50 buffer = ''
51
52 # filter out comments and empty lines
53 line = line.strip()
54 if not line or line.startswith('#'):
55 continue
56
57 for clause in line.split(','):
58 clause = clause.strip()
59 if not (no_args_tests.match(clause) or args_tests.match(clause) or
60 no_args_assign.match(clause) or args_assign.match(clause)):
61
Zbigniew Jędrzejewski-Szmek29563952017-11-22 12:29:46 +010062 print('Invalid line {}:{}: {}'.format(path, lineno, line))
63 print(' clause:', clause)
64 print()
Martin Pittb2ad12e2010-09-21 12:45:52 +020065 result = 1
66 break
67
68sys.exit(result)