Revert "geometry: Apply LCHS values for boot devices"
This reverts commit 9caa19be0e534c687081fbdfcd301406e728c98c.
diff --git a/src/block.c b/src/block.c
index ca23a83..f73ec18 100644
--- a/src/block.c
+++ b/src/block.c
@@ -69,17 +69,9 @@
* Disk geometry translation
****************************************************************/
-static int
-overriden_lchs_supplied(struct drive_s *drive)
-{
- return drive->lchs.cylinder || drive->lchs.head || drive->lchs.sector;
-}
-
static u8
get_translation(struct drive_s *drive)
{
- if (overriden_lchs_supplied(drive))
- return TRANSLATION_MACHINE;
u8 type = drive->type;
if (CONFIG_QEMU && type == DTYPE_ATA) {
// Emulators pass in the translation info via nvram.
@@ -167,16 +159,6 @@
break;
}
break;
- case TRANSLATION_MACHINE:
- desc = "overriden";
- cylinders = drive->lchs.cylinder;
- heads = drive->lchs.head;
- if (heads > 255)
- heads = 255;
- spt = drive->lchs.sector;
- if (spt > 63)
- spt = 63;
- break;
}
// clip to 1024 cylinders in lchs
if (cylinders > 1024)
@@ -441,8 +423,7 @@
u16 options = 0;
if (GET_GLOBALFLAT(drive_gf->type) == DTYPE_ATA) {
u8 translation = GET_GLOBALFLAT(drive_gf->translation);
- if ((translation != TRANSLATION_NONE) &&
- (translation != TRANSLATION_MACHINE)) {
+ if (translation != TRANSLATION_NONE) {
options |= 1<<3; // CHS translation
if (translation == TRANSLATION_LBA)
options |= 1<<9;
diff --git a/src/block.h b/src/block.h
index 12f27ee..f64e880 100644
--- a/src/block.h
+++ b/src/block.h
@@ -90,7 +90,6 @@
#define TRANSLATION_LBA 1
#define TRANSLATION_LARGE 2
#define TRANSLATION_RECHS 3
-#define TRANSLATION_MACHINE 4
#define EXTTYPE_FLOPPY 0
#define EXTTYPE_HD 1
diff --git a/src/hw/ahci.c b/src/hw/ahci.c
index d45b430..45dc661 100644
--- a/src/hw/ahci.c
+++ b/src/hw/ahci.c
@@ -594,7 +594,6 @@
, ata_extract_version(buffer));
port->prio = bootprio_find_ata_device(ctrl->pci_tmp, pnr, 0);
}
- boot_lchs_find_ata_device(ctrl->pci_tmp, pnr, 0, &(port->drive.lchs));
return 0;
}
diff --git a/src/hw/ata.c b/src/hw/ata.c
index f788ce7..b6e073c 100644
--- a/src/hw/ata.c
+++ b/src/hw/ata.c
@@ -755,10 +755,6 @@
int prio = bootprio_find_ata_device(adrive->chan_gf->pci_tmp,
adrive->chan_gf->chanid,
adrive->slave);
- boot_lchs_find_ata_device(adrive->chan_gf->pci_tmp,
- adrive->chan_gf->chanid,
- adrive->slave,
- &(adrive->drive.lchs));
boot_add_cd(&adrive->drive, desc, prio);
}
@@ -809,10 +805,6 @@
int prio = bootprio_find_ata_device(adrive->chan_gf->pci_tmp,
adrive->chan_gf->chanid,
adrive->slave);
- boot_lchs_find_ata_device(adrive->chan_gf->pci_tmp,
- adrive->chan_gf->chanid,
- adrive->slave,
- &(adrive->drive.lchs));
// Register with bcv system.
boot_add_hd(&adrive->drive, desc, prio);
diff --git a/src/hw/esp-scsi.c b/src/hw/esp-scsi.c
index cc25f22..ffd86d0 100644
--- a/src/hw/esp-scsi.c
+++ b/src/hw/esp-scsi.c
@@ -181,8 +181,6 @@
char *name = znprintf(MAXDESCSIZE, "esp %pP %d:%d",
llun->pci, llun->target, llun->lun);
- boot_lchs_find_scsi_device(llun->pci, llun->target, llun->lun,
- &(llun->drive.lchs));
int prio = bootprio_find_scsi_device(llun->pci, llun->target, llun->lun);
int ret = scsi_drive_setup(&llun->drive, name, prio);
free(name);
diff --git a/src/hw/lsi-scsi.c b/src/hw/lsi-scsi.c
index cbaa2ac..d5fc3e4 100644
--- a/src/hw/lsi-scsi.c
+++ b/src/hw/lsi-scsi.c
@@ -158,8 +158,6 @@
lsi_scsi_init_lun(llun, tmpl_llun->pci, tmpl_llun->iobase,
tmpl_llun->target, lun);
- boot_lchs_find_scsi_device(llun->pci, llun->target, llun->lun,
- &(llun->drive.lchs));
char *name = znprintf(MAXDESCSIZE, "lsi %pP %d:%d",
llun->pci, llun->target, llun->lun);
int prio = bootprio_find_scsi_device(llun->pci, llun->target, llun->lun);
diff --git a/src/hw/megasas.c b/src/hw/megasas.c
index 87b8bee..d267580 100644
--- a/src/hw/megasas.c
+++ b/src/hw/megasas.c
@@ -225,7 +225,6 @@
free(mlun);
return -1;
}
- boot_lchs_find_scsi_device(pci, target, lun, &(mlun->drive.lchs));
name = znprintf(MAXDESCSIZE, "MegaRAID SAS (PCI %pP) LD %d:%d"
, pci, target, lun);
prio = bootprio_find_scsi_device(pci, target, lun);
diff --git a/src/hw/mpt-scsi.c b/src/hw/mpt-scsi.c
index 570b212..1faede6 100644
--- a/src/hw/mpt-scsi.c
+++ b/src/hw/mpt-scsi.c
@@ -221,8 +221,6 @@
mpt_scsi_init_lun(llun, tmpl_llun->pci, tmpl_llun->iobase,
tmpl_llun->target, lun);
- boot_lchs_find_scsi_device(llun->pci, llun->target, llun->lun,
- &(llun->drive.lchs));
char *name = znprintf(MAXDESCSIZE, "mpt %pP %d:%d",
llun->pci, llun->target, llun->lun);
int prio = bootprio_find_scsi_device(llun->pci, llun->target, llun->lun);
diff --git a/src/hw/pvscsi.c b/src/hw/pvscsi.c
index 3e5171a..9d7d68d 100644
--- a/src/hw/pvscsi.c
+++ b/src/hw/pvscsi.c
@@ -273,7 +273,6 @@
plun->iobase = iobase;
plun->ring_dsc = ring_dsc;
- boot_lchs_find_scsi_device(pci, target, lun, &(plun->drive.lchs));
char *name = znprintf(MAXDESCSIZE, "pvscsi %pP %d:%d", pci, target, lun);
int prio = bootprio_find_scsi_device(pci, target, lun);
int ret = scsi_drive_setup(&plun->drive, name, prio);
diff --git a/src/hw/virtio-blk.c b/src/hw/virtio-blk.c
index 3e615b2..88d7e54 100644
--- a/src/hw/virtio-blk.c
+++ b/src/hw/virtio-blk.c
@@ -183,8 +183,6 @@
status |= VIRTIO_CONFIG_S_DRIVER_OK;
vp_set_status(&vdrive->vp, status);
-
- boot_lchs_find_pci_device(pci, &vdrive->drive.lchs);
return;
fail:
diff --git a/src/hw/virtio-scsi.c b/src/hw/virtio-scsi.c
index e1e2f5d..a87cad8 100644
--- a/src/hw/virtio-scsi.c
+++ b/src/hw/virtio-scsi.c
@@ -121,8 +121,6 @@
virtio_scsi_init_lun(vlun, tmpl_vlun->pci, tmpl_vlun->vp, tmpl_vlun->vq,
tmpl_vlun->target, lun);
- boot_lchs_find_scsi_device(vlun->pci, vlun->target, vlun->lun,
- &(vlun->drive.lchs));
int prio = bootprio_find_scsi_device(vlun->pci, vlun->target, vlun->lun);
int ret = scsi_drive_setup(&vlun->drive, "virtio-scsi", prio);
if (ret)