commit 6de9dc640bbc75a8a867720a11b986aaa375c35a
author Todd Broch <tbroch@chromium.org> Mon Apr 09 15:23:53 2012 -0700
committer Gerrit <chrome-bot@google.com> Mon Apr 16 16:02:44 2012 -0700
tree 0f08cd61d32e5c2ef4cb0f0eeef0189106ddb008
parent 102884af4c0868101d47dccfa01673760a893ad9

hdctools: servod: Add error checking to invocation.

Following CL adds more error checking to servod invocation:

1. All servo / mini-servo's should have properly programmed iserial
  numbers which allow for proper choosing of XML configs.  However,
  servod should be tolerant of such programming failures and fall-back
  to choose configs based on product ID instead.
2. if installation requires privs ( sudo ), will return better error
  messaging and raise an exception.

BUG=none
TEST=manual

Launch servod on properly and improperly formatted iserial strings.

Change-Id: I95758745b049cfca19b0d812b4599d389adcc5d5
Reviewed-on: https://gerrit.chromium.org/gerrit/19856
Reviewed-by: Doug Anderson <dianders@chromium.org>
Commit-Ready: Todd Broch <tbroch@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>

servo/servo_server.py

diff --git a/servo/servo_server.py b/servo/servo_server.py
index a849693..4707a2d 100644
--- a/servo/servo_server.py
+++ b/servo/servo_server.py
@@ -94,10 +94,17 @@
 
     Returns:
       Instance object of interface.
+
+    Raises:
+      ServodError: If init fails
     """
     fobj = ftdigpio.Fgpio(self._vendor, self._product, interface,
                           self._serialname)
-    fobj.open()
+    try:
+      fobj.open()
+    except ftdigpio.FgpioError as e:
+      raise ServodError('Opening gpio interface. %s ( %d )' % (e.msg, e.value))
+
     return fobj
 
   def _init_i2c(self, interface):
@@ -108,13 +115,21 @@
 
     Returns:
       Instance object of interface
+
+    Raises:
+      ServodError: If init fails
     """
     fobj = ftdii2c.Fi2c(self._vendor, self._product, interface,
                         self._serialname)
-    fobj.open()
+    try:
+      fobj.open()
+    except ftdii2c.Fi2cError as e:
+      raise ServodError('Opening i2c interface. %s ( %d )' % (e.msg, e.value))
+
     # Set the frequency of operation of the i2c bus.
     # TODO(tbroch) make configureable
     fobj.setclock(MAX_I2C_CLOCK_HZ)
+
     return fobj
 
   def _init_uart(self, interface):
@@ -130,9 +145,16 @@
 
     Returns:
       Instance object of interface
+
+    Raises:
+      ServodError: If init fails
     """
     fobj = ftdiuart.Fuart(self._vendor, self._product, interface)
-    fobj.run()
+    try:
+      fobj.run()
+    except ftdiuart.FuartError as e:
+      raise ServodError('Running uart interface. %s ( %d )' % (e.msg, e.value))
+
     self._logger.info("%s" % fobj.get_pty())
     return fobj
 
@@ -149,10 +171,17 @@
 
     Returns:
       Instance objects of interface
+
+    Raises:
+      ServodError: If init fails
     """
     fgpio = self._init_gpio(interface)
     fuart = ftdiuart.Fuart(self._vendor, self._product, interface, fgpio._fc)
-    fuart.run()
+    try:
+      fuart.run()
+    except ftdiuart.FuartError as e:
+      raise ServodError('Running uart interface. %s ( %d )' % (e.msg, e.value))
+
     self._logger.info("uart pty: %s" % fuart.get_pty())
     return fgpio, fuart