Current programmer parameter syntax is
-p programmer=parameter
Unfortunately, many parameters are of the form variable=val, so we get
commandlines like this:
flashrom -p it87spi=port=0x820
and this looks horrible.
Using : instead of = would make such parameters look better:
flashrom -p it87spi:port=0x820
As a side benefit, this patch mentions the programmer name in the error
message if it is unknown.
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://coreboot.org/flashrom/trunk@693 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
diff --git a/flashrom.c b/flashrom.c
index b1f9471..b531699 100644
--- a/flashrom.c
+++ b/flashrom.c
@@ -708,7 +708,7 @@
namelen = strlen(name);
if (strncmp(optarg, name, namelen) == 0) {
switch (optarg[namelen]) {
- case '=':
+ case ':':
programmer_param = strdup(optarg + namelen + 1);
break;
case '\0':
@@ -725,7 +725,7 @@
}
}
if (programmer == PROGRAMMER_INVALID) {
- printf("Error: Unknown programmer.\n");
+ printf("Error: Unknown programmer %s.\n", optarg);
exit(1);
}
break;