eliminate magic numbers indicating maximum column sizes in print_supported_chipsets and print_supported_boards_helper
without this the magic numbers need to be kept in sync with the maximum length of the
strings printed in the corresponding column. if not, an overflow and a nasty ' '-storm occur
on executing flashrom -L.
Signed-off-by: Stefan Tauner <stefan.tauner@student.tuwien.ac.at>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
git-svn-id: svn://coreboot.org/flashrom/trunk@1318 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
diff --git a/programmer.h b/programmer.h
index b68aa88..e1147f1 100644
--- a/programmer.h
+++ b/programmer.h
@@ -145,7 +145,7 @@
struct penable {
uint16_t vendor_id;
uint16_t device_id;
- int status;
+ int status; /* OK=0 and NT=1 are defines only. Beware! */
const char *vendor_name;
const char *device_name;
int (*doit) (struct pci_dev *dev, const char *name);
@@ -174,10 +174,10 @@
uint16_t second_card_vendor;
uint16_t second_card_device;
- /* Pattern to match DMI entries */
+ /* Pattern to match DMI entries. May be NULL. */
const char *dmi_pattern;
- /* The vendor / part name from the coreboot table. */
+ /* The vendor / part name from the coreboot table. May be NULL. */
const char *lb_vendor;
const char *lb_part;
@@ -188,7 +188,7 @@
int max_rom_decode_parallel;
int status;
- int (*enable) (void);
+ int (*enable) (void); /* May be NULL. */
};
extern const struct board_pciid_enable board_pciid_enables[];