Fix pickling of long integers.
shifting more than the number of bits in the type yields undefined results.
diff --git a/common/pickle.hpp b/common/pickle.hpp
index 60694fa..41667e6 100644
--- a/common/pickle.hpp
+++ b/common/pickle.hpp
@@ -300,12 +300,15 @@
return;
}
- unsigned c = 1;
// Same as l >> (8 * sizeof l), but without the warnings
T sign = l < 0 ? ~0 : 0;
- while ((l >> (8 * c)) != sign) {
+
+ T sl = l;
+ unsigned c = 0;
+ do {
++c;
- }
+ } while (sl >>= 8 != sign);
+
// Add an extra byte if sign bit doesn't match
if (((l >> (8 * c - 1)) & 1) != ((l >> (8 * sizeof l - 1)) & 1)) {
++c;