blob: 36f40aa77dca52228796a01a6004e44d94b752db [file] [log] [blame]
Mike Frysinger4f994402019-09-13 17:40:45 -04001#!/usr/bin/env python3
Jon Salz98255932012-08-18 14:48:02 +08002# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
Mike Frysingerae409522014-02-01 03:16:11 -05006"""Presubmit checks to run when doing `repo upload`.
7
Tom Hughes40bdce52020-08-25 08:57:03 -07008You can add new checks by adding a function to the HOOKS constants.
Mike Frysingerae409522014-02-01 03:16:11 -05009"""
10
Keigo Okadd908822019-06-04 11:30:25 +090011import argparse
Alex Deymo643ac4c2015-09-03 10:40:50 -070012import collections
Mike Frysingerf252cfc2019-12-09 17:34:28 -050013import configparser
Keigo Oka7e880ac2019-07-03 15:03:43 +090014import datetime
Daniel Erate3ea3fc2015-02-13 15:27:52 -070015import fnmatch
Jon Salz3ee59de2012-08-18 13:54:22 +080016import functools
Dale Curtis2975c432011-05-03 17:25:20 -070017import json
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070018import os
Stephen Boyd6bf5ea82020-10-15 00:02:07 -070019import pathlib
Ryan Cuiec4d6332011-05-02 14:15:25 -070020import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070021import sys
Peter Ammon811f6702014-06-12 15:45:38 -070022import stat
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -050023import subprocess
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070024
Ryan Cui1562fb82011-05-09 11:01:31 -070025from errors import (VerifyException, HookFailure, PrintErrorForProject,
26 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070027
Mike Frysinger919c7032019-09-13 17:48:08 -040028if __name__ in ('__builtin__', 'builtins'):
Mike Frysinger653cd262019-09-20 14:05:02 -040029 # If repo imports us, the __name__ will be __builtin__, and the cwd will be in
30 # the top level of the checkout (i.e. $CHROMEOS_CHECKOUT). chromite will be
31 # in that directory, so add it to our path. This works whether we're running
32 # the repo in $CHROMEOS_CHECKOUT/.repo/repo/ or a custom version in a
33 # completely different tree.
34 # TODO(vapier): Python 2 used "__builtin__" while Python 3 uses "builtins".
Mike Frysinger6850d512018-05-21 12:12:14 -040035 sys.path.insert(0, os.getcwd())
36
Mike Frysinger653cd262019-09-20 14:05:02 -040037elif __name__ == '__main__':
38 # If we're run directly, we'll find chromite relative to the repohooks dir in
39 # $CHROMEOS_CHECKOUT/src/repohooks, so go up two dirs.
David Jamesc3b68b32013-04-03 09:17:03 -070040 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
41
Mike Frysingerfd481ce2019-09-13 18:14:48 -040042# The sys.path monkey patching confuses the linter.
43# pylint: disable=wrong-import-position
Mike Frysinger66142932014-12-18 14:55:57 -050044from chromite.lib import commandline
Rahul Chaudhry0e515342015-08-07 12:00:43 -070045from chromite.lib import cros_build_lib
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050046from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070047from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070048from chromite.lib import patch
Mike Frysingered1b95a2019-12-12 19:04:51 -050049from chromite.lib import terminal
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040050from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070051
Mike Frysingerff4768e2020-02-27 18:48:13 -050052
53assert sys.version_info >= (3, 6), 'This module requires Python 3.6+'
54
55
Vadim Bendebury2b62d742014-06-22 13:14:51 -070056PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070057
Mike Frysingered9b2a02019-12-12 18:52:32 -050058
59# Link to commit message documentation for users.
60DOC_COMMIT_MSG_URL = ('https://chromium.googlesource.com/chromiumos/docs/+/HEAD'
61 '/contributing.md#commit-messages')
62
63
Ryan Cuiec4d6332011-05-02 14:15:25 -070064COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050065 # C++ and friends
Mike Frysinger24dd3c52019-08-17 14:22:48 -040066 r'.*\.c$', r'.*\.cc$', r'.*\.cpp$', r'.*\.h$', r'.*\.m$', r'.*\.mm$',
67 r'.*\.inl$', r'.*\.asm$', r'.*\.hxx$', r'.*\.hpp$', r'.*\.s$', r'.*\.S$',
Mike Frysingerae409522014-02-01 03:16:11 -050068 # Scripts
Mike Frysinger24dd3c52019-08-17 14:22:48 -040069 r'.*\.js$', r'.*\.py$', r'.*\.sh$', r'.*\.rb$', r'.*\.pl$', r'.*\.pm$',
Bob Haarman0dc1f942020-10-03 00:06:59 +000070 # No extension at all, note that ALL CAPS files are excluded by
Mike Frysingerae409522014-02-01 03:16:11 -050071 # COMMON_EXCLUDED_LIST below.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040072 r'(^|.*[\\\/])[^.]+$',
Mike Frysingerae409522014-02-01 03:16:11 -050073 # Other
Mike Frysinger24dd3c52019-08-17 14:22:48 -040074 r'.*\.java$', r'.*\.mk$', r'.*\.am$',
Harry Cutts24a75b62020-12-04 12:03:14 -080075 r'.*\.policy$', r'.*\.rules$', r'.*\.conf$', r'.*\.go$',
Mike Frysinger24dd3c52019-08-17 14:22:48 -040076 r'(^OWNERS|/OWNERS)',
Ryan Cuiec4d6332011-05-02 14:15:25 -070077]
78
Ryan Cui1562fb82011-05-09 11:01:31 -070079
Ryan Cuiec4d6332011-05-02 14:15:25 -070080COMMON_EXCLUDED_PATHS = [
Daniel Erate3ea3fc2015-02-13 15:27:52 -070081 # For ebuild trees, ignore any caches and manifest data.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040082 r'.*/Manifest$',
Mike Frysingereb6b60d2021-02-10 01:16:49 -050083 r'.*/files/srcuris$',
Mike Frysinger24dd3c52019-08-17 14:22:48 -040084 r'.*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$',
Doug Anderson5bfb6792011-10-25 16:45:41 -070085
Daniel Erate3ea3fc2015-02-13 15:27:52 -070086 # Ignore profiles data (like overlay-tegra2/profiles).
Mike Frysinger24dd3c52019-08-17 14:22:48 -040087 r'(^|.*/)overlay-.*/profiles/.*',
88 r'^profiles/.*$',
Mike Frysinger98638102014-08-28 00:15:08 -040089
C Shapiro8f90e9b2017-06-28 09:54:50 -060090 # Ignore config files in ebuild setup.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040091 r'(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*',
92 r'^chromeos-base/chromeos-bsp.*/files/.*',
C Shapiro8f90e9b2017-06-28 09:54:50 -060093
Daniel Erate3ea3fc2015-02-13 15:27:52 -070094 # Ignore minified js and jquery.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040095 r'.*\.min\.js',
96 r'.*jquery.*\.js',
Mike Frysinger33a458d2014-03-03 17:00:51 -050097
98 # Ignore license files as the content is often taken verbatim.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040099 r'.*/licenses/.*',
Alex Klein619c0912019-01-30 17:13:23 -0700100
Mike Frysinger13650402019-07-31 14:31:46 -0400101 # Exclude generated protobuf bindings.
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400102 r'.*_pb2\.py$',
103 r'.*\.pb\.go$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700104]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700105
Ken Turnerd07564b2018-02-08 17:57:59 +1100106LICENSE_EXCLUDED_PATHS = [
LaMont Jones775c2b32020-02-19 17:32:54 -0700107 r'^(.*/)?OWNERS(\..*)?$',
Tom Hughes90b7bd42020-11-10 10:31:49 -0800108 r'^(.*/)?DIR_METADATA(\..*)?$',
Ken Turnerd07564b2018-02-08 17:57:59 +1100109]
Ryan Cui1562fb82011-05-09 11:01:31 -0700110
Ryan Cui9b651632011-05-11 11:38:58 -0700111_CONFIG_FILE = 'PRESUBMIT.cfg'
112
113
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700114# File containing wildcards, one per line, matching files that should be
115# excluded from presubmit checks. Lines beginning with '#' are ignored.
116_IGNORE_FILE = '.presubmitignore'
117
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700118BLOCKED_TERMS_FILE = 'blocked_terms.txt'
119UNBLOCKED_TERMS_FILE = 'unblocked_terms.txt'
120
Allen Webb00c74ba2021-04-14 10:20:56 -0500121# Android internal and external projects use "Bug: " to track bugs in
122# buganizer, so use Bug: and Test: instead of BUG= and TEST=.
123TAG_COLON_REMOTES = {
124 'aosp',
125 'goog',
126}
127
Doug Anderson44a644f2011-11-02 10:37:37 -0700128# Exceptions
129
130
131class BadInvocation(Exception):
132 """An Exception indicating a bad invocation of the program."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700133
134
Ryan Cui1562fb82011-05-09 11:01:31 -0700135# General Helpers
136
Sean Paulba01d402011-05-05 11:36:23 -0400137
Mike Frysingerb2496652019-09-12 23:35:46 -0400138class Cache(object):
139 """General helper for caching git content."""
140
141 def __init__(self):
142 self._cache = {}
143
144 def get_subcache(self, scope):
145 return self._cache.setdefault(scope, {})
146
147 def clear(self):
148 self._cache.clear()
149
150CACHE = Cache()
151
152
Alex Deymo643ac4c2015-09-03 10:40:50 -0700153Project = collections.namedtuple('Project', ['name', 'dir', 'remote'])
154
155
Mike Frysinger526a5f82019-09-13 18:05:30 -0400156def _run_command(cmd, **kwargs):
Doug Anderson44a644f2011-11-02 10:37:37 -0700157 """Executes the passed in command and returns raw stdout output.
158
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400159 This is a convenience func to set some run defaults differently.
Mike Frysinger526a5f82019-09-13 18:05:30 -0400160
Doug Anderson44a644f2011-11-02 10:37:37 -0700161 Args:
162 cmd: The command to run; should be a list of strings.
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400163 **kwargs: Same as cros_build_lib.run.
Doug Anderson44a644f2011-11-02 10:37:37 -0700164
165 Returns:
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700166 The stdout from the process (discards stderr and returncode).
Doug Anderson44a644f2011-11-02 10:37:37 -0700167 """
Mike Frysinger526a5f82019-09-13 18:05:30 -0400168 kwargs.setdefault('print_cmd', False)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400169 kwargs.setdefault('stdout', True)
170 kwargs.setdefault('check', False)
Mike Frysinger054c1592019-11-18 03:51:54 -0500171 result = cros_build_lib.run(cmd, **kwargs)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400172 # NB: We decode this directly rather than through kwargs as our tests rely
173 # on this post-processing behavior currently.
Mike Frysinger71e643e2019-09-13 17:26:39 -0400174 return result.output.decode('utf-8', 'replace')
Ryan Cui72834d12011-05-05 14:51:33 -0700175
Ryan Cui1562fb82011-05-09 11:01:31 -0700176
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700177def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700178 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700179 if __name__ == '__main__':
180 # Works when file is run on its own (__file__ is defined)...
181 return os.path.abspath(os.path.dirname(__file__))
182 else:
183 # We need to do this when we're run through repo. Since repo executes
184 # us with execfile(), we don't get __file__ defined.
185 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
186 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700187
Ryan Cui1562fb82011-05-09 11:01:31 -0700188
Ryan Cuiec4d6332011-05-02 14:15:25 -0700189def _match_regex_list(subject, expressions):
190 """Try to match a list of regular expressions to a string.
191
192 Args:
193 subject: The string to match regexes on
194 expressions: A list of regular expressions to check for matches with.
195
196 Returns:
197 Whether the passed in subject matches any of the passed in regexes.
198 """
199 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500200 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700201 return True
202 return False
203
Ryan Cui1562fb82011-05-09 11:01:31 -0700204
Mike Frysingerae409522014-02-01 03:16:11 -0500205def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700206 """Filter out files based on the conditions passed in.
207
208 Args:
209 files: list of filepaths to filter
210 include_list: list of regex that when matched with a file path will cause it
211 to be added to the output list unless the file is also matched with a
212 regex in the exclude_list.
213 exclude_list: list of regex that when matched with a file will prevent it
214 from being added to the output list, even if it is also matched with a
215 regex in the include_list.
216
217 Returns:
218 A list of filepaths that contain files matched in the include_list and not
219 in the exclude_list.
220 """
221 filtered = []
222 for f in files:
223 if (_match_regex_list(f, include_list) and
224 not _match_regex_list(f, exclude_list)):
225 filtered.append(f)
226 return filtered
227
Ryan Cuiec4d6332011-05-02 14:15:25 -0700228
229# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700230
231
Ryan Cui4725d952011-05-05 15:41:19 -0700232def _get_upstream_branch():
233 """Returns the upstream tracking branch of the current branch.
234
235 Raises:
236 Error if there is no tracking branch
237 """
238 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
239 current_branch = current_branch.replace('refs/heads/', '')
240 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700241 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700242
243 cfg_option = 'branch.' + current_branch + '.%s'
244 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
245 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
246 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700247 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700248
249 return full_upstream.replace('heads', 'remotes/' + remote)
250
Ryan Cui1562fb82011-05-09 11:01:31 -0700251
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700252def _get_patch(commit):
253 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700254 if commit == PRE_SUBMIT:
255 return _run_command(['git', 'diff', '--cached', 'HEAD'])
256 else:
257 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700258
Ryan Cui1562fb82011-05-09 11:01:31 -0700259
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500260def _get_file_content(path, commit):
261 """Returns the content of a file at a specific commit.
262
263 We can't rely on the file as it exists in the filesystem as people might be
264 uploading a series of changes which modifies the file multiple times.
265
266 Note: The "content" of a symlink is just the target. So if you're expecting
267 a full file, you should check that first. One way to detect is that the
268 content will not have any newlines.
269 """
Mike Frysingerb2496652019-09-12 23:35:46 -0400270 # Make sure people don't accidentally pass in full paths which will never
271 # work. You need to use relative=True with _get_affected_files.
272 if path.startswith('/'):
273 raise ValueError('_get_file_content must be called with relative paths: %s'
274 % (path,))
275
276 # {<commit>: {<path1>: <content>, <path2>: <content>}}
277 cache = CACHE.get_subcache('get_file_content')
278 if path in cache:
279 return cache[path]
280
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700281 if commit == PRE_SUBMIT:
Mike Frysingerd9ed85f2021-02-03 12:38:24 -0500282 content = _run_command(['git', 'diff', 'HEAD', '--', path], stderr=True)
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700283 else:
Mike Frysingerd9ed85f2021-02-03 12:38:24 -0500284 content = _run_command(['git', 'show', '%s:%s' % (commit, path)],
285 stderr=True)
Mike Frysingerb2496652019-09-12 23:35:46 -0400286 cache[path] = content
287 return content
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500288
289
Mike Frysingerae409522014-02-01 03:16:11 -0500290def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700291 """Returns a list of (linenum, lines) tuples that the commit touched."""
Mike Frysingerb2496652019-09-12 23:35:46 -0400292 # {<commit>: {<path1>: <content>, <path2>: <content>}}
293 cache = CACHE.get_subcache('get_file_diff')
294 if path in cache:
295 return cache[path]
296
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700297 if commit == PRE_SUBMIT:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800298 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD',
Yu-Ping Wue3e47362020-09-22 15:54:40 +0800299 '--', path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700300 else:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800301 command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit,
Yu-Ping Wue3e47362020-09-22 15:54:40 +0800302 '--', path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700303 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700304
305 new_lines = []
306 line_num = 0
307 for line in output.splitlines():
308 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
309 if m:
310 line_num = int(m.groups(1)[0])
311 continue
312 if line.startswith('+') and not line.startswith('++'):
Mike Frysinger71e643e2019-09-13 17:26:39 -0400313 new_lines.append((line_num, line[1:]))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700314 if not line.startswith('-'):
315 line_num += 1
Mike Frysingerb2496652019-09-12 23:35:46 -0400316 cache[path] = new_lines
Ryan Cuiec4d6332011-05-02 14:15:25 -0700317 return new_lines
318
Ryan Cui1562fb82011-05-09 11:01:31 -0700319
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700320def _get_ignore_wildcards(directory, cache):
321 """Get wildcards listed in a directory's _IGNORE_FILE.
322
323 Args:
324 directory: A string containing a directory path.
325 cache: A dictionary (opaque to caller) caching previously-read wildcards.
326
327 Returns:
328 A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE
329 wasn't present.
330 """
331 # In the cache, keys are directories and values are lists of wildcards from
332 # _IGNORE_FILE within those directories (and empty if no file was present).
333 if directory not in cache:
334 wildcards = []
335 dotfile_path = os.path.join(directory, _IGNORE_FILE)
336 if os.path.exists(dotfile_path):
337 # TODO(derat): Consider using _get_file_content() to get the file as of
338 # this commit instead of the on-disk version. This may have a noticeable
339 # performance impact, as each call to _get_file_content() runs git.
340 with open(dotfile_path, 'r') as dotfile:
341 for line in dotfile.readlines():
342 line = line.strip()
343 if line.startswith('#'):
344 continue
345 if line.endswith('/'):
346 line += '*'
347 wildcards.append(line)
348 cache[directory] = wildcards
349
350 return cache[directory]
351
352
353def _path_is_ignored(path, cache):
354 """Check whether a path is ignored by _IGNORE_FILE.
355
356 Args:
357 path: A string containing a path.
358 cache: A dictionary (opaque to caller) caching previously-read wildcards.
359
360 Returns:
361 True if a file named _IGNORE_FILE in one of the passed-in path's parent
362 directories contains a wildcard matching the path.
363 """
364 # Skip ignore files.
365 if os.path.basename(path) == _IGNORE_FILE:
366 return True
367
368 path = os.path.abspath(path)
369 base = os.getcwd()
370
371 prefix = os.path.dirname(path)
372 while prefix.startswith(base):
373 rel_path = path[len(prefix) + 1:]
374 for wildcard in _get_ignore_wildcards(prefix, cache):
375 if fnmatch.fnmatch(rel_path, wildcard):
376 return True
377 prefix = os.path.dirname(prefix)
378
379 return False
380
381
Mike Frysinger292b45d2014-11-25 01:17:10 -0500382def _get_affected_files(commit, include_deletes=False, relative=False,
383 include_symlinks=False, include_adds=True,
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700384 full_details=False, use_ignore_files=True):
Peter Ammon811f6702014-06-12 15:45:38 -0700385 """Returns list of file paths that were modified/added, excluding symlinks.
386
387 Args:
388 commit: The commit
389 include_deletes: If true, we'll include deleted files in the result
390 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500391 include_symlinks: If true, we'll include symlinks in the result
392 include_adds: If true, we'll include new files in the result
393 full_details: If False, return filenames, else return structured results.
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700394 use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files.
Peter Ammon811f6702014-06-12 15:45:38 -0700395
396 Returns:
397 A list of modified/added (and perhaps deleted) files
398 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500399 if not relative and full_details:
400 raise ValueError('full_details only supports relative paths currently')
401
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700402 if commit == PRE_SUBMIT:
403 return _run_command(['git', 'diff-index', '--cached',
404 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500405
406 path = os.getcwd()
Mike Frysingerb2496652019-09-12 23:35:46 -0400407 # {<commit>: {<path1>: <content>, <path2>: <content>}}
408 cache = CACHE.get_subcache('get_affected_files')
409 if path not in cache:
410 cache[path] = git.RawDiff(path, '%s^!' % commit)
411 files = cache[path]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500412
413 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500414 if not include_symlinks:
415 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500416
417 if not include_deletes:
418 files = [x for x in files if x.status != 'D']
419
Mike Frysinger292b45d2014-11-25 01:17:10 -0500420 if not include_adds:
421 files = [x for x in files if x.status != 'A']
422
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700423 if use_ignore_files:
424 cache = {}
425 is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache)
426 files = [x for x in files if not is_ignored(x)]
427
Mike Frysinger292b45d2014-11-25 01:17:10 -0500428 if full_details:
429 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500430 return files
431 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500432 # Caller only cares about filenames.
433 files = [x.dst_file if x.dst_file else x.src_file for x in files]
434 if relative:
435 return files
436 else:
437 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700438
439
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700440def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700441 """Returns a list of commits for this review."""
Mike Frysingere300c7d2019-09-12 23:33:52 -0400442 cmd = ['git', 'log', '--no-merges', '--format=%H',
443 '%s..' % _get_upstream_branch()]
Ryan Cui72834d12011-05-05 14:51:33 -0700444 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700445
Ryan Cui1562fb82011-05-09 11:01:31 -0700446
Ryan Cuiec4d6332011-05-02 14:15:25 -0700447def _get_commit_desc(commit):
448 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700449 if commit == PRE_SUBMIT:
450 return ''
Mike Frysingerb2496652019-09-12 23:35:46 -0400451
452 # {<commit>: <content>}
453 cache = CACHE.get_subcache('get_commit_desc')
454 if commit not in cache:
Mike Frysinger4efdee72019-11-04 10:57:01 -0500455 cache[commit] = _run_command(['git', 'log', '--format=%B',
Mike Frysingerb2496652019-09-12 23:35:46 -0400456 commit + '^!'])
457 return cache[commit]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700458
459
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800460def _check_lines_in_diff(commit, files, check_callable, error_description):
461 """Checks given file for errors via the given check.
462
463 This is a convenience function for common per-line checks. It goes through all
464 files and returns a HookFailure with the error description listing all the
465 failures.
466
467 Args:
468 commit: The commit we're working on.
469 files: The files to check.
470 check_callable: A callable that takes a line and returns True if this line
471 _fails_ the check.
472 error_description: A string describing the error.
473 """
474 errors = []
475 for afile in files:
476 for line_num, line in _get_file_diff(afile, commit):
Bernie Thompson8e26f742020-07-23 14:32:31 -0700477 result = check_callable(line)
478 if result:
479 msg = f'{afile}, line {line_num}'
480 if isinstance(result, str):
481 msg += f': {result}'
482 errors.append(msg)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800483 if errors:
484 return HookFailure(error_description, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400485 return None
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800486
487
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900488def _parse_common_inclusion_options(options):
489 """Parses common hook options for including/excluding files.
490
491 Args:
492 options: Option string list.
493
494 Returns:
495 (included, excluded) where each one is a list of regex strings.
496 """
497 parser = argparse.ArgumentParser()
498 parser.add_argument('--exclude_regex', action='append')
499 parser.add_argument('--include_regex', action='append')
500 opts = parser.parse_args(options)
501 included = opts.include_regex or []
502 excluded = opts.exclude_regex or []
503 return included, excluded
504
505
Ryan Cuiec4d6332011-05-02 14:15:25 -0700506# Common Hooks
507
Ryan Cui1562fb82011-05-09 11:01:31 -0700508
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900509def _check_no_long_lines(_project, commit, options=()):
Mike Frysinger55f85b52014-12-18 14:45:21 -0500510 """Checks there are no lines longer than MAX_LEN in any of the text files."""
Keigo Oka9732e382019-06-28 17:44:59 +0900511 LONG_LINE_OK_PATHS = [
512 # Go has no line length limit.
513 # https://golang.org/doc/effective_go.html#formatting
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400514 r'.*\.go$',
Mike Frysingerf8961942020-05-15 00:36:31 -0400515 # Python does its own long line checks via pylint.
516 r'.*\.py$',
Keigo Oka9732e382019-06-28 17:44:59 +0900517 ]
Mike Frysinger55f85b52014-12-18 14:45:21 -0500518
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900519 DEFAULT_MAX_LENGTHS = [
520 # Java's line length limit is 100 chars.
521 # https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md
522 (r'.*\.java$', 100),
Mike Frysingerf8961942020-05-15 00:36:31 -0400523 # Rust's line length limit is 100 chars.
524 (r'.*\.rs$', 100),
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900525 ]
526
Ryan Cuiec4d6332011-05-02 14:15:25 -0700527 MAX_LEN = 80
528
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900529 included, excluded = _parse_common_inclusion_options(options)
Youkichi Hosoib9e15ab2021-03-13 04:03:48 +0900530 files = _filter_files(_get_affected_files(commit, relative=True),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900531 included + COMMON_INCLUDED_PATHS,
Keigo Oka9732e382019-06-28 17:44:59 +0900532 excluded + COMMON_EXCLUDED_PATHS + LONG_LINE_OK_PATHS)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700533
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900534 errors = []
Ryan Cuiec4d6332011-05-02 14:15:25 -0700535 for afile in files:
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700536 skip_regexps = (
537 r'https?://',
538 r'^#\s*(define|include|import|pragma|if|ifndef|endif)\b',
539 )
540
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900541 max_len = MAX_LEN
542
543 for expr, length in DEFAULT_MAX_LENGTHS:
544 if re.search(expr, afile):
545 max_len = length
546 break
547
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700548 if os.path.basename(afile).startswith('OWNERS'):
549 # File paths can get long, and there's no way to break them up into
550 # multiple lines.
551 skip_regexps += (
552 r'^include\b',
553 r'file:',
554 )
555
556 skip_regexps = [re.compile(x) for x in skip_regexps]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700557 for line_num, line in _get_file_diff(afile, commit):
558 # Allow certain lines to exceed the maxlen rule.
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900559 if len(line) <= max_len or any(x.search(line) for x in skip_regexps):
Jon Salz98255932012-08-18 14:48:02 +0800560 continue
561
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900562 errors.append('%s, line %s, %s chars, over %s chars' %
563 (afile, line_num, len(line), max_len))
Jon Salz98255932012-08-18 14:48:02 +0800564 if len(errors) == 5: # Just show the first 5 errors.
565 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700566
567 if errors:
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900568 msg = 'Found lines longer than the limit (first 5 shown):'
Ryan Cui1562fb82011-05-09 11:01:31 -0700569 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400570 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700571
Ryan Cuiec4d6332011-05-02 14:15:25 -0700572
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900573def _check_no_stray_whitespace(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700574 """Checks that there is no stray whitespace at source lines end."""
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900575 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700576 files = _filter_files(_get_affected_files(commit),
Tomasz Figa375b9622020-09-22 14:25:07 +0000577 included + COMMON_INCLUDED_PATHS + [r'^.*\.md$'],
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900578 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800579 return _check_lines_in_diff(commit, files,
580 lambda line: line.rstrip() != line,
581 'Found line ending with white space in:')
Ryan Cui1562fb82011-05-09 11:01:31 -0700582
Ryan Cuiec4d6332011-05-02 14:15:25 -0700583
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900584def _check_no_tabs(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700585 """Checks there are no unexpanded tabs."""
Mike Frysingercd134512017-10-26 04:36:33 -0400586 # Don't add entire repos here. Update the PRESUBMIT.cfg in each repo instead.
Bob Haarman0dc1f942020-10-03 00:06:59 +0000587 # We only allow known specific filetypes here that show up in all repos.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700588 TAB_OK_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400589 r'.*\.ebuild$',
590 r'.*\.eclass$',
591 r'.*\.go$',
592 r'.*/[M|m]akefile$',
593 r'.*\.mk$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700594 ]
595
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900596 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700597 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900598 included + COMMON_INCLUDED_PATHS,
599 excluded + COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800600 return _check_lines_in_diff(commit, files,
601 lambda line: '\t' in line,
602 'Found a tab character in:')
Ryan Cuiec4d6332011-05-02 14:15:25 -0700603
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800604
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700605def _read_terms_file(terms_file):
606 """Read list of words from file, skipping comments and blank lines."""
607 file_terms = set()
608 for line in osutils.ReadFile(terms_file).splitlines():
609 # Allow comment and blank lines.
610 line = line.split('#', 1)[0]
611 if not line:
612 continue
613 file_terms.add(line)
614 return file_terms
615
616
Daisuke Nojiri062a0a92021-02-14 15:38:16 -0800617def _check_keywords_in_file(project, commit, file, keywords,
618 unblocked_terms_file, opts):
619 """Checks there are no blocked keywords in a file being changed."""
620 if file:
621 # Search for UNBLOCKED_TERMS_FILE in the parent directories of the file
622 # being changed.
623 d = os.path.dirname(file)
624 while d != project.dir:
625 terms_file = os.path.join(d, UNBLOCKED_TERMS_FILE)
626 if os.path.isfile(terms_file):
627 unblocked_terms_file = terms_file
628 break
629 d = os.path.dirname(d)
Bernie Thompson8e26f742020-07-23 14:32:31 -0700630
Daisuke Nojiri062a0a92021-02-14 15:38:16 -0800631 # Read unblocked word list.
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700632 unblocked_words = _read_terms_file(unblocked_terms_file)
633 unblocked_words.update(opts.unblock)
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700634 keywords = sorted(keywords - unblocked_words)
Bernie Thompson8e26f742020-07-23 14:32:31 -0700635
636 def _check_line(line):
Laurent Chavey434af9a2020-09-28 22:25:16 +0900637 # Store information about each span matching blocking regex.
638 # to match unblocked regex with blocked reg ex match.
639 # [{'span':re.span, - overlap of matching regex in line
640 # 'group':re.group, - matching term
641 # 'blocked':bool, - True: matching blocked, False: matching unblocked
642 # 'keyword':regex, - block regex
643 # }, ...]
644 blocked_span = []
645 # Store information about each span matching unblocking regex.
646 # [re.span, ...]
647 unblocked_span = []
648
Bernie Thompson8e26f742020-07-23 14:32:31 -0700649 for word in keywords:
Laurent Chavey434af9a2020-09-28 22:25:16 +0900650 for match in re.finditer(word, line, flags=re.I):
651 blocked_span.append({'span' : match.span(),
652 'group' : match.group(0),
653 'blocked' : True,
654 'keyword' : word})
655
656 for unblocked in unblocked_words:
657 for match in re.finditer(unblocked, line, flags=re.I):
658 unblocked_span.append(match.span())
659
660 # Unblock terms that are superset of blocked terms:
661 # blocked := "this.?word"
662 # unblocked := "\.this.?word"
663 # "this line is blocked because of this1word"
664 # "this line is unblocked because of thenew.this1word"
665 #
666 for b in blocked_span:
667 for ub in unblocked_span:
668 if ub[0] <= b['span'][0] and ub[1] >= b['span'][1]:
669 b['blocked'] = False
670 if b['blocked']:
671 return f'Matched "{b["group"]}" with regex of "{b["keyword"]}"'
Bernie Thompson8e26f742020-07-23 14:32:31 -0700672 return False
673
Daisuke Nojiri062a0a92021-02-14 15:38:16 -0800674 if file:
675 return _check_lines_in_diff(commit, [file], _check_line,
676 'Found a blocked keyword in:')
Bernie Thompson8e26f742020-07-23 14:32:31 -0700677
678 line_num = 1
679 commit_desc_errors = []
680 for line in _get_commit_desc(commit).splitlines():
681 result = _check_line(line)
682 if result:
683 commit_desc_errors.append('Commit message, line %s: %s' %
684 (line_num, result))
685 line_num += 1
686 if commit_desc_errors:
Daisuke Nojiri062a0a92021-02-14 15:38:16 -0800687 return HookFailure('Found a blocked keyword in:', commit_desc_errors)
688
689 return None
690
691
692def _check_keywords(project, commit, options=()):
693 """Checks there are no blocked keywords in commit content."""
694 # Read options from override list.
695 parser = argparse.ArgumentParser()
696 parser.add_argument('--exclude_regex', action='append', default=[])
697 parser.add_argument('--include_regex', action='append', default=[])
698 parser.add_argument('--block', action='append', default=[])
699 parser.add_argument('--unblock', action='append', default=[])
700 opts = parser.parse_args(options)
701
702 # Read blocked word list.
703 blocked_terms_file = os.path.join(_get_hooks_dir(), BLOCKED_TERMS_FILE)
704 common_keywords = _read_terms_file(blocked_terms_file)
705
706 # Find unblocked word list in project root directory. If not found, global
707 # list is used.
708 unblocked_terms_file = os.path.join(_get_hooks_dir(), UNBLOCKED_TERMS_FILE)
709 if os.path.isfile(os.path.join(project.dir, UNBLOCKED_TERMS_FILE)):
710 unblocked_terms_file = os.path.join(project.dir, UNBLOCKED_TERMS_FILE)
711
712 keywords = set(common_keywords | set(opts.block))
713
714 files = _filter_files(
715 _get_affected_files(commit),
716 opts.include_regex + COMMON_INCLUDED_PATHS + [r'^.*\.md$'],
717 opts.exclude_regex + COMMON_EXCLUDED_PATHS)
718
719 errors = []
720 for file in files:
721 errs = _check_keywords_in_file(project, commit, file,
722 keywords, unblocked_terms_file, opts)
723 if errs:
724 errors.append(errs)
725
726 errs = _check_keywords_in_file(project, commit, None,
727 keywords, unblocked_terms_file, opts)
728 if errs:
729 errors.append(errs)
730
Bernie Thompson8e26f742020-07-23 14:32:31 -0700731 return errors
732
733
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900734def _check_tabbed_indents(_project, commit, options=()):
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800735 """Checks that indents use tabs only."""
736 TABS_REQUIRED_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400737 r'.*\.ebuild$',
738 r'.*\.eclass$',
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800739 ]
740 LEADING_SPACE_RE = re.compile('[\t]* ')
741
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900742 included, excluded = _parse_common_inclusion_options(options)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800743 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900744 included + TABS_REQUIRED_PATHS,
745 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800746 return _check_lines_in_diff(
747 commit, files,
748 lambda line: LEADING_SPACE_RE.match(line) is not None,
749 'Found a space in indentation (must be all tabs):')
Ryan Cui1562fb82011-05-09 11:01:31 -0700750
Ryan Cuiec4d6332011-05-02 14:15:25 -0700751
LaMont Jones872fe762020-02-10 15:36:14 -0700752def _check_gofmt(_project, commit, options=()):
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700753 """Checks that Go files are formatted with gofmt."""
LaMont Jones872fe762020-02-10 15:36:14 -0700754 included, excluded = _parse_common_inclusion_options(options)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700755 errors = []
756 files = _filter_files(_get_affected_files(commit, relative=True),
LaMont Jones872fe762020-02-10 15:36:14 -0700757 included + [r'\.go$'],
758 excluded)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700759
760 for gofile in files:
761 contents = _get_file_content(gofile, commit)
Mike Frysingeraa7dc942019-09-25 00:07:24 -0400762 output = _run_command(cmd=['gofmt', '-l'], input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500763 stderr=subprocess.STDOUT)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700764 if output:
765 errors.append(gofile)
766 if errors:
767 return HookFailure('Files not formatted with gofmt:', errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400768 return None
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700769
770
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600771def _check_rustfmt(_project, commit):
772 """Checks that Rust files are formatted with rustfmt."""
773 errors = []
774 files = _filter_files(_get_affected_files(commit, relative=True),
775 [r'\.rs$'])
776
777 for rustfile in files:
778 contents = _get_file_content(rustfile, commit)
Chirantan Ekbote1da56d52020-07-13 17:35:35 +0900779 output = _run_command(cmd=['rustfmt', '--edition', '2018'],
780 input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500781 stderr=subprocess.STDOUT)
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600782 if output != contents:
783 errors.append(rustfile)
784 if errors:
785 return HookFailure('Files not formatted with rustfmt: '
786 "(run 'cargo fmt' to fix)", errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400787 return None
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600788
789
Keiichi Watanabe6ab73fd2020-07-14 23:42:02 +0900790class CargoClippyArgumentParserError(Exception):
791 """An exception indicating an invalid check_cargo_clippy option."""
792
793
794class CargoClippyArgumentParser(argparse.ArgumentParser):
795 """A argument parser for check_cargo_clippy."""
796
797 def error(self, message):
798 raise CargoClippyArgumentParserError(message)
799
800
801# A cargo project in which clippy runs.
802ClippyProject = collections.namedtuple('ClippyProject', ('root', 'script'))
803
804
805class _AddClippyProjectAction(argparse.Action):
806 """A callback that adds a cargo clippy setting.
807
808 It accepts a value which is in the form of "ROOT[:SCRIPT]".
809 """
810
811 def __call__(self, parser, namespace, values, option_string=None):
812 if getattr(namespace, self.dest, None) is None:
813 setattr(namespace, self.dest, [])
814 spec = values.split(':', 1)
815 if len(spec) == 1:
816 spec += [None]
817
818 if spec[0].startswith('/'):
819 raise CargoClippyArgumentParserError('root path must not start with "/"'
820 f' but "{spec[0]}"')
821
822 clippy = ClippyProject(root=spec[0], script=spec[1])
823 getattr(namespace, self.dest).append(clippy)
824
825
826def _get_cargo_clippy_parser():
827 """Creates a parser for check_cargo_clippy options."""
828
829 parser = CargoClippyArgumentParser()
830 parser.add_argument('--project', action=_AddClippyProjectAction, default=[])
831
832 return parser
833
834
835def _check_cargo_clippy(project, commit, options=()):
836 """Checks that a change doesn't produce cargo-clippy errors."""
837
838 options = list(options)
839 if not options:
840 return []
841 parser = _get_cargo_clippy_parser()
842
843 try:
844 opts = parser.parse_args(options)
845 except CargoClippyArgumentParserError as e:
846 return [HookFailure('invalid check_cargo_clippy option is given.'
847 f' Please check PRESUBMIT.cfg is correct: {e}')]
848 files = _get_affected_files(commit)
849
850 errors = []
851 for clippy in opts.project:
852 root = os.path.normpath(os.path.join(project.dir, clippy.root))
853
854 # Check if any file under `root` was modified.
855 modified = False
856 for f in files:
857 if f.startswith(root):
858 modified = True
859 break
860 if not modified:
861 continue
862
863 # Clean cargo's cache when we run clippy for this `root` for the first time.
864 # We don't want to clean the cache between commits to save time when
865 # multiple commits are checked.
866 if root not in _check_cargo_clippy.cleaned_root:
867 _run_command(['cargo', 'clean',
868 f'--manifest-path={root}/Cargo.toml'],
869 stderr=subprocess.STDOUT)
870 _check_cargo_clippy.cleaned_root.add(root)
871
872 cmd = ['cargo', 'clippy', '--all-features', '--all-targets',
873 f'--manifest-path={root}/Cargo.toml',
874 '--', '-D', 'warnings']
875 # Overwrite the clippy command if a project-specific script is specified.
876 if clippy.script:
877 cmd = [os.path.join(project.dir, clippy.script)]
878
879 output = _run_command(cmd, stderr=subprocess.STDOUT)
880 error = re.search(r'^error: ', output, flags=re.MULTILINE)
881 if error:
882 msg = output[error.start():]
883 errors.append(HookFailure(msg))
884
885 return errors
886
887
888# Stores cargo projects in which `cargo clean` ran.
889_check_cargo_clippy.cleaned_root = set()
890
891
Allen Webb00c74ba2021-04-14 10:20:56 -0500892def _get_test_field_re(project):
893 """Provide the regular expression that matches the test field.
894
895 Android internal and external projects use "Bug: " in the commit messages to
896 track bugs in buganizer, so "Test: " is used instead of "TEST=".
897 """
898 if project.remote in TAG_COLON_REMOTES:
899 return r'\nTest: \S+'
900 else:
901 return r'\nTEST=\S+'
902
903
904def _check_change_has_test_field(project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700905 """Check for a non-empty 'TEST=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500906 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700907
Allen Webb00c74ba2021-04-14 10:20:56 -0500908 TEST_FIELD_RE = _get_test_field_re(project)
Cheng Yuehb707c522020-01-02 14:06:59 +0800909 if not re.search(TEST_FIELD_RE, _get_commit_desc(commit)):
Mike Frysingered9b2a02019-12-12 18:52:32 -0500910 msg = ('Changelist description needs TEST field (after first line)\n%s' %
911 (SEE_ALSO,))
Ryan Cui1562fb82011-05-09 11:01:31 -0700912 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400913 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700914
Ryan Cuiec4d6332011-05-02 14:15:25 -0700915
Mike Frysingerae409522014-02-01 03:16:11 -0500916def _check_change_has_valid_cq_depend(_project, commit):
Jason D. Clinton299e3222019-05-23 09:42:03 -0600917 """Check for a correctly formatted Cq-Depend field in the commit message."""
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700918 desc = _get_commit_desc(commit)
Jason D. Clinton299e3222019-05-23 09:42:03 -0600919 msg = 'Changelist has invalid Cq-Depend target.'
920 example = 'Example: Cq-Depend: chromium:1234, chrome-internal:2345'
David Jamesc3b68b32013-04-03 09:17:03 -0700921 try:
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700922 patch.GetPaladinDeps(desc)
David Jamesc3b68b32013-04-03 09:17:03 -0700923 except ValueError as ex:
924 return HookFailure(msg, [example, str(ex)])
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700925 # Check that Cq-Depend is in the same paragraph as Change-Id.
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500926 msg = 'Cq-Depend is not in the same paragraph as Change-Id.'
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700927 paragraphs = desc.split('\n\n')
928 for paragraph in paragraphs:
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500929 if (re.search(r'^Cq-Depend:', paragraph, re.M) and not
930 re.search('^Change-Id:', paragraph, re.M)):
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700931 return HookFailure(msg)
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500932
933 # We no longer support CQ-DEPEND= lines.
934 if re.search(r'^CQ-DEPEND[=:]', desc, re.M):
935 return HookFailure(
936 'CQ-DEPEND= is no longer supported. Please see:\n'
937 'https://chromium.googlesource.com/chromiumos/docs/+/HEAD/'
938 'contributing.md#CQ-DEPEND')
939
Mike Frysinger8cf80812019-09-16 23:49:29 -0400940 return None
David Jamesc3b68b32013-04-03 09:17:03 -0700941
942
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800943def _check_change_is_contribution(_project, commit):
944 """Check that the change is a contribution."""
945 NO_CONTRIB = 'not a contribution'
946 if NO_CONTRIB in _get_commit_desc(commit).lower():
947 msg = ('Changelist is not a contribution, this cannot be accepted.\n'
948 'Please remove the "%s" text from the commit message.') % NO_CONTRIB
949 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400950 return None
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800951
952
Alex Deymo643ac4c2015-09-03 10:40:50 -0700953def _check_change_has_bug_field(project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700954 """Check for a correctly formatted 'BUG=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500955 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
956
David James5c0073d2013-04-03 08:48:52 -0700957 OLD_BUG_RE = r'\nBUG=.*chromium-os'
958 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
959 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
960 'the chromium tracker in your BUG= line now.')
961 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700962
Alex Deymo643ac4c2015-09-03 10:40:50 -0700963 # Android internal and external projects use "Bug: " to track bugs in
964 # buganizer.
Allen Webb00c74ba2021-04-14 10:20:56 -0500965 if project.remote in TAG_COLON_REMOTES:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700966 BUG_RE = r'\nBug: ?([Nn]one|\d+)'
967 if not re.search(BUG_RE, _get_commit_desc(commit)):
968 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500969 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700970 'Bug: 9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500971 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700972 return HookFailure(msg)
973 else:
Jorge Lucangeli Obesdce214e2017-10-25 15:04:39 -0400974 BUG_RE = r'\nBUG=([Nn]one|(chromium|b):\d+)'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700975 if not re.search(BUG_RE, _get_commit_desc(commit)):
976 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500977 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700978 'BUG=chromium:9999 (for public tracker)\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700979 'BUG=b:9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500980 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700981 return HookFailure(msg)
Ryan Cui1562fb82011-05-09 11:01:31 -0700982
Allen Webb00c74ba2021-04-14 10:20:56 -0500983 TEST_BEFORE_BUG_RE = _get_test_field_re(project) + r'.*' + BUG_RE
Cheng Yuehb707c522020-01-02 14:06:59 +0800984
985 if re.search(TEST_BEFORE_BUG_RE, _get_commit_desc(commit), re.DOTALL):
986 msg = ('The BUG field must come before the TEST field.\n%s' %
987 (SEE_ALSO,))
988 return HookFailure(msg)
989
Mike Frysinger8cf80812019-09-16 23:49:29 -0400990 return None
991
Ryan Cuiec4d6332011-05-02 14:15:25 -0700992
Jack Neus8edbf642019-07-10 16:08:31 -0600993def _check_change_no_include_oem(project, commit):
994 """Check that the change does not reference OEMs."""
995 ALLOWLIST = {
996 'chromiumos/platform/ec',
997 # Used by unit tests.
998 'project',
999 }
1000 if project.name not in ALLOWLIST:
1001 return None
1002
Mike Frysingerbb34a222019-07-31 14:40:46 -04001003 TAGS = {
Jack Neus8edbf642019-07-10 16:08:31 -06001004 'Reviewed-on',
1005 'Reviewed-by',
1006 'Signed-off-by',
1007 'Commit-Ready',
1008 'Tested-by',
1009 'Commit-Queue',
Jack Neus8edbf642019-07-10 16:08:31 -06001010 'Acked-by',
1011 'Modified-by',
1012 'CC',
1013 'Suggested-by',
1014 'Reported-by',
1015 'Acked-for-chrome-by',
LaMont Jones237f3ef2020-01-22 10:40:52 -07001016 'Cq-Cl-Tag',
LaMont Jonesfb5e8bf2020-03-03 12:50:06 -07001017 'Cq-Include-Trybots',
Mike Frysingerbb34a222019-07-31 14:40:46 -04001018 }
Jack Neus8edbf642019-07-10 16:08:31 -06001019
1020 # Ignore tags, which could reasonably contain OEM names
1021 # (e.g. Reviewed-by: foo@oem.corp-partner.google.com).
Jack Neus8edbf642019-07-10 16:08:31 -06001022 commit_message = ' '.join(
Mike Frysingerbb34a222019-07-31 14:40:46 -04001023 x for x in _get_commit_desc(commit).splitlines()
1024 if ':' not in x or x.split(':', 1)[0] not in TAGS)
1025
Jack Neus8edbf642019-07-10 16:08:31 -06001026 commit_message = re.sub(r'[\s_-]+', ' ', commit_message)
1027
1028 # Exercise caution when expanding these lists. Adding a name
1029 # could indicate a new relationship with a company!
1030 OEMS = ['hp', 'hewlett packard', 'dell', 'lenovo', 'acer', 'asus', 'samsung']
1031 ODMS = [
1032 'bitland', 'compal', 'haier', 'huaqin', 'inventec', 'lg', 'pegatron',
1033 'pegatron(ems)', 'quanta', 'samsung', 'wistron'
1034 ]
1035
1036 for name_type, name_list in [('OEM', OEMS), ('ODM', ODMS)]:
1037 # Construct regex
1038 name_re = r'\b(%s)\b' % '|'.join([re.escape(x) for x in name_list])
1039 matches = [x[0] for x in re.findall(name_re, commit_message, re.IGNORECASE)]
Mike Frysingere52b1bc2019-09-16 23:45:41 -04001040 if matches:
Jack Neus8edbf642019-07-10 16:08:31 -06001041 # If there's a match, throw an error.
1042 error_msg = ('Changelist description contains the name of an'
1043 ' %s: "%s".' % (name_type, '","'.join(matches)))
1044 return HookFailure(error_msg)
1045
Mike Frysinger8cf80812019-09-16 23:49:29 -04001046 return None
1047
Jack Neus8edbf642019-07-10 16:08:31 -06001048
Mike Frysinger292b45d2014-11-25 01:17:10 -05001049def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -07001050 """Check that we're not missing a revbump of an ebuild in the given commit.
1051
1052 If the given commit touches files in a directory that has ebuilds somewhere
1053 up the directory hierarchy, it's very likely that we need an ebuild revbump
1054 in order for those changes to take effect.
1055
1056 It's not totally trivial to detect a revbump, so at least detect that an
1057 ebuild with a revision number in it was touched. This should handle the
1058 common case where we use a symlink to do the revbump.
1059
1060 TODO: it would be nice to enhance this hook to:
1061 * Handle cases where people revbump with a slightly different syntax. I see
1062 one ebuild (puppy) that revbumps with _pN. This is a false positive.
1063 * Catches cases where people aren't using symlinks for revbumps. If they
1064 edit a revisioned file directly (and are expected to rename it for revbump)
1065 we'll miss that. Perhaps we could detect that the file touched is a
1066 symlink?
1067
1068 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
1069 still better off than without this check.
1070
1071 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001072 project: The Project to look at
Doug Anderson42b8a052013-06-26 10:45:36 -07001073 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -05001074 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -07001075
1076 Returns:
1077 A HookFailure or None.
1078 """
Mike Frysinger011af942014-01-17 16:12:22 -05001079 # If this is the portage-stable overlay, then ignore the check. It's rare
1080 # that we're doing anything other than importing files from upstream, so
1081 # forcing a rev bump makes no sense.
Bob Haarman0dc1f942020-10-03 00:06:59 +00001082 allowlist = (
Mike Frysinger011af942014-01-17 16:12:22 -05001083 'chromiumos/overlays/portage-stable',
1084 )
Bob Haarman0dc1f942020-10-03 00:06:59 +00001085 if project.name in allowlist:
Mike Frysinger011af942014-01-17 16:12:22 -05001086 return None
1087
Mike Frysinger292b45d2014-11-25 01:17:10 -05001088 def FinalName(obj):
1089 # If the file is being deleted, then the dst_file is not set.
1090 if obj.dst_file is None:
1091 return obj.src_file
1092 else:
1093 return obj.dst_file
1094
Stephen Boyd6bf5ea82020-10-15 00:02:07 -07001095 def AllowedPath(obj):
Mike Frysinger78dbc242020-11-27 16:46:39 -05001096 allowed_files = {
1097 'ChangeLog', 'Manifest', 'metadata.xml', 'OWNERS', 'README.md',
1098 }
Stephen Boyd6bf5ea82020-10-15 00:02:07 -07001099 allowed_directories = {'profiles'}
1100
1101 affected = pathlib.Path(FinalName(obj))
1102 if affected.name in allowed_files:
1103 return True
1104
1105 for directory in allowed_directories:
1106 if directory in affected.parts:
1107 return True
1108
1109 return False
1110
Mike Frysinger292b45d2014-11-25 01:17:10 -05001111 affected_path_objs = _get_affected_files(
1112 commit, include_deletes=True, include_symlinks=True, relative=True,
1113 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -07001114
Stephen Boyd6bf5ea82020-10-15 00:02:07 -07001115 # Don't yell about changes to allowed files or directories...
Mike Frysinger292b45d2014-11-25 01:17:10 -05001116 affected_path_objs = [x for x in affected_path_objs
Stephen Boyd6bf5ea82020-10-15 00:02:07 -07001117 if not AllowedPath(x)]
Mike Frysinger292b45d2014-11-25 01:17:10 -05001118 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -07001119 return None
1120
1121 # If we've touched any file named with a -rN.ebuild then we'll say we're
1122 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -05001123 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
1124 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -07001125 if touched_revved_ebuild:
1126 return None
1127
Mike Frysinger292b45d2014-11-25 01:17:10 -05001128 # If we're creating new ebuilds from scratch, then we don't need an uprev.
1129 # Find all the dirs that new ebuilds and ignore their files/.
1130 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
1131 if FinalName(x).endswith('.ebuild') and x.status == 'A']
1132 affected_path_objs = [obj for obj in affected_path_objs
1133 if not any(FinalName(obj).startswith(x)
1134 for x in ebuild_dirs)]
1135 if not affected_path_objs:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001136 return None
Mike Frysinger292b45d2014-11-25 01:17:10 -05001137
Doug Anderson42b8a052013-06-26 10:45:36 -07001138 # We want to examine the current contents of all directories that are parents
1139 # of files that were touched (up to the top of the project).
1140 #
1141 # ...note: we use the current directory contents even though it may have
1142 # changed since the commit we're looking at. This is just a heuristic after
1143 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -05001144 if project_top is None:
1145 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -07001146 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -05001147 for obj in affected_path_objs:
1148 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -07001149 while os.path.exists(path) and not os.path.samefile(path, project_top):
1150 dirs_to_check.add(path)
1151 path = os.path.dirname(path)
1152
1153 # Look through each directory. If it's got an ebuild in it then we'll
1154 # consider this as a case when we need a revbump.
Gwendal Grignoua3086c32014-12-09 11:17:22 -08001155 affected_paths = set(os.path.join(project_top, FinalName(x))
1156 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -07001157 for dir_path in dirs_to_check:
1158 contents = os.listdir(dir_path)
1159 ebuilds = [os.path.join(dir_path, path)
1160 for path in contents if path.endswith('.ebuild')]
1161 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
1162
C Shapiroae157ae2017-09-18 16:24:03 -06001163 affected_paths_under_9999_ebuilds = set()
1164 for affected_path in affected_paths:
1165 for ebuild_9999 in ebuilds_9999:
1166 ebuild_dir = os.path.dirname(ebuild_9999)
1167 if affected_path.startswith(ebuild_dir):
1168 affected_paths_under_9999_ebuilds.add(affected_path)
1169
1170 # If every file changed exists under a 9999 ebuild, then skip
1171 if len(affected_paths_under_9999_ebuilds) == len(affected_paths):
1172 continue
1173
Doug Anderson42b8a052013-06-26 10:45:36 -07001174 # If the -9999.ebuild file was touched the bot will uprev for us.
1175 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -05001176 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -07001177 continue
1178
1179 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -05001180 return HookFailure('Changelist probably needs a revbump of an ebuild, '
1181 'or a -r1.ebuild symlink if this is a new ebuild:\n'
1182 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -07001183
1184 return None
1185
1186
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001187def _check_ebuild_eapi(project, commit):
Mike Frysinger948284a2018-02-01 15:22:56 -05001188 """Make sure we have people use EAPI=5 or newer with custom ebuilds.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001189
1190 We want to get away from older EAPI's as it makes life confusing and they
1191 have less builtin error checking.
1192
1193 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001194 project: The Project to look at
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001195 commit: The commit to look at
1196
1197 Returns:
1198 A HookFailure or None.
1199 """
1200 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -05001201 # that we're doing anything other than importing files from upstream, and
1202 # we shouldn't be rewriting things fundamentally anyways.
Bob Haarman0dc1f942020-10-03 00:06:59 +00001203 allowlist = (
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001204 'chromiumos/overlays/portage-stable',
1205 )
Bob Haarman0dc1f942020-10-03 00:06:59 +00001206 if project.name in allowlist:
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001207 return None
1208
Mike Frysinger948284a2018-02-01 15:22:56 -05001209 BAD_EAPIS = ('0', '1', '2', '3', '4')
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001210
1211 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
1212
1213 ebuilds_re = [r'\.ebuild$']
1214 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1215 ebuilds_re)
1216 bad_ebuilds = []
1217
1218 for ebuild in ebuilds:
1219 # If the ebuild does not specify an EAPI, it defaults to 0.
1220 eapi = '0'
1221
1222 lines = _get_file_content(ebuild, commit).splitlines()
1223 if len(lines) == 1:
1224 # This is most likely a symlink, so skip it entirely.
1225 continue
1226
1227 for line in lines:
1228 m = get_eapi.match(line)
1229 if m:
1230 # Once we hit the first EAPI line in this ebuild, stop processing.
1231 # The spec requires that there only be one and it be first, so
1232 # checking all possible values is pointless. We also assume that
1233 # it's "the" EAPI line and not something in the middle of a heredoc.
1234 eapi = m.group(1)
1235 break
1236
1237 if eapi in BAD_EAPIS:
1238 bad_ebuilds.append((ebuild, eapi))
1239
1240 if bad_ebuilds:
1241 # pylint: disable=C0301
Mike Frysingerc6114f42020-05-15 00:55:05 -04001242 url = 'https://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001243 # pylint: enable=C0301
1244 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -05001245 'These ebuilds are using old EAPIs. If these are imported from\n'
1246 'Gentoo, then you may ignore and upload once with the --no-verify\n'
Mike Frysingerc6114f42020-05-15 00:55:05 -04001247 'flag. Otherwise, please update to 7 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001248 '\t%s\n'
1249 'See this guide for more details:\n%s\n' %
1250 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
1251
Mike Frysinger8cf80812019-09-16 23:49:29 -04001252 return None
1253
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001254
Mike Frysinger89bdb852014-02-01 05:26:26 -05001255def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -05001256 """Make sure we use the new style KEYWORDS when possible in ebuilds.
1257
1258 If an ebuild generally does not care about the arch it is running on, then
1259 ebuilds should flag it with one of:
1260 KEYWORDS="*" # A stable ebuild.
1261 KEYWORDS="~*" # An unstable ebuild.
1262 KEYWORDS="-* ..." # Is known to only work on specific arches.
1263
1264 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001265 project: The Project to look at
Mike Frysingerc51ece72014-01-17 16:23:40 -05001266 commit: The commit to look at
1267
1268 Returns:
1269 A HookFailure or None.
1270 """
Bob Haarman0dc1f942020-10-03 00:06:59 +00001271 ALLOWLIST = set(('*', '-*', '~*'))
Mike Frysingerc51ece72014-01-17 16:23:40 -05001272
1273 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
1274
Mike Frysinger89bdb852014-02-01 05:26:26 -05001275 ebuilds_re = [r'\.ebuild$']
1276 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1277 ebuilds_re)
1278
Mike Frysinger8d42d742014-09-22 15:50:21 -04001279 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -05001280 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -04001281 # We get the full content rather than a diff as the latter does not work
1282 # on new files (like when adding new ebuilds).
1283 lines = _get_file_content(ebuild, commit).splitlines()
1284 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -05001285 m = get_keywords.match(line)
1286 if m:
1287 keywords = set(m.group(1).split())
Bob Haarman0dc1f942020-10-03 00:06:59 +00001288 if not keywords or ALLOWLIST - keywords != ALLOWLIST:
Mike Frysingerc51ece72014-01-17 16:23:40 -05001289 continue
1290
Mike Frysinger8d42d742014-09-22 15:50:21 -04001291 bad_ebuilds.append(ebuild)
1292
1293 if bad_ebuilds:
1294 return HookFailure(
1295 '%s\n'
1296 'Please update KEYWORDS to use a glob:\n'
1297 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
1298 ' KEYWORDS="*"\n'
1299 'If the ebuild should be marked unstable (normal for '
1300 'cros-workon / 9999 ebuilds):\n'
1301 ' KEYWORDS="~*"\n'
Mike Frysingerde8efea2015-05-17 03:42:26 -04001302 'If the ebuild needs to be marked for only specific arches, '
Mike Frysinger8d42d742014-09-22 15:50:21 -04001303 'then use -* like so:\n'
1304 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -05001305
Mike Frysinger8cf80812019-09-16 23:49:29 -04001306 return None
1307
Mike Frysingerc51ece72014-01-17 16:23:40 -05001308
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001309def _check_ebuild_licenses(_project, commit):
1310 """Check if the LICENSE field in the ebuild is correct."""
Brian Norris7a610e82016-02-17 12:24:54 -08001311 affected_paths = _get_affected_files(commit, relative=True)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001312 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
1313
1314 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -08001315 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001316
1317 for ebuild in touched_ebuilds:
Alex Kleinb5953522018-08-03 11:44:21 -06001318 # e.g. path/to/overlay/category/package/package.ebuild -> path/to/overlay
1319 overlay_path = os.sep.join(ebuild.split(os.sep)[:-3])
1320
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001321 try:
Brian Norris7a610e82016-02-17 12:24:54 -08001322 ebuild_content = _get_file_content(ebuild, commit)
Alex Kleinb5953522018-08-03 11:44:21 -06001323 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content,
1324 overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001325 except ValueError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001326 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001327
Sergey Frolovc1bd8782021-01-20 19:35:44 -07001328 # Virtual packages must use "metapackage" license.
1329 if ebuild.split('/')[-3] == 'virtual':
1330 if license_types != ['metapackage']:
1331 return HookFailure('Virtual package must use LICENSE="metapackage".',
1332 [ebuild])
1333
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001334 # Also ignore licenses ending with '?'
1335 for license_type in [x for x in license_types
1336 if x not in LICENSES_IGNORE and not x.endswith('?')]:
1337 try:
Alex Kleinb5953522018-08-03 11:44:21 -06001338 licenses_lib.Licensing.FindLicenseType(license_type,
1339 overlay_path=overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001340 except AssertionError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001341 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001342
Mike Frysinger8cf80812019-09-16 23:49:29 -04001343 return None
1344
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001345
Mike Frysingerd9ed85f2021-02-03 12:38:24 -05001346def _check_ebuild_owners(project, commit):
Mike Frysingerb04778f2020-11-30 02:41:14 -05001347 """Require all new packages include an OWNERS file."""
1348 # Look for all adds/removes since we're going to ignore changes that only
1349 # update a package. We only want to flag new package imports for now.
1350 affected_files_objs = _get_affected_files(
1351 commit, include_deletes=True, include_symlinks=True, relative=True,
1352 full_details=True)
1353
1354 # If this CL doesn't include any ebuilds, don't bother complaining.
1355 new_ebuilds = [x for x in affected_files_objs
1356 if x.status == 'A' and x.src_file.endswith('.ebuild')]
1357 if not new_ebuilds:
1358 return None
1359
1360 # Check each package dir.
1361 packages_missing_owners = []
1362 package_dirs = sorted(set(os.path.dirname(x.src_file) for x in new_ebuilds))
1363 for package_dir in package_dirs:
1364 package_files = [
1365 x for x in affected_files_objs
1366 if (x.src_file and x.src_file.startswith(f'{package_dir}/')) or
1367 (x.dst_file and x.dst_file.startswith(f'{package_dir}/'))]
1368
1369 # Only complain about new ebuilds, not existing ones. For now.
1370 # We'll assume that "all adds" means it's a new package.
1371 if any(x for x in package_files if x.status != 'A'):
1372 continue
1373
1374 # See if there's an OWNERS file in there already.
Mike Frysingerd9ed85f2021-02-03 12:38:24 -05001375 data = _get_file_content(os.path.join(package_dir, 'OWNERS'), commit)
1376 if not data:
1377 # Allow specific overlays to declare OWNERS for all packages.
1378 if (project.name == 'chromiumos/overlays/board-overlays' or
1379 re.match(r'^chromeos/overlays/(baseboard|chipset|project|overlay)-',
1380 project.name)):
1381 data = _get_file_content(os.path.join(os.path.dirname(os.path.dirname(
1382 package_dir)), 'OWNERS'), commit)
1383
1384 if not data:
1385 packages_missing_owners.append(package_dir)
1386 continue
1387
1388 # Require specific people and not just *.
1389 lines = {x for x in data.splitlines() if x.split('#', 1)[0].strip()}
1390 if not lines - {'*'}:
Mike Frysingerb04778f2020-11-30 02:41:14 -05001391 packages_missing_owners.append(package_dir)
1392
1393 if packages_missing_owners:
1394 return HookFailure(
Mike Frysingerd9ed85f2021-02-03 12:38:24 -05001395 'All new packages must have an OWNERS file filled out.',
Mike Frysingerb04778f2020-11-30 02:41:14 -05001396 packages_missing_owners)
1397
1398 return None
1399
1400
Mike Frysinger6ee76b82020-11-20 01:16:06 -05001401def _check_ebuild_r0(_project, commit):
1402 """Do not allow ebuilds to end with -r0 versions."""
1403 ebuilds = _filter_files(
1404 _get_affected_files(commit, include_symlinks=True, relative=True),
1405 (r'-r0\.ebuild$',))
1406 if ebuilds:
1407 return HookFailure(
1408 'The -r0 in ebuilds is redundant and confusing. Simply remove it.\n'
1409 'For example: git mv foo-1.0-r0.ebuild foo-1.0.ebuild',
1410 ebuilds)
1411
1412 return None
1413
1414
Mike Frysingercd363c82014-02-01 05:20:18 -05001415def _check_ebuild_virtual_pv(project, commit):
1416 """Enforce the virtual PV policies."""
1417 # If this is the portage-stable overlay, then ignore the check.
1418 # We want to import virtuals as-is from upstream Gentoo.
Bob Haarman0dc1f942020-10-03 00:06:59 +00001419 allowlist = (
Mike Frysingercd363c82014-02-01 05:20:18 -05001420 'chromiumos/overlays/portage-stable',
1421 )
Bob Haarman0dc1f942020-10-03 00:06:59 +00001422 if project.name in allowlist:
Mike Frysingercd363c82014-02-01 05:20:18 -05001423 return None
1424
George Burgess IVe2402c22021-05-12 16:57:52 -07001425 # Per-project listings of packages with virtuals known to come from upstream
1426 # Gentoo, so we shouldn't complain about them.
1427 if project.name == 'chromiumos/overlays/chromiumos':
1428 pkg_allowlist = ('rust',)
1429 else:
1430 pkg_allowlist = ()
1431
Mike Frysingercd363c82014-02-01 05:20:18 -05001432 # We assume the repo name is the same as the dir name on disk.
1433 # It would be dumb to not have them match though.
Alex Deymo643ac4c2015-09-03 10:40:50 -07001434 project_base = os.path.basename(project.name)
Mike Frysingercd363c82014-02-01 05:20:18 -05001435
1436 is_variant = lambda x: x.startswith('overlay-variant-')
1437 is_board = lambda x: x.startswith('overlay-')
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001438 is_baseboard = lambda x: x.startswith('baseboard-')
1439 is_chipset = lambda x: x.startswith('chipset-')
1440 is_project = lambda x: x.startswith('project-')
Mike Frysingercd363c82014-02-01 05:20:18 -05001441 is_private = lambda x: x.endswith('-private')
1442
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001443 is_special_overlay = lambda x: (is_board(x) or is_chipset(x) or
1444 is_baseboard(x) or is_project(x))
1445
Mike Frysingercd363c82014-02-01 05:20:18 -05001446 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
1447
1448 ebuilds_re = [r'\.ebuild$']
1449 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1450 ebuilds_re)
1451 bad_ebuilds = []
1452
1453 for ebuild in ebuilds:
1454 m = get_pv.match(ebuild)
George Burgess IVe2402c22021-05-12 16:57:52 -07001455 if not m:
1456 continue
Mike Frysingercd363c82014-02-01 05:20:18 -05001457
George Burgess IVe2402c22021-05-12 16:57:52 -07001458 overlay, package_name, pv = m.groups()
1459 if package_name in pkg_allowlist:
1460 continue
Mike Frysingercd363c82014-02-01 05:20:18 -05001461
George Burgess IVe2402c22021-05-12 16:57:52 -07001462 pv = pv.split('-', 1)[0]
1463 if not overlay or not is_special_overlay(overlay):
1464 overlay = project_base
1465
1466 # Virtual versions >= 4 are special cases used above the standard
1467 # versioning structure, e.g. if one has a board inheriting a board.
1468 if pv[0] >= '4':
1469 want_pv = pv
1470 elif is_board(overlay):
1471 if is_private(overlay):
1472 want_pv = '3.5' if is_variant(overlay) else '3'
Mike Frysingercd363c82014-02-01 05:20:18 -05001473 elif is_board(overlay):
George Burgess IVe2402c22021-05-12 16:57:52 -07001474 want_pv = '2.5' if is_variant(overlay) else '2'
1475 elif is_baseboard(overlay):
1476 want_pv = '1.9.5' if is_private(overlay) else '1.9'
1477 elif is_chipset(overlay):
1478 want_pv = '1.8.5' if is_private(overlay) else '1.8'
1479 elif is_project(overlay):
1480 want_pv = '1.7' if is_private(overlay) else '1.5'
1481 else:
1482 want_pv = '1'
Mike Frysingercd363c82014-02-01 05:20:18 -05001483
George Burgess IVe2402c22021-05-12 16:57:52 -07001484 if pv != want_pv:
1485 bad_ebuilds.append((ebuild, pv, want_pv))
Mike Frysingercd363c82014-02-01 05:20:18 -05001486
1487 if bad_ebuilds:
1488 # pylint: disable=C0301
1489 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
1490 # pylint: enable=C0301
1491 return HookFailure(
1492 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
1493 '\t%s\n'
1494 'If this is an upstream Gentoo virtual, then you may ignore this\n'
1495 'check (and re-run w/--no-verify). Otherwise, please see this\n'
1496 'page for more details:\n%s\n' %
1497 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
1498 for x in bad_ebuilds]), url))
1499
Mike Frysinger8cf80812019-09-16 23:49:29 -04001500 return None
1501
Mike Frysingercd363c82014-02-01 05:20:18 -05001502
Daniel Erat9d203ff2015-02-17 10:12:21 -07001503def _check_portage_make_use_var(_project, commit):
1504 """Verify that $USE is set correctly in make.conf and make.defaults."""
1505 files = _filter_files(_get_affected_files(commit, relative=True),
1506 [r'(^|/)make.(conf|defaults)$'])
1507
1508 errors = []
1509 for path in files:
1510 basename = os.path.basename(path)
1511
1512 # Has a USE= line already been encountered in this file?
1513 saw_use = False
1514
1515 for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1):
1516 if not line.startswith('USE='):
1517 continue
1518
1519 preserves_use = '${USE}' in line or '$USE' in line
1520
1521 if (basename == 'make.conf' or
1522 (basename == 'make.defaults' and saw_use)) and not preserves_use:
1523 errors.append('%s:%d: missing ${USE}' % (path, i))
1524 elif basename == 'make.defaults' and not saw_use and preserves_use:
1525 errors.append('%s:%d: ${USE} referenced in initial declaration' %
1526 (path, i))
1527
1528 saw_use = True
1529
1530 if errors:
1531 return HookFailure(
1532 'One or more Portage make files appear to set USE incorrectly.\n'
1533 '\n'
1534 'All USE assignments in make.conf and all assignments after the\n'
1535 'initial declaration in make.defaults should contain "${USE}" to\n'
1536 'preserve previously-set flags.\n'
1537 '\n'
1538 'The initial USE declaration in make.defaults should not contain\n'
1539 '"${USE}".\n',
1540 errors)
1541
Mike Frysinger8cf80812019-09-16 23:49:29 -04001542 return None
1543
Daniel Erat9d203ff2015-02-17 10:12:21 -07001544
Mike Frysingerae409522014-02-01 03:16:11 -05001545def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001546 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001547 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001548 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001549 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001550 if not m:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001551 return HookFailure('Last paragraph of description must include Change-Id.')
Ryan Cui1562fb82011-05-09 11:01:31 -07001552
LaMont Jonesfb5e8bf2020-03-03 12:50:06 -07001553 # S-o-b and some other tags always allowed to follow Change-ID in the footer.
1554 allowed_tags = ['Signed-off-by', 'Cq-Cl-Tag', 'Cq-Include-Trybots']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001555
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001556 end = desc[m.end():].strip().splitlines()
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001557 cherry_pick_marker = 'cherry picked from commit'
1558
1559 if end and cherry_pick_marker in end[-1]:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001560 # Cherry picked patches allow more tags in the last paragraph.
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001561 allowed_tags += ['Commit-Queue', 'Commit-Ready', 'Reviewed-by',
1562 'Reviewed-on', 'Tested-by']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001563 end = end[:-1]
1564
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001565 # Note that descriptions could have multiple cherry pick markers.
1566 tag_search = r'^(%s:|\(%s) ' % (':|'.join(allowed_tags), cherry_pick_marker)
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001567
1568 if [x for x in end if not re.search(tag_search, x)]:
1569 return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' %
1570 ':", "'.join(allowed_tags))
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001571
Mike Frysinger8cf80812019-09-16 23:49:29 -04001572 return None
1573
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001574
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001575def _check_commit_message_style(_project, commit):
1576 """Verify that the commit message matches our style.
1577
1578 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
1579 commit hooks.
1580 """
Mike Frysingered9b2a02019-12-12 18:52:32 -05001581 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Mike Frysinger4efdee72019-11-04 10:57:01 -05001582
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001583 desc = _get_commit_desc(commit)
1584
1585 # The first line should be by itself.
1586 lines = desc.splitlines()
1587 if len(lines) > 1 and lines[1]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001588 return HookFailure('The second line of the commit message must be blank.'
1589 '\n%s' % (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001590
1591 # The first line should be one sentence.
1592 if '. ' in lines[0]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001593 return HookFailure('The first line cannot be more than one sentence.\n%s' %
1594 (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001595
1596 # The first line cannot be too long.
1597 MAX_FIRST_LINE_LEN = 100
Mike Frysingerd2451822021-02-17 13:52:19 -05001598 first_line = lines[0]
1599 if len(first_line) > MAX_FIRST_LINE_LEN:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001600 return HookFailure('The first line must be less than %i chars.\n%s' %
1601 (MAX_FIRST_LINE_LEN, SEE_ALSO))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001602
Mike Frysingerd2451822021-02-17 13:52:19 -05001603 # Don't allow random git keywords.
1604 if first_line.startswith('fixup!') or first_line.startswith('squash!'):
1605 return HookFailure(
1606 'Git fixup/squash commit detected: rebase your local branch, or '
1607 'cleanup the commit message')
1608
Mike Frysinger8cf80812019-09-16 23:49:29 -04001609 return None
1610
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001611
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001612def _check_cros_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001613 """Verifies the Chromium OS license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -07001614
Mike Frysinger98638102014-08-28 00:15:08 -04001615 Should be following the spec:
1616 http://dev.chromium.org/developers/coding-style#TOC-File-headers
1617 """
1618 # For older years, be a bit more flexible as our policy says leave them be.
1619 LICENSE_HEADER = (
Keigo Oka7e880ac2019-07-03 15:03:43 +09001620 r'.*Copyright(?: \(c\))? (20[0-9]{2})(?:-20[0-9]{2})? The Chromium OS '
1621 r'Authors\. All rights reserved\.\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001622 r'.*Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001623 r'be\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001624 r'.*found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -05001625 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001626 )
1627 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1628
1629 # For newer years, be stricter.
Keigo Oka7e880ac2019-07-03 15:03:43 +09001630 BAD_COPYRIGHT_LINE = (
Brian Norris68838dd2018-09-26 18:30:24 -07001631 r'.*Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001632 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001633 )
Keigo Oka7e880ac2019-07-03 15:03:43 +09001634 bad_copyright_re = re.compile(BAD_COPYRIGHT_LINE)
Mike Frysinger98638102014-08-28 00:15:08 -04001635
Shuhei Takahashiabc20f32017-07-10 19:35:45 +09001636 included, excluded = _parse_common_inclusion_options(options)
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001637
Mike Frysinger98638102014-08-28 00:15:08 -04001638 bad_files = []
1639 bad_copyright_files = []
Keigo Oka7e880ac2019-07-03 15:03:43 +09001640 bad_year_files = []
1641
Ken Turnerd07564b2018-02-08 17:57:59 +11001642 files = _filter_files(
1643 _get_affected_files(commit, relative=True),
1644 included + COMMON_INCLUDED_PATHS,
1645 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001646 existing_files = set(_get_affected_files(commit, relative=True,
1647 include_adds=False))
Mike Frysinger98638102014-08-28 00:15:08 -04001648
Keigo Oka7e880ac2019-07-03 15:03:43 +09001649 current_year = str(datetime.datetime.now().year)
Mike Frysinger98638102014-08-28 00:15:08 -04001650 for f in files:
1651 contents = _get_file_content(f, commit)
1652 if not contents:
1653 # Ignore empty files.
1654 continue
1655
Keigo Oka7e880ac2019-07-03 15:03:43 +09001656 m = license_re.search(contents)
1657 if not m:
Mike Frysinger98638102014-08-28 00:15:08 -04001658 bad_files.append(f)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001659 elif bad_copyright_re.search(contents):
Mike Frysinger98638102014-08-28 00:15:08 -04001660 bad_copyright_files.append(f)
1661
Keigo Oka7e880ac2019-07-03 15:03:43 +09001662 if m and f not in existing_files:
1663 year = m.group(1)
1664 if year != current_year:
1665 bad_year_files.append(f)
1666
1667 errors = []
Mike Frysinger98638102014-08-28 00:15:08 -04001668 if bad_files:
1669 msg = '%s:\n%s\n%s' % (
1670 'License must match', license_re.pattern,
1671 'Found a bad header in these files:')
Keigo Oka7e880ac2019-07-03 15:03:43 +09001672 errors.append(HookFailure(msg, bad_files))
Mike Frysinger98638102014-08-28 00:15:08 -04001673 if bad_copyright_files:
1674 msg = 'Do not use (c) in copyright headers in new files:'
Keigo Oka7e880ac2019-07-03 15:03:43 +09001675 errors.append(HookFailure(msg, bad_copyright_files))
1676 if bad_year_files:
1677 msg = 'Use current year (%s) in copyright headers in new files:' % (
1678 current_year)
1679 errors.append(HookFailure(msg, bad_year_files))
Ryan Cuiec4d6332011-05-02 14:15:25 -07001680
Keigo Oka7e880ac2019-07-03 15:03:43 +09001681 return errors
Ryan Cuiec4d6332011-05-02 14:15:25 -07001682
Mike Frysinger8cf80812019-09-16 23:49:29 -04001683
Amin Hassani391efa92018-01-26 17:58:05 -08001684def _check_aosp_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001685 """Verifies the AOSP license/copyright header.
1686
1687 AOSP uses the Apache2 License:
1688 https://source.android.com/source/licenses.html
1689 """
1690 LICENSE_HEADER = (
1691 r"""^[#/\*]*
1692[#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project
1693[#/\*]* ?
1694[#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\);
1695[#/\*]* ?you may not use this file except in compliance with the License\.
1696[#/\*]* ?You may obtain a copy of the License at
1697[#/\*]* ?
1698[#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0
1699[#/\*]* ?
1700[#/\*]* ?Unless required by applicable law or agreed to in writing, software
1701[#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS,
1702[#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """
1703 r"""implied\.
1704[#/\*]* ?See the License for the specific language governing permissions and
1705[#/\*]* ?limitations under the License\.
1706[#/\*]*$
1707"""
1708 )
1709 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1710
Amin Hassani391efa92018-01-26 17:58:05 -08001711 included, excluded = _parse_common_inclusion_options(options)
1712
Ken Turnerd07564b2018-02-08 17:57:59 +11001713 files = _filter_files(
1714 _get_affected_files(commit, relative=True),
1715 included + COMMON_INCLUDED_PATHS,
1716 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Alex Deymof5792ce2015-08-24 22:50:08 -07001717
1718 bad_files = []
1719 for f in files:
1720 contents = _get_file_content(f, commit)
1721 if not contents:
1722 # Ignore empty files.
1723 continue
1724
1725 if not license_re.search(contents):
1726 bad_files.append(f)
1727
1728 if bad_files:
1729 msg = ('License must match:\n%s\nFound a bad header in these files:' %
1730 license_re.pattern)
1731 return HookFailure(msg, bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001732 return None
Alex Deymof5792ce2015-08-24 22:50:08 -07001733
1734
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001735def _check_layout_conf(_project, commit):
1736 """Verifies the metadata/layout.conf file."""
1737 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001738 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001739 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001740 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001741
Mike Frysinger94a670c2014-09-19 12:46:26 -04001742 # Handle multiple overlays in a single commit (like the public tree).
1743 for f in _get_affected_files(commit, relative=True):
1744 if f.endswith(repo_name):
1745 repo_names.append(f)
1746 elif f.endswith(layout_path):
1747 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001748
1749 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -04001750 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001751 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -04001752 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001753
Mike Frysinger94a670c2014-09-19 12:46:26 -04001754 # Gather all the errors in one pass so we show one full message.
1755 all_errors = {}
1756 for layout_path in layout_paths:
1757 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001758
Mike Frysinger94a670c2014-09-19 12:46:26 -04001759 # Make sure the config file is sorted.
1760 data = [x for x in _get_file_content(layout_path, commit).splitlines()
1761 if x and x[0] != '#']
1762 if sorted(data) != data:
1763 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001764
Mike Frysinger94a670c2014-09-19 12:46:26 -04001765 # Require people to set specific values all the time.
1766 settings = (
1767 # TODO: Enable this for everyone. http://crbug.com/408038
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001768 # ('fast caching', 'cache-format = md5-dict'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001769 ('fast manifests', 'thin-manifests = true'),
Mike Frysingerd7734522015-02-26 16:12:43 -05001770 ('extra features', 'profile-formats = portage-2 profile-default-eapi'),
1771 ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001772 )
1773 for reason, line in settings:
1774 if line not in data:
1775 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001776
Mike Frysinger94a670c2014-09-19 12:46:26 -04001777 # Require one of these settings.
Mike Frysinger5fae62d2015-11-11 20:12:15 -05001778 if 'use-manifests = strict' not in data:
1779 errors += ['enable file checking with: use-manifests = strict']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001780
Mike Frysinger94a670c2014-09-19 12:46:26 -04001781 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -04001782 for line in data:
1783 if line.startswith('repo-name = '):
1784 break
1785 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -04001786 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001787
Mike Frysinger94a670c2014-09-19 12:46:26 -04001788 # Summarize all the errors we saw (if any).
1789 lines = ''
1790 for layout_path, errors in all_errors.items():
1791 if errors:
1792 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
1793 if lines:
1794 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
1795 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001796
Mike Frysinger8cf80812019-09-16 23:49:29 -04001797 return None
1798
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001799
Keigo Oka4a09bd92019-05-07 14:01:00 +09001800def _check_no_new_gyp(_project, commit):
1801 """Verifies no project starts to use GYP."""
Keigo Oka4a09bd92019-05-07 14:01:00 +09001802 gypfiles = _filter_files(
1803 _get_affected_files(commit, include_symlinks=True, relative=True),
1804 [r'\.gyp$'])
1805
1806 if gypfiles:
1807 return HookFailure('GYP is deprecated and not allowed in a new project:',
1808 gypfiles)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001809 return None
Keigo Oka4a09bd92019-05-07 14:01:00 +09001810
1811
Ryan Cuiec4d6332011-05-02 14:15:25 -07001812# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001813
Ryan Cui1562fb82011-05-09 11:01:31 -07001814
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001815def _check_clang_format(_project, commit, options=()):
1816 """Runs clang-format on the given project"""
1817 hooks_dir = _get_hooks_dir()
1818 options = list(options)
1819 if commit == PRE_SUBMIT:
1820 options.append('--commit=HEAD')
1821 else:
1822 options.extend(['--commit', commit])
Brian Norris0c62a142018-12-11 13:24:29 -08001823 cmd = [os.path.join(hooks_dir, 'clang-format.py')] + options
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001824 cmd_result = cros_build_lib.run(cmd,
1825 print_cmd=False,
1826 stdout=True,
1827 encoding='utf-8',
1828 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001829 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001830 check=False)
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001831 if cmd_result.returncode:
1832 return HookFailure('clang-format.py errors/warnings\n\n' +
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001833 cmd_result.stdout)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001834 return None
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001835
1836
Mike Frysingerae409522014-02-01 03:16:11 -05001837def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001838 """Runs checkpatch.pl on the given project"""
Tomasz Figabd8faf62020-09-22 14:06:05 +00001839 # Bypass checkpatch for upstream or almost upstream commits, since we do not
1840 # intend to modify the upstream commits when landing them to our branches.
1841 # Any fixes should sent as independent patches.
1842 # The check is retained for FROMLIST and BACKPORT commits, as by definition
1843 # those can be still fixed up.
1844 desc = _get_commit_desc(commit)
1845 if desc.startswith('UPSTREAM:') or desc.startswith('FROMGIT:'):
1846 return None
1847
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001848 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001849 options = list(options)
Brian Norris4cee0502020-06-12 17:02:56 -07001850 if options and options[0].startswith('./') and os.path.exists(options[0]):
1851 cmdpath = options.pop(0)
1852 else:
1853 cmdpath = os.path.join(hooks_dir, 'checkpatch.pl')
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001854 if commit == PRE_SUBMIT:
1855 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
1856 # this case.
1857 options.append('--ignore=MISSING_SIGN_OFF')
Filipe Brandenburger28d48d62015-10-07 09:48:54 -07001858 # Always ignore the check for the MAINTAINERS file. We do not track that
1859 # information on that file in our source trees, so let's suppress the
1860 # warning.
1861 options.append('--ignore=FILE_PATH_CHANGES')
Filipe Brandenburgerce978322015-10-09 10:04:15 -07001862 # Do not complain about the Change-Id: fields, since we use Gerrit.
1863 # Upstream does not want those lines (since they do not use Gerrit), but
1864 # we always do, so disable the check globally.
Daisuke Nojiri4844f892015-10-08 09:54:33 -07001865 options.append('--ignore=GERRIT_CHANGE_ID')
Brian Norris4cee0502020-06-12 17:02:56 -07001866 cmd = [cmdpath] + options + ['-']
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001867 cmd_result = cros_build_lib.run(
1868 cmd, print_cmd=False, input=_get_patch(commit).encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001869 stdout=True, stderr=subprocess.STDOUT, check=False, encoding='utf-8',
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001870 errors='replace')
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001871 if cmd_result.returncode:
Brian Norris4cee0502020-06-12 17:02:56 -07001872 return HookFailure('%s errors/warnings\n\n%s' %
1873 (cmdpath, cmd_result.stdout))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001874 return None
Ryan Cuiec4d6332011-05-02 14:15:25 -07001875
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001876
Brian Norris23c62e92018-11-14 12:25:51 -08001877def _run_kerneldoc(_project, commit, options=()):
1878 """Runs kernel-doc validator on the given project"""
1879 included, excluded = _parse_common_inclusion_options(options)
1880 files = _filter_files(_get_affected_files(commit, relative=True),
1881 included, excluded)
1882 if files:
1883 hooks_dir = _get_hooks_dir()
Brian Norris0c62a142018-12-11 13:24:29 -08001884 cmd = [os.path.join(hooks_dir, 'kernel-doc'), '-none'] + files
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001885 output = _run_command(cmd, stderr=subprocess.STDOUT)
Brian Norris23c62e92018-11-14 12:25:51 -08001886 if output:
Brian Norris0c62a142018-12-11 13:24:29 -08001887 return HookFailure('kernel-doc errors/warnings:',
1888 items=output.splitlines())
Mike Frysinger8cf80812019-09-16 23:49:29 -04001889 return None
Brian Norris23c62e92018-11-14 12:25:51 -08001890
1891
Mike Frysingerae409522014-02-01 03:16:11 -05001892def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -07001893 """Makes sure kernel config changes are not mixed with code changes"""
1894 files = _get_affected_files(commit)
Mike Frysingerf252cfc2019-12-09 17:34:28 -05001895 if len(_filter_files(files, [r'chromeos/config'])) not in [0, len(files)]:
Olof Johanssona96810f2012-09-04 16:20:03 -07001896 return HookFailure('Changes to chromeos/config/ and regular files must '
1897 'be in separate commits:\n%s' % '\n'.join(files))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001898 return None
Anton Staaf815d6852011-08-22 10:08:45 -07001899
Mike Frysingerae409522014-02-01 03:16:11 -05001900
1901def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -07001902 """Checks that all JSON files are syntactically valid."""
Mike Frysinger908be682018-01-04 02:21:50 -05001903 ret = []
1904
1905 files = _filter_files(_get_affected_files(commit, relative=True),
1906 [r'.*\.json$'])
1907 for f in files:
1908 data = _get_file_content(f, commit)
Dale Curtis2975c432011-05-03 17:25:20 -07001909 try:
Mike Frysinger908be682018-01-04 02:21:50 -05001910 json.loads(data)
1911 except Exception as e:
1912 ret.append('%s: Invalid JSON: %s' % (f, e))
1913
1914 if ret:
1915 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001916 return None
Dale Curtis2975c432011-05-03 17:25:20 -07001917
1918
Mike Frysingerae409522014-02-01 03:16:11 -05001919def _check_manifests(_project, commit):
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001920 """Make sure Manifest files only have comments & DIST lines."""
1921 ret = []
Mike Frysinger52b537e2013-08-22 22:59:53 -04001922
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001923 manifests = _filter_files(_get_affected_files(commit, relative=True),
1924 [r'.*/Manifest$'])
1925 for path in manifests:
1926 data = _get_file_content(path, commit)
1927
1928 # Disallow blank files.
1929 if not data.strip():
1930 ret.append('%s: delete empty file' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001931 continue
1932
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001933 # Make sure the last newline isn't omitted.
1934 if data[-1] != '\n':
1935 ret.append('%s: missing trailing newline' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001936
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001937 # Do not allow leading or trailing blank lines.
1938 lines = data.splitlines()
1939 if not lines[0]:
1940 ret.append('%s: delete leading blank lines' % (path,))
1941 if not lines[-1]:
1942 ret.append('%s: delete trailing blank lines' % (path,))
1943
1944 for line in lines:
1945 # Disallow leading/trailing whitespace.
1946 if line != line.strip():
1947 ret.append('%s: remove leading/trailing whitespace: %s' % (path, line))
1948
1949 # Allow blank lines & comments.
1950 line = line.split('#', 1)[0]
1951 if not line:
1952 continue
1953
1954 # All other linse should start with DIST.
1955 if not line.startswith('DIST '):
1956 ret.append('%s: remove non-DIST lines: %s' % (path, line))
1957 break
1958
1959 if ret:
1960 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001961 return None
Mike Frysinger52b537e2013-08-22 22:59:53 -04001962
1963
Mike Frysingerae409522014-02-01 03:16:11 -05001964def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001965 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001966 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001967 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001968 BRANCH_RE = r'\nBRANCH=\S+'
1969
1970 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
1971 msg = ('Changelist description needs BRANCH field (after first line)\n'
1972 'E.g. BRANCH=none or BRANCH=link,snow')
1973 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001974 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001975
1976
Mike Frysinger45334bd2019-11-04 10:42:33 -05001977def _check_change_has_no_branch_field(_project, commit):
1978 """Verify 'BRANCH=' field does not exist in the commit message."""
1979 if commit == PRE_SUBMIT:
1980 return None
1981 BRANCH_RE = r'\nBRANCH=\S+'
1982
1983 if re.search(BRANCH_RE, _get_commit_desc(commit)):
1984 msg = 'This checkout does not use BRANCH= fields. Delete them.'
1985 return HookFailure(msg)
1986 return None
1987
1988
Mike Frysingerae409522014-02-01 03:16:11 -05001989def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001990 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001991 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001992 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001993 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1994
1995 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1996 msg = ('Changelist description needs Signed-off-by: field\n'
1997 'E.g. Signed-off-by: My Name <me@chromium.org>')
1998 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001999 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08002000
2001
Mike Frysinger9ab64b12019-11-04 10:53:08 -05002002def _check_change_has_no_signoff_field(_project, commit):
2003 """Verify 'Signed-off-by:' field does not exist in the commit message."""
2004 if commit == PRE_SUBMIT:
2005 return None
2006 SIGNOFF_RE = r'\nSigned-off-by: \S+'
2007
2008 if re.search(SIGNOFF_RE, _get_commit_desc(commit)):
2009 msg = 'This checkout does not use Signed-off-by: tags. Delete them.'
2010 return HookFailure(msg)
2011 return None
2012
2013
Jon Salz3ee59de2012-08-18 13:54:22 +08002014def _run_project_hook_script(script, project, commit):
2015 """Runs a project hook script.
2016
2017 The script is run with the following environment variables set:
2018 PRESUBMIT_PROJECT: The affected project
2019 PRESUBMIT_COMMIT: The affected commit
2020 PRESUBMIT_FILES: A newline-separated list of affected files
2021
2022 The script is considered to fail if the exit code is non-zero. It should
2023 write an error message to stdout.
2024 """
2025 env = dict(os.environ)
Alex Deymo643ac4c2015-09-03 10:40:50 -07002026 env['PRESUBMIT_PROJECT'] = project.name
Jon Salz3ee59de2012-08-18 13:54:22 +08002027 env['PRESUBMIT_COMMIT'] = commit
2028
2029 # Put affected files in an environment variable
2030 files = _get_affected_files(commit)
2031 env['PRESUBMIT_FILES'] = '\n'.join(files)
2032
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002033 cmd_result = cros_build_lib.run(cmd=script,
2034 env=env,
2035 shell=True,
2036 print_cmd=False,
2037 input=os.devnull,
2038 stdout=True,
2039 encoding='utf-8',
2040 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05002041 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002042 check=False)
Rahul Chaudhry0e515342015-08-07 12:00:43 -07002043 if cmd_result.returncode:
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002044 stdout = cmd_result.stdout
Jon Salz7b618af2012-08-31 06:03:16 +08002045 if stdout:
2046 stdout = re.sub('(?m)^', ' ', stdout)
2047 return HookFailure('Hook script "%s" failed with code %d%s' %
Rahul Chaudhry0e515342015-08-07 12:00:43 -07002048 (script, cmd_result.returncode,
Jon Salz3ee59de2012-08-18 13:54:22 +08002049 ':\n' + stdout if stdout else ''))
Mike Frysinger8cf80812019-09-16 23:49:29 -04002050 return None
Jon Salz3ee59de2012-08-18 13:54:22 +08002051
2052
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07002053def _check_project_prefix(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -05002054 """Require the commit message have a project specific prefix as needed."""
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07002055
Brian Norris77608e12018-04-06 10:38:43 -07002056 files = _get_affected_files(commit, include_deletes=True, relative=True)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07002057 prefix = os.path.commonprefix(files)
2058 prefix = os.path.dirname(prefix)
2059
2060 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07002061 if not prefix:
Mike Frysinger8cf80812019-09-16 23:49:29 -04002062 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07002063
2064 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07002065
2066 # The common files may all be within a subdirectory of the main project
2067 # directory, so walk up the tree until we find an alias file.
2068 # _get_affected_files() should return relative paths, but check against '/' to
2069 # ensure that this loop terminates even if it receives an absolute path.
2070 while prefix and prefix != '/':
2071 alias_file = os.path.join(prefix, '.project_alias')
2072
2073 # If an alias exists, use it.
2074 if os.path.isfile(alias_file):
2075 project_name = osutils.ReadFile(alias_file).strip()
2076
2077 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07002078
2079 if not _get_commit_desc(commit).startswith(project_name + ': '):
2080 return HookFailure('The commit title for changes affecting only %s'
2081 ' should start with \"%s: \"'
2082 % (project_name, project_name))
Mike Frysinger8cf80812019-09-16 23:49:29 -04002083 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07002084
2085
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09002086def _check_filepath_chartype(_project, commit):
2087 """Checks that FilePath::CharType stuff is not used."""
2088
2089 FILEPATH_REGEXP = re.compile('|'.join(
2090 [r'(?:base::)?FilePath::(?:Char|String|StringPiece)Type',
Satoru Takabayashi4ca37922018-08-08 10:16:38 +09002091 r'(?:base::)?FilePath::FromUTF8Unsafe',
2092 r'AsUTF8Unsafe',
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09002093 r'FILE_PATH_LITERAL']))
2094 files = _filter_files(_get_affected_files(commit, relative=True),
2095 [r'.*\.(cc|h)$'])
2096
2097 errors = []
2098 for afile in files:
2099 for line_num, line in _get_file_diff(afile, commit):
2100 m = re.search(FILEPATH_REGEXP, line)
2101 if m:
2102 errors.append('%s, line %s has %s' % (afile, line_num, m.group(0)))
2103
2104 if errors:
2105 msg = 'Please assume FilePath::CharType is char (crbug.com/870621):'
2106 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -04002107 return None
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09002108
2109
Mike Frysingerf9d41b32017-02-23 15:20:04 -05002110def _check_exec_files(_project, commit):
2111 """Make +x bits on files."""
2112 # List of files that should never be +x.
2113 NO_EXEC = (
2114 'ChangeLog*',
2115 'COPYING',
2116 'make.conf',
2117 'make.defaults',
2118 'Manifest',
2119 'OWNERS',
2120 'package.use',
2121 'package.keywords',
2122 'package.mask',
2123 'parent',
2124 'README',
2125 'TODO',
2126 '.gitignore',
2127 '*.[achly]',
2128 '*.[ch]xx',
2129 '*.boto',
2130 '*.cc',
2131 '*.cfg',
2132 '*.conf',
2133 '*.config',
2134 '*.cpp',
2135 '*.css',
2136 '*.ebuild',
2137 '*.eclass',
Tatsuhisa Yamaguchi3b053632019-01-10 14:45:14 +09002138 '*.gn',
2139 '*.gni',
Mike Frysingerf9d41b32017-02-23 15:20:04 -05002140 '*.gyp',
2141 '*.gypi',
2142 '*.htm',
2143 '*.html',
2144 '*.ini',
2145 '*.js',
2146 '*.json',
2147 '*.md',
2148 '*.mk',
2149 '*.patch',
2150 '*.policy',
2151 '*.proto',
2152 '*.raw',
2153 '*.rules',
2154 '*.service',
2155 '*.target',
2156 '*.txt',
2157 '*.xml',
2158 '*.yaml',
2159 )
2160
2161 def FinalName(obj):
2162 # If the file is being deleted, then the dst_file is not set.
2163 if obj.dst_file is None:
2164 return obj.src_file
2165 else:
2166 return obj.dst_file
2167
2168 bad_files = []
2169 files = _get_affected_files(commit, relative=True, full_details=True)
2170 for f in files:
2171 mode = int(f.dst_mode, 8)
2172 if not mode & 0o111:
2173 continue
2174 name = FinalName(f)
2175 for no_exec in NO_EXEC:
2176 if fnmatch.fnmatch(name, no_exec):
2177 bad_files.append(name)
2178 break
2179
2180 if bad_files:
2181 return HookFailure('These files should not be executable. '
2182 'Please `chmod -x` them.', bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04002183 return None
Mike Frysingerf9d41b32017-02-23 15:20:04 -05002184
2185
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002186# Base
2187
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002188# A list of hooks which are not project specific and check patch description
2189# (as opposed to patch body).
2190_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07002191 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07002192 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07002193 _check_change_has_test_field,
2194 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04002195 _check_commit_message_style,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08002196 _check_change_is_contribution,
Jack Neus8edbf642019-07-10 16:08:31 -06002197 _check_change_no_include_oem,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002198]
2199
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002200# A list of hooks that are not project-specific
2201_COMMON_HOOKS = [
Keiichi Watanabe6ab73fd2020-07-14 23:42:02 +09002202 _check_cargo_clippy,
Aviv Keshet5ac59522017-01-31 14:28:27 -08002203 _check_cros_license,
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05002204 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05002205 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08002206 _check_ebuild_licenses,
Mike Frysingerb04778f2020-11-30 02:41:14 -05002207 _check_ebuild_owners,
Mike Frysinger6ee76b82020-11-20 01:16:06 -05002208 _check_ebuild_r0,
Mike Frysingercd363c82014-02-01 05:20:18 -05002209 _check_ebuild_virtual_pv,
Mike Frysingerf9d41b32017-02-23 15:20:04 -05002210 _check_exec_files,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002211 _check_for_uprev,
Rahul Chaudhry09f61372015-07-31 17:14:26 -07002212 _check_gofmt,
Bernie Thompson8e26f742020-07-23 14:32:31 -07002213 _check_keywords,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04002214 _check_layout_conf,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002215 _check_no_long_lines,
Keigo Oka4a09bd92019-05-07 14:01:00 +09002216 _check_no_new_gyp,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002217 _check_no_stray_whitespace,
Ryan Cui9b651632011-05-11 11:38:58 -07002218 _check_no_tabs,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002219 _check_portage_make_use_var,
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -06002220 _check_rustfmt,
Aviv Keshet5ac59522017-01-31 14:28:27 -08002221 _check_tabbed_indents,
Ryan Cui9b651632011-05-11 11:38:58 -07002222]
Ryan Cuiec4d6332011-05-02 14:15:25 -07002223
Ryan Cui1562fb82011-05-09 11:01:31 -07002224
Ryan Cui9b651632011-05-11 11:38:58 -07002225# A dictionary of flags (keys) that can appear in the config file, and the hook
Mike Frysinger3554bc92015-03-11 04:59:21 -04002226# that the flag controls (value).
2227_HOOK_FLAGS = {
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07002228 'clang_format_check': _check_clang_format,
Mike Frysingera7642f52015-03-25 18:31:42 -04002229 'checkpatch_check': _run_checkpatch,
Brian Norris23c62e92018-11-14 12:25:51 -08002230 'kerneldoc_check': _run_kerneldoc,
Ryan Cui9b651632011-05-11 11:38:58 -07002231 'stray_whitespace_check': _check_no_stray_whitespace,
Mike Frysingerff6c7d62015-03-24 13:49:46 -04002232 'json_check': _run_json_check,
Ryan Cui9b651632011-05-11 11:38:58 -07002233 'long_line_check': _check_no_long_lines,
Alex Deymof5792ce2015-08-24 22:50:08 -07002234 'cros_license_check': _check_cros_license,
2235 'aosp_license_check': _check_aosp_license,
LaMont Jones872fe762020-02-10 15:36:14 -07002236 'gofmt_check': _check_gofmt,
Bernie Thompson8e26f742020-07-23 14:32:31 -07002237 'keyword_check': _check_keywords,
Ryan Cui9b651632011-05-11 11:38:58 -07002238 'tab_check': _check_no_tabs,
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08002239 'tabbed_indent_required_check': _check_tabbed_indents,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07002240 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08002241 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07002242 'bug_field_check': _check_change_has_bug_field,
2243 'test_field_check': _check_change_has_test_field,
Steve Fung49ec7e92015-03-23 16:07:12 -07002244 'manifest_check': _check_manifests,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08002245 'contribution_check': _check_change_is_contribution,
Mike Frysinger47bd1252018-06-11 12:12:20 -04002246 'project_prefix_check': _check_project_prefix,
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09002247 'filepath_chartype_check': _check_filepath_chartype,
Keiichi Watanabe6ab73fd2020-07-14 23:42:02 +09002248 'cargo_clippy_check': _check_cargo_clippy,
Julius Werner291d8602020-07-31 17:34:02 -07002249 'exec_files_check': _check_exec_files,
Mike Frysingera5c2a5b2020-12-18 01:57:13 -05002250 'kernel_splitconfig_check': _kernel_configcheck,
Ryan Cui9b651632011-05-11 11:38:58 -07002251}
2252
2253
Mike Frysinger3554bc92015-03-11 04:59:21 -04002254def _get_override_hooks(config):
2255 """Returns a set of hooks controlled by the current project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07002256
2257 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08002258
2259 Args:
2260 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07002261 """
2262 SECTION = 'Hook Overrides'
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002263 SECTION_OPTIONS = 'Hook Overrides Options'
Ryan Cui9b651632011-05-11 11:38:58 -07002264
Mike Frysinger56e8de02019-07-31 14:40:14 -04002265 valid_keys = set(_HOOK_FLAGS.keys())
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002266 hooks = _HOOK_FLAGS.copy()
Mike Frysinger180ecd62020-08-19 00:41:51 -04002267 hook_overrides = set(
2268 config.options(SECTION) if config.has_section(SECTION) else [])
2269
2270 unknown_keys = hook_overrides - valid_keys
2271 if unknown_keys:
2272 raise ValueError(f'{_CONFIG_FILE}: [{SECTION}]: unknown keys: '
2273 f'{unknown_keys}')
Mike Frysinger3554bc92015-03-11 04:59:21 -04002274
2275 enable_flags = []
Ryan Cui9b651632011-05-11 11:38:58 -07002276 disable_flags = []
Mike Frysinger180ecd62020-08-19 00:41:51 -04002277 for flag in valid_keys:
2278 if flag in hook_overrides:
2279 try:
2280 enabled = config.getboolean(SECTION, flag)
2281 except ValueError as e:
2282 raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' %
2283 (flag, _CONFIG_FILE, e))
2284 elif hooks[flag] in _COMMON_HOOKS:
2285 # Enable common hooks by default so we process custom options below.
2286 enabled = True
2287 else:
2288 # All other hooks we left as a tristate. We use this below for a few
2289 # hooks to control default behavior.
2290 enabled = None
Mike Frysinger3554bc92015-03-11 04:59:21 -04002291
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002292 if enabled:
2293 enable_flags.append(flag)
Mike Frysinger180ecd62020-08-19 00:41:51 -04002294 elif enabled is not None:
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002295 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07002296
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002297 # See if this hook has custom options.
2298 if enabled:
2299 try:
2300 options = config.get(SECTION_OPTIONS, flag)
2301 hooks[flag] = functools.partial(hooks[flag], options=options.split())
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002302 hooks[flag].__name__ = flag
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04002303 except (configparser.NoOptionError, configparser.NoSectionError):
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002304 pass
2305
2306 enabled_hooks = set(hooks[x] for x in enable_flags)
2307 disabled_hooks = set(hooks[x] for x in disable_flags)
Mike Frysinger45334bd2019-11-04 10:42:33 -05002308
Mike Frysinger9ab64b12019-11-04 10:53:08 -05002309 if _check_change_has_signoff_field not in enabled_hooks:
Drew Davenport85848e52020-01-15 14:40:29 -07002310 if _check_change_has_signoff_field not in disabled_hooks:
2311 enabled_hooks.add(_check_change_has_no_signoff_field)
Mike Frysinger45334bd2019-11-04 10:42:33 -05002312 if _check_change_has_branch_field not in enabled_hooks:
2313 enabled_hooks.add(_check_change_has_no_branch_field)
2314
Mike Frysinger3554bc92015-03-11 04:59:21 -04002315 return enabled_hooks, disabled_hooks
Ryan Cui9b651632011-05-11 11:38:58 -07002316
2317
Jon Salz3ee59de2012-08-18 13:54:22 +08002318def _get_project_hook_scripts(config):
2319 """Returns a list of project-specific hook scripts.
2320
2321 Args:
2322 config: A ConfigParser for the project's config file.
2323 """
2324 SECTION = 'Hook Scripts'
2325 if not config.has_section(SECTION):
2326 return []
2327
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002328 return config.items(SECTION)
Jon Salz3ee59de2012-08-18 13:54:22 +08002329
2330
Mike Frysingerff916c62020-12-18 01:58:08 -05002331def _get_project_hooks(presubmit, config_file=None):
Ryan Cui9b651632011-05-11 11:38:58 -07002332 """Returns a list of hooks that need to be run for a project.
2333
2334 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002335
2336 Args:
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002337 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002338 config_file: A string, the config file. Defaults to _CONFIG_FILE.
Ryan Cui9b651632011-05-11 11:38:58 -07002339 """
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04002340 config = configparser.RawConfigParser()
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002341 if config_file is None:
2342 config_file = _CONFIG_FILE
2343 if not os.path.exists(config_file):
Jon Salz3ee59de2012-08-18 13:54:22 +08002344 # Just use an empty config file
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04002345 config = configparser.RawConfigParser()
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09002346 else:
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002347 config.read(config_file)
Jon Salz3ee59de2012-08-18 13:54:22 +08002348
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002349 if presubmit:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07002350 hooks = _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002351 else:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07002352 hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002353
Mike Frysinger3554bc92015-03-11 04:59:21 -04002354 enabled_hooks, disabled_hooks = _get_override_hooks(config)
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07002355 hooks = [hook for hook in hooks if hook not in disabled_hooks]
2356
2357 # If a list is both in _COMMON_HOOKS and also enabled explicitly through an
2358 # override, keep the override only. Note that the override may end up being
2359 # a functools.partial, in which case we need to extract the .func to compare
2360 # it to the common hooks.
2361 unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks]
2362 hooks = [hook for hook in hooks if hook not in unwrapped_hooks]
2363
2364 hooks = list(enabled_hooks) + hooks
Ryan Cui9b651632011-05-11 11:38:58 -07002365
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002366 for name, script in _get_project_hook_scripts(config):
2367 func = functools.partial(_run_project_hook_script, script)
2368 func.__name__ = name
2369 hooks.append(func)
Jon Salz3ee59de2012-08-18 13:54:22 +08002370
Ryan Cui9b651632011-05-11 11:38:58 -07002371 return hooks
2372
2373
Alex Deymo643ac4c2015-09-03 10:40:50 -07002374def _run_project_hooks(project_name, proj_dir=None,
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002375 commit_list=None, presubmit=False,
2376 config_file=None):
Ryan Cui1562fb82011-05-09 11:01:31 -07002377 """For each project run its project specific hook from the hooks dictionary.
2378
2379 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002380 project_name: The name of project to run hooks for.
Doug Anderson44a644f2011-11-02 10:37:37 -07002381 proj_dir: If non-None, this is the directory the project is in. If None,
2382 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07002383 commit_list: A list of commits to run hooks against. If None or empty list
2384 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002385 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002386 config_file: A string, the presubmit config file. If not specified,
2387 defaults to PRESUBMIT.cfg in the project directory.
Ryan Cui1562fb82011-05-09 11:01:31 -07002388
2389 Returns:
2390 Boolean value of whether any errors were ecountered while running the hooks.
2391 """
Doug Anderson44a644f2011-11-02 10:37:37 -07002392 if proj_dir is None:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002393 proj_dirs = _run_command(
2394 ['repo', 'forall', project_name, '-c', 'pwd']).split()
Mike Frysingere52b1bc2019-09-16 23:45:41 -04002395 if not proj_dirs:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002396 print('%s cannot be found.' % project_name, file=sys.stderr)
David James2edd9002013-10-11 14:09:19 -07002397 print('Please specify a valid project.', file=sys.stderr)
2398 return True
2399 if len(proj_dirs) > 1:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002400 print('%s is associated with multiple directories.' % project_name,
David James2edd9002013-10-11 14:09:19 -07002401 file=sys.stderr)
2402 print('Please specify a directory to help disambiguate.', file=sys.stderr)
2403 return True
2404 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07002405
Ryan Cuiec4d6332011-05-02 14:15:25 -07002406 pwd = os.getcwd()
2407 # hooks assume they are run from the root of the project
2408 os.chdir(proj_dir)
2409
Mike Frysingered1b95a2019-12-12 19:04:51 -05002410 color = terminal.Color()
2411
Alex Deymo643ac4c2015-09-03 10:40:50 -07002412 remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref',
2413 '--symbolic-full-name', '@{u}']).strip()
2414 if not remote_branch:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002415 print("Your project %s doesn't track any remote repo." % project_name,
Alex Deymo643ac4c2015-09-03 10:40:50 -07002416 file=sys.stderr)
2417 remote = None
2418 else:
Josh Pratt15d13ab2018-08-13 11:52:48 +10002419 branch_items = remote_branch.split('/', 1)
2420 if len(branch_items) != 2:
2421 PrintErrorForProject(
2422 project_name,
2423 HookFailure(
2424 'Cannot get remote and branch name (%s)' % remote_branch))
2425 os.chdir(pwd)
2426 return True
2427 remote, _branch = branch_items
Alex Deymo643ac4c2015-09-03 10:40:50 -07002428
2429 project = Project(name=project_name, dir=proj_dir, remote=remote)
2430
Doug Anderson14749562013-06-26 13:38:29 -07002431 if not commit_list:
2432 try:
2433 commit_list = _get_commits()
2434 except VerifyException as e:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002435 PrintErrorForProject(project.name, HookFailure(str(e)))
Doug Anderson14749562013-06-26 13:38:29 -07002436 os.chdir(pwd)
2437 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07002438
Mike Frysingerff916c62020-12-18 01:58:08 -05002439 hooks = _get_project_hooks(presubmit, config_file)
Ryan Cui1562fb82011-05-09 11:01:31 -07002440 error_found = False
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002441 commit_count = len(commit_list)
Mike Frysingerb99b3772019-08-17 14:19:44 -04002442 hook_count = len(hooks)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002443 for i, commit in enumerate(commit_list):
Mike Frysingerb2496652019-09-12 23:35:46 -04002444 CACHE.clear()
2445
LaMont Jones69d3e182020-03-11 15:00:53 -06002446 # If run with --pre-submit, then commit is PRE_SUBMIT, and not a commit.
2447 # Use that as the description.
2448 desc = commit if commit == PRE_SUBMIT else _get_commit_desc(commit)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002449 print('[%s %i/%i %s] %s' %
2450 (color.Color(color.CYAN, 'COMMIT'), i + 1, commit_count, commit[0:12],
2451 desc.splitlines()[0]))
2452
Mike Frysingerb99b3772019-08-17 14:19:44 -04002453 for h, hook in enumerate(hooks):
Mike Frysingered1b95a2019-12-12 19:04:51 -05002454 output = ('[%s %i/%i PRESUBMIT.cfg] %s' %
2455 (color.Color(color.YELLOW, 'RUNNING'), h + 1, hook_count,
2456 hook.__name__))
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002457 print(output, end='\r')
2458 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002459 hook_error = hook(project, commit)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002460 print(' ' * len(output), end='\r')
2461 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002462 if hook_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002463 if not isinstance(hook_error, list):
2464 hook_error = [hook_error]
2465 PrintErrorsForCommit(color, hook, project.name, hook_error)
Ryan Cui1562fb82011-05-09 11:01:31 -07002466 error_found = True
Don Garrettdba548a2011-05-05 15:17:14 -07002467
Ryan Cuiec4d6332011-05-02 14:15:25 -07002468 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07002469 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002470
Mike Frysingerae409522014-02-01 03:16:11 -05002471
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002472# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002473
Ryan Cui1562fb82011-05-09 11:01:31 -07002474
Mike Frysingerae409522014-02-01 03:16:11 -05002475def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08002476 """Main function invoked directly by repo.
2477
2478 This function will exit directly upon error so that repo doesn't print some
2479 obscure error message.
2480
2481 Args:
2482 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07002483 worktree_list: A list of directories. It should be the same length as
2484 project_list, so that each entry in project_list matches with a directory
2485 in worktree_list. If None, we will attempt to calculate the directories
2486 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08002487 kwargs: Leave this here for forward-compatibility.
2488 """
Mike Frysingered1b95a2019-12-12 19:04:51 -05002489 start_time = datetime.datetime.now()
Ryan Cui1562fb82011-05-09 11:01:31 -07002490 found_error = False
David James2edd9002013-10-11 14:09:19 -07002491 if not worktree_list:
2492 worktree_list = [None] * len(project_list)
2493 for project, worktree in zip(project_list, worktree_list):
2494 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07002495 found_error = True
2496
Mike Frysingered1b95a2019-12-12 19:04:51 -05002497 end_time = datetime.datetime.now()
2498 color = terminal.Color()
Mike Frysingerae409522014-02-01 03:16:11 -05002499 if found_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002500 msg = ('%s: Preupload failed due to above error(s).\n'
Ryan Cui9b651632011-05-11 11:38:58 -07002501 '- To disable some source style checks, and for other hints, see '
Mike Frysingered1b95a2019-12-12 19:04:51 -05002502 '<checkout_dir>/src/repohooks/README.md\n'
2503 "- To upload only current project, run 'repo upload .'" %
2504 (color.Color(color.RED, 'FATAL'),))
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04002505 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07002506 sys.exit(1)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002507 else:
2508 msg = ('[%s] repohooks passed in %s' %
2509 (color.Color(color.GREEN, 'PASSED'), end_time - start_time))
2510 print(msg)
Anush Elangovan63afad72011-03-23 00:41:27 -07002511
Ryan Cui1562fb82011-05-09 11:01:31 -07002512
Doug Anderson44a644f2011-11-02 10:37:37 -07002513def _identify_project(path):
2514 """Identify the repo project associated with the given path.
2515
2516 Returns:
2517 A string indicating what project is associated with the path passed in or
2518 a blank string upon failure.
2519 """
2520 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002521 stderr=True, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002522
2523
Mike Frysinger55f85b52014-12-18 14:45:21 -05002524def direct_main(argv):
Doug Anderson44a644f2011-11-02 10:37:37 -07002525 """Run hooks directly (outside of the context of repo).
2526
Doug Anderson44a644f2011-11-02 10:37:37 -07002527 Args:
Mike Frysinger55f85b52014-12-18 14:45:21 -05002528 argv: The command line args to process
Doug Anderson44a644f2011-11-02 10:37:37 -07002529
2530 Returns:
2531 0 if no pre-upload failures, 1 if failures.
2532
2533 Raises:
2534 BadInvocation: On some types of invocation errors.
2535 """
Mike Frysinger66142932014-12-18 14:55:57 -05002536 parser = commandline.ArgumentParser(description=__doc__)
2537 parser.add_argument('--dir', default=None,
2538 help='The directory that the project lives in. If not '
2539 'specified, use the git project root based on the cwd.')
2540 parser.add_argument('--project', default=None,
2541 help='The project repo path; this can affect how the '
2542 'hooks get run, since some hooks are project-specific. '
2543 'For chromite this is chromiumos/chromite. If not '
2544 'specified, the repo tool will be used to figure this '
2545 'out based on the dir.')
2546 parser.add_argument('--rerun-since', default=None,
Vadim Bendebury75447b92018-01-10 12:06:01 -08002547 help='Rerun hooks on old commits since some point '
2548 'in the past. The argument could be a date (should '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002549 "match git log's concept of a date, e.g. 2012-06-20), "
Vadim Bendebury75447b92018-01-10 12:06:01 -08002550 'or a SHA1, or just a number of commits to check (from 1 '
2551 'to 99). This option is mutually exclusive with '
2552 '--pre-submit.')
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002553 parser.add_argument('--pre-submit', action='store_true',
Mike Frysinger66142932014-12-18 14:55:57 -05002554 help='Run the check against the pending commit. '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002555 "This option should be used at the 'git commit' "
2556 "phase as opposed to 'repo upload'. This option "
Mike Frysinger66142932014-12-18 14:55:57 -05002557 'is mutually exclusive with --rerun-since.')
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002558 parser.add_argument('--presubmit-config',
2559 help='Specify presubmit config file to be used.')
Mike Frysinger66142932014-12-18 14:55:57 -05002560 parser.add_argument('commits', nargs='*',
2561 help='Check specific commits')
2562 opts = parser.parse_args(argv)
Doug Anderson44a644f2011-11-02 10:37:37 -07002563
Doug Anderson14749562013-06-26 13:38:29 -07002564 if opts.rerun_since:
Mike Frysinger66142932014-12-18 14:55:57 -05002565 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002566 raise BadInvocation("Can't pass commits and use rerun-since: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002567 ' '.join(opts.commits))
Doug Anderson14749562013-06-26 13:38:29 -07002568
Vadim Bendebury75447b92018-01-10 12:06:01 -08002569 if len(opts.rerun_since) < 3 and opts.rerun_since.isdigit():
2570 # This must be the number of commits to check. We don't expect the user
2571 # to want to check more than 99 commits.
2572 limit = '-n%s' % opts.rerun_since
2573 elif git.IsSHA1(opts.rerun_since, False):
2574 limit = '%s..' % opts.rerun_since
2575 else:
2576 # This better be a date.
2577 limit = '--since=%s' % opts.rerun_since
2578 cmd = ['git', 'log', limit, '--pretty=%H']
Doug Anderson14749562013-06-26 13:38:29 -07002579 all_commits = _run_command(cmd).splitlines()
2580 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
2581
2582 # Eliminate chrome-bot commits but keep ordering the same...
2583 bot_commits = set(bot_commits)
Mike Frysinger66142932014-12-18 14:55:57 -05002584 opts.commits = [c for c in all_commits if c not in bot_commits]
Doug Anderson14749562013-06-26 13:38:29 -07002585
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002586 if opts.pre_submit:
2587 raise BadInvocation('rerun-since and pre-submit can not be '
2588 'used together')
2589 if opts.pre_submit:
Mike Frysinger66142932014-12-18 14:55:57 -05002590 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002591 raise BadInvocation("Can't pass commits and use pre-submit: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002592 ' '.join(opts.commits))
2593 opts.commits = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07002594
2595 # Check/normlaize git dir; if unspecified, we'll use the root of the git
2596 # project from CWD
2597 if opts.dir is None:
Mike Frysinger9ba001a2020-11-20 01:02:11 -05002598 git_dir = _run_command(['git', 'rev-parse', '--show-toplevel'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002599 stderr=True).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002600 if not git_dir:
2601 raise BadInvocation('The current directory is not part of a git project.')
Mike Frysinger9ba001a2020-11-20 01:02:11 -05002602 opts.dir = git_dir
Doug Anderson44a644f2011-11-02 10:37:37 -07002603 elif not os.path.isdir(opts.dir):
2604 raise BadInvocation('Invalid dir: %s' % opts.dir)
2605 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
2606 raise BadInvocation('Not a git directory: %s' % opts.dir)
2607
2608 # Identify the project if it wasn't specified; this _requires_ the repo
2609 # tool to be installed and for the project to be part of a repo checkout.
2610 if not opts.project:
2611 opts.project = _identify_project(opts.dir)
2612 if not opts.project:
2613 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
2614
Doug Anderson14749562013-06-26 13:38:29 -07002615 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Mike Frysinger66142932014-12-18 14:55:57 -05002616 commit_list=opts.commits,
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002617 presubmit=opts.pre_submit,
2618 config_file=opts.presubmit_config)
Doug Anderson44a644f2011-11-02 10:37:37 -07002619 if found_error:
2620 return 1
2621 return 0
2622
2623
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002624if __name__ == '__main__':
Mike Frysinger55f85b52014-12-18 14:45:21 -05002625 sys.exit(direct_main(sys.argv[1:]))