blob: a8c4240250fdd3bdbefe2a39cba6092b6a3e5f5e [file] [log] [blame]
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08001#!/usr/bin/env python2
Jon Salz98255932012-08-18 14:48:02 +08002# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
Mike Frysingerae409522014-02-01 03:16:11 -05006"""Presubmit checks to run when doing `repo upload`.
7
8You can add new checks by adding a functions to the HOOKS constants.
9"""
10
Mike Frysinger09d6a3d2013-10-08 22:21:03 -040011from __future__ import print_function
12
Filipe Brandenburger4b542b12015-10-09 12:46:31 -070013import argparse
Alex Deymo643ac4c2015-09-03 10:40:50 -070014import collections
Ryan Cui9b651632011-05-11 11:38:58 -070015import ConfigParser
Daniel Erate3ea3fc2015-02-13 15:27:52 -070016import fnmatch
Jon Salz3ee59de2012-08-18 13:54:22 +080017import functools
Dale Curtis2975c432011-05-03 17:25:20 -070018import json
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070019import os
Ryan Cuiec4d6332011-05-02 14:15:25 -070020import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070021import sys
Peter Ammon811f6702014-06-12 15:45:38 -070022import stat
Aviv Keshet5ac59522017-01-31 14:28:27 -080023import StringIO
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070024
Ryan Cui1562fb82011-05-09 11:01:31 -070025from errors import (VerifyException, HookFailure, PrintErrorForProject,
26 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070027
David Jamesc3b68b32013-04-03 09:17:03 -070028# If repo imports us, the __name__ will be __builtin__, and the wrapper will
29# be in $CHROMEOS_CHECKOUT/.repo/repo/main.py, so we need to go two directories
30# up. The same logic also happens to work if we're executed directly.
31if __name__ in ('__builtin__', '__main__'):
32 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
33
Mike Frysinger66142932014-12-18 14:55:57 -050034from chromite.lib import commandline
Aviv Keshet5ac59522017-01-31 14:28:27 -080035from chromite.lib import constants
Rahul Chaudhry0e515342015-08-07 12:00:43 -070036from chromite.lib import cros_build_lib
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050037from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070038from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070039from chromite.lib import patch
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040040from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070041
Vadim Bendebury2b62d742014-06-22 13:14:51 -070042PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070043
44COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050045 # C++ and friends
46 r".*\.c$", r".*\.cc$", r".*\.cpp$", r".*\.h$", r".*\.m$", r".*\.mm$",
47 r".*\.inl$", r".*\.asm$", r".*\.hxx$", r".*\.hpp$", r".*\.s$", r".*\.S$",
48 # Scripts
49 r".*\.js$", r".*\.py$", r".*\.sh$", r".*\.rb$", r".*\.pl$", r".*\.pm$",
50 # No extension at all, note that ALL CAPS files are black listed in
51 # COMMON_EXCLUDED_LIST below.
52 r"(^|.*[\\\/])[^.]+$",
53 # Other
54 r".*\.java$", r".*\.mk$", r".*\.am$",
Brian Norrisfdbac8e2016-06-16 11:09:05 -070055 r".*\.policy$", r".*\.conf$",
Ryan Cuiec4d6332011-05-02 14:15:25 -070056]
57
Ryan Cui1562fb82011-05-09 11:01:31 -070058
Ryan Cuiec4d6332011-05-02 14:15:25 -070059COMMON_EXCLUDED_PATHS = [
Daniel Erate3ea3fc2015-02-13 15:27:52 -070060 # Avoid doing source file checks for kernel.
Mike Frysingerae409522014-02-01 03:16:11 -050061 r"/src/third_party/kernel/",
62 r"/src/third_party/kernel-next/",
63 r"/src/third_party/ktop/",
64 r"/src/third_party/punybench/",
65 r".*\bexperimental[\\\/].*",
66 r".*\b[A-Z0-9_]{2,}$",
67 r".*[\\\/]debian[\\\/]rules$",
Daniel Erate3ea3fc2015-02-13 15:27:52 -070068
69 # For ebuild trees, ignore any caches and manifest data.
Mike Frysingerae409522014-02-01 03:16:11 -050070 r".*/Manifest$",
71 r".*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$",
Doug Anderson5bfb6792011-10-25 16:45:41 -070072
Daniel Erate3ea3fc2015-02-13 15:27:52 -070073 # Ignore profiles data (like overlay-tegra2/profiles).
Mike Frysinger94a670c2014-09-19 12:46:26 -040074 r"(^|.*/)overlay-.*/profiles/.*",
Mike Frysinger98638102014-08-28 00:15:08 -040075 r"^profiles/.*$",
76
C Shapiro8f90e9b2017-06-28 09:54:50 -060077 # Ignore config files in ebuild setup.
78 r"(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*",
79 r"^chromeos-base/chromeos-bsp.*/files/.*",
80
Daniel Erate3ea3fc2015-02-13 15:27:52 -070081 # Ignore minified js and jquery.
Mike Frysingerae409522014-02-01 03:16:11 -050082 r".*\.min\.js",
83 r".*jquery.*\.js",
Mike Frysinger33a458d2014-03-03 17:00:51 -050084
85 # Ignore license files as the content is often taken verbatim.
Daniel Erate3ea3fc2015-02-13 15:27:52 -070086 r".*/licenses/.*",
Ryan Cuiec4d6332011-05-02 14:15:25 -070087]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070088
Ryan Cui1562fb82011-05-09 11:01:31 -070089
Ryan Cui9b651632011-05-11 11:38:58 -070090_CONFIG_FILE = 'PRESUBMIT.cfg'
91
92
Daniel Erate3ea3fc2015-02-13 15:27:52 -070093# File containing wildcards, one per line, matching files that should be
94# excluded from presubmit checks. Lines beginning with '#' are ignored.
95_IGNORE_FILE = '.presubmitignore'
96
97
Doug Anderson44a644f2011-11-02 10:37:37 -070098# Exceptions
99
100
101class BadInvocation(Exception):
102 """An Exception indicating a bad invocation of the program."""
103 pass
104
105
Ryan Cui1562fb82011-05-09 11:01:31 -0700106# General Helpers
107
Sean Paulba01d402011-05-05 11:36:23 -0400108
Alex Deymo643ac4c2015-09-03 10:40:50 -0700109Project = collections.namedtuple('Project', ['name', 'dir', 'remote'])
110
111
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700112# pylint: disable=redefined-builtin
113def _run_command(cmd, cwd=None, input=None,
114 redirect_stderr=False, combine_stdout_stderr=False):
Doug Anderson44a644f2011-11-02 10:37:37 -0700115 """Executes the passed in command and returns raw stdout output.
116
117 Args:
118 cmd: The command to run; should be a list of strings.
119 cwd: The directory to switch to for running the command.
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700120 input: The data to pipe into this command through stdin. If a file object
121 or file descriptor, stdin will be connected directly to that.
122 redirect_stderr: Redirect stderr away from console.
123 combine_stdout_stderr: Combines stdout and stderr streams into stdout.
Doug Anderson44a644f2011-11-02 10:37:37 -0700124
125 Returns:
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700126 The stdout from the process (discards stderr and returncode).
Doug Anderson44a644f2011-11-02 10:37:37 -0700127 """
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700128 return cros_build_lib.RunCommand(cmd=cmd,
129 cwd=cwd,
130 print_cmd=False,
131 input=input,
132 stdout_to_pipe=True,
133 redirect_stderr=redirect_stderr,
134 combine_stdout_stderr=combine_stdout_stderr,
135 error_code_ok=True).output
136# pylint: enable=redefined-builtin
Ryan Cui72834d12011-05-05 14:51:33 -0700137
Ryan Cui1562fb82011-05-09 11:01:31 -0700138
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700139def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700140 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700141 if __name__ == '__main__':
142 # Works when file is run on its own (__file__ is defined)...
143 return os.path.abspath(os.path.dirname(__file__))
144 else:
145 # We need to do this when we're run through repo. Since repo executes
146 # us with execfile(), we don't get __file__ defined.
147 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
148 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700149
Ryan Cui1562fb82011-05-09 11:01:31 -0700150
Ryan Cuiec4d6332011-05-02 14:15:25 -0700151def _match_regex_list(subject, expressions):
152 """Try to match a list of regular expressions to a string.
153
154 Args:
155 subject: The string to match regexes on
156 expressions: A list of regular expressions to check for matches with.
157
158 Returns:
159 Whether the passed in subject matches any of the passed in regexes.
160 """
161 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500162 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700163 return True
164 return False
165
Ryan Cui1562fb82011-05-09 11:01:31 -0700166
Mike Frysingerae409522014-02-01 03:16:11 -0500167def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700168 """Filter out files based on the conditions passed in.
169
170 Args:
171 files: list of filepaths to filter
172 include_list: list of regex that when matched with a file path will cause it
173 to be added to the output list unless the file is also matched with a
174 regex in the exclude_list.
175 exclude_list: list of regex that when matched with a file will prevent it
176 from being added to the output list, even if it is also matched with a
177 regex in the include_list.
178
179 Returns:
180 A list of filepaths that contain files matched in the include_list and not
181 in the exclude_list.
182 """
183 filtered = []
184 for f in files:
185 if (_match_regex_list(f, include_list) and
186 not _match_regex_list(f, exclude_list)):
187 filtered.append(f)
188 return filtered
189
Ryan Cuiec4d6332011-05-02 14:15:25 -0700190
191# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700192
193
Ryan Cui4725d952011-05-05 15:41:19 -0700194def _get_upstream_branch():
195 """Returns the upstream tracking branch of the current branch.
196
197 Raises:
198 Error if there is no tracking branch
199 """
200 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
201 current_branch = current_branch.replace('refs/heads/', '')
202 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700203 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700204
205 cfg_option = 'branch.' + current_branch + '.%s'
206 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
207 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
208 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700209 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700210
211 return full_upstream.replace('heads', 'remotes/' + remote)
212
Ryan Cui1562fb82011-05-09 11:01:31 -0700213
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700214def _get_patch(commit):
215 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700216 if commit == PRE_SUBMIT:
217 return _run_command(['git', 'diff', '--cached', 'HEAD'])
218 else:
219 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700220
Ryan Cui1562fb82011-05-09 11:01:31 -0700221
Jon Salz98255932012-08-18 14:48:02 +0800222def _try_utf8_decode(data):
223 """Attempts to decode a string as UTF-8.
224
225 Returns:
226 The decoded Unicode object, or the original string if parsing fails.
227 """
228 try:
229 return unicode(data, 'utf-8', 'strict')
230 except UnicodeDecodeError:
231 return data
232
233
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500234def _get_file_content(path, commit):
235 """Returns the content of a file at a specific commit.
236
237 We can't rely on the file as it exists in the filesystem as people might be
238 uploading a series of changes which modifies the file multiple times.
239
240 Note: The "content" of a symlink is just the target. So if you're expecting
241 a full file, you should check that first. One way to detect is that the
242 content will not have any newlines.
243 """
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700244 if commit == PRE_SUBMIT:
245 return _run_command(['git', 'diff', 'HEAD', path])
246 else:
247 return _run_command(['git', 'show', '%s:%s' % (commit, path)])
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500248
249
Mike Frysingerae409522014-02-01 03:16:11 -0500250def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700251 """Returns a list of (linenum, lines) tuples that the commit touched."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700252 if commit == PRE_SUBMIT:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800253 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD',
254 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700255 else:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800256 command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit,
257 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700258 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700259
260 new_lines = []
261 line_num = 0
262 for line in output.splitlines():
263 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
264 if m:
265 line_num = int(m.groups(1)[0])
266 continue
267 if line.startswith('+') and not line.startswith('++'):
Jon Salz98255932012-08-18 14:48:02 +0800268 new_lines.append((line_num, _try_utf8_decode(line[1:])))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700269 if not line.startswith('-'):
270 line_num += 1
271 return new_lines
272
Ryan Cui1562fb82011-05-09 11:01:31 -0700273
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700274def _get_ignore_wildcards(directory, cache):
275 """Get wildcards listed in a directory's _IGNORE_FILE.
276
277 Args:
278 directory: A string containing a directory path.
279 cache: A dictionary (opaque to caller) caching previously-read wildcards.
280
281 Returns:
282 A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE
283 wasn't present.
284 """
285 # In the cache, keys are directories and values are lists of wildcards from
286 # _IGNORE_FILE within those directories (and empty if no file was present).
287 if directory not in cache:
288 wildcards = []
289 dotfile_path = os.path.join(directory, _IGNORE_FILE)
290 if os.path.exists(dotfile_path):
291 # TODO(derat): Consider using _get_file_content() to get the file as of
292 # this commit instead of the on-disk version. This may have a noticeable
293 # performance impact, as each call to _get_file_content() runs git.
294 with open(dotfile_path, 'r') as dotfile:
295 for line in dotfile.readlines():
296 line = line.strip()
297 if line.startswith('#'):
298 continue
299 if line.endswith('/'):
300 line += '*'
301 wildcards.append(line)
302 cache[directory] = wildcards
303
304 return cache[directory]
305
306
307def _path_is_ignored(path, cache):
308 """Check whether a path is ignored by _IGNORE_FILE.
309
310 Args:
311 path: A string containing a path.
312 cache: A dictionary (opaque to caller) caching previously-read wildcards.
313
314 Returns:
315 True if a file named _IGNORE_FILE in one of the passed-in path's parent
316 directories contains a wildcard matching the path.
317 """
318 # Skip ignore files.
319 if os.path.basename(path) == _IGNORE_FILE:
320 return True
321
322 path = os.path.abspath(path)
323 base = os.getcwd()
324
325 prefix = os.path.dirname(path)
326 while prefix.startswith(base):
327 rel_path = path[len(prefix) + 1:]
328 for wildcard in _get_ignore_wildcards(prefix, cache):
329 if fnmatch.fnmatch(rel_path, wildcard):
330 return True
331 prefix = os.path.dirname(prefix)
332
333 return False
334
335
Mike Frysinger292b45d2014-11-25 01:17:10 -0500336def _get_affected_files(commit, include_deletes=False, relative=False,
337 include_symlinks=False, include_adds=True,
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700338 full_details=False, use_ignore_files=True):
Peter Ammon811f6702014-06-12 15:45:38 -0700339 """Returns list of file paths that were modified/added, excluding symlinks.
340
341 Args:
342 commit: The commit
343 include_deletes: If true, we'll include deleted files in the result
344 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500345 include_symlinks: If true, we'll include symlinks in the result
346 include_adds: If true, we'll include new files in the result
347 full_details: If False, return filenames, else return structured results.
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700348 use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files.
Peter Ammon811f6702014-06-12 15:45:38 -0700349
350 Returns:
351 A list of modified/added (and perhaps deleted) files
352 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500353 if not relative and full_details:
354 raise ValueError('full_details only supports relative paths currently')
355
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700356 if commit == PRE_SUBMIT:
357 return _run_command(['git', 'diff-index', '--cached',
358 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500359
360 path = os.getcwd()
361 files = git.RawDiff(path, '%s^!' % commit)
362
363 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500364 if not include_symlinks:
365 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500366
367 if not include_deletes:
368 files = [x for x in files if x.status != 'D']
369
Mike Frysinger292b45d2014-11-25 01:17:10 -0500370 if not include_adds:
371 files = [x for x in files if x.status != 'A']
372
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700373 if use_ignore_files:
374 cache = {}
375 is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache)
376 files = [x for x in files if not is_ignored(x)]
377
Mike Frysinger292b45d2014-11-25 01:17:10 -0500378 if full_details:
379 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500380 return files
381 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500382 # Caller only cares about filenames.
383 files = [x.dst_file if x.dst_file else x.src_file for x in files]
384 if relative:
385 return files
386 else:
387 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700388
389
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700390def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700391 """Returns a list of commits for this review."""
Ryan Cui4725d952011-05-05 15:41:19 -0700392 cmd = ['git', 'log', '%s..' % _get_upstream_branch(), '--format=%H']
Ryan Cui72834d12011-05-05 14:51:33 -0700393 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700394
Ryan Cui1562fb82011-05-09 11:01:31 -0700395
Ryan Cuiec4d6332011-05-02 14:15:25 -0700396def _get_commit_desc(commit):
397 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700398 if commit == PRE_SUBMIT:
399 return ''
Sean Paul23a2c582011-05-06 13:10:44 -0400400 return _run_command(['git', 'log', '--format=%s%n%n%b', commit + '^!'])
Ryan Cuiec4d6332011-05-02 14:15:25 -0700401
402
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800403def _check_lines_in_diff(commit, files, check_callable, error_description):
404 """Checks given file for errors via the given check.
405
406 This is a convenience function for common per-line checks. It goes through all
407 files and returns a HookFailure with the error description listing all the
408 failures.
409
410 Args:
411 commit: The commit we're working on.
412 files: The files to check.
413 check_callable: A callable that takes a line and returns True if this line
414 _fails_ the check.
415 error_description: A string describing the error.
416 """
417 errors = []
418 for afile in files:
419 for line_num, line in _get_file_diff(afile, commit):
420 if check_callable(line):
421 errors.append('%s, line %s' % (afile, line_num))
422 if errors:
423 return HookFailure(error_description, errors)
424
425
Ryan Cuiec4d6332011-05-02 14:15:25 -0700426# Common Hooks
427
Ryan Cui1562fb82011-05-09 11:01:31 -0700428
Mike Frysingerae409522014-02-01 03:16:11 -0500429def _check_no_long_lines(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -0500430 """Checks there are no lines longer than MAX_LEN in any of the text files."""
431
Ryan Cuiec4d6332011-05-02 14:15:25 -0700432 MAX_LEN = 80
Jon Salz98255932012-08-18 14:48:02 +0800433 SKIP_REGEXP = re.compile('|'.join([
434 r'https?://',
435 r'^#\s*(define|include|import|pragma|if|endif)\b']))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700436
437 errors = []
438 files = _filter_files(_get_affected_files(commit),
439 COMMON_INCLUDED_PATHS,
440 COMMON_EXCLUDED_PATHS)
441
442 for afile in files:
443 for line_num, line in _get_file_diff(afile, commit):
444 # Allow certain lines to exceed the maxlen rule.
Mike Frysingerae409522014-02-01 03:16:11 -0500445 if len(line) <= MAX_LEN or SKIP_REGEXP.search(line):
Jon Salz98255932012-08-18 14:48:02 +0800446 continue
447
448 errors.append('%s, line %s, %s chars' % (afile, line_num, len(line)))
449 if len(errors) == 5: # Just show the first 5 errors.
450 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700451
452 if errors:
453 msg = 'Found lines longer than %s characters (first 5 shown):' % MAX_LEN
Ryan Cui1562fb82011-05-09 11:01:31 -0700454 return HookFailure(msg, errors)
455
Ryan Cuiec4d6332011-05-02 14:15:25 -0700456
Mike Frysingerae409522014-02-01 03:16:11 -0500457def _check_no_stray_whitespace(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700458 """Checks that there is no stray whitespace at source lines end."""
Ryan Cuiec4d6332011-05-02 14:15:25 -0700459 files = _filter_files(_get_affected_files(commit),
Mike Frysingerae409522014-02-01 03:16:11 -0500460 COMMON_INCLUDED_PATHS,
461 COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800462 return _check_lines_in_diff(commit, files,
463 lambda line: line.rstrip() != line,
464 'Found line ending with white space in:')
Ryan Cui1562fb82011-05-09 11:01:31 -0700465
Ryan Cuiec4d6332011-05-02 14:15:25 -0700466
Mike Frysingerae409522014-02-01 03:16:11 -0500467def _check_no_tabs(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700468 """Checks there are no unexpanded tabs."""
469 TAB_OK_PATHS = [
Ryan Cui31e0c172011-05-04 21:00:45 -0700470 r"/src/third_party/u-boot/",
C Shapiroa270fce2017-06-29 09:27:03 -0600471 r"/src/third_party/bluez/",
Ryan Cuiec4d6332011-05-02 14:15:25 -0700472 r".*\.ebuild$",
473 r".*\.eclass$",
Elly Jones5ab34192011-11-15 14:57:06 -0500474 r".*/[M|m]akefile$",
475 r".*\.mk$"
Ryan Cuiec4d6332011-05-02 14:15:25 -0700476 ]
477
Ryan Cuiec4d6332011-05-02 14:15:25 -0700478 files = _filter_files(_get_affected_files(commit),
479 COMMON_INCLUDED_PATHS,
480 COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800481 return _check_lines_in_diff(commit, files,
482 lambda line: '\t' in line,
483 'Found a tab character in:')
Ryan Cuiec4d6332011-05-02 14:15:25 -0700484
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800485
486def _check_tabbed_indents(_project, commit):
487 """Checks that indents use tabs only."""
488 TABS_REQUIRED_PATHS = [
489 r".*\.ebuild$",
490 r".*\.eclass$",
491 ]
492 LEADING_SPACE_RE = re.compile('[\t]* ')
493
494 files = _filter_files(_get_affected_files(commit),
495 TABS_REQUIRED_PATHS,
496 COMMON_EXCLUDED_PATHS)
497 return _check_lines_in_diff(
498 commit, files,
499 lambda line: LEADING_SPACE_RE.match(line) is not None,
500 'Found a space in indentation (must be all tabs):')
Ryan Cui1562fb82011-05-09 11:01:31 -0700501
Ryan Cuiec4d6332011-05-02 14:15:25 -0700502
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700503def _check_gofmt(_project, commit):
504 """Checks that Go files are formatted with gofmt."""
505 errors = []
506 files = _filter_files(_get_affected_files(commit, relative=True),
507 [r'\.go$'])
508
509 for gofile in files:
510 contents = _get_file_content(gofile, commit)
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700511 output = _run_command(cmd=['gofmt', '-l'], input=contents,
512 combine_stdout_stderr=True)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700513 if output:
514 errors.append(gofile)
515 if errors:
516 return HookFailure('Files not formatted with gofmt:', errors)
517
518
Mike Frysingerae409522014-02-01 03:16:11 -0500519def _check_change_has_test_field(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700520 """Check for a non-empty 'TEST=' field in the commit message."""
David McMahon8f6553e2011-06-10 15:46:36 -0700521 TEST_RE = r'\nTEST=\S+'
Ryan Cuiec4d6332011-05-02 14:15:25 -0700522
Mandeep Singh Baines96a53be2011-05-03 11:10:25 -0700523 if not re.search(TEST_RE, _get_commit_desc(commit)):
Ryan Cui1562fb82011-05-09 11:01:31 -0700524 msg = 'Changelist description needs TEST field (after first line)'
525 return HookFailure(msg)
526
Ryan Cuiec4d6332011-05-02 14:15:25 -0700527
Mike Frysingerae409522014-02-01 03:16:11 -0500528def _check_change_has_valid_cq_depend(_project, commit):
David Jamesc3b68b32013-04-03 09:17:03 -0700529 """Check for a correctly formatted CQ-DEPEND field in the commit message."""
530 msg = 'Changelist has invalid CQ-DEPEND target.'
531 example = 'Example: CQ-DEPEND=CL:1234, CL:2345'
532 try:
533 patch.GetPaladinDeps(_get_commit_desc(commit))
534 except ValueError as ex:
535 return HookFailure(msg, [example, str(ex)])
536
537
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800538def _check_change_is_contribution(_project, commit):
539 """Check that the change is a contribution."""
540 NO_CONTRIB = 'not a contribution'
541 if NO_CONTRIB in _get_commit_desc(commit).lower():
542 msg = ('Changelist is not a contribution, this cannot be accepted.\n'
543 'Please remove the "%s" text from the commit message.') % NO_CONTRIB
544 return HookFailure(msg)
545
546
Alex Deymo643ac4c2015-09-03 10:40:50 -0700547def _check_change_has_bug_field(project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700548 """Check for a correctly formatted 'BUG=' field in the commit message."""
David James5c0073d2013-04-03 08:48:52 -0700549 OLD_BUG_RE = r'\nBUG=.*chromium-os'
550 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
551 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
552 'the chromium tracker in your BUG= line now.')
553 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700554
Alex Deymo643ac4c2015-09-03 10:40:50 -0700555 # Android internal and external projects use "Bug: " to track bugs in
556 # buganizer.
557 BUG_COLON_REMOTES = (
558 'aosp',
559 'goog',
560 )
561 if project.remote in BUG_COLON_REMOTES:
562 BUG_RE = r'\nBug: ?([Nn]one|\d+)'
563 if not re.search(BUG_RE, _get_commit_desc(commit)):
564 msg = ('Changelist description needs BUG field (after first line):\n'
565 'Bug: 9999 (for buganizer)\n'
566 'BUG=None')
567 return HookFailure(msg)
568 else:
569 BUG_RE = r'\nBUG=([Nn]one|(chrome-os-partner|chromium|brillo|b):\d+)'
570 if not re.search(BUG_RE, _get_commit_desc(commit)):
571 msg = ('Changelist description needs BUG field (after first line):\n'
572 'BUG=brillo:9999 (for Brillo tracker)\n'
573 'BUG=chromium:9999 (for public tracker)\n'
574 'BUG=chrome-os-partner:9999 (for partner tracker)\n'
575 'BUG=b:9999 (for buganizer)\n'
576 'BUG=None')
577 return HookFailure(msg)
Ryan Cui1562fb82011-05-09 11:01:31 -0700578
Ryan Cuiec4d6332011-05-02 14:15:25 -0700579
Mike Frysinger292b45d2014-11-25 01:17:10 -0500580def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -0700581 """Check that we're not missing a revbump of an ebuild in the given commit.
582
583 If the given commit touches files in a directory that has ebuilds somewhere
584 up the directory hierarchy, it's very likely that we need an ebuild revbump
585 in order for those changes to take effect.
586
587 It's not totally trivial to detect a revbump, so at least detect that an
588 ebuild with a revision number in it was touched. This should handle the
589 common case where we use a symlink to do the revbump.
590
591 TODO: it would be nice to enhance this hook to:
592 * Handle cases where people revbump with a slightly different syntax. I see
593 one ebuild (puppy) that revbumps with _pN. This is a false positive.
594 * Catches cases where people aren't using symlinks for revbumps. If they
595 edit a revisioned file directly (and are expected to rename it for revbump)
596 we'll miss that. Perhaps we could detect that the file touched is a
597 symlink?
598
599 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
600 still better off than without this check.
601
602 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700603 project: The Project to look at
Doug Anderson42b8a052013-06-26 10:45:36 -0700604 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -0500605 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -0700606
607 Returns:
608 A HookFailure or None.
609 """
Mike Frysinger011af942014-01-17 16:12:22 -0500610 # If this is the portage-stable overlay, then ignore the check. It's rare
611 # that we're doing anything other than importing files from upstream, so
612 # forcing a rev bump makes no sense.
613 whitelist = (
614 'chromiumos/overlays/portage-stable',
615 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700616 if project.name in whitelist:
Mike Frysinger011af942014-01-17 16:12:22 -0500617 return None
618
Mike Frysinger292b45d2014-11-25 01:17:10 -0500619 def FinalName(obj):
620 # If the file is being deleted, then the dst_file is not set.
621 if obj.dst_file is None:
622 return obj.src_file
623 else:
624 return obj.dst_file
625
626 affected_path_objs = _get_affected_files(
627 commit, include_deletes=True, include_symlinks=True, relative=True,
628 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -0700629
630 # Don't yell about changes to whitelisted files...
Aviv Keshet272f2e52016-04-25 14:49:44 -0700631 whitelist = ('ChangeLog', 'Manifest', 'metadata.xml', 'COMMIT-QUEUE.ini')
Mike Frysinger292b45d2014-11-25 01:17:10 -0500632 affected_path_objs = [x for x in affected_path_objs
633 if os.path.basename(FinalName(x)) not in whitelist]
634 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -0700635 return None
636
637 # If we've touched any file named with a -rN.ebuild then we'll say we're
638 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500639 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
640 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700641 if touched_revved_ebuild:
642 return None
643
Mike Frysinger292b45d2014-11-25 01:17:10 -0500644 # If we're creating new ebuilds from scratch, then we don't need an uprev.
645 # Find all the dirs that new ebuilds and ignore their files/.
646 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
647 if FinalName(x).endswith('.ebuild') and x.status == 'A']
648 affected_path_objs = [obj for obj in affected_path_objs
649 if not any(FinalName(obj).startswith(x)
650 for x in ebuild_dirs)]
651 if not affected_path_objs:
652 return
653
Doug Anderson42b8a052013-06-26 10:45:36 -0700654 # We want to examine the current contents of all directories that are parents
655 # of files that were touched (up to the top of the project).
656 #
657 # ...note: we use the current directory contents even though it may have
658 # changed since the commit we're looking at. This is just a heuristic after
659 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500660 if project_top is None:
661 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -0700662 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -0500663 for obj in affected_path_objs:
664 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -0700665 while os.path.exists(path) and not os.path.samefile(path, project_top):
666 dirs_to_check.add(path)
667 path = os.path.dirname(path)
668
669 # Look through each directory. If it's got an ebuild in it then we'll
670 # consider this as a case when we need a revbump.
Gwendal Grignoua3086c32014-12-09 11:17:22 -0800671 affected_paths = set(os.path.join(project_top, FinalName(x))
672 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700673 for dir_path in dirs_to_check:
674 contents = os.listdir(dir_path)
675 ebuilds = [os.path.join(dir_path, path)
676 for path in contents if path.endswith('.ebuild')]
677 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
678
679 # If the -9999.ebuild file was touched the bot will uprev for us.
680 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -0500681 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -0700682 continue
683
684 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500685 return HookFailure('Changelist probably needs a revbump of an ebuild, '
686 'or a -r1.ebuild symlink if this is a new ebuild:\n'
687 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -0700688
689 return None
690
691
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500692def _check_ebuild_eapi(project, commit):
693 """Make sure we have people use EAPI=4 or newer with custom ebuilds.
694
695 We want to get away from older EAPI's as it makes life confusing and they
696 have less builtin error checking.
697
698 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700699 project: The Project to look at
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500700 commit: The commit to look at
701
702 Returns:
703 A HookFailure or None.
704 """
705 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500706 # that we're doing anything other than importing files from upstream, and
707 # we shouldn't be rewriting things fundamentally anyways.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500708 whitelist = (
709 'chromiumos/overlays/portage-stable',
710 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700711 if project.name in whitelist:
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500712 return None
713
714 BAD_EAPIS = ('0', '1', '2', '3')
715
716 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
717
718 ebuilds_re = [r'\.ebuild$']
719 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
720 ebuilds_re)
721 bad_ebuilds = []
722
723 for ebuild in ebuilds:
724 # If the ebuild does not specify an EAPI, it defaults to 0.
725 eapi = '0'
726
727 lines = _get_file_content(ebuild, commit).splitlines()
728 if len(lines) == 1:
729 # This is most likely a symlink, so skip it entirely.
730 continue
731
732 for line in lines:
733 m = get_eapi.match(line)
734 if m:
735 # Once we hit the first EAPI line in this ebuild, stop processing.
736 # The spec requires that there only be one and it be first, so
737 # checking all possible values is pointless. We also assume that
738 # it's "the" EAPI line and not something in the middle of a heredoc.
739 eapi = m.group(1)
740 break
741
742 if eapi in BAD_EAPIS:
743 bad_ebuilds.append((ebuild, eapi))
744
745 if bad_ebuilds:
746 # pylint: disable=C0301
747 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
748 # pylint: enable=C0301
749 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500750 'These ebuilds are using old EAPIs. If these are imported from\n'
751 'Gentoo, then you may ignore and upload once with the --no-verify\n'
752 'flag. Otherwise, please update to 4 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500753 '\t%s\n'
754 'See this guide for more details:\n%s\n' %
755 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
756
757
Mike Frysinger89bdb852014-02-01 05:26:26 -0500758def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -0500759 """Make sure we use the new style KEYWORDS when possible in ebuilds.
760
761 If an ebuild generally does not care about the arch it is running on, then
762 ebuilds should flag it with one of:
763 KEYWORDS="*" # A stable ebuild.
764 KEYWORDS="~*" # An unstable ebuild.
765 KEYWORDS="-* ..." # Is known to only work on specific arches.
766
767 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700768 project: The Project to look at
Mike Frysingerc51ece72014-01-17 16:23:40 -0500769 commit: The commit to look at
770
771 Returns:
772 A HookFailure or None.
773 """
774 WHITELIST = set(('*', '-*', '~*'))
775
776 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
777
Mike Frysinger89bdb852014-02-01 05:26:26 -0500778 ebuilds_re = [r'\.ebuild$']
779 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
780 ebuilds_re)
781
Mike Frysinger8d42d742014-09-22 15:50:21 -0400782 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -0500783 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -0400784 # We get the full content rather than a diff as the latter does not work
785 # on new files (like when adding new ebuilds).
786 lines = _get_file_content(ebuild, commit).splitlines()
787 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -0500788 m = get_keywords.match(line)
789 if m:
790 keywords = set(m.group(1).split())
791 if not keywords or WHITELIST - keywords != WHITELIST:
792 continue
793
Mike Frysinger8d42d742014-09-22 15:50:21 -0400794 bad_ebuilds.append(ebuild)
795
796 if bad_ebuilds:
797 return HookFailure(
798 '%s\n'
799 'Please update KEYWORDS to use a glob:\n'
800 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
801 ' KEYWORDS="*"\n'
802 'If the ebuild should be marked unstable (normal for '
803 'cros-workon / 9999 ebuilds):\n'
804 ' KEYWORDS="~*"\n'
Mike Frysingerde8efea2015-05-17 03:42:26 -0400805 'If the ebuild needs to be marked for only specific arches, '
Mike Frysinger8d42d742014-09-22 15:50:21 -0400806 'then use -* like so:\n'
807 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -0500808
809
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800810def _check_ebuild_licenses(_project, commit):
811 """Check if the LICENSE field in the ebuild is correct."""
Brian Norris7a610e82016-02-17 12:24:54 -0800812 affected_paths = _get_affected_files(commit, relative=True)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800813 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
814
815 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -0800816 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800817
818 for ebuild in touched_ebuilds:
819 # Skip virutal packages.
820 if ebuild.split('/')[-3] == 'virtual':
821 continue
822
823 try:
Brian Norris7a610e82016-02-17 12:24:54 -0800824 ebuild_content = _get_file_content(ebuild, commit)
825 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800826 except ValueError as e:
827 return HookFailure(e.message, [ebuild])
828
829 # Also ignore licenses ending with '?'
830 for license_type in [x for x in license_types
831 if x not in LICENSES_IGNORE and not x.endswith('?')]:
832 try:
Mike Frysinger2ec70ed2014-08-17 19:28:34 -0400833 licenses_lib.Licensing.FindLicenseType(license_type)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800834 except AssertionError as e:
835 return HookFailure(e.message, [ebuild])
836
837
Mike Frysingercd363c82014-02-01 05:20:18 -0500838def _check_ebuild_virtual_pv(project, commit):
839 """Enforce the virtual PV policies."""
840 # If this is the portage-stable overlay, then ignore the check.
841 # We want to import virtuals as-is from upstream Gentoo.
842 whitelist = (
843 'chromiumos/overlays/portage-stable',
844 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700845 if project.name in whitelist:
Mike Frysingercd363c82014-02-01 05:20:18 -0500846 return None
847
848 # We assume the repo name is the same as the dir name on disk.
849 # It would be dumb to not have them match though.
Alex Deymo643ac4c2015-09-03 10:40:50 -0700850 project_base = os.path.basename(project.name)
Mike Frysingercd363c82014-02-01 05:20:18 -0500851
852 is_variant = lambda x: x.startswith('overlay-variant-')
853 is_board = lambda x: x.startswith('overlay-')
854 is_private = lambda x: x.endswith('-private')
855
856 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
857
858 ebuilds_re = [r'\.ebuild$']
859 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
860 ebuilds_re)
861 bad_ebuilds = []
862
863 for ebuild in ebuilds:
864 m = get_pv.match(ebuild)
865 if m:
866 overlay = m.group(1)
867 if not overlay or not is_board(overlay):
Alex Deymo643ac4c2015-09-03 10:40:50 -0700868 overlay = project_base
Mike Frysingercd363c82014-02-01 05:20:18 -0500869
870 pv = m.group(3).split('-', 1)[0]
871
Bernie Thompsone5ee1822016-01-12 14:22:23 -0800872 # Virtual versions >= 4 are special cases used above the standard
873 # versioning structure, e.g. if one has a board inheriting a board.
874 if float(pv) >= 4:
875 want_pv = pv
876 elif is_private(overlay):
Mike Frysingercd363c82014-02-01 05:20:18 -0500877 want_pv = '3.5' if is_variant(overlay) else '3'
878 elif is_board(overlay):
879 want_pv = '2.5' if is_variant(overlay) else '2'
880 else:
881 want_pv = '1'
882
883 if pv != want_pv:
884 bad_ebuilds.append((ebuild, pv, want_pv))
885
886 if bad_ebuilds:
887 # pylint: disable=C0301
888 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
889 # pylint: enable=C0301
890 return HookFailure(
891 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
892 '\t%s\n'
893 'If this is an upstream Gentoo virtual, then you may ignore this\n'
894 'check (and re-run w/--no-verify). Otherwise, please see this\n'
895 'page for more details:\n%s\n' %
896 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
897 for x in bad_ebuilds]), url))
898
899
Daniel Erat9d203ff2015-02-17 10:12:21 -0700900def _check_portage_make_use_var(_project, commit):
901 """Verify that $USE is set correctly in make.conf and make.defaults."""
902 files = _filter_files(_get_affected_files(commit, relative=True),
903 [r'(^|/)make.(conf|defaults)$'])
904
905 errors = []
906 for path in files:
907 basename = os.path.basename(path)
908
909 # Has a USE= line already been encountered in this file?
910 saw_use = False
911
912 for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1):
913 if not line.startswith('USE='):
914 continue
915
916 preserves_use = '${USE}' in line or '$USE' in line
917
918 if (basename == 'make.conf' or
919 (basename == 'make.defaults' and saw_use)) and not preserves_use:
920 errors.append('%s:%d: missing ${USE}' % (path, i))
921 elif basename == 'make.defaults' and not saw_use and preserves_use:
922 errors.append('%s:%d: ${USE} referenced in initial declaration' %
923 (path, i))
924
925 saw_use = True
926
927 if errors:
928 return HookFailure(
929 'One or more Portage make files appear to set USE incorrectly.\n'
930 '\n'
931 'All USE assignments in make.conf and all assignments after the\n'
932 'initial declaration in make.defaults should contain "${USE}" to\n'
933 'preserve previously-set flags.\n'
934 '\n'
935 'The initial USE declaration in make.defaults should not contain\n'
936 '"${USE}".\n',
937 errors)
938
939
Mike Frysingerae409522014-02-01 03:16:11 -0500940def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -0700941 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -0400942 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -0700943 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -0400944 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -0500945 if not m:
Vadim Bendebury20532ba2017-05-23 17:26:15 -0700946 return HookFailure('Last paragraph of description must include Change-Id.')
Ryan Cui1562fb82011-05-09 11:01:31 -0700947
Vadim Bendebury20532ba2017-05-23 17:26:15 -0700948 # S-o-b tags always allowed to follow Change-ID.
949 allowed_tags = ['Signed-off-by']
950
Mike Frysinger02b88bd2014-11-21 00:29:38 -0500951 end = desc[m.end():].strip().splitlines()
Vadim Bendebury20532ba2017-05-23 17:26:15 -0700952 if end and end[-1].startswith('(cherry picked from commit'):
953 # Cherry picked patches allow more tags in the last paragraph.
954 allowed_tags += ['Reviewed-on', 'Reviewed-by', 'Commit-Ready', 'Tested-by']
955 end = end[:-1]
956
957 tag_search = '^(%s): ' % '|'.join(allowed_tags)
958
959 if [x for x in end if not re.search(tag_search, x)]:
960 return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' %
961 ':", "'.join(allowed_tags))
Mike Frysinger02b88bd2014-11-21 00:29:38 -0500962
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -0700963
Mike Frysinger36b2ebc2014-10-31 14:02:03 -0400964def _check_commit_message_style(_project, commit):
965 """Verify that the commit message matches our style.
966
967 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
968 commit hooks.
969 """
970 desc = _get_commit_desc(commit)
971
972 # The first line should be by itself.
973 lines = desc.splitlines()
974 if len(lines) > 1 and lines[1]:
975 return HookFailure('The second line of the commit message must be blank.')
976
977 # The first line should be one sentence.
978 if '. ' in lines[0]:
979 return HookFailure('The first line cannot be more than one sentence.')
980
981 # The first line cannot be too long.
982 MAX_FIRST_LINE_LEN = 100
983 if len(lines[0]) > MAX_FIRST_LINE_LEN:
984 return HookFailure('The first line must be less than %i chars.' %
985 MAX_FIRST_LINE_LEN)
986
987
Filipe Brandenburger4b542b12015-10-09 12:46:31 -0700988def _check_cros_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -0700989 """Verifies the Chromium OS license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700990
Mike Frysinger98638102014-08-28 00:15:08 -0400991 Should be following the spec:
992 http://dev.chromium.org/developers/coding-style#TOC-File-headers
993 """
994 # For older years, be a bit more flexible as our policy says leave them be.
995 LICENSE_HEADER = (
996 r'.* Copyright( \(c\))? 20[-0-9]{2,7} The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -0500997 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -0400998 r'.* Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -0500999 r'be\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001000 r'.* found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -05001001 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001002 )
1003 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1004
1005 # For newer years, be stricter.
1006 COPYRIGHT_LINE = (
1007 r'.* Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001008 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001009 )
1010 copyright_re = re.compile(COPYRIGHT_LINE)
1011
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001012 parser = argparse.ArgumentParser()
1013 parser.add_argument('--exclude_regex', action='append')
1014 parser.add_argument('--include_regex', action='append')
1015 opts = parser.parse_args(options)
1016 included = opts.include_regex or []
1017 excluded = opts.exclude_regex or []
1018
Mike Frysinger98638102014-08-28 00:15:08 -04001019 bad_files = []
1020 bad_copyright_files = []
1021 files = _filter_files(_get_affected_files(commit, relative=True),
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001022 included + COMMON_INCLUDED_PATHS,
1023 excluded + COMMON_EXCLUDED_PATHS)
Mike Frysinger98638102014-08-28 00:15:08 -04001024
1025 for f in files:
1026 contents = _get_file_content(f, commit)
1027 if not contents:
1028 # Ignore empty files.
1029 continue
1030
1031 if not license_re.search(contents):
1032 bad_files.append(f)
1033 elif copyright_re.search(contents):
1034 bad_copyright_files.append(f)
1035
1036 if bad_files:
1037 msg = '%s:\n%s\n%s' % (
1038 'License must match', license_re.pattern,
1039 'Found a bad header in these files:')
1040 return HookFailure(msg, bad_files)
1041
1042 if bad_copyright_files:
1043 msg = 'Do not use (c) in copyright headers in new files:'
1044 return HookFailure(msg, bad_copyright_files)
Ryan Cuiec4d6332011-05-02 14:15:25 -07001045
1046
Alex Deymof5792ce2015-08-24 22:50:08 -07001047def _check_aosp_license(_project, commit):
1048 """Verifies the AOSP license/copyright header.
1049
1050 AOSP uses the Apache2 License:
1051 https://source.android.com/source/licenses.html
1052 """
1053 LICENSE_HEADER = (
1054 r"""^[#/\*]*
1055[#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project
1056[#/\*]* ?
1057[#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\);
1058[#/\*]* ?you may not use this file except in compliance with the License\.
1059[#/\*]* ?You may obtain a copy of the License at
1060[#/\*]* ?
1061[#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0
1062[#/\*]* ?
1063[#/\*]* ?Unless required by applicable law or agreed to in writing, software
1064[#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS,
1065[#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """
1066 r"""implied\.
1067[#/\*]* ?See the License for the specific language governing permissions and
1068[#/\*]* ?limitations under the License\.
1069[#/\*]*$
1070"""
1071 )
1072 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1073
1074 files = _filter_files(_get_affected_files(commit, relative=True),
1075 COMMON_INCLUDED_PATHS,
1076 COMMON_EXCLUDED_PATHS)
1077
1078 bad_files = []
1079 for f in files:
1080 contents = _get_file_content(f, commit)
1081 if not contents:
1082 # Ignore empty files.
1083 continue
1084
1085 if not license_re.search(contents):
1086 bad_files.append(f)
1087
1088 if bad_files:
1089 msg = ('License must match:\n%s\nFound a bad header in these files:' %
1090 license_re.pattern)
1091 return HookFailure(msg, bad_files)
1092
1093
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001094def _check_layout_conf(_project, commit):
1095 """Verifies the metadata/layout.conf file."""
1096 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001097 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001098 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001099 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001100
Mike Frysinger94a670c2014-09-19 12:46:26 -04001101 # Handle multiple overlays in a single commit (like the public tree).
1102 for f in _get_affected_files(commit, relative=True):
1103 if f.endswith(repo_name):
1104 repo_names.append(f)
1105 elif f.endswith(layout_path):
1106 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001107
1108 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -04001109 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001110 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -04001111 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001112
Mike Frysinger94a670c2014-09-19 12:46:26 -04001113 # Gather all the errors in one pass so we show one full message.
1114 all_errors = {}
1115 for layout_path in layout_paths:
1116 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001117
Mike Frysinger94a670c2014-09-19 12:46:26 -04001118 # Make sure the config file is sorted.
1119 data = [x for x in _get_file_content(layout_path, commit).splitlines()
1120 if x and x[0] != '#']
1121 if sorted(data) != data:
1122 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001123
Mike Frysinger94a670c2014-09-19 12:46:26 -04001124 # Require people to set specific values all the time.
1125 settings = (
1126 # TODO: Enable this for everyone. http://crbug.com/408038
1127 #('fast caching', 'cache-format = md5-dict'),
1128 ('fast manifests', 'thin-manifests = true'),
Mike Frysingerd7734522015-02-26 16:12:43 -05001129 ('extra features', 'profile-formats = portage-2 profile-default-eapi'),
1130 ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001131 )
1132 for reason, line in settings:
1133 if line not in data:
1134 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001135
Mike Frysinger94a670c2014-09-19 12:46:26 -04001136 # Require one of these settings.
Mike Frysinger5fae62d2015-11-11 20:12:15 -05001137 if 'use-manifests = strict' not in data:
1138 errors += ['enable file checking with: use-manifests = strict']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001139
Mike Frysinger94a670c2014-09-19 12:46:26 -04001140 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -04001141 for line in data:
1142 if line.startswith('repo-name = '):
1143 break
1144 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -04001145 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001146
Mike Frysinger94a670c2014-09-19 12:46:26 -04001147 # Summarize all the errors we saw (if any).
1148 lines = ''
1149 for layout_path, errors in all_errors.items():
1150 if errors:
1151 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
1152 if lines:
1153 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
1154 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001155
1156
Ryan Cuiec4d6332011-05-02 14:15:25 -07001157# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001158
Ryan Cui1562fb82011-05-09 11:01:31 -07001159
Mike Frysingerae409522014-02-01 03:16:11 -05001160def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001161 """Runs checkpatch.pl on the given project"""
1162 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001163 options = list(options)
1164 if commit == PRE_SUBMIT:
1165 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
1166 # this case.
1167 options.append('--ignore=MISSING_SIGN_OFF')
Filipe Brandenburger28d48d62015-10-07 09:48:54 -07001168 # Always ignore the check for the MAINTAINERS file. We do not track that
1169 # information on that file in our source trees, so let's suppress the
1170 # warning.
1171 options.append('--ignore=FILE_PATH_CHANGES')
Filipe Brandenburgerce978322015-10-09 10:04:15 -07001172 # Do not complain about the Change-Id: fields, since we use Gerrit.
1173 # Upstream does not want those lines (since they do not use Gerrit), but
1174 # we always do, so disable the check globally.
Daisuke Nojiri4844f892015-10-08 09:54:33 -07001175 options.append('--ignore=GERRIT_CHANGE_ID')
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001176 cmd = ['%s/checkpatch.pl' % hooks_dir] + options + ['-']
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001177 cmd_result = cros_build_lib.RunCommand(cmd=cmd,
1178 print_cmd=False,
1179 input=_get_patch(commit),
1180 stdout_to_pipe=True,
1181 combine_stdout_stderr=True,
1182 error_code_ok=True)
1183 if cmd_result.returncode:
1184 return HookFailure('checkpatch.pl errors/warnings\n\n' + cmd_result.output)
Ryan Cuiec4d6332011-05-02 14:15:25 -07001185
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001186
Mike Frysingerae409522014-02-01 03:16:11 -05001187def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -07001188 """Makes sure kernel config changes are not mixed with code changes"""
1189 files = _get_affected_files(commit)
1190 if not len(_filter_files(files, [r'chromeos/config'])) in [0, len(files)]:
1191 return HookFailure('Changes to chromeos/config/ and regular files must '
1192 'be in separate commits:\n%s' % '\n'.join(files))
Anton Staaf815d6852011-08-22 10:08:45 -07001193
Mike Frysingerae409522014-02-01 03:16:11 -05001194
1195def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -07001196 """Checks that all JSON files are syntactically valid."""
Dale Curtisa039cfd2011-05-04 12:01:05 -07001197 for f in _filter_files(_get_affected_files(commit), [r'.*\.json']):
Dale Curtis2975c432011-05-03 17:25:20 -07001198 try:
1199 json.load(open(f))
1200 except Exception, e:
Ryan Cui1562fb82011-05-09 11:01:31 -07001201 return HookFailure('Invalid JSON in %s: %s' % (f, e))
Dale Curtis2975c432011-05-03 17:25:20 -07001202
1203
Mike Frysingerae409522014-02-01 03:16:11 -05001204def _check_manifests(_project, commit):
Mike Frysinger52b537e2013-08-22 22:59:53 -04001205 """Make sure Manifest files only have DIST lines"""
1206 paths = []
1207
1208 for path in _get_affected_files(commit):
1209 if os.path.basename(path) != 'Manifest':
1210 continue
1211 if not os.path.exists(path):
1212 continue
1213
1214 with open(path, 'r') as f:
1215 for line in f.readlines():
1216 if not line.startswith('DIST '):
1217 paths.append(path)
1218 break
1219
1220 if paths:
1221 return HookFailure('Please remove lines that do not start with DIST:\n%s' %
1222 ('\n'.join(paths),))
1223
1224
Mike Frysingerae409522014-02-01 03:16:11 -05001225def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001226 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001227 if commit == PRE_SUBMIT:
1228 return
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001229 BRANCH_RE = r'\nBRANCH=\S+'
1230
1231 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
1232 msg = ('Changelist description needs BRANCH field (after first line)\n'
1233 'E.g. BRANCH=none or BRANCH=link,snow')
1234 return HookFailure(msg)
1235
1236
Mike Frysingerae409522014-02-01 03:16:11 -05001237def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001238 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001239 if commit == PRE_SUBMIT:
1240 return
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001241 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1242
1243 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1244 msg = ('Changelist description needs Signed-off-by: field\n'
1245 'E.g. Signed-off-by: My Name <me@chromium.org>')
1246 return HookFailure(msg)
1247
1248
Aviv Keshet5ac59522017-01-31 14:28:27 -08001249def _check_cq_ini_well_formed(_project, commit):
1250 """Check that any modified COMMIT-QUEUE.ini files are well formed."""
1251 pattern = '.*' + constants.CQ_CONFIG_FILENAME
1252 files = _filter_files(_get_affected_files(commit), (pattern,))
1253
1254 # TODO(akeshet): Check not only that the file is parseable, but that all the
1255 # pre-cq configs it requests are existing ones.
1256 for f in files:
1257 try:
1258 parser = ConfigParser.SafeConfigParser()
1259 # Prior to python3, ConfigParser has no read_string method, so we must
1260 # pass it either a file path or file like object. And we must use
1261 # _get_file_content to fetch file contents to ensure we are examining the
1262 # commit diff, rather than whatever's on disk.
1263 contents = _get_file_content(f, commit)
1264 parser.readfp(StringIO.StringIO(contents))
1265 except ConfigParser.Error as e:
1266 msg = ('Unable to parse COMMIT-QUEUE.ini file at %s due to %s.' %
1267 (f, e))
1268 return HookFailure(msg)
1269
1270
Jon Salz3ee59de2012-08-18 13:54:22 +08001271def _run_project_hook_script(script, project, commit):
1272 """Runs a project hook script.
1273
1274 The script is run with the following environment variables set:
1275 PRESUBMIT_PROJECT: The affected project
1276 PRESUBMIT_COMMIT: The affected commit
1277 PRESUBMIT_FILES: A newline-separated list of affected files
1278
1279 The script is considered to fail if the exit code is non-zero. It should
1280 write an error message to stdout.
1281 """
1282 env = dict(os.environ)
Alex Deymo643ac4c2015-09-03 10:40:50 -07001283 env['PRESUBMIT_PROJECT'] = project.name
Jon Salz3ee59de2012-08-18 13:54:22 +08001284 env['PRESUBMIT_COMMIT'] = commit
1285
1286 # Put affected files in an environment variable
1287 files = _get_affected_files(commit)
1288 env['PRESUBMIT_FILES'] = '\n'.join(files)
1289
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001290 cmd_result = cros_build_lib.RunCommand(cmd=script,
1291 env=env,
1292 shell=True,
1293 print_cmd=False,
1294 input=os.devnull,
1295 stdout_to_pipe=True,
1296 combine_stdout_stderr=True,
1297 error_code_ok=True)
1298 if cmd_result.returncode:
1299 stdout = cmd_result.output
Jon Salz7b618af2012-08-31 06:03:16 +08001300 if stdout:
1301 stdout = re.sub('(?m)^', ' ', stdout)
1302 return HookFailure('Hook script "%s" failed with code %d%s' %
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001303 (script, cmd_result.returncode,
Jon Salz3ee59de2012-08-18 13:54:22 +08001304 ':\n' + stdout if stdout else ''))
1305
1306
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001307def _check_project_prefix(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -05001308 """Require the commit message have a project specific prefix as needed."""
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001309
1310 files = _get_affected_files(commit, relative=True)
1311 prefix = os.path.commonprefix(files)
1312 prefix = os.path.dirname(prefix)
1313
1314 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07001315 if not prefix:
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001316 return
1317
1318 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07001319
1320 # The common files may all be within a subdirectory of the main project
1321 # directory, so walk up the tree until we find an alias file.
1322 # _get_affected_files() should return relative paths, but check against '/' to
1323 # ensure that this loop terminates even if it receives an absolute path.
1324 while prefix and prefix != '/':
1325 alias_file = os.path.join(prefix, '.project_alias')
1326
1327 # If an alias exists, use it.
1328 if os.path.isfile(alias_file):
1329 project_name = osutils.ReadFile(alias_file).strip()
1330
1331 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001332
1333 if not _get_commit_desc(commit).startswith(project_name + ': '):
1334 return HookFailure('The commit title for changes affecting only %s'
1335 ' should start with \"%s: \"'
1336 % (project_name, project_name))
1337
1338
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001339def _check_exec_files(_project, commit):
1340 """Make +x bits on files."""
1341 # List of files that should never be +x.
1342 NO_EXEC = (
1343 'ChangeLog*',
1344 'COPYING',
1345 'make.conf',
1346 'make.defaults',
1347 'Manifest',
1348 'OWNERS',
1349 'package.use',
1350 'package.keywords',
1351 'package.mask',
1352 'parent',
1353 'README',
1354 'TODO',
1355 '.gitignore',
1356 '*.[achly]',
1357 '*.[ch]xx',
1358 '*.boto',
1359 '*.cc',
1360 '*.cfg',
1361 '*.conf',
1362 '*.config',
1363 '*.cpp',
1364 '*.css',
1365 '*.ebuild',
1366 '*.eclass',
1367 '*.gyp',
1368 '*.gypi',
1369 '*.htm',
1370 '*.html',
1371 '*.ini',
1372 '*.js',
1373 '*.json',
1374 '*.md',
1375 '*.mk',
1376 '*.patch',
1377 '*.policy',
1378 '*.proto',
1379 '*.raw',
1380 '*.rules',
1381 '*.service',
1382 '*.target',
1383 '*.txt',
1384 '*.xml',
1385 '*.yaml',
1386 )
1387
1388 def FinalName(obj):
1389 # If the file is being deleted, then the dst_file is not set.
1390 if obj.dst_file is None:
1391 return obj.src_file
1392 else:
1393 return obj.dst_file
1394
1395 bad_files = []
1396 files = _get_affected_files(commit, relative=True, full_details=True)
1397 for f in files:
1398 mode = int(f.dst_mode, 8)
1399 if not mode & 0o111:
1400 continue
1401 name = FinalName(f)
1402 for no_exec in NO_EXEC:
1403 if fnmatch.fnmatch(name, no_exec):
1404 bad_files.append(name)
1405 break
1406
1407 if bad_files:
1408 return HookFailure('These files should not be executable. '
1409 'Please `chmod -x` them.', bad_files)
1410
1411
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001412# Base
1413
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001414# A list of hooks which are not project specific and check patch description
1415# (as opposed to patch body).
1416_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07001417 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07001418 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07001419 _check_change_has_test_field,
1420 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001421 _check_commit_message_style,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001422 _check_change_is_contribution,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001423]
1424
1425
1426# A list of hooks that are not project-specific
1427_COMMON_HOOKS = [
Aviv Keshet5ac59522017-01-31 14:28:27 -08001428 _check_cq_ini_well_formed,
1429 _check_cros_license,
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001430 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05001431 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001432 _check_ebuild_licenses,
Mike Frysingercd363c82014-02-01 05:20:18 -05001433 _check_ebuild_virtual_pv,
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001434 _check_exec_files,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001435 _check_for_uprev,
Rahul Chaudhry09f61372015-07-31 17:14:26 -07001436 _check_gofmt,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001437 _check_layout_conf,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001438 _check_no_long_lines,
1439 _check_no_stray_whitespace,
Ryan Cui9b651632011-05-11 11:38:58 -07001440 _check_no_tabs,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001441 _check_portage_make_use_var,
Aviv Keshet5ac59522017-01-31 14:28:27 -08001442 _check_tabbed_indents,
Ryan Cui9b651632011-05-11 11:38:58 -07001443]
Ryan Cuiec4d6332011-05-02 14:15:25 -07001444
Ryan Cui1562fb82011-05-09 11:01:31 -07001445
Ryan Cui9b651632011-05-11 11:38:58 -07001446# A dictionary of project-specific hooks(callbacks), indexed by project name.
1447# dict[project] = [callback1, callback2]
1448_PROJECT_SPECIFIC_HOOKS = {
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001449 "chromiumos/platform2": [_check_project_prefix],
Mike Frysingeraf891292015-03-25 19:46:53 -04001450 "chromiumos/third_party/kernel": [_kernel_configcheck],
1451 "chromiumos/third_party/kernel-next": [_kernel_configcheck],
Ryan Cui9b651632011-05-11 11:38:58 -07001452}
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001453
Ryan Cui1562fb82011-05-09 11:01:31 -07001454
Ryan Cui9b651632011-05-11 11:38:58 -07001455# A dictionary of flags (keys) that can appear in the config file, and the hook
Mike Frysinger3554bc92015-03-11 04:59:21 -04001456# that the flag controls (value).
1457_HOOK_FLAGS = {
Mike Frysingera7642f52015-03-25 18:31:42 -04001458 'checkpatch_check': _run_checkpatch,
Ryan Cui9b651632011-05-11 11:38:58 -07001459 'stray_whitespace_check': _check_no_stray_whitespace,
Mike Frysingerff6c7d62015-03-24 13:49:46 -04001460 'json_check': _run_json_check,
Ryan Cui9b651632011-05-11 11:38:58 -07001461 'long_line_check': _check_no_long_lines,
Alex Deymof5792ce2015-08-24 22:50:08 -07001462 'cros_license_check': _check_cros_license,
1463 'aosp_license_check': _check_aosp_license,
Ryan Cui9b651632011-05-11 11:38:58 -07001464 'tab_check': _check_no_tabs,
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08001465 'tabbed_indent_required_check': _check_tabbed_indents,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001466 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001467 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07001468 'bug_field_check': _check_change_has_bug_field,
1469 'test_field_check': _check_change_has_test_field,
Steve Fung49ec7e92015-03-23 16:07:12 -07001470 'manifest_check': _check_manifests,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001471 'contribution_check': _check_change_is_contribution,
Ryan Cui9b651632011-05-11 11:38:58 -07001472}
1473
1474
Mike Frysinger3554bc92015-03-11 04:59:21 -04001475def _get_override_hooks(config):
1476 """Returns a set of hooks controlled by the current project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001477
1478 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08001479
1480 Args:
1481 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001482 """
1483 SECTION = 'Hook Overrides'
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001484 SECTION_OPTIONS = 'Hook Overrides Options'
Jon Salz3ee59de2012-08-18 13:54:22 +08001485 if not config.has_section(SECTION):
Mike Frysinger3554bc92015-03-11 04:59:21 -04001486 return set(), set()
Ryan Cui9b651632011-05-11 11:38:58 -07001487
Mike Frysinger3554bc92015-03-11 04:59:21 -04001488 valid_keys = set(_HOOK_FLAGS.iterkeys())
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001489 hooks = _HOOK_FLAGS.copy()
Mike Frysinger3554bc92015-03-11 04:59:21 -04001490
1491 enable_flags = []
Ryan Cui9b651632011-05-11 11:38:58 -07001492 disable_flags = []
Jon Salz3ee59de2012-08-18 13:54:22 +08001493 for flag in config.options(SECTION):
Mike Frysinger3554bc92015-03-11 04:59:21 -04001494 if flag not in valid_keys:
1495 raise ValueError('Error: unknown key "%s" in hook section of "%s"' %
1496 (flag, _CONFIG_FILE))
1497
Ryan Cui9b651632011-05-11 11:38:58 -07001498 try:
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001499 enabled = config.getboolean(SECTION, flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001500 except ValueError as e:
Mike Frysinger3554bc92015-03-11 04:59:21 -04001501 raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' %
1502 (flag, _CONFIG_FILE, e))
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001503 if enabled:
1504 enable_flags.append(flag)
1505 else:
1506 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001507
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001508 # See if this hook has custom options.
1509 if enabled:
1510 try:
1511 options = config.get(SECTION_OPTIONS, flag)
1512 hooks[flag] = functools.partial(hooks[flag], options=options.split())
1513 except (ConfigParser.NoOptionError, ConfigParser.NoSectionError):
1514 pass
1515
1516 enabled_hooks = set(hooks[x] for x in enable_flags)
1517 disabled_hooks = set(hooks[x] for x in disable_flags)
Mike Frysinger3554bc92015-03-11 04:59:21 -04001518 return enabled_hooks, disabled_hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001519
1520
Jon Salz3ee59de2012-08-18 13:54:22 +08001521def _get_project_hook_scripts(config):
1522 """Returns a list of project-specific hook scripts.
1523
1524 Args:
1525 config: A ConfigParser for the project's config file.
1526 """
1527 SECTION = 'Hook Scripts'
1528 if not config.has_section(SECTION):
1529 return []
1530
1531 hook_names_values = config.items(SECTION)
1532 hook_names_values.sort(key=lambda x: x[0])
1533 return [x[1] for x in hook_names_values]
1534
1535
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001536def _get_project_hooks(project, presubmit):
Ryan Cui9b651632011-05-11 11:38:58 -07001537 """Returns a list of hooks that need to be run for a project.
1538
1539 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001540
1541 Args:
1542 project: A string, name of the project.
1543 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui9b651632011-05-11 11:38:58 -07001544 """
Jon Salz3ee59de2012-08-18 13:54:22 +08001545 config = ConfigParser.RawConfigParser()
1546 try:
1547 config.read(_CONFIG_FILE)
1548 except ConfigParser.Error:
1549 # Just use an empty config file
1550 config = ConfigParser.RawConfigParser()
1551
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001552 if presubmit:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001553 hooks = _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001554 else:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001555 hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001556
Mike Frysinger3554bc92015-03-11 04:59:21 -04001557 enabled_hooks, disabled_hooks = _get_override_hooks(config)
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001558 hooks = [hook for hook in hooks if hook not in disabled_hooks]
1559
1560 # If a list is both in _COMMON_HOOKS and also enabled explicitly through an
1561 # override, keep the override only. Note that the override may end up being
1562 # a functools.partial, in which case we need to extract the .func to compare
1563 # it to the common hooks.
1564 unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks]
1565 hooks = [hook for hook in hooks if hook not in unwrapped_hooks]
1566
1567 hooks = list(enabled_hooks) + hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001568
1569 if project in _PROJECT_SPECIFIC_HOOKS:
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001570 hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project]
1571 if hook not in disabled_hooks)
Ryan Cui9b651632011-05-11 11:38:58 -07001572
Jon Salz3ee59de2012-08-18 13:54:22 +08001573 for script in _get_project_hook_scripts(config):
1574 hooks.append(functools.partial(_run_project_hook_script, script))
1575
Ryan Cui9b651632011-05-11 11:38:58 -07001576 return hooks
1577
1578
Alex Deymo643ac4c2015-09-03 10:40:50 -07001579def _run_project_hooks(project_name, proj_dir=None,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001580 commit_list=None, presubmit=False):
Ryan Cui1562fb82011-05-09 11:01:31 -07001581 """For each project run its project specific hook from the hooks dictionary.
1582
1583 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001584 project_name: The name of project to run hooks for.
Doug Anderson44a644f2011-11-02 10:37:37 -07001585 proj_dir: If non-None, this is the directory the project is in. If None,
1586 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07001587 commit_list: A list of commits to run hooks against. If None or empty list
1588 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001589 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui1562fb82011-05-09 11:01:31 -07001590
1591 Returns:
1592 Boolean value of whether any errors were ecountered while running the hooks.
1593 """
Doug Anderson44a644f2011-11-02 10:37:37 -07001594 if proj_dir is None:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001595 proj_dirs = _run_command(
1596 ['repo', 'forall', project_name, '-c', 'pwd']).split()
David James2edd9002013-10-11 14:09:19 -07001597 if len(proj_dirs) == 0:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001598 print('%s cannot be found.' % project_name, file=sys.stderr)
David James2edd9002013-10-11 14:09:19 -07001599 print('Please specify a valid project.', file=sys.stderr)
1600 return True
1601 if len(proj_dirs) > 1:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001602 print('%s is associated with multiple directories.' % project_name,
David James2edd9002013-10-11 14:09:19 -07001603 file=sys.stderr)
1604 print('Please specify a directory to help disambiguate.', file=sys.stderr)
1605 return True
1606 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07001607
Ryan Cuiec4d6332011-05-02 14:15:25 -07001608 pwd = os.getcwd()
1609 # hooks assume they are run from the root of the project
1610 os.chdir(proj_dir)
1611
Alex Deymo643ac4c2015-09-03 10:40:50 -07001612 remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref',
1613 '--symbolic-full-name', '@{u}']).strip()
1614 if not remote_branch:
1615 print('Your project %s doesn\'t track any remote repo.' % project_name,
1616 file=sys.stderr)
1617 remote = None
1618 else:
1619 remote, _branch = remote_branch.split('/', 1)
1620
1621 project = Project(name=project_name, dir=proj_dir, remote=remote)
1622
Doug Anderson14749562013-06-26 13:38:29 -07001623 if not commit_list:
1624 try:
1625 commit_list = _get_commits()
1626 except VerifyException as e:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001627 PrintErrorForProject(project.name, HookFailure(str(e)))
Doug Anderson14749562013-06-26 13:38:29 -07001628 os.chdir(pwd)
1629 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07001630
Alex Deymo643ac4c2015-09-03 10:40:50 -07001631 hooks = _get_project_hooks(project.name, presubmit)
Ryan Cui1562fb82011-05-09 11:01:31 -07001632 error_found = False
Ryan Cuifa55df52011-05-06 11:16:55 -07001633 for commit in commit_list:
Ryan Cui1562fb82011-05-09 11:01:31 -07001634 error_list = []
Ryan Cui9b651632011-05-11 11:38:58 -07001635 for hook in hooks:
Ryan Cui1562fb82011-05-09 11:01:31 -07001636 hook_error = hook(project, commit)
1637 if hook_error:
1638 error_list.append(hook_error)
1639 error_found = True
1640 if error_list:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001641 PrintErrorsForCommit(project.name, commit, _get_commit_desc(commit),
Ryan Cui1562fb82011-05-09 11:01:31 -07001642 error_list)
Don Garrettdba548a2011-05-05 15:17:14 -07001643
Ryan Cuiec4d6332011-05-02 14:15:25 -07001644 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07001645 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001646
Mike Frysingerae409522014-02-01 03:16:11 -05001647
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001648# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07001649
Ryan Cui1562fb82011-05-09 11:01:31 -07001650
Mike Frysingerae409522014-02-01 03:16:11 -05001651def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08001652 """Main function invoked directly by repo.
1653
1654 This function will exit directly upon error so that repo doesn't print some
1655 obscure error message.
1656
1657 Args:
1658 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07001659 worktree_list: A list of directories. It should be the same length as
1660 project_list, so that each entry in project_list matches with a directory
1661 in worktree_list. If None, we will attempt to calculate the directories
1662 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08001663 kwargs: Leave this here for forward-compatibility.
1664 """
Ryan Cui1562fb82011-05-09 11:01:31 -07001665 found_error = False
David James2edd9002013-10-11 14:09:19 -07001666 if not worktree_list:
1667 worktree_list = [None] * len(project_list)
1668 for project, worktree in zip(project_list, worktree_list):
1669 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07001670 found_error = True
1671
Mike Frysingerae409522014-02-01 03:16:11 -05001672 if found_error:
Ryan Cui1562fb82011-05-09 11:01:31 -07001673 msg = ('Preupload failed due to errors in project(s). HINTS:\n'
Ryan Cui9b651632011-05-11 11:38:58 -07001674 '- To disable some source style checks, and for other hints, see '
1675 '<checkout_dir>/src/repohooks/README\n'
1676 '- To upload only current project, run \'repo upload .\'')
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04001677 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07001678 sys.exit(1)
Anush Elangovan63afad72011-03-23 00:41:27 -07001679
Ryan Cui1562fb82011-05-09 11:01:31 -07001680
Doug Anderson44a644f2011-11-02 10:37:37 -07001681def _identify_project(path):
1682 """Identify the repo project associated with the given path.
1683
1684 Returns:
1685 A string indicating what project is associated with the path passed in or
1686 a blank string upon failure.
1687 """
1688 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001689 redirect_stderr=True, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07001690
1691
Mike Frysinger55f85b52014-12-18 14:45:21 -05001692def direct_main(argv):
Doug Anderson44a644f2011-11-02 10:37:37 -07001693 """Run hooks directly (outside of the context of repo).
1694
Doug Anderson44a644f2011-11-02 10:37:37 -07001695 Args:
Mike Frysinger55f85b52014-12-18 14:45:21 -05001696 argv: The command line args to process
Doug Anderson44a644f2011-11-02 10:37:37 -07001697
1698 Returns:
1699 0 if no pre-upload failures, 1 if failures.
1700
1701 Raises:
1702 BadInvocation: On some types of invocation errors.
1703 """
Mike Frysinger66142932014-12-18 14:55:57 -05001704 parser = commandline.ArgumentParser(description=__doc__)
1705 parser.add_argument('--dir', default=None,
1706 help='The directory that the project lives in. If not '
1707 'specified, use the git project root based on the cwd.')
1708 parser.add_argument('--project', default=None,
1709 help='The project repo path; this can affect how the '
1710 'hooks get run, since some hooks are project-specific. '
1711 'For chromite this is chromiumos/chromite. If not '
1712 'specified, the repo tool will be used to figure this '
1713 'out based on the dir.')
1714 parser.add_argument('--rerun-since', default=None,
1715 help='Rerun hooks on old commits since the given date. '
1716 'The date should match git log\'s concept of a date. '
1717 'e.g. 2012-06-20. This option is mutually exclusive '
1718 'with --pre-submit.')
1719 parser.add_argument('--pre-submit', action="store_true",
1720 help='Run the check against the pending commit. '
1721 'This option should be used at the \'git commit\' '
1722 'phase as opposed to \'repo upload\'. This option '
1723 'is mutually exclusive with --rerun-since.')
1724 parser.add_argument('commits', nargs='*',
1725 help='Check specific commits')
1726 opts = parser.parse_args(argv)
Doug Anderson44a644f2011-11-02 10:37:37 -07001727
Doug Anderson14749562013-06-26 13:38:29 -07001728 if opts.rerun_since:
Mike Frysinger66142932014-12-18 14:55:57 -05001729 if opts.commits:
Doug Anderson14749562013-06-26 13:38:29 -07001730 raise BadInvocation('Can\'t pass commits and use rerun-since: %s' %
Mike Frysinger66142932014-12-18 14:55:57 -05001731 ' '.join(opts.commits))
Doug Anderson14749562013-06-26 13:38:29 -07001732
1733 cmd = ['git', 'log', '--since="%s"' % opts.rerun_since, '--pretty=%H']
1734 all_commits = _run_command(cmd).splitlines()
1735 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
1736
1737 # Eliminate chrome-bot commits but keep ordering the same...
1738 bot_commits = set(bot_commits)
Mike Frysinger66142932014-12-18 14:55:57 -05001739 opts.commits = [c for c in all_commits if c not in bot_commits]
Doug Anderson14749562013-06-26 13:38:29 -07001740
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001741 if opts.pre_submit:
1742 raise BadInvocation('rerun-since and pre-submit can not be '
1743 'used together')
1744 if opts.pre_submit:
Mike Frysinger66142932014-12-18 14:55:57 -05001745 if opts.commits:
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001746 raise BadInvocation('Can\'t pass commits and use pre-submit: %s' %
Mike Frysinger66142932014-12-18 14:55:57 -05001747 ' '.join(opts.commits))
1748 opts.commits = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07001749
1750 # Check/normlaize git dir; if unspecified, we'll use the root of the git
1751 # project from CWD
1752 if opts.dir is None:
1753 git_dir = _run_command(['git', 'rev-parse', '--git-dir'],
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001754 redirect_stderr=True).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07001755 if not git_dir:
1756 raise BadInvocation('The current directory is not part of a git project.')
1757 opts.dir = os.path.dirname(os.path.abspath(git_dir))
1758 elif not os.path.isdir(opts.dir):
1759 raise BadInvocation('Invalid dir: %s' % opts.dir)
1760 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
1761 raise BadInvocation('Not a git directory: %s' % opts.dir)
1762
1763 # Identify the project if it wasn't specified; this _requires_ the repo
1764 # tool to be installed and for the project to be part of a repo checkout.
1765 if not opts.project:
1766 opts.project = _identify_project(opts.dir)
1767 if not opts.project:
1768 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
1769
Doug Anderson14749562013-06-26 13:38:29 -07001770 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Mike Frysinger66142932014-12-18 14:55:57 -05001771 commit_list=opts.commits,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001772 presubmit=opts.pre_submit)
Doug Anderson44a644f2011-11-02 10:37:37 -07001773 if found_error:
1774 return 1
1775 return 0
1776
1777
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07001778if __name__ == '__main__':
Mike Frysinger55f85b52014-12-18 14:45:21 -05001779 sys.exit(direct_main(sys.argv[1:]))