blob: 2c14bb5886eadbcd0d445c0a9700f1928118eda7 [file] [log] [blame]
Daniel Erat9d203ff2015-02-17 10:12:21 -07001#!/usr/bin/python2
Jon Salz98255932012-08-18 14:48:02 +08002# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
Mike Frysingerae409522014-02-01 03:16:11 -05006"""Presubmit checks to run when doing `repo upload`.
7
8You can add new checks by adding a functions to the HOOKS constants.
9"""
10
Mike Frysinger09d6a3d2013-10-08 22:21:03 -040011from __future__ import print_function
12
Filipe Brandenburger4b542b12015-10-09 12:46:31 -070013import argparse
Alex Deymo643ac4c2015-09-03 10:40:50 -070014import collections
Ryan Cui9b651632011-05-11 11:38:58 -070015import ConfigParser
Daniel Erate3ea3fc2015-02-13 15:27:52 -070016import fnmatch
Jon Salz3ee59de2012-08-18 13:54:22 +080017import functools
Dale Curtis2975c432011-05-03 17:25:20 -070018import json
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070019import os
Ryan Cuiec4d6332011-05-02 14:15:25 -070020import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070021import sys
Peter Ammon811f6702014-06-12 15:45:38 -070022import stat
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070023
Ryan Cui1562fb82011-05-09 11:01:31 -070024from errors import (VerifyException, HookFailure, PrintErrorForProject,
25 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070026
David Jamesc3b68b32013-04-03 09:17:03 -070027# If repo imports us, the __name__ will be __builtin__, and the wrapper will
28# be in $CHROMEOS_CHECKOUT/.repo/repo/main.py, so we need to go two directories
29# up. The same logic also happens to work if we're executed directly.
30if __name__ in ('__builtin__', '__main__'):
31 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
32
Mike Frysinger66142932014-12-18 14:55:57 -050033from chromite.lib import commandline
Rahul Chaudhry0e515342015-08-07 12:00:43 -070034from chromite.lib import cros_build_lib
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050035from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070036from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070037from chromite.lib import patch
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040038from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070039
Vadim Bendebury2b62d742014-06-22 13:14:51 -070040PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070041
42COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050043 # C++ and friends
44 r".*\.c$", r".*\.cc$", r".*\.cpp$", r".*\.h$", r".*\.m$", r".*\.mm$",
45 r".*\.inl$", r".*\.asm$", r".*\.hxx$", r".*\.hpp$", r".*\.s$", r".*\.S$",
46 # Scripts
47 r".*\.js$", r".*\.py$", r".*\.sh$", r".*\.rb$", r".*\.pl$", r".*\.pm$",
48 # No extension at all, note that ALL CAPS files are black listed in
49 # COMMON_EXCLUDED_LIST below.
50 r"(^|.*[\\\/])[^.]+$",
51 # Other
52 r".*\.java$", r".*\.mk$", r".*\.am$",
Brian Norrisfdbac8e2016-06-16 11:09:05 -070053 r".*\.policy$", r".*\.conf$",
Ryan Cuiec4d6332011-05-02 14:15:25 -070054]
55
Ryan Cui1562fb82011-05-09 11:01:31 -070056
Ryan Cuiec4d6332011-05-02 14:15:25 -070057COMMON_EXCLUDED_PATHS = [
Daniel Erate3ea3fc2015-02-13 15:27:52 -070058 # Avoid doing source file checks for kernel.
Mike Frysingerae409522014-02-01 03:16:11 -050059 r"/src/third_party/kernel/",
60 r"/src/third_party/kernel-next/",
61 r"/src/third_party/ktop/",
62 r"/src/third_party/punybench/",
63 r".*\bexperimental[\\\/].*",
64 r".*\b[A-Z0-9_]{2,}$",
65 r".*[\\\/]debian[\\\/]rules$",
Daniel Erate3ea3fc2015-02-13 15:27:52 -070066
67 # For ebuild trees, ignore any caches and manifest data.
Mike Frysingerae409522014-02-01 03:16:11 -050068 r".*/Manifest$",
69 r".*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$",
Doug Anderson5bfb6792011-10-25 16:45:41 -070070
Daniel Erate3ea3fc2015-02-13 15:27:52 -070071 # Ignore profiles data (like overlay-tegra2/profiles).
Mike Frysinger94a670c2014-09-19 12:46:26 -040072 r"(^|.*/)overlay-.*/profiles/.*",
Mike Frysinger98638102014-08-28 00:15:08 -040073 r"^profiles/.*$",
74
Daniel Erate3ea3fc2015-02-13 15:27:52 -070075 # Ignore minified js and jquery.
Mike Frysingerae409522014-02-01 03:16:11 -050076 r".*\.min\.js",
77 r".*jquery.*\.js",
Mike Frysinger33a458d2014-03-03 17:00:51 -050078
79 # Ignore license files as the content is often taken verbatim.
Daniel Erate3ea3fc2015-02-13 15:27:52 -070080 r".*/licenses/.*",
Ryan Cuiec4d6332011-05-02 14:15:25 -070081]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070082
Ryan Cui1562fb82011-05-09 11:01:31 -070083
Ryan Cui9b651632011-05-11 11:38:58 -070084_CONFIG_FILE = 'PRESUBMIT.cfg'
85
86
Daniel Erate3ea3fc2015-02-13 15:27:52 -070087# File containing wildcards, one per line, matching files that should be
88# excluded from presubmit checks. Lines beginning with '#' are ignored.
89_IGNORE_FILE = '.presubmitignore'
90
91
Doug Anderson44a644f2011-11-02 10:37:37 -070092# Exceptions
93
94
95class BadInvocation(Exception):
96 """An Exception indicating a bad invocation of the program."""
97 pass
98
99
Ryan Cui1562fb82011-05-09 11:01:31 -0700100# General Helpers
101
Sean Paulba01d402011-05-05 11:36:23 -0400102
Alex Deymo643ac4c2015-09-03 10:40:50 -0700103Project = collections.namedtuple('Project', ['name', 'dir', 'remote'])
104
105
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700106# pylint: disable=redefined-builtin
107def _run_command(cmd, cwd=None, input=None,
108 redirect_stderr=False, combine_stdout_stderr=False):
Doug Anderson44a644f2011-11-02 10:37:37 -0700109 """Executes the passed in command and returns raw stdout output.
110
111 Args:
112 cmd: The command to run; should be a list of strings.
113 cwd: The directory to switch to for running the command.
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700114 input: The data to pipe into this command through stdin. If a file object
115 or file descriptor, stdin will be connected directly to that.
116 redirect_stderr: Redirect stderr away from console.
117 combine_stdout_stderr: Combines stdout and stderr streams into stdout.
Doug Anderson44a644f2011-11-02 10:37:37 -0700118
119 Returns:
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700120 The stdout from the process (discards stderr and returncode).
Doug Anderson44a644f2011-11-02 10:37:37 -0700121 """
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700122 return cros_build_lib.RunCommand(cmd=cmd,
123 cwd=cwd,
124 print_cmd=False,
125 input=input,
126 stdout_to_pipe=True,
127 redirect_stderr=redirect_stderr,
128 combine_stdout_stderr=combine_stdout_stderr,
129 error_code_ok=True).output
130# pylint: enable=redefined-builtin
Ryan Cui72834d12011-05-05 14:51:33 -0700131
Ryan Cui1562fb82011-05-09 11:01:31 -0700132
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700133def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700134 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700135 if __name__ == '__main__':
136 # Works when file is run on its own (__file__ is defined)...
137 return os.path.abspath(os.path.dirname(__file__))
138 else:
139 # We need to do this when we're run through repo. Since repo executes
140 # us with execfile(), we don't get __file__ defined.
141 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
142 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700143
Ryan Cui1562fb82011-05-09 11:01:31 -0700144
Ryan Cuiec4d6332011-05-02 14:15:25 -0700145def _match_regex_list(subject, expressions):
146 """Try to match a list of regular expressions to a string.
147
148 Args:
149 subject: The string to match regexes on
150 expressions: A list of regular expressions to check for matches with.
151
152 Returns:
153 Whether the passed in subject matches any of the passed in regexes.
154 """
155 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500156 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700157 return True
158 return False
159
Ryan Cui1562fb82011-05-09 11:01:31 -0700160
Mike Frysingerae409522014-02-01 03:16:11 -0500161def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700162 """Filter out files based on the conditions passed in.
163
164 Args:
165 files: list of filepaths to filter
166 include_list: list of regex that when matched with a file path will cause it
167 to be added to the output list unless the file is also matched with a
168 regex in the exclude_list.
169 exclude_list: list of regex that when matched with a file will prevent it
170 from being added to the output list, even if it is also matched with a
171 regex in the include_list.
172
173 Returns:
174 A list of filepaths that contain files matched in the include_list and not
175 in the exclude_list.
176 """
177 filtered = []
178 for f in files:
179 if (_match_regex_list(f, include_list) and
180 not _match_regex_list(f, exclude_list)):
181 filtered.append(f)
182 return filtered
183
Ryan Cuiec4d6332011-05-02 14:15:25 -0700184
185# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700186
187
Ryan Cui4725d952011-05-05 15:41:19 -0700188def _get_upstream_branch():
189 """Returns the upstream tracking branch of the current branch.
190
191 Raises:
192 Error if there is no tracking branch
193 """
194 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
195 current_branch = current_branch.replace('refs/heads/', '')
196 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700197 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700198
199 cfg_option = 'branch.' + current_branch + '.%s'
200 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
201 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
202 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700203 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700204
205 return full_upstream.replace('heads', 'remotes/' + remote)
206
Ryan Cui1562fb82011-05-09 11:01:31 -0700207
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700208def _get_patch(commit):
209 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700210 if commit == PRE_SUBMIT:
211 return _run_command(['git', 'diff', '--cached', 'HEAD'])
212 else:
213 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700214
Ryan Cui1562fb82011-05-09 11:01:31 -0700215
Jon Salz98255932012-08-18 14:48:02 +0800216def _try_utf8_decode(data):
217 """Attempts to decode a string as UTF-8.
218
219 Returns:
220 The decoded Unicode object, or the original string if parsing fails.
221 """
222 try:
223 return unicode(data, 'utf-8', 'strict')
224 except UnicodeDecodeError:
225 return data
226
227
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500228def _get_file_content(path, commit):
229 """Returns the content of a file at a specific commit.
230
231 We can't rely on the file as it exists in the filesystem as people might be
232 uploading a series of changes which modifies the file multiple times.
233
234 Note: The "content" of a symlink is just the target. So if you're expecting
235 a full file, you should check that first. One way to detect is that the
236 content will not have any newlines.
237 """
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700238 if commit == PRE_SUBMIT:
239 return _run_command(['git', 'diff', 'HEAD', path])
240 else:
241 return _run_command(['git', 'show', '%s:%s' % (commit, path)])
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500242
243
Mike Frysingerae409522014-02-01 03:16:11 -0500244def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700245 """Returns a list of (linenum, lines) tuples that the commit touched."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700246 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff']
247 if commit == PRE_SUBMIT:
248 command += ['HEAD', path]
249 else:
250 command += [commit, path]
251 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700252
253 new_lines = []
254 line_num = 0
255 for line in output.splitlines():
256 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
257 if m:
258 line_num = int(m.groups(1)[0])
259 continue
260 if line.startswith('+') and not line.startswith('++'):
Jon Salz98255932012-08-18 14:48:02 +0800261 new_lines.append((line_num, _try_utf8_decode(line[1:])))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700262 if not line.startswith('-'):
263 line_num += 1
264 return new_lines
265
Ryan Cui1562fb82011-05-09 11:01:31 -0700266
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700267def _get_ignore_wildcards(directory, cache):
268 """Get wildcards listed in a directory's _IGNORE_FILE.
269
270 Args:
271 directory: A string containing a directory path.
272 cache: A dictionary (opaque to caller) caching previously-read wildcards.
273
274 Returns:
275 A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE
276 wasn't present.
277 """
278 # In the cache, keys are directories and values are lists of wildcards from
279 # _IGNORE_FILE within those directories (and empty if no file was present).
280 if directory not in cache:
281 wildcards = []
282 dotfile_path = os.path.join(directory, _IGNORE_FILE)
283 if os.path.exists(dotfile_path):
284 # TODO(derat): Consider using _get_file_content() to get the file as of
285 # this commit instead of the on-disk version. This may have a noticeable
286 # performance impact, as each call to _get_file_content() runs git.
287 with open(dotfile_path, 'r') as dotfile:
288 for line in dotfile.readlines():
289 line = line.strip()
290 if line.startswith('#'):
291 continue
292 if line.endswith('/'):
293 line += '*'
294 wildcards.append(line)
295 cache[directory] = wildcards
296
297 return cache[directory]
298
299
300def _path_is_ignored(path, cache):
301 """Check whether a path is ignored by _IGNORE_FILE.
302
303 Args:
304 path: A string containing a path.
305 cache: A dictionary (opaque to caller) caching previously-read wildcards.
306
307 Returns:
308 True if a file named _IGNORE_FILE in one of the passed-in path's parent
309 directories contains a wildcard matching the path.
310 """
311 # Skip ignore files.
312 if os.path.basename(path) == _IGNORE_FILE:
313 return True
314
315 path = os.path.abspath(path)
316 base = os.getcwd()
317
318 prefix = os.path.dirname(path)
319 while prefix.startswith(base):
320 rel_path = path[len(prefix) + 1:]
321 for wildcard in _get_ignore_wildcards(prefix, cache):
322 if fnmatch.fnmatch(rel_path, wildcard):
323 return True
324 prefix = os.path.dirname(prefix)
325
326 return False
327
328
Mike Frysinger292b45d2014-11-25 01:17:10 -0500329def _get_affected_files(commit, include_deletes=False, relative=False,
330 include_symlinks=False, include_adds=True,
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700331 full_details=False, use_ignore_files=True):
Peter Ammon811f6702014-06-12 15:45:38 -0700332 """Returns list of file paths that were modified/added, excluding symlinks.
333
334 Args:
335 commit: The commit
336 include_deletes: If true, we'll include deleted files in the result
337 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500338 include_symlinks: If true, we'll include symlinks in the result
339 include_adds: If true, we'll include new files in the result
340 full_details: If False, return filenames, else return structured results.
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700341 use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files.
Peter Ammon811f6702014-06-12 15:45:38 -0700342
343 Returns:
344 A list of modified/added (and perhaps deleted) files
345 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500346 if not relative and full_details:
347 raise ValueError('full_details only supports relative paths currently')
348
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700349 if commit == PRE_SUBMIT:
350 return _run_command(['git', 'diff-index', '--cached',
351 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500352
353 path = os.getcwd()
354 files = git.RawDiff(path, '%s^!' % commit)
355
356 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500357 if not include_symlinks:
358 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500359
360 if not include_deletes:
361 files = [x for x in files if x.status != 'D']
362
Mike Frysinger292b45d2014-11-25 01:17:10 -0500363 if not include_adds:
364 files = [x for x in files if x.status != 'A']
365
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700366 if use_ignore_files:
367 cache = {}
368 is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache)
369 files = [x for x in files if not is_ignored(x)]
370
Mike Frysinger292b45d2014-11-25 01:17:10 -0500371 if full_details:
372 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500373 return files
374 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500375 # Caller only cares about filenames.
376 files = [x.dst_file if x.dst_file else x.src_file for x in files]
377 if relative:
378 return files
379 else:
380 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700381
382
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700383def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700384 """Returns a list of commits for this review."""
Ryan Cui4725d952011-05-05 15:41:19 -0700385 cmd = ['git', 'log', '%s..' % _get_upstream_branch(), '--format=%H']
Ryan Cui72834d12011-05-05 14:51:33 -0700386 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700387
Ryan Cui1562fb82011-05-09 11:01:31 -0700388
Ryan Cuiec4d6332011-05-02 14:15:25 -0700389def _get_commit_desc(commit):
390 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700391 if commit == PRE_SUBMIT:
392 return ''
Sean Paul23a2c582011-05-06 13:10:44 -0400393 return _run_command(['git', 'log', '--format=%s%n%n%b', commit + '^!'])
Ryan Cuiec4d6332011-05-02 14:15:25 -0700394
395
396# Common Hooks
397
Ryan Cui1562fb82011-05-09 11:01:31 -0700398
Mike Frysingerae409522014-02-01 03:16:11 -0500399def _check_no_long_lines(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -0500400 """Checks there are no lines longer than MAX_LEN in any of the text files."""
401
Ryan Cuiec4d6332011-05-02 14:15:25 -0700402 MAX_LEN = 80
Jon Salz98255932012-08-18 14:48:02 +0800403 SKIP_REGEXP = re.compile('|'.join([
404 r'https?://',
405 r'^#\s*(define|include|import|pragma|if|endif)\b']))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700406
407 errors = []
408 files = _filter_files(_get_affected_files(commit),
409 COMMON_INCLUDED_PATHS,
410 COMMON_EXCLUDED_PATHS)
411
412 for afile in files:
413 for line_num, line in _get_file_diff(afile, commit):
414 # Allow certain lines to exceed the maxlen rule.
Mike Frysingerae409522014-02-01 03:16:11 -0500415 if len(line) <= MAX_LEN or SKIP_REGEXP.search(line):
Jon Salz98255932012-08-18 14:48:02 +0800416 continue
417
418 errors.append('%s, line %s, %s chars' % (afile, line_num, len(line)))
419 if len(errors) == 5: # Just show the first 5 errors.
420 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700421
422 if errors:
423 msg = 'Found lines longer than %s characters (first 5 shown):' % MAX_LEN
Ryan Cui1562fb82011-05-09 11:01:31 -0700424 return HookFailure(msg, errors)
425
Ryan Cuiec4d6332011-05-02 14:15:25 -0700426
Mike Frysingerae409522014-02-01 03:16:11 -0500427def _check_no_stray_whitespace(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700428 """Checks that there is no stray whitespace at source lines end."""
429 errors = []
430 files = _filter_files(_get_affected_files(commit),
Mike Frysingerae409522014-02-01 03:16:11 -0500431 COMMON_INCLUDED_PATHS,
432 COMMON_EXCLUDED_PATHS)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700433 for afile in files:
434 for line_num, line in _get_file_diff(afile, commit):
435 if line.rstrip() != line:
436 errors.append('%s, line %s' % (afile, line_num))
437 if errors:
Ryan Cui1562fb82011-05-09 11:01:31 -0700438 return HookFailure('Found line ending with white space in:', errors)
439
Ryan Cuiec4d6332011-05-02 14:15:25 -0700440
Mike Frysingerae409522014-02-01 03:16:11 -0500441def _check_no_tabs(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700442 """Checks there are no unexpanded tabs."""
443 TAB_OK_PATHS = [
Ryan Cui31e0c172011-05-04 21:00:45 -0700444 r"/src/third_party/u-boot/",
Ryan Cuiec4d6332011-05-02 14:15:25 -0700445 r".*\.ebuild$",
446 r".*\.eclass$",
Elly Jones5ab34192011-11-15 14:57:06 -0500447 r".*/[M|m]akefile$",
448 r".*\.mk$"
Ryan Cuiec4d6332011-05-02 14:15:25 -0700449 ]
450
451 errors = []
452 files = _filter_files(_get_affected_files(commit),
453 COMMON_INCLUDED_PATHS,
454 COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
455
456 for afile in files:
457 for line_num, line in _get_file_diff(afile, commit):
458 if '\t' in line:
Mike Frysingerae409522014-02-01 03:16:11 -0500459 errors.append('%s, line %s' % (afile, line_num))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700460 if errors:
Ryan Cui1562fb82011-05-09 11:01:31 -0700461 return HookFailure('Found a tab character in:', errors)
462
Ryan Cuiec4d6332011-05-02 14:15:25 -0700463
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700464def _check_gofmt(_project, commit):
465 """Checks that Go files are formatted with gofmt."""
466 errors = []
467 files = _filter_files(_get_affected_files(commit, relative=True),
468 [r'\.go$'])
469
470 for gofile in files:
471 contents = _get_file_content(gofile, commit)
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700472 output = _run_command(cmd=['gofmt', '-l'], input=contents,
473 combine_stdout_stderr=True)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700474 if output:
475 errors.append(gofile)
476 if errors:
477 return HookFailure('Files not formatted with gofmt:', errors)
478
479
Mike Frysingerae409522014-02-01 03:16:11 -0500480def _check_change_has_test_field(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700481 """Check for a non-empty 'TEST=' field in the commit message."""
David McMahon8f6553e2011-06-10 15:46:36 -0700482 TEST_RE = r'\nTEST=\S+'
Ryan Cuiec4d6332011-05-02 14:15:25 -0700483
Mandeep Singh Baines96a53be2011-05-03 11:10:25 -0700484 if not re.search(TEST_RE, _get_commit_desc(commit)):
Ryan Cui1562fb82011-05-09 11:01:31 -0700485 msg = 'Changelist description needs TEST field (after first line)'
486 return HookFailure(msg)
487
Ryan Cuiec4d6332011-05-02 14:15:25 -0700488
Mike Frysingerae409522014-02-01 03:16:11 -0500489def _check_change_has_valid_cq_depend(_project, commit):
David Jamesc3b68b32013-04-03 09:17:03 -0700490 """Check for a correctly formatted CQ-DEPEND field in the commit message."""
491 msg = 'Changelist has invalid CQ-DEPEND target.'
492 example = 'Example: CQ-DEPEND=CL:1234, CL:2345'
493 try:
494 patch.GetPaladinDeps(_get_commit_desc(commit))
495 except ValueError as ex:
496 return HookFailure(msg, [example, str(ex)])
497
498
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800499def _check_change_is_contribution(_project, commit):
500 """Check that the change is a contribution."""
501 NO_CONTRIB = 'not a contribution'
502 if NO_CONTRIB in _get_commit_desc(commit).lower():
503 msg = ('Changelist is not a contribution, this cannot be accepted.\n'
504 'Please remove the "%s" text from the commit message.') % NO_CONTRIB
505 return HookFailure(msg)
506
507
Alex Deymo643ac4c2015-09-03 10:40:50 -0700508def _check_change_has_bug_field(project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700509 """Check for a correctly formatted 'BUG=' field in the commit message."""
David James5c0073d2013-04-03 08:48:52 -0700510 OLD_BUG_RE = r'\nBUG=.*chromium-os'
511 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
512 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
513 'the chromium tracker in your BUG= line now.')
514 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700515
Alex Deymo643ac4c2015-09-03 10:40:50 -0700516 # Android internal and external projects use "Bug: " to track bugs in
517 # buganizer.
518 BUG_COLON_REMOTES = (
519 'aosp',
520 'goog',
521 )
522 if project.remote in BUG_COLON_REMOTES:
523 BUG_RE = r'\nBug: ?([Nn]one|\d+)'
524 if not re.search(BUG_RE, _get_commit_desc(commit)):
525 msg = ('Changelist description needs BUG field (after first line):\n'
526 'Bug: 9999 (for buganizer)\n'
527 'BUG=None')
528 return HookFailure(msg)
529 else:
530 BUG_RE = r'\nBUG=([Nn]one|(chrome-os-partner|chromium|brillo|b):\d+)'
531 if not re.search(BUG_RE, _get_commit_desc(commit)):
532 msg = ('Changelist description needs BUG field (after first line):\n'
533 'BUG=brillo:9999 (for Brillo tracker)\n'
534 'BUG=chromium:9999 (for public tracker)\n'
535 'BUG=chrome-os-partner:9999 (for partner tracker)\n'
536 'BUG=b:9999 (for buganizer)\n'
537 'BUG=None')
538 return HookFailure(msg)
Ryan Cui1562fb82011-05-09 11:01:31 -0700539
Ryan Cuiec4d6332011-05-02 14:15:25 -0700540
Mike Frysinger292b45d2014-11-25 01:17:10 -0500541def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -0700542 """Check that we're not missing a revbump of an ebuild in the given commit.
543
544 If the given commit touches files in a directory that has ebuilds somewhere
545 up the directory hierarchy, it's very likely that we need an ebuild revbump
546 in order for those changes to take effect.
547
548 It's not totally trivial to detect a revbump, so at least detect that an
549 ebuild with a revision number in it was touched. This should handle the
550 common case where we use a symlink to do the revbump.
551
552 TODO: it would be nice to enhance this hook to:
553 * Handle cases where people revbump with a slightly different syntax. I see
554 one ebuild (puppy) that revbumps with _pN. This is a false positive.
555 * Catches cases where people aren't using symlinks for revbumps. If they
556 edit a revisioned file directly (and are expected to rename it for revbump)
557 we'll miss that. Perhaps we could detect that the file touched is a
558 symlink?
559
560 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
561 still better off than without this check.
562
563 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700564 project: The Project to look at
Doug Anderson42b8a052013-06-26 10:45:36 -0700565 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -0500566 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -0700567
568 Returns:
569 A HookFailure or None.
570 """
Mike Frysinger011af942014-01-17 16:12:22 -0500571 # If this is the portage-stable overlay, then ignore the check. It's rare
572 # that we're doing anything other than importing files from upstream, so
573 # forcing a rev bump makes no sense.
574 whitelist = (
575 'chromiumos/overlays/portage-stable',
576 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700577 if project.name in whitelist:
Mike Frysinger011af942014-01-17 16:12:22 -0500578 return None
579
Mike Frysinger292b45d2014-11-25 01:17:10 -0500580 def FinalName(obj):
581 # If the file is being deleted, then the dst_file is not set.
582 if obj.dst_file is None:
583 return obj.src_file
584 else:
585 return obj.dst_file
586
587 affected_path_objs = _get_affected_files(
588 commit, include_deletes=True, include_symlinks=True, relative=True,
589 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -0700590
591 # Don't yell about changes to whitelisted files...
Aviv Keshet272f2e52016-04-25 14:49:44 -0700592 whitelist = ('ChangeLog', 'Manifest', 'metadata.xml', 'COMMIT-QUEUE.ini')
Mike Frysinger292b45d2014-11-25 01:17:10 -0500593 affected_path_objs = [x for x in affected_path_objs
594 if os.path.basename(FinalName(x)) not in whitelist]
595 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -0700596 return None
597
598 # If we've touched any file named with a -rN.ebuild then we'll say we're
599 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500600 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
601 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700602 if touched_revved_ebuild:
603 return None
604
Mike Frysinger292b45d2014-11-25 01:17:10 -0500605 # If we're creating new ebuilds from scratch, then we don't need an uprev.
606 # Find all the dirs that new ebuilds and ignore their files/.
607 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
608 if FinalName(x).endswith('.ebuild') and x.status == 'A']
609 affected_path_objs = [obj for obj in affected_path_objs
610 if not any(FinalName(obj).startswith(x)
611 for x in ebuild_dirs)]
612 if not affected_path_objs:
613 return
614
Doug Anderson42b8a052013-06-26 10:45:36 -0700615 # We want to examine the current contents of all directories that are parents
616 # of files that were touched (up to the top of the project).
617 #
618 # ...note: we use the current directory contents even though it may have
619 # changed since the commit we're looking at. This is just a heuristic after
620 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500621 if project_top is None:
622 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -0700623 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -0500624 for obj in affected_path_objs:
625 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -0700626 while os.path.exists(path) and not os.path.samefile(path, project_top):
627 dirs_to_check.add(path)
628 path = os.path.dirname(path)
629
630 # Look through each directory. If it's got an ebuild in it then we'll
631 # consider this as a case when we need a revbump.
Gwendal Grignoua3086c32014-12-09 11:17:22 -0800632 affected_paths = set(os.path.join(project_top, FinalName(x))
633 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700634 for dir_path in dirs_to_check:
635 contents = os.listdir(dir_path)
636 ebuilds = [os.path.join(dir_path, path)
637 for path in contents if path.endswith('.ebuild')]
638 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
639
640 # If the -9999.ebuild file was touched the bot will uprev for us.
641 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -0500642 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -0700643 continue
644
645 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500646 return HookFailure('Changelist probably needs a revbump of an ebuild, '
647 'or a -r1.ebuild symlink if this is a new ebuild:\n'
648 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -0700649
650 return None
651
652
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500653def _check_ebuild_eapi(project, commit):
654 """Make sure we have people use EAPI=4 or newer with custom ebuilds.
655
656 We want to get away from older EAPI's as it makes life confusing and they
657 have less builtin error checking.
658
659 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700660 project: The Project to look at
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500661 commit: The commit to look at
662
663 Returns:
664 A HookFailure or None.
665 """
666 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500667 # that we're doing anything other than importing files from upstream, and
668 # we shouldn't be rewriting things fundamentally anyways.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500669 whitelist = (
670 'chromiumos/overlays/portage-stable',
671 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700672 if project.name in whitelist:
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500673 return None
674
675 BAD_EAPIS = ('0', '1', '2', '3')
676
677 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
678
679 ebuilds_re = [r'\.ebuild$']
680 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
681 ebuilds_re)
682 bad_ebuilds = []
683
684 for ebuild in ebuilds:
685 # If the ebuild does not specify an EAPI, it defaults to 0.
686 eapi = '0'
687
688 lines = _get_file_content(ebuild, commit).splitlines()
689 if len(lines) == 1:
690 # This is most likely a symlink, so skip it entirely.
691 continue
692
693 for line in lines:
694 m = get_eapi.match(line)
695 if m:
696 # Once we hit the first EAPI line in this ebuild, stop processing.
697 # The spec requires that there only be one and it be first, so
698 # checking all possible values is pointless. We also assume that
699 # it's "the" EAPI line and not something in the middle of a heredoc.
700 eapi = m.group(1)
701 break
702
703 if eapi in BAD_EAPIS:
704 bad_ebuilds.append((ebuild, eapi))
705
706 if bad_ebuilds:
707 # pylint: disable=C0301
708 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
709 # pylint: enable=C0301
710 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500711 'These ebuilds are using old EAPIs. If these are imported from\n'
712 'Gentoo, then you may ignore and upload once with the --no-verify\n'
713 'flag. Otherwise, please update to 4 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500714 '\t%s\n'
715 'See this guide for more details:\n%s\n' %
716 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
717
718
Mike Frysinger89bdb852014-02-01 05:26:26 -0500719def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -0500720 """Make sure we use the new style KEYWORDS when possible in ebuilds.
721
722 If an ebuild generally does not care about the arch it is running on, then
723 ebuilds should flag it with one of:
724 KEYWORDS="*" # A stable ebuild.
725 KEYWORDS="~*" # An unstable ebuild.
726 KEYWORDS="-* ..." # Is known to only work on specific arches.
727
728 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700729 project: The Project to look at
Mike Frysingerc51ece72014-01-17 16:23:40 -0500730 commit: The commit to look at
731
732 Returns:
733 A HookFailure or None.
734 """
735 WHITELIST = set(('*', '-*', '~*'))
736
737 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
738
Mike Frysinger89bdb852014-02-01 05:26:26 -0500739 ebuilds_re = [r'\.ebuild$']
740 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
741 ebuilds_re)
742
Mike Frysinger8d42d742014-09-22 15:50:21 -0400743 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -0500744 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -0400745 # We get the full content rather than a diff as the latter does not work
746 # on new files (like when adding new ebuilds).
747 lines = _get_file_content(ebuild, commit).splitlines()
748 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -0500749 m = get_keywords.match(line)
750 if m:
751 keywords = set(m.group(1).split())
752 if not keywords or WHITELIST - keywords != WHITELIST:
753 continue
754
Mike Frysinger8d42d742014-09-22 15:50:21 -0400755 bad_ebuilds.append(ebuild)
756
757 if bad_ebuilds:
758 return HookFailure(
759 '%s\n'
760 'Please update KEYWORDS to use a glob:\n'
761 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
762 ' KEYWORDS="*"\n'
763 'If the ebuild should be marked unstable (normal for '
764 'cros-workon / 9999 ebuilds):\n'
765 ' KEYWORDS="~*"\n'
Mike Frysingerde8efea2015-05-17 03:42:26 -0400766 'If the ebuild needs to be marked for only specific arches, '
Mike Frysinger8d42d742014-09-22 15:50:21 -0400767 'then use -* like so:\n'
768 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -0500769
770
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800771def _check_ebuild_licenses(_project, commit):
772 """Check if the LICENSE field in the ebuild is correct."""
Brian Norris7a610e82016-02-17 12:24:54 -0800773 affected_paths = _get_affected_files(commit, relative=True)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800774 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
775
776 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -0800777 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800778
779 for ebuild in touched_ebuilds:
780 # Skip virutal packages.
781 if ebuild.split('/')[-3] == 'virtual':
782 continue
783
784 try:
Brian Norris7a610e82016-02-17 12:24:54 -0800785 ebuild_content = _get_file_content(ebuild, commit)
786 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800787 except ValueError as e:
788 return HookFailure(e.message, [ebuild])
789
790 # Also ignore licenses ending with '?'
791 for license_type in [x for x in license_types
792 if x not in LICENSES_IGNORE and not x.endswith('?')]:
793 try:
Mike Frysinger2ec70ed2014-08-17 19:28:34 -0400794 licenses_lib.Licensing.FindLicenseType(license_type)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800795 except AssertionError as e:
796 return HookFailure(e.message, [ebuild])
797
798
Mike Frysingercd363c82014-02-01 05:20:18 -0500799def _check_ebuild_virtual_pv(project, commit):
800 """Enforce the virtual PV policies."""
801 # If this is the portage-stable overlay, then ignore the check.
802 # We want to import virtuals as-is from upstream Gentoo.
803 whitelist = (
804 'chromiumos/overlays/portage-stable',
805 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700806 if project.name in whitelist:
Mike Frysingercd363c82014-02-01 05:20:18 -0500807 return None
808
809 # We assume the repo name is the same as the dir name on disk.
810 # It would be dumb to not have them match though.
Alex Deymo643ac4c2015-09-03 10:40:50 -0700811 project_base = os.path.basename(project.name)
Mike Frysingercd363c82014-02-01 05:20:18 -0500812
813 is_variant = lambda x: x.startswith('overlay-variant-')
814 is_board = lambda x: x.startswith('overlay-')
815 is_private = lambda x: x.endswith('-private')
816
817 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
818
819 ebuilds_re = [r'\.ebuild$']
820 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
821 ebuilds_re)
822 bad_ebuilds = []
823
824 for ebuild in ebuilds:
825 m = get_pv.match(ebuild)
826 if m:
827 overlay = m.group(1)
828 if not overlay or not is_board(overlay):
Alex Deymo643ac4c2015-09-03 10:40:50 -0700829 overlay = project_base
Mike Frysingercd363c82014-02-01 05:20:18 -0500830
831 pv = m.group(3).split('-', 1)[0]
832
Bernie Thompsone5ee1822016-01-12 14:22:23 -0800833 # Virtual versions >= 4 are special cases used above the standard
834 # versioning structure, e.g. if one has a board inheriting a board.
835 if float(pv) >= 4:
836 want_pv = pv
837 elif is_private(overlay):
Mike Frysingercd363c82014-02-01 05:20:18 -0500838 want_pv = '3.5' if is_variant(overlay) else '3'
839 elif is_board(overlay):
840 want_pv = '2.5' if is_variant(overlay) else '2'
841 else:
842 want_pv = '1'
843
844 if pv != want_pv:
845 bad_ebuilds.append((ebuild, pv, want_pv))
846
847 if bad_ebuilds:
848 # pylint: disable=C0301
849 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
850 # pylint: enable=C0301
851 return HookFailure(
852 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
853 '\t%s\n'
854 'If this is an upstream Gentoo virtual, then you may ignore this\n'
855 'check (and re-run w/--no-verify). Otherwise, please see this\n'
856 'page for more details:\n%s\n' %
857 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
858 for x in bad_ebuilds]), url))
859
860
Daniel Erat9d203ff2015-02-17 10:12:21 -0700861def _check_portage_make_use_var(_project, commit):
862 """Verify that $USE is set correctly in make.conf and make.defaults."""
863 files = _filter_files(_get_affected_files(commit, relative=True),
864 [r'(^|/)make.(conf|defaults)$'])
865
866 errors = []
867 for path in files:
868 basename = os.path.basename(path)
869
870 # Has a USE= line already been encountered in this file?
871 saw_use = False
872
873 for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1):
874 if not line.startswith('USE='):
875 continue
876
877 preserves_use = '${USE}' in line or '$USE' in line
878
879 if (basename == 'make.conf' or
880 (basename == 'make.defaults' and saw_use)) and not preserves_use:
881 errors.append('%s:%d: missing ${USE}' % (path, i))
882 elif basename == 'make.defaults' and not saw_use and preserves_use:
883 errors.append('%s:%d: ${USE} referenced in initial declaration' %
884 (path, i))
885
886 saw_use = True
887
888 if errors:
889 return HookFailure(
890 'One or more Portage make files appear to set USE incorrectly.\n'
891 '\n'
892 'All USE assignments in make.conf and all assignments after the\n'
893 'initial declaration in make.defaults should contain "${USE}" to\n'
894 'preserve previously-set flags.\n'
895 '\n'
896 'The initial USE declaration in make.defaults should not contain\n'
897 '"${USE}".\n',
898 errors)
899
900
Mike Frysingerae409522014-02-01 03:16:11 -0500901def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -0700902 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -0400903 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -0700904 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -0400905 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -0500906 if not m:
Ryan Cui1562fb82011-05-09 11:01:31 -0700907 return HookFailure('Change-Id must be in last paragraph of description.')
908
Mike Frysinger02b88bd2014-11-21 00:29:38 -0500909 # Allow s-o-b tags to follow it, but only those.
910 end = desc[m.end():].strip().splitlines()
911 if [x for x in end if not x.startswith('Signed-off-by: ')]:
912 return HookFailure('Only "Signed-off-by:" tags may follow the Change-Id.')
913
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -0700914
Mike Frysinger36b2ebc2014-10-31 14:02:03 -0400915def _check_commit_message_style(_project, commit):
916 """Verify that the commit message matches our style.
917
918 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
919 commit hooks.
920 """
921 desc = _get_commit_desc(commit)
922
923 # The first line should be by itself.
924 lines = desc.splitlines()
925 if len(lines) > 1 and lines[1]:
926 return HookFailure('The second line of the commit message must be blank.')
927
928 # The first line should be one sentence.
929 if '. ' in lines[0]:
930 return HookFailure('The first line cannot be more than one sentence.')
931
932 # The first line cannot be too long.
933 MAX_FIRST_LINE_LEN = 100
934 if len(lines[0]) > MAX_FIRST_LINE_LEN:
935 return HookFailure('The first line must be less than %i chars.' %
936 MAX_FIRST_LINE_LEN)
937
938
Filipe Brandenburger4b542b12015-10-09 12:46:31 -0700939def _check_cros_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -0700940 """Verifies the Chromium OS license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700941
Mike Frysinger98638102014-08-28 00:15:08 -0400942 Should be following the spec:
943 http://dev.chromium.org/developers/coding-style#TOC-File-headers
944 """
945 # For older years, be a bit more flexible as our policy says leave them be.
946 LICENSE_HEADER = (
947 r'.* Copyright( \(c\))? 20[-0-9]{2,7} The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -0500948 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -0400949 r'.* Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -0500950 r'be\n'
Mike Frysinger98638102014-08-28 00:15:08 -0400951 r'.* found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -0500952 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -0400953 )
954 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
955
956 # For newer years, be stricter.
957 COPYRIGHT_LINE = (
958 r'.* Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -0500959 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -0400960 )
961 copyright_re = re.compile(COPYRIGHT_LINE)
962
Filipe Brandenburger4b542b12015-10-09 12:46:31 -0700963 parser = argparse.ArgumentParser()
964 parser.add_argument('--exclude_regex', action='append')
965 parser.add_argument('--include_regex', action='append')
966 opts = parser.parse_args(options)
967 included = opts.include_regex or []
968 excluded = opts.exclude_regex or []
969
Mike Frysinger98638102014-08-28 00:15:08 -0400970 bad_files = []
971 bad_copyright_files = []
972 files = _filter_files(_get_affected_files(commit, relative=True),
Filipe Brandenburger4b542b12015-10-09 12:46:31 -0700973 included + COMMON_INCLUDED_PATHS,
974 excluded + COMMON_EXCLUDED_PATHS)
Mike Frysinger98638102014-08-28 00:15:08 -0400975
976 for f in files:
977 contents = _get_file_content(f, commit)
978 if not contents:
979 # Ignore empty files.
980 continue
981
982 if not license_re.search(contents):
983 bad_files.append(f)
984 elif copyright_re.search(contents):
985 bad_copyright_files.append(f)
986
987 if bad_files:
988 msg = '%s:\n%s\n%s' % (
989 'License must match', license_re.pattern,
990 'Found a bad header in these files:')
991 return HookFailure(msg, bad_files)
992
993 if bad_copyright_files:
994 msg = 'Do not use (c) in copyright headers in new files:'
995 return HookFailure(msg, bad_copyright_files)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700996
997
Alex Deymof5792ce2015-08-24 22:50:08 -0700998def _check_aosp_license(_project, commit):
999 """Verifies the AOSP license/copyright header.
1000
1001 AOSP uses the Apache2 License:
1002 https://source.android.com/source/licenses.html
1003 """
1004 LICENSE_HEADER = (
1005 r"""^[#/\*]*
1006[#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project
1007[#/\*]* ?
1008[#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\);
1009[#/\*]* ?you may not use this file except in compliance with the License\.
1010[#/\*]* ?You may obtain a copy of the License at
1011[#/\*]* ?
1012[#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0
1013[#/\*]* ?
1014[#/\*]* ?Unless required by applicable law or agreed to in writing, software
1015[#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS,
1016[#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """
1017 r"""implied\.
1018[#/\*]* ?See the License for the specific language governing permissions and
1019[#/\*]* ?limitations under the License\.
1020[#/\*]*$
1021"""
1022 )
1023 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1024
1025 files = _filter_files(_get_affected_files(commit, relative=True),
1026 COMMON_INCLUDED_PATHS,
1027 COMMON_EXCLUDED_PATHS)
1028
1029 bad_files = []
1030 for f in files:
1031 contents = _get_file_content(f, commit)
1032 if not contents:
1033 # Ignore empty files.
1034 continue
1035
1036 if not license_re.search(contents):
1037 bad_files.append(f)
1038
1039 if bad_files:
1040 msg = ('License must match:\n%s\nFound a bad header in these files:' %
1041 license_re.pattern)
1042 return HookFailure(msg, bad_files)
1043
1044
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001045def _check_layout_conf(_project, commit):
1046 """Verifies the metadata/layout.conf file."""
1047 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001048 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001049 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001050 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001051
Mike Frysinger94a670c2014-09-19 12:46:26 -04001052 # Handle multiple overlays in a single commit (like the public tree).
1053 for f in _get_affected_files(commit, relative=True):
1054 if f.endswith(repo_name):
1055 repo_names.append(f)
1056 elif f.endswith(layout_path):
1057 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001058
1059 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -04001060 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001061 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -04001062 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001063
Mike Frysinger94a670c2014-09-19 12:46:26 -04001064 # Gather all the errors in one pass so we show one full message.
1065 all_errors = {}
1066 for layout_path in layout_paths:
1067 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001068
Mike Frysinger94a670c2014-09-19 12:46:26 -04001069 # Make sure the config file is sorted.
1070 data = [x for x in _get_file_content(layout_path, commit).splitlines()
1071 if x and x[0] != '#']
1072 if sorted(data) != data:
1073 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001074
Mike Frysinger94a670c2014-09-19 12:46:26 -04001075 # Require people to set specific values all the time.
1076 settings = (
1077 # TODO: Enable this for everyone. http://crbug.com/408038
1078 #('fast caching', 'cache-format = md5-dict'),
1079 ('fast manifests', 'thin-manifests = true'),
Mike Frysingerd7734522015-02-26 16:12:43 -05001080 ('extra features', 'profile-formats = portage-2 profile-default-eapi'),
1081 ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001082 )
1083 for reason, line in settings:
1084 if line not in data:
1085 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001086
Mike Frysinger94a670c2014-09-19 12:46:26 -04001087 # Require one of these settings.
Mike Frysinger5fae62d2015-11-11 20:12:15 -05001088 if 'use-manifests = strict' not in data:
1089 errors += ['enable file checking with: use-manifests = strict']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001090
Mike Frysinger94a670c2014-09-19 12:46:26 -04001091 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -04001092 for line in data:
1093 if line.startswith('repo-name = '):
1094 break
1095 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -04001096 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001097
Mike Frysinger94a670c2014-09-19 12:46:26 -04001098 # Summarize all the errors we saw (if any).
1099 lines = ''
1100 for layout_path, errors in all_errors.items():
1101 if errors:
1102 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
1103 if lines:
1104 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
1105 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001106
1107
Ryan Cuiec4d6332011-05-02 14:15:25 -07001108# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001109
Ryan Cui1562fb82011-05-09 11:01:31 -07001110
Mike Frysingerae409522014-02-01 03:16:11 -05001111def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001112 """Runs checkpatch.pl on the given project"""
1113 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001114 options = list(options)
1115 if commit == PRE_SUBMIT:
1116 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
1117 # this case.
1118 options.append('--ignore=MISSING_SIGN_OFF')
Filipe Brandenburger28d48d62015-10-07 09:48:54 -07001119 # Always ignore the check for the MAINTAINERS file. We do not track that
1120 # information on that file in our source trees, so let's suppress the
1121 # warning.
1122 options.append('--ignore=FILE_PATH_CHANGES')
Filipe Brandenburgerce978322015-10-09 10:04:15 -07001123 # Do not complain about the Change-Id: fields, since we use Gerrit.
1124 # Upstream does not want those lines (since they do not use Gerrit), but
1125 # we always do, so disable the check globally.
Daisuke Nojiri4844f892015-10-08 09:54:33 -07001126 options.append('--ignore=GERRIT_CHANGE_ID')
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001127 cmd = ['%s/checkpatch.pl' % hooks_dir] + options + ['-']
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001128 cmd_result = cros_build_lib.RunCommand(cmd=cmd,
1129 print_cmd=False,
1130 input=_get_patch(commit),
1131 stdout_to_pipe=True,
1132 combine_stdout_stderr=True,
1133 error_code_ok=True)
1134 if cmd_result.returncode:
1135 return HookFailure('checkpatch.pl errors/warnings\n\n' + cmd_result.output)
Ryan Cuiec4d6332011-05-02 14:15:25 -07001136
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001137
Mike Frysingerae409522014-02-01 03:16:11 -05001138def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -07001139 """Makes sure kernel config changes are not mixed with code changes"""
1140 files = _get_affected_files(commit)
1141 if not len(_filter_files(files, [r'chromeos/config'])) in [0, len(files)]:
1142 return HookFailure('Changes to chromeos/config/ and regular files must '
1143 'be in separate commits:\n%s' % '\n'.join(files))
Anton Staaf815d6852011-08-22 10:08:45 -07001144
Mike Frysingerae409522014-02-01 03:16:11 -05001145
1146def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -07001147 """Checks that all JSON files are syntactically valid."""
Dale Curtisa039cfd2011-05-04 12:01:05 -07001148 for f in _filter_files(_get_affected_files(commit), [r'.*\.json']):
Dale Curtis2975c432011-05-03 17:25:20 -07001149 try:
1150 json.load(open(f))
1151 except Exception, e:
Ryan Cui1562fb82011-05-09 11:01:31 -07001152 return HookFailure('Invalid JSON in %s: %s' % (f, e))
Dale Curtis2975c432011-05-03 17:25:20 -07001153
1154
Mike Frysingerae409522014-02-01 03:16:11 -05001155def _check_manifests(_project, commit):
Mike Frysinger52b537e2013-08-22 22:59:53 -04001156 """Make sure Manifest files only have DIST lines"""
1157 paths = []
1158
1159 for path in _get_affected_files(commit):
1160 if os.path.basename(path) != 'Manifest':
1161 continue
1162 if not os.path.exists(path):
1163 continue
1164
1165 with open(path, 'r') as f:
1166 for line in f.readlines():
1167 if not line.startswith('DIST '):
1168 paths.append(path)
1169 break
1170
1171 if paths:
1172 return HookFailure('Please remove lines that do not start with DIST:\n%s' %
1173 ('\n'.join(paths),))
1174
1175
Mike Frysingerae409522014-02-01 03:16:11 -05001176def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001177 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001178 if commit == PRE_SUBMIT:
1179 return
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001180 BRANCH_RE = r'\nBRANCH=\S+'
1181
1182 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
1183 msg = ('Changelist description needs BRANCH field (after first line)\n'
1184 'E.g. BRANCH=none or BRANCH=link,snow')
1185 return HookFailure(msg)
1186
1187
Mike Frysingerae409522014-02-01 03:16:11 -05001188def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001189 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001190 if commit == PRE_SUBMIT:
1191 return
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001192 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1193
1194 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1195 msg = ('Changelist description needs Signed-off-by: field\n'
1196 'E.g. Signed-off-by: My Name <me@chromium.org>')
1197 return HookFailure(msg)
1198
1199
Jon Salz3ee59de2012-08-18 13:54:22 +08001200def _run_project_hook_script(script, project, commit):
1201 """Runs a project hook script.
1202
1203 The script is run with the following environment variables set:
1204 PRESUBMIT_PROJECT: The affected project
1205 PRESUBMIT_COMMIT: The affected commit
1206 PRESUBMIT_FILES: A newline-separated list of affected files
1207
1208 The script is considered to fail if the exit code is non-zero. It should
1209 write an error message to stdout.
1210 """
1211 env = dict(os.environ)
Alex Deymo643ac4c2015-09-03 10:40:50 -07001212 env['PRESUBMIT_PROJECT'] = project.name
Jon Salz3ee59de2012-08-18 13:54:22 +08001213 env['PRESUBMIT_COMMIT'] = commit
1214
1215 # Put affected files in an environment variable
1216 files = _get_affected_files(commit)
1217 env['PRESUBMIT_FILES'] = '\n'.join(files)
1218
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001219 cmd_result = cros_build_lib.RunCommand(cmd=script,
1220 env=env,
1221 shell=True,
1222 print_cmd=False,
1223 input=os.devnull,
1224 stdout_to_pipe=True,
1225 combine_stdout_stderr=True,
1226 error_code_ok=True)
1227 if cmd_result.returncode:
1228 stdout = cmd_result.output
Jon Salz7b618af2012-08-31 06:03:16 +08001229 if stdout:
1230 stdout = re.sub('(?m)^', ' ', stdout)
1231 return HookFailure('Hook script "%s" failed with code %d%s' %
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001232 (script, cmd_result.returncode,
Jon Salz3ee59de2012-08-18 13:54:22 +08001233 ':\n' + stdout if stdout else ''))
1234
1235
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001236def _check_project_prefix(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -05001237 """Require the commit message have a project specific prefix as needed."""
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001238
1239 files = _get_affected_files(commit, relative=True)
1240 prefix = os.path.commonprefix(files)
1241 prefix = os.path.dirname(prefix)
1242
1243 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07001244 if not prefix:
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001245 return
1246
1247 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07001248
1249 # The common files may all be within a subdirectory of the main project
1250 # directory, so walk up the tree until we find an alias file.
1251 # _get_affected_files() should return relative paths, but check against '/' to
1252 # ensure that this loop terminates even if it receives an absolute path.
1253 while prefix and prefix != '/':
1254 alias_file = os.path.join(prefix, '.project_alias')
1255
1256 # If an alias exists, use it.
1257 if os.path.isfile(alias_file):
1258 project_name = osutils.ReadFile(alias_file).strip()
1259
1260 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001261
1262 if not _get_commit_desc(commit).startswith(project_name + ': '):
1263 return HookFailure('The commit title for changes affecting only %s'
1264 ' should start with \"%s: \"'
1265 % (project_name, project_name))
1266
1267
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001268# Base
1269
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001270# A list of hooks which are not project specific and check patch description
1271# (as opposed to patch body).
1272_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07001273 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07001274 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07001275 _check_change_has_test_field,
1276 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001277 _check_commit_message_style,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001278 _check_change_is_contribution,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001279]
1280
1281
1282# A list of hooks that are not project-specific
1283_COMMON_HOOKS = [
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001284 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05001285 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001286 _check_ebuild_licenses,
Mike Frysingercd363c82014-02-01 05:20:18 -05001287 _check_ebuild_virtual_pv,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001288 _check_for_uprev,
Rahul Chaudhry09f61372015-07-31 17:14:26 -07001289 _check_gofmt,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001290 _check_layout_conf,
Alex Deymof5792ce2015-08-24 22:50:08 -07001291 _check_cros_license,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001292 _check_no_long_lines,
1293 _check_no_stray_whitespace,
Ryan Cui9b651632011-05-11 11:38:58 -07001294 _check_no_tabs,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001295 _check_portage_make_use_var,
Ryan Cui9b651632011-05-11 11:38:58 -07001296]
Ryan Cuiec4d6332011-05-02 14:15:25 -07001297
Ryan Cui1562fb82011-05-09 11:01:31 -07001298
Ryan Cui9b651632011-05-11 11:38:58 -07001299# A dictionary of project-specific hooks(callbacks), indexed by project name.
1300# dict[project] = [callback1, callback2]
1301_PROJECT_SPECIFIC_HOOKS = {
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001302 "chromiumos/platform2": [_check_project_prefix],
Mike Frysingeraf891292015-03-25 19:46:53 -04001303 "chromiumos/third_party/kernel": [_kernel_configcheck],
1304 "chromiumos/third_party/kernel-next": [_kernel_configcheck],
Ryan Cui9b651632011-05-11 11:38:58 -07001305}
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001306
Ryan Cui1562fb82011-05-09 11:01:31 -07001307
Ryan Cui9b651632011-05-11 11:38:58 -07001308# A dictionary of flags (keys) that can appear in the config file, and the hook
Mike Frysinger3554bc92015-03-11 04:59:21 -04001309# that the flag controls (value).
1310_HOOK_FLAGS = {
Mike Frysingera7642f52015-03-25 18:31:42 -04001311 'checkpatch_check': _run_checkpatch,
Ryan Cui9b651632011-05-11 11:38:58 -07001312 'stray_whitespace_check': _check_no_stray_whitespace,
Mike Frysingerff6c7d62015-03-24 13:49:46 -04001313 'json_check': _run_json_check,
Ryan Cui9b651632011-05-11 11:38:58 -07001314 'long_line_check': _check_no_long_lines,
Alex Deymof5792ce2015-08-24 22:50:08 -07001315 'cros_license_check': _check_cros_license,
1316 'aosp_license_check': _check_aosp_license,
Ryan Cui9b651632011-05-11 11:38:58 -07001317 'tab_check': _check_no_tabs,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001318 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001319 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07001320 'bug_field_check': _check_change_has_bug_field,
1321 'test_field_check': _check_change_has_test_field,
Steve Fung49ec7e92015-03-23 16:07:12 -07001322 'manifest_check': _check_manifests,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001323 'contribution_check': _check_change_is_contribution,
Ryan Cui9b651632011-05-11 11:38:58 -07001324}
1325
1326
Mike Frysinger3554bc92015-03-11 04:59:21 -04001327def _get_override_hooks(config):
1328 """Returns a set of hooks controlled by the current project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001329
1330 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08001331
1332 Args:
1333 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001334 """
1335 SECTION = 'Hook Overrides'
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001336 SECTION_OPTIONS = 'Hook Overrides Options'
Jon Salz3ee59de2012-08-18 13:54:22 +08001337 if not config.has_section(SECTION):
Mike Frysinger3554bc92015-03-11 04:59:21 -04001338 return set(), set()
Ryan Cui9b651632011-05-11 11:38:58 -07001339
Mike Frysinger3554bc92015-03-11 04:59:21 -04001340 valid_keys = set(_HOOK_FLAGS.iterkeys())
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001341 hooks = _HOOK_FLAGS.copy()
Mike Frysinger3554bc92015-03-11 04:59:21 -04001342
1343 enable_flags = []
Ryan Cui9b651632011-05-11 11:38:58 -07001344 disable_flags = []
Jon Salz3ee59de2012-08-18 13:54:22 +08001345 for flag in config.options(SECTION):
Mike Frysinger3554bc92015-03-11 04:59:21 -04001346 if flag not in valid_keys:
1347 raise ValueError('Error: unknown key "%s" in hook section of "%s"' %
1348 (flag, _CONFIG_FILE))
1349
Ryan Cui9b651632011-05-11 11:38:58 -07001350 try:
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001351 enabled = config.getboolean(SECTION, flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001352 except ValueError as e:
Mike Frysinger3554bc92015-03-11 04:59:21 -04001353 raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' %
1354 (flag, _CONFIG_FILE, e))
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001355 if enabled:
1356 enable_flags.append(flag)
1357 else:
1358 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001359
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001360 # See if this hook has custom options.
1361 if enabled:
1362 try:
1363 options = config.get(SECTION_OPTIONS, flag)
1364 hooks[flag] = functools.partial(hooks[flag], options=options.split())
1365 except (ConfigParser.NoOptionError, ConfigParser.NoSectionError):
1366 pass
1367
1368 enabled_hooks = set(hooks[x] for x in enable_flags)
1369 disabled_hooks = set(hooks[x] for x in disable_flags)
Mike Frysinger3554bc92015-03-11 04:59:21 -04001370 return enabled_hooks, disabled_hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001371
1372
Jon Salz3ee59de2012-08-18 13:54:22 +08001373def _get_project_hook_scripts(config):
1374 """Returns a list of project-specific hook scripts.
1375
1376 Args:
1377 config: A ConfigParser for the project's config file.
1378 """
1379 SECTION = 'Hook Scripts'
1380 if not config.has_section(SECTION):
1381 return []
1382
1383 hook_names_values = config.items(SECTION)
1384 hook_names_values.sort(key=lambda x: x[0])
1385 return [x[1] for x in hook_names_values]
1386
1387
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001388def _get_project_hooks(project, presubmit):
Ryan Cui9b651632011-05-11 11:38:58 -07001389 """Returns a list of hooks that need to be run for a project.
1390
1391 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001392
1393 Args:
1394 project: A string, name of the project.
1395 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui9b651632011-05-11 11:38:58 -07001396 """
Jon Salz3ee59de2012-08-18 13:54:22 +08001397 config = ConfigParser.RawConfigParser()
1398 try:
1399 config.read(_CONFIG_FILE)
1400 except ConfigParser.Error:
1401 # Just use an empty config file
1402 config = ConfigParser.RawConfigParser()
1403
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001404 if presubmit:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001405 hooks = _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001406 else:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001407 hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001408
Mike Frysinger3554bc92015-03-11 04:59:21 -04001409 enabled_hooks, disabled_hooks = _get_override_hooks(config)
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001410 hooks = [hook for hook in hooks if hook not in disabled_hooks]
1411
1412 # If a list is both in _COMMON_HOOKS and also enabled explicitly through an
1413 # override, keep the override only. Note that the override may end up being
1414 # a functools.partial, in which case we need to extract the .func to compare
1415 # it to the common hooks.
1416 unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks]
1417 hooks = [hook for hook in hooks if hook not in unwrapped_hooks]
1418
1419 hooks = list(enabled_hooks) + hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001420
1421 if project in _PROJECT_SPECIFIC_HOOKS:
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001422 hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project]
1423 if hook not in disabled_hooks)
Ryan Cui9b651632011-05-11 11:38:58 -07001424
Jon Salz3ee59de2012-08-18 13:54:22 +08001425 for script in _get_project_hook_scripts(config):
1426 hooks.append(functools.partial(_run_project_hook_script, script))
1427
Ryan Cui9b651632011-05-11 11:38:58 -07001428 return hooks
1429
1430
Alex Deymo643ac4c2015-09-03 10:40:50 -07001431def _run_project_hooks(project_name, proj_dir=None,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001432 commit_list=None, presubmit=False):
Ryan Cui1562fb82011-05-09 11:01:31 -07001433 """For each project run its project specific hook from the hooks dictionary.
1434
1435 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001436 project_name: The name of project to run hooks for.
Doug Anderson44a644f2011-11-02 10:37:37 -07001437 proj_dir: If non-None, this is the directory the project is in. If None,
1438 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07001439 commit_list: A list of commits to run hooks against. If None or empty list
1440 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001441 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui1562fb82011-05-09 11:01:31 -07001442
1443 Returns:
1444 Boolean value of whether any errors were ecountered while running the hooks.
1445 """
Doug Anderson44a644f2011-11-02 10:37:37 -07001446 if proj_dir is None:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001447 proj_dirs = _run_command(
1448 ['repo', 'forall', project_name, '-c', 'pwd']).split()
David James2edd9002013-10-11 14:09:19 -07001449 if len(proj_dirs) == 0:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001450 print('%s cannot be found.' % project_name, file=sys.stderr)
David James2edd9002013-10-11 14:09:19 -07001451 print('Please specify a valid project.', file=sys.stderr)
1452 return True
1453 if len(proj_dirs) > 1:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001454 print('%s is associated with multiple directories.' % project_name,
David James2edd9002013-10-11 14:09:19 -07001455 file=sys.stderr)
1456 print('Please specify a directory to help disambiguate.', file=sys.stderr)
1457 return True
1458 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07001459
Ryan Cuiec4d6332011-05-02 14:15:25 -07001460 pwd = os.getcwd()
1461 # hooks assume they are run from the root of the project
1462 os.chdir(proj_dir)
1463
Alex Deymo643ac4c2015-09-03 10:40:50 -07001464 remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref',
1465 '--symbolic-full-name', '@{u}']).strip()
1466 if not remote_branch:
1467 print('Your project %s doesn\'t track any remote repo.' % project_name,
1468 file=sys.stderr)
1469 remote = None
1470 else:
1471 remote, _branch = remote_branch.split('/', 1)
1472
1473 project = Project(name=project_name, dir=proj_dir, remote=remote)
1474
Doug Anderson14749562013-06-26 13:38:29 -07001475 if not commit_list:
1476 try:
1477 commit_list = _get_commits()
1478 except VerifyException as e:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001479 PrintErrorForProject(project.name, HookFailure(str(e)))
Doug Anderson14749562013-06-26 13:38:29 -07001480 os.chdir(pwd)
1481 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07001482
Alex Deymo643ac4c2015-09-03 10:40:50 -07001483 hooks = _get_project_hooks(project.name, presubmit)
Ryan Cui1562fb82011-05-09 11:01:31 -07001484 error_found = False
Ryan Cuifa55df52011-05-06 11:16:55 -07001485 for commit in commit_list:
Ryan Cui1562fb82011-05-09 11:01:31 -07001486 error_list = []
Ryan Cui9b651632011-05-11 11:38:58 -07001487 for hook in hooks:
Ryan Cui1562fb82011-05-09 11:01:31 -07001488 hook_error = hook(project, commit)
1489 if hook_error:
1490 error_list.append(hook_error)
1491 error_found = True
1492 if error_list:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001493 PrintErrorsForCommit(project.name, commit, _get_commit_desc(commit),
Ryan Cui1562fb82011-05-09 11:01:31 -07001494 error_list)
Don Garrettdba548a2011-05-05 15:17:14 -07001495
Ryan Cuiec4d6332011-05-02 14:15:25 -07001496 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07001497 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001498
Mike Frysingerae409522014-02-01 03:16:11 -05001499
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001500# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07001501
Ryan Cui1562fb82011-05-09 11:01:31 -07001502
Mike Frysingerae409522014-02-01 03:16:11 -05001503def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08001504 """Main function invoked directly by repo.
1505
1506 This function will exit directly upon error so that repo doesn't print some
1507 obscure error message.
1508
1509 Args:
1510 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07001511 worktree_list: A list of directories. It should be the same length as
1512 project_list, so that each entry in project_list matches with a directory
1513 in worktree_list. If None, we will attempt to calculate the directories
1514 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08001515 kwargs: Leave this here for forward-compatibility.
1516 """
Ryan Cui1562fb82011-05-09 11:01:31 -07001517 found_error = False
David James2edd9002013-10-11 14:09:19 -07001518 if not worktree_list:
1519 worktree_list = [None] * len(project_list)
1520 for project, worktree in zip(project_list, worktree_list):
1521 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07001522 found_error = True
1523
Mike Frysingerae409522014-02-01 03:16:11 -05001524 if found_error:
Ryan Cui1562fb82011-05-09 11:01:31 -07001525 msg = ('Preupload failed due to errors in project(s). HINTS:\n'
Ryan Cui9b651632011-05-11 11:38:58 -07001526 '- To disable some source style checks, and for other hints, see '
1527 '<checkout_dir>/src/repohooks/README\n'
1528 '- To upload only current project, run \'repo upload .\'')
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04001529 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07001530 sys.exit(1)
Anush Elangovan63afad72011-03-23 00:41:27 -07001531
Ryan Cui1562fb82011-05-09 11:01:31 -07001532
Doug Anderson44a644f2011-11-02 10:37:37 -07001533def _identify_project(path):
1534 """Identify the repo project associated with the given path.
1535
1536 Returns:
1537 A string indicating what project is associated with the path passed in or
1538 a blank string upon failure.
1539 """
1540 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001541 redirect_stderr=True, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07001542
1543
Mike Frysinger55f85b52014-12-18 14:45:21 -05001544def direct_main(argv):
Doug Anderson44a644f2011-11-02 10:37:37 -07001545 """Run hooks directly (outside of the context of repo).
1546
Doug Anderson44a644f2011-11-02 10:37:37 -07001547 Args:
Mike Frysinger55f85b52014-12-18 14:45:21 -05001548 argv: The command line args to process
Doug Anderson44a644f2011-11-02 10:37:37 -07001549
1550 Returns:
1551 0 if no pre-upload failures, 1 if failures.
1552
1553 Raises:
1554 BadInvocation: On some types of invocation errors.
1555 """
Mike Frysinger66142932014-12-18 14:55:57 -05001556 parser = commandline.ArgumentParser(description=__doc__)
1557 parser.add_argument('--dir', default=None,
1558 help='The directory that the project lives in. If not '
1559 'specified, use the git project root based on the cwd.')
1560 parser.add_argument('--project', default=None,
1561 help='The project repo path; this can affect how the '
1562 'hooks get run, since some hooks are project-specific. '
1563 'For chromite this is chromiumos/chromite. If not '
1564 'specified, the repo tool will be used to figure this '
1565 'out based on the dir.')
1566 parser.add_argument('--rerun-since', default=None,
1567 help='Rerun hooks on old commits since the given date. '
1568 'The date should match git log\'s concept of a date. '
1569 'e.g. 2012-06-20. This option is mutually exclusive '
1570 'with --pre-submit.')
1571 parser.add_argument('--pre-submit', action="store_true",
1572 help='Run the check against the pending commit. '
1573 'This option should be used at the \'git commit\' '
1574 'phase as opposed to \'repo upload\'. This option '
1575 'is mutually exclusive with --rerun-since.')
1576 parser.add_argument('commits', nargs='*',
1577 help='Check specific commits')
1578 opts = parser.parse_args(argv)
Doug Anderson44a644f2011-11-02 10:37:37 -07001579
Doug Anderson14749562013-06-26 13:38:29 -07001580 if opts.rerun_since:
Mike Frysinger66142932014-12-18 14:55:57 -05001581 if opts.commits:
Doug Anderson14749562013-06-26 13:38:29 -07001582 raise BadInvocation('Can\'t pass commits and use rerun-since: %s' %
Mike Frysinger66142932014-12-18 14:55:57 -05001583 ' '.join(opts.commits))
Doug Anderson14749562013-06-26 13:38:29 -07001584
1585 cmd = ['git', 'log', '--since="%s"' % opts.rerun_since, '--pretty=%H']
1586 all_commits = _run_command(cmd).splitlines()
1587 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
1588
1589 # Eliminate chrome-bot commits but keep ordering the same...
1590 bot_commits = set(bot_commits)
Mike Frysinger66142932014-12-18 14:55:57 -05001591 opts.commits = [c for c in all_commits if c not in bot_commits]
Doug Anderson14749562013-06-26 13:38:29 -07001592
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001593 if opts.pre_submit:
1594 raise BadInvocation('rerun-since and pre-submit can not be '
1595 'used together')
1596 if opts.pre_submit:
Mike Frysinger66142932014-12-18 14:55:57 -05001597 if opts.commits:
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001598 raise BadInvocation('Can\'t pass commits and use pre-submit: %s' %
Mike Frysinger66142932014-12-18 14:55:57 -05001599 ' '.join(opts.commits))
1600 opts.commits = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07001601
1602 # Check/normlaize git dir; if unspecified, we'll use the root of the git
1603 # project from CWD
1604 if opts.dir is None:
1605 git_dir = _run_command(['git', 'rev-parse', '--git-dir'],
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001606 redirect_stderr=True).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07001607 if not git_dir:
1608 raise BadInvocation('The current directory is not part of a git project.')
1609 opts.dir = os.path.dirname(os.path.abspath(git_dir))
1610 elif not os.path.isdir(opts.dir):
1611 raise BadInvocation('Invalid dir: %s' % opts.dir)
1612 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
1613 raise BadInvocation('Not a git directory: %s' % opts.dir)
1614
1615 # Identify the project if it wasn't specified; this _requires_ the repo
1616 # tool to be installed and for the project to be part of a repo checkout.
1617 if not opts.project:
1618 opts.project = _identify_project(opts.dir)
1619 if not opts.project:
1620 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
1621
Doug Anderson14749562013-06-26 13:38:29 -07001622 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Mike Frysinger66142932014-12-18 14:55:57 -05001623 commit_list=opts.commits,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001624 presubmit=opts.pre_submit)
Doug Anderson44a644f2011-11-02 10:37:37 -07001625 if found_error:
1626 return 1
1627 return 0
1628
1629
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07001630if __name__ == '__main__':
Mike Frysinger55f85b52014-12-18 14:45:21 -05001631 sys.exit(direct_main(sys.argv[1:]))