blob: ffa6eaed5fb1e233f590c8768eea1ee5772152f6 [file] [log] [blame]
Doug Anderson44a644f2011-11-02 10:37:37 -07001#!/usr/bin/env python
Jon Salz98255932012-08-18 14:48:02 +08002# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
Mike Frysingerae409522014-02-01 03:16:11 -05006"""Presubmit checks to run when doing `repo upload`.
7
8You can add new checks by adding a functions to the HOOKS constants.
9"""
10
Mike Frysinger09d6a3d2013-10-08 22:21:03 -040011from __future__ import print_function
12
Ryan Cui9b651632011-05-11 11:38:58 -070013import ConfigParser
Jon Salz3ee59de2012-08-18 13:54:22 +080014import functools
Dale Curtis2975c432011-05-03 17:25:20 -070015import json
Doug Anderson44a644f2011-11-02 10:37:37 -070016import optparse
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070017import os
Ryan Cuiec4d6332011-05-02 14:15:25 -070018import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070019import sys
Peter Ammon811f6702014-06-12 15:45:38 -070020import stat
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050021import subprocess
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070022
Ryan Cui1562fb82011-05-09 11:01:31 -070023from errors import (VerifyException, HookFailure, PrintErrorForProject,
24 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070025
David Jamesc3b68b32013-04-03 09:17:03 -070026# If repo imports us, the __name__ will be __builtin__, and the wrapper will
27# be in $CHROMEOS_CHECKOUT/.repo/repo/main.py, so we need to go two directories
28# up. The same logic also happens to work if we're executed directly.
29if __name__ in ('__builtin__', '__main__'):
30 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
31
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050032from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070033from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070034from chromite.lib import patch
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040035from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070036
Vadim Bendebury2b62d742014-06-22 13:14:51 -070037PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070038
39COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050040 # C++ and friends
41 r".*\.c$", r".*\.cc$", r".*\.cpp$", r".*\.h$", r".*\.m$", r".*\.mm$",
42 r".*\.inl$", r".*\.asm$", r".*\.hxx$", r".*\.hpp$", r".*\.s$", r".*\.S$",
43 # Scripts
44 r".*\.js$", r".*\.py$", r".*\.sh$", r".*\.rb$", r".*\.pl$", r".*\.pm$",
45 # No extension at all, note that ALL CAPS files are black listed in
46 # COMMON_EXCLUDED_LIST below.
47 r"(^|.*[\\\/])[^.]+$",
48 # Other
49 r".*\.java$", r".*\.mk$", r".*\.am$",
Ryan Cuiec4d6332011-05-02 14:15:25 -070050]
51
Ryan Cui1562fb82011-05-09 11:01:31 -070052
Ryan Cuiec4d6332011-05-02 14:15:25 -070053COMMON_EXCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050054 # avoid doing source file checks for kernel
55 r"/src/third_party/kernel/",
56 r"/src/third_party/kernel-next/",
57 r"/src/third_party/ktop/",
58 r"/src/third_party/punybench/",
59 r".*\bexperimental[\\\/].*",
60 r".*\b[A-Z0-9_]{2,}$",
61 r".*[\\\/]debian[\\\/]rules$",
62 # for ebuild trees, ignore any caches and manifest data
63 r".*/Manifest$",
64 r".*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$",
Doug Anderson5bfb6792011-10-25 16:45:41 -070065
Mike Frysingerae409522014-02-01 03:16:11 -050066 # ignore profiles data (like overlay-tegra2/profiles)
Mike Frysinger94a670c2014-09-19 12:46:26 -040067 r"(^|.*/)overlay-.*/profiles/.*",
Mike Frysinger98638102014-08-28 00:15:08 -040068 r"^profiles/.*$",
69
Mike Frysingerae409522014-02-01 03:16:11 -050070 # ignore minified js and jquery
71 r".*\.min\.js",
72 r".*jquery.*\.js",
Mike Frysinger33a458d2014-03-03 17:00:51 -050073
74 # Ignore license files as the content is often taken verbatim.
75 r'.*/licenses/.*',
Ryan Cuiec4d6332011-05-02 14:15:25 -070076]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070077
Ryan Cui1562fb82011-05-09 11:01:31 -070078
Ryan Cui9b651632011-05-11 11:38:58 -070079_CONFIG_FILE = 'PRESUBMIT.cfg'
80
81
Doug Anderson44a644f2011-11-02 10:37:37 -070082# Exceptions
83
84
85class BadInvocation(Exception):
86 """An Exception indicating a bad invocation of the program."""
87 pass
88
89
Ryan Cui1562fb82011-05-09 11:01:31 -070090# General Helpers
91
Sean Paulba01d402011-05-05 11:36:23 -040092
Doug Anderson44a644f2011-11-02 10:37:37 -070093def _run_command(cmd, cwd=None, stderr=None):
94 """Executes the passed in command and returns raw stdout output.
95
96 Args:
97 cmd: The command to run; should be a list of strings.
98 cwd: The directory to switch to for running the command.
99 stderr: Can be one of None (print stderr to console), subprocess.STDOUT
100 (combine stderr with stdout), or subprocess.PIPE (ignore stderr).
101
102 Returns:
103 The standard out from the process.
104 """
105 p = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=stderr, cwd=cwd)
106 return p.communicate()[0]
Ryan Cui72834d12011-05-05 14:51:33 -0700107
Ryan Cui1562fb82011-05-09 11:01:31 -0700108
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700109def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700110 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700111 if __name__ == '__main__':
112 # Works when file is run on its own (__file__ is defined)...
113 return os.path.abspath(os.path.dirname(__file__))
114 else:
115 # We need to do this when we're run through repo. Since repo executes
116 # us with execfile(), we don't get __file__ defined.
117 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
118 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700119
Ryan Cui1562fb82011-05-09 11:01:31 -0700120
Ryan Cuiec4d6332011-05-02 14:15:25 -0700121def _match_regex_list(subject, expressions):
122 """Try to match a list of regular expressions to a string.
123
124 Args:
125 subject: The string to match regexes on
126 expressions: A list of regular expressions to check for matches with.
127
128 Returns:
129 Whether the passed in subject matches any of the passed in regexes.
130 """
131 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500132 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700133 return True
134 return False
135
Ryan Cui1562fb82011-05-09 11:01:31 -0700136
Mike Frysingerae409522014-02-01 03:16:11 -0500137def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700138 """Filter out files based on the conditions passed in.
139
140 Args:
141 files: list of filepaths to filter
142 include_list: list of regex that when matched with a file path will cause it
143 to be added to the output list unless the file is also matched with a
144 regex in the exclude_list.
145 exclude_list: list of regex that when matched with a file will prevent it
146 from being added to the output list, even if it is also matched with a
147 regex in the include_list.
148
149 Returns:
150 A list of filepaths that contain files matched in the include_list and not
151 in the exclude_list.
152 """
153 filtered = []
154 for f in files:
155 if (_match_regex_list(f, include_list) and
156 not _match_regex_list(f, exclude_list)):
157 filtered.append(f)
158 return filtered
159
Ryan Cuiec4d6332011-05-02 14:15:25 -0700160
161# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700162
163
Ryan Cui4725d952011-05-05 15:41:19 -0700164def _get_upstream_branch():
165 """Returns the upstream tracking branch of the current branch.
166
167 Raises:
168 Error if there is no tracking branch
169 """
170 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
171 current_branch = current_branch.replace('refs/heads/', '')
172 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700173 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700174
175 cfg_option = 'branch.' + current_branch + '.%s'
176 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
177 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
178 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700179 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700180
181 return full_upstream.replace('heads', 'remotes/' + remote)
182
Ryan Cui1562fb82011-05-09 11:01:31 -0700183
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700184def _get_patch(commit):
185 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700186 if commit == PRE_SUBMIT:
187 return _run_command(['git', 'diff', '--cached', 'HEAD'])
188 else:
189 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700190
Ryan Cui1562fb82011-05-09 11:01:31 -0700191
Jon Salz98255932012-08-18 14:48:02 +0800192def _try_utf8_decode(data):
193 """Attempts to decode a string as UTF-8.
194
195 Returns:
196 The decoded Unicode object, or the original string if parsing fails.
197 """
198 try:
199 return unicode(data, 'utf-8', 'strict')
200 except UnicodeDecodeError:
201 return data
202
203
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500204def _get_file_content(path, commit):
205 """Returns the content of a file at a specific commit.
206
207 We can't rely on the file as it exists in the filesystem as people might be
208 uploading a series of changes which modifies the file multiple times.
209
210 Note: The "content" of a symlink is just the target. So if you're expecting
211 a full file, you should check that first. One way to detect is that the
212 content will not have any newlines.
213 """
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700214 if commit == PRE_SUBMIT:
215 return _run_command(['git', 'diff', 'HEAD', path])
216 else:
217 return _run_command(['git', 'show', '%s:%s' % (commit, path)])
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500218
219
Mike Frysingerae409522014-02-01 03:16:11 -0500220def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700221 """Returns a list of (linenum, lines) tuples that the commit touched."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700222 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff']
223 if commit == PRE_SUBMIT:
224 command += ['HEAD', path]
225 else:
226 command += [commit, path]
227 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700228
229 new_lines = []
230 line_num = 0
231 for line in output.splitlines():
232 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
233 if m:
234 line_num = int(m.groups(1)[0])
235 continue
236 if line.startswith('+') and not line.startswith('++'):
Jon Salz98255932012-08-18 14:48:02 +0800237 new_lines.append((line_num, _try_utf8_decode(line[1:])))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700238 if not line.startswith('-'):
239 line_num += 1
240 return new_lines
241
Ryan Cui1562fb82011-05-09 11:01:31 -0700242
Mike Frysinger292b45d2014-11-25 01:17:10 -0500243def _get_affected_files(commit, include_deletes=False, relative=False,
244 include_symlinks=False, include_adds=True,
245 full_details=False):
Peter Ammon811f6702014-06-12 15:45:38 -0700246 """Returns list of file paths that were modified/added, excluding symlinks.
247
248 Args:
249 commit: The commit
250 include_deletes: If true, we'll include deleted files in the result
251 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500252 include_symlinks: If true, we'll include symlinks in the result
253 include_adds: If true, we'll include new files in the result
254 full_details: If False, return filenames, else return structured results.
Peter Ammon811f6702014-06-12 15:45:38 -0700255
256 Returns:
257 A list of modified/added (and perhaps deleted) files
258 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500259 if not relative and full_details:
260 raise ValueError('full_details only supports relative paths currently')
261
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700262 if commit == PRE_SUBMIT:
263 return _run_command(['git', 'diff-index', '--cached',
264 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500265
266 path = os.getcwd()
267 files = git.RawDiff(path, '%s^!' % commit)
268
269 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500270 if not include_symlinks:
271 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500272
273 if not include_deletes:
274 files = [x for x in files if x.status != 'D']
275
Mike Frysinger292b45d2014-11-25 01:17:10 -0500276 if not include_adds:
277 files = [x for x in files if x.status != 'A']
278
279 if full_details:
280 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500281 return files
282 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500283 # Caller only cares about filenames.
284 files = [x.dst_file if x.dst_file else x.src_file for x in files]
285 if relative:
286 return files
287 else:
288 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700289
290
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700291def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700292 """Returns a list of commits for this review."""
Ryan Cui4725d952011-05-05 15:41:19 -0700293 cmd = ['git', 'log', '%s..' % _get_upstream_branch(), '--format=%H']
Ryan Cui72834d12011-05-05 14:51:33 -0700294 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700295
Ryan Cui1562fb82011-05-09 11:01:31 -0700296
Ryan Cuiec4d6332011-05-02 14:15:25 -0700297def _get_commit_desc(commit):
298 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700299 if commit == PRE_SUBMIT:
300 return ''
Sean Paul23a2c582011-05-06 13:10:44 -0400301 return _run_command(['git', 'log', '--format=%s%n%n%b', commit + '^!'])
Ryan Cuiec4d6332011-05-02 14:15:25 -0700302
303
304# Common Hooks
305
Ryan Cui1562fb82011-05-09 11:01:31 -0700306
Mike Frysingerae409522014-02-01 03:16:11 -0500307def _check_no_long_lines(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700308 """Checks that there aren't any lines longer than maxlen characters in any of
309 the text files to be submitted.
310 """
311 MAX_LEN = 80
Jon Salz98255932012-08-18 14:48:02 +0800312 SKIP_REGEXP = re.compile('|'.join([
313 r'https?://',
314 r'^#\s*(define|include|import|pragma|if|endif)\b']))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700315
316 errors = []
317 files = _filter_files(_get_affected_files(commit),
318 COMMON_INCLUDED_PATHS,
319 COMMON_EXCLUDED_PATHS)
320
321 for afile in files:
322 for line_num, line in _get_file_diff(afile, commit):
323 # Allow certain lines to exceed the maxlen rule.
Mike Frysingerae409522014-02-01 03:16:11 -0500324 if len(line) <= MAX_LEN or SKIP_REGEXP.search(line):
Jon Salz98255932012-08-18 14:48:02 +0800325 continue
326
327 errors.append('%s, line %s, %s chars' % (afile, line_num, len(line)))
328 if len(errors) == 5: # Just show the first 5 errors.
329 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700330
331 if errors:
332 msg = 'Found lines longer than %s characters (first 5 shown):' % MAX_LEN
Ryan Cui1562fb82011-05-09 11:01:31 -0700333 return HookFailure(msg, errors)
334
Ryan Cuiec4d6332011-05-02 14:15:25 -0700335
Mike Frysingerae409522014-02-01 03:16:11 -0500336def _check_no_stray_whitespace(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700337 """Checks that there is no stray whitespace at source lines end."""
338 errors = []
339 files = _filter_files(_get_affected_files(commit),
Mike Frysingerae409522014-02-01 03:16:11 -0500340 COMMON_INCLUDED_PATHS,
341 COMMON_EXCLUDED_PATHS)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700342 for afile in files:
343 for line_num, line in _get_file_diff(afile, commit):
344 if line.rstrip() != line:
345 errors.append('%s, line %s' % (afile, line_num))
346 if errors:
Ryan Cui1562fb82011-05-09 11:01:31 -0700347 return HookFailure('Found line ending with white space in:', errors)
348
Ryan Cuiec4d6332011-05-02 14:15:25 -0700349
Mike Frysingerae409522014-02-01 03:16:11 -0500350def _check_no_tabs(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700351 """Checks there are no unexpanded tabs."""
352 TAB_OK_PATHS = [
Ryan Cui31e0c172011-05-04 21:00:45 -0700353 r"/src/third_party/u-boot/",
Ryan Cuiec4d6332011-05-02 14:15:25 -0700354 r".*\.ebuild$",
355 r".*\.eclass$",
Elly Jones5ab34192011-11-15 14:57:06 -0500356 r".*/[M|m]akefile$",
357 r".*\.mk$"
Ryan Cuiec4d6332011-05-02 14:15:25 -0700358 ]
359
360 errors = []
361 files = _filter_files(_get_affected_files(commit),
362 COMMON_INCLUDED_PATHS,
363 COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
364
365 for afile in files:
366 for line_num, line in _get_file_diff(afile, commit):
367 if '\t' in line:
Mike Frysingerae409522014-02-01 03:16:11 -0500368 errors.append('%s, line %s' % (afile, line_num))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700369 if errors:
Ryan Cui1562fb82011-05-09 11:01:31 -0700370 return HookFailure('Found a tab character in:', errors)
371
Ryan Cuiec4d6332011-05-02 14:15:25 -0700372
Mike Frysingerae409522014-02-01 03:16:11 -0500373def _check_change_has_test_field(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700374 """Check for a non-empty 'TEST=' field in the commit message."""
David McMahon8f6553e2011-06-10 15:46:36 -0700375 TEST_RE = r'\nTEST=\S+'
Ryan Cuiec4d6332011-05-02 14:15:25 -0700376
Mandeep Singh Baines96a53be2011-05-03 11:10:25 -0700377 if not re.search(TEST_RE, _get_commit_desc(commit)):
Ryan Cui1562fb82011-05-09 11:01:31 -0700378 msg = 'Changelist description needs TEST field (after first line)'
379 return HookFailure(msg)
380
Ryan Cuiec4d6332011-05-02 14:15:25 -0700381
Mike Frysingerae409522014-02-01 03:16:11 -0500382def _check_change_has_valid_cq_depend(_project, commit):
David Jamesc3b68b32013-04-03 09:17:03 -0700383 """Check for a correctly formatted CQ-DEPEND field in the commit message."""
384 msg = 'Changelist has invalid CQ-DEPEND target.'
385 example = 'Example: CQ-DEPEND=CL:1234, CL:2345'
386 try:
387 patch.GetPaladinDeps(_get_commit_desc(commit))
388 except ValueError as ex:
389 return HookFailure(msg, [example, str(ex)])
390
391
Mike Frysingerae409522014-02-01 03:16:11 -0500392def _check_change_has_bug_field(_project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700393 """Check for a correctly formatted 'BUG=' field in the commit message."""
David James5c0073d2013-04-03 08:48:52 -0700394 OLD_BUG_RE = r'\nBUG=.*chromium-os'
395 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
396 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
397 'the chromium tracker in your BUG= line now.')
398 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700399
David James5c0073d2013-04-03 08:48:52 -0700400 BUG_RE = r'\nBUG=([Nn]one|(chrome-os-partner|chromium):\d+)'
Mandeep Singh Baines96a53be2011-05-03 11:10:25 -0700401 if not re.search(BUG_RE, _get_commit_desc(commit)):
David McMahon8f6553e2011-06-10 15:46:36 -0700402 msg = ('Changelist description needs BUG field (after first line):\n'
David James5c0073d2013-04-03 08:48:52 -0700403 'BUG=chromium:9999 (for public tracker)\n'
David McMahon8f6553e2011-06-10 15:46:36 -0700404 'BUG=chrome-os-partner:9999 (for partner tracker)\n'
405 'BUG=None')
Ryan Cui1562fb82011-05-09 11:01:31 -0700406 return HookFailure(msg)
407
Ryan Cuiec4d6332011-05-02 14:15:25 -0700408
Mike Frysinger292b45d2014-11-25 01:17:10 -0500409def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -0700410 """Check that we're not missing a revbump of an ebuild in the given commit.
411
412 If the given commit touches files in a directory that has ebuilds somewhere
413 up the directory hierarchy, it's very likely that we need an ebuild revbump
414 in order for those changes to take effect.
415
416 It's not totally trivial to detect a revbump, so at least detect that an
417 ebuild with a revision number in it was touched. This should handle the
418 common case where we use a symlink to do the revbump.
419
420 TODO: it would be nice to enhance this hook to:
421 * Handle cases where people revbump with a slightly different syntax. I see
422 one ebuild (puppy) that revbumps with _pN. This is a false positive.
423 * Catches cases where people aren't using symlinks for revbumps. If they
424 edit a revisioned file directly (and are expected to rename it for revbump)
425 we'll miss that. Perhaps we could detect that the file touched is a
426 symlink?
427
428 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
429 still better off than without this check.
430
431 Args:
432 project: The project to look at
433 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -0500434 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -0700435
436 Returns:
437 A HookFailure or None.
438 """
Mike Frysinger011af942014-01-17 16:12:22 -0500439 # If this is the portage-stable overlay, then ignore the check. It's rare
440 # that we're doing anything other than importing files from upstream, so
441 # forcing a rev bump makes no sense.
442 whitelist = (
443 'chromiumos/overlays/portage-stable',
444 )
445 if project in whitelist:
446 return None
447
Mike Frysinger292b45d2014-11-25 01:17:10 -0500448 def FinalName(obj):
449 # If the file is being deleted, then the dst_file is not set.
450 if obj.dst_file is None:
451 return obj.src_file
452 else:
453 return obj.dst_file
454
455 affected_path_objs = _get_affected_files(
456 commit, include_deletes=True, include_symlinks=True, relative=True,
457 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -0700458
459 # Don't yell about changes to whitelisted files...
Mike Frysinger011af942014-01-17 16:12:22 -0500460 whitelist = ('ChangeLog', 'Manifest', 'metadata.xml')
Mike Frysinger292b45d2014-11-25 01:17:10 -0500461 affected_path_objs = [x for x in affected_path_objs
462 if os.path.basename(FinalName(x)) not in whitelist]
463 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -0700464 return None
465
466 # If we've touched any file named with a -rN.ebuild then we'll say we're
467 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500468 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
469 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700470 if touched_revved_ebuild:
471 return None
472
Mike Frysinger292b45d2014-11-25 01:17:10 -0500473 # If we're creating new ebuilds from scratch, then we don't need an uprev.
474 # Find all the dirs that new ebuilds and ignore their files/.
475 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
476 if FinalName(x).endswith('.ebuild') and x.status == 'A']
477 affected_path_objs = [obj for obj in affected_path_objs
478 if not any(FinalName(obj).startswith(x)
479 for x in ebuild_dirs)]
480 if not affected_path_objs:
481 return
482
Doug Anderson42b8a052013-06-26 10:45:36 -0700483 # We want to examine the current contents of all directories that are parents
484 # of files that were touched (up to the top of the project).
485 #
486 # ...note: we use the current directory contents even though it may have
487 # changed since the commit we're looking at. This is just a heuristic after
488 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500489 if project_top is None:
490 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -0700491 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -0500492 for obj in affected_path_objs:
493 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -0700494 while os.path.exists(path) and not os.path.samefile(path, project_top):
495 dirs_to_check.add(path)
496 path = os.path.dirname(path)
497
498 # Look through each directory. If it's got an ebuild in it then we'll
499 # consider this as a case when we need a revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500500 affected_paths = set([FinalName(x) for x in affected_path_objs])
Doug Anderson42b8a052013-06-26 10:45:36 -0700501 for dir_path in dirs_to_check:
502 contents = os.listdir(dir_path)
503 ebuilds = [os.path.join(dir_path, path)
504 for path in contents if path.endswith('.ebuild')]
505 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
506
507 # If the -9999.ebuild file was touched the bot will uprev for us.
508 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -0500509 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -0700510 continue
511
512 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500513 return HookFailure('Changelist probably needs a revbump of an ebuild, '
514 'or a -r1.ebuild symlink if this is a new ebuild:\n'
515 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -0700516
517 return None
518
519
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500520def _check_ebuild_eapi(project, commit):
521 """Make sure we have people use EAPI=4 or newer with custom ebuilds.
522
523 We want to get away from older EAPI's as it makes life confusing and they
524 have less builtin error checking.
525
526 Args:
527 project: The project to look at
528 commit: The commit to look at
529
530 Returns:
531 A HookFailure or None.
532 """
533 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500534 # that we're doing anything other than importing files from upstream, and
535 # we shouldn't be rewriting things fundamentally anyways.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500536 whitelist = (
537 'chromiumos/overlays/portage-stable',
538 )
539 if project in whitelist:
540 return None
541
542 BAD_EAPIS = ('0', '1', '2', '3')
543
544 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
545
546 ebuilds_re = [r'\.ebuild$']
547 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
548 ebuilds_re)
549 bad_ebuilds = []
550
551 for ebuild in ebuilds:
552 # If the ebuild does not specify an EAPI, it defaults to 0.
553 eapi = '0'
554
555 lines = _get_file_content(ebuild, commit).splitlines()
556 if len(lines) == 1:
557 # This is most likely a symlink, so skip it entirely.
558 continue
559
560 for line in lines:
561 m = get_eapi.match(line)
562 if m:
563 # Once we hit the first EAPI line in this ebuild, stop processing.
564 # The spec requires that there only be one and it be first, so
565 # checking all possible values is pointless. We also assume that
566 # it's "the" EAPI line and not something in the middle of a heredoc.
567 eapi = m.group(1)
568 break
569
570 if eapi in BAD_EAPIS:
571 bad_ebuilds.append((ebuild, eapi))
572
573 if bad_ebuilds:
574 # pylint: disable=C0301
575 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
576 # pylint: enable=C0301
577 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500578 'These ebuilds are using old EAPIs. If these are imported from\n'
579 'Gentoo, then you may ignore and upload once with the --no-verify\n'
580 'flag. Otherwise, please update to 4 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500581 '\t%s\n'
582 'See this guide for more details:\n%s\n' %
583 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
584
585
Mike Frysinger89bdb852014-02-01 05:26:26 -0500586def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -0500587 """Make sure we use the new style KEYWORDS when possible in ebuilds.
588
589 If an ebuild generally does not care about the arch it is running on, then
590 ebuilds should flag it with one of:
591 KEYWORDS="*" # A stable ebuild.
592 KEYWORDS="~*" # An unstable ebuild.
593 KEYWORDS="-* ..." # Is known to only work on specific arches.
594
595 Args:
596 project: The project to look at
597 commit: The commit to look at
598
599 Returns:
600 A HookFailure or None.
601 """
602 WHITELIST = set(('*', '-*', '~*'))
603
604 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
605
Mike Frysinger89bdb852014-02-01 05:26:26 -0500606 ebuilds_re = [r'\.ebuild$']
607 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
608 ebuilds_re)
609
Mike Frysinger8d42d742014-09-22 15:50:21 -0400610 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -0500611 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -0400612 # We get the full content rather than a diff as the latter does not work
613 # on new files (like when adding new ebuilds).
614 lines = _get_file_content(ebuild, commit).splitlines()
615 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -0500616 m = get_keywords.match(line)
617 if m:
618 keywords = set(m.group(1).split())
619 if not keywords or WHITELIST - keywords != WHITELIST:
620 continue
621
Mike Frysinger8d42d742014-09-22 15:50:21 -0400622 bad_ebuilds.append(ebuild)
623
624 if bad_ebuilds:
625 return HookFailure(
626 '%s\n'
627 'Please update KEYWORDS to use a glob:\n'
628 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
629 ' KEYWORDS="*"\n'
630 'If the ebuild should be marked unstable (normal for '
631 'cros-workon / 9999 ebuilds):\n'
632 ' KEYWORDS="~*"\n'
633 'If the ebuild needs to be marked for only specific arches,'
634 'then use -* like so:\n'
635 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -0500636
637
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800638def _check_ebuild_licenses(_project, commit):
639 """Check if the LICENSE field in the ebuild is correct."""
640 affected_paths = _get_affected_files(commit)
641 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
642
643 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -0800644 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800645
646 for ebuild in touched_ebuilds:
647 # Skip virutal packages.
648 if ebuild.split('/')[-3] == 'virtual':
649 continue
650
651 try:
Mike Frysinger2ec70ed2014-08-17 19:28:34 -0400652 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800653 except ValueError as e:
654 return HookFailure(e.message, [ebuild])
655
656 # Also ignore licenses ending with '?'
657 for license_type in [x for x in license_types
658 if x not in LICENSES_IGNORE and not x.endswith('?')]:
659 try:
Mike Frysinger2ec70ed2014-08-17 19:28:34 -0400660 licenses_lib.Licensing.FindLicenseType(license_type)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800661 except AssertionError as e:
662 return HookFailure(e.message, [ebuild])
663
664
Mike Frysingercd363c82014-02-01 05:20:18 -0500665def _check_ebuild_virtual_pv(project, commit):
666 """Enforce the virtual PV policies."""
667 # If this is the portage-stable overlay, then ignore the check.
668 # We want to import virtuals as-is from upstream Gentoo.
669 whitelist = (
670 'chromiumos/overlays/portage-stable',
671 )
672 if project in whitelist:
673 return None
674
675 # We assume the repo name is the same as the dir name on disk.
676 # It would be dumb to not have them match though.
677 project = os.path.basename(project)
678
679 is_variant = lambda x: x.startswith('overlay-variant-')
680 is_board = lambda x: x.startswith('overlay-')
681 is_private = lambda x: x.endswith('-private')
682
683 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
684
685 ebuilds_re = [r'\.ebuild$']
686 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
687 ebuilds_re)
688 bad_ebuilds = []
689
690 for ebuild in ebuilds:
691 m = get_pv.match(ebuild)
692 if m:
693 overlay = m.group(1)
694 if not overlay or not is_board(overlay):
695 overlay = project
696
697 pv = m.group(3).split('-', 1)[0]
698
699 if is_private(overlay):
700 want_pv = '3.5' if is_variant(overlay) else '3'
701 elif is_board(overlay):
702 want_pv = '2.5' if is_variant(overlay) else '2'
703 else:
704 want_pv = '1'
705
706 if pv != want_pv:
707 bad_ebuilds.append((ebuild, pv, want_pv))
708
709 if bad_ebuilds:
710 # pylint: disable=C0301
711 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
712 # pylint: enable=C0301
713 return HookFailure(
714 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
715 '\t%s\n'
716 'If this is an upstream Gentoo virtual, then you may ignore this\n'
717 'check (and re-run w/--no-verify). Otherwise, please see this\n'
718 'page for more details:\n%s\n' %
719 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
720 for x in bad_ebuilds]), url))
721
722
Mike Frysingerae409522014-02-01 03:16:11 -0500723def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -0700724 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -0400725 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -0700726 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -0400727 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -0500728 if not m:
Ryan Cui1562fb82011-05-09 11:01:31 -0700729 return HookFailure('Change-Id must be in last paragraph of description.')
730
Mike Frysinger02b88bd2014-11-21 00:29:38 -0500731 # Allow s-o-b tags to follow it, but only those.
732 end = desc[m.end():].strip().splitlines()
733 if [x for x in end if not x.startswith('Signed-off-by: ')]:
734 return HookFailure('Only "Signed-off-by:" tags may follow the Change-Id.')
735
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -0700736
Mike Frysinger36b2ebc2014-10-31 14:02:03 -0400737def _check_commit_message_style(_project, commit):
738 """Verify that the commit message matches our style.
739
740 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
741 commit hooks.
742 """
743 desc = _get_commit_desc(commit)
744
745 # The first line should be by itself.
746 lines = desc.splitlines()
747 if len(lines) > 1 and lines[1]:
748 return HookFailure('The second line of the commit message must be blank.')
749
750 # The first line should be one sentence.
751 if '. ' in lines[0]:
752 return HookFailure('The first line cannot be more than one sentence.')
753
754 # The first line cannot be too long.
755 MAX_FIRST_LINE_LEN = 100
756 if len(lines[0]) > MAX_FIRST_LINE_LEN:
757 return HookFailure('The first line must be less than %i chars.' %
758 MAX_FIRST_LINE_LEN)
759
760
Mike Frysingerae409522014-02-01 03:16:11 -0500761def _check_license(_project, commit):
Mike Frysinger98638102014-08-28 00:15:08 -0400762 """Verifies the license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700763
Mike Frysinger98638102014-08-28 00:15:08 -0400764 Should be following the spec:
765 http://dev.chromium.org/developers/coding-style#TOC-File-headers
766 """
767 # For older years, be a bit more flexible as our policy says leave them be.
768 LICENSE_HEADER = (
769 r'.* Copyright( \(c\))? 20[-0-9]{2,7} The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -0500770 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -0400771 r'.* Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -0500772 r'be\n'
Mike Frysinger98638102014-08-28 00:15:08 -0400773 r'.* found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -0500774 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -0400775 )
776 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
777
778 # For newer years, be stricter.
779 COPYRIGHT_LINE = (
780 r'.* Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -0500781 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -0400782 )
783 copyright_re = re.compile(COPYRIGHT_LINE)
784
785 bad_files = []
786 bad_copyright_files = []
787 files = _filter_files(_get_affected_files(commit, relative=True),
788 COMMON_INCLUDED_PATHS,
789 COMMON_EXCLUDED_PATHS)
790
791 for f in files:
792 contents = _get_file_content(f, commit)
793 if not contents:
794 # Ignore empty files.
795 continue
796
797 if not license_re.search(contents):
798 bad_files.append(f)
799 elif copyright_re.search(contents):
800 bad_copyright_files.append(f)
801
802 if bad_files:
803 msg = '%s:\n%s\n%s' % (
804 'License must match', license_re.pattern,
805 'Found a bad header in these files:')
806 return HookFailure(msg, bad_files)
807
808 if bad_copyright_files:
809 msg = 'Do not use (c) in copyright headers in new files:'
810 return HookFailure(msg, bad_copyright_files)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700811
812
Mike Frysinger998c2cc2014-08-27 05:20:23 -0400813def _check_layout_conf(_project, commit):
814 """Verifies the metadata/layout.conf file."""
815 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -0400816 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -0400817 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -0400818 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -0400819
Mike Frysinger94a670c2014-09-19 12:46:26 -0400820 # Handle multiple overlays in a single commit (like the public tree).
821 for f in _get_affected_files(commit, relative=True):
822 if f.endswith(repo_name):
823 repo_names.append(f)
824 elif f.endswith(layout_path):
825 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -0400826
827 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -0400828 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -0400829 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -0400830 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -0400831
Mike Frysinger94a670c2014-09-19 12:46:26 -0400832 # Gather all the errors in one pass so we show one full message.
833 all_errors = {}
834 for layout_path in layout_paths:
835 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -0400836
Mike Frysinger94a670c2014-09-19 12:46:26 -0400837 # Make sure the config file is sorted.
838 data = [x for x in _get_file_content(layout_path, commit).splitlines()
839 if x and x[0] != '#']
840 if sorted(data) != data:
841 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -0400842
Mike Frysinger94a670c2014-09-19 12:46:26 -0400843 # Require people to set specific values all the time.
844 settings = (
845 # TODO: Enable this for everyone. http://crbug.com/408038
846 #('fast caching', 'cache-format = md5-dict'),
847 ('fast manifests', 'thin-manifests = true'),
848 ('extra features', 'profile-formats = portage-2'),
849 )
850 for reason, line in settings:
851 if line not in data:
852 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -0400853
Mike Frysinger94a670c2014-09-19 12:46:26 -0400854 # Require one of these settings.
855 if ('use-manifests = true' not in data and
856 'use-manifests = strict' not in data):
857 errors += ['enable file checking with: use-manifests = true']
Mike Frysinger998c2cc2014-08-27 05:20:23 -0400858
Mike Frysinger94a670c2014-09-19 12:46:26 -0400859 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -0400860 for line in data:
861 if line.startswith('repo-name = '):
862 break
863 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -0400864 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -0400865
Mike Frysinger94a670c2014-09-19 12:46:26 -0400866 # Summarize all the errors we saw (if any).
867 lines = ''
868 for layout_path, errors in all_errors.items():
869 if errors:
870 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
871 if lines:
872 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
873 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -0400874
875
Ryan Cuiec4d6332011-05-02 14:15:25 -0700876# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700877
Ryan Cui1562fb82011-05-09 11:01:31 -0700878
Mike Frysingerae409522014-02-01 03:16:11 -0500879def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700880 """Runs checkpatch.pl on the given project"""
881 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700882 options = list(options)
883 if commit == PRE_SUBMIT:
884 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
885 # this case.
886 options.append('--ignore=MISSING_SIGN_OFF')
887 cmd = ['%s/checkpatch.pl' % hooks_dir] + options + ['-']
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700888 p = subprocess.Popen(cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE)
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700889 output = p.communicate(_get_patch(commit))[0]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700890 if p.returncode:
Ryan Cui1562fb82011-05-09 11:01:31 -0700891 return HookFailure('checkpatch.pl errors/warnings\n\n' + output)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700892
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700893
Anton Staaf815d6852011-08-22 10:08:45 -0700894def _run_checkpatch_no_tree(project, commit):
895 return _run_checkpatch(project, commit, ['--no-tree'])
896
Mike Frysingerae409522014-02-01 03:16:11 -0500897
Randall Spangler7318fd62013-11-21 12:16:58 -0800898def _run_checkpatch_ec(project, commit):
899 """Runs checkpatch with options for Chromium EC projects."""
900 return _run_checkpatch(project, commit, ['--no-tree',
901 '--ignore=MSLEEP,VOLATILE'])
902
Mike Frysingerae409522014-02-01 03:16:11 -0500903
Vadim Bendeburyf8536032014-06-22 12:42:18 -0700904def _run_checkpatch_depthcharge(project, commit):
905 """Runs checkpatch with options for depthcharge."""
906 return _run_checkpatch(project, commit, [
907 '--no-tree',
Julius Werner83a35bb2014-06-23 12:51:48 -0700908 '--ignore=CAMELCASE,C99_COMMENTS,NEW_TYPEDEFS,CONFIG_DESCRIPTION,'
909 'SPACING,PREFER_PACKED,PREFER_PRINTF,PREFER_ALIGNED,GLOBAL_INITIALISERS,'
910 'INITIALISED_STATIC,OPEN_BRACE,TRAILING_STATEMENTS'])
Vadim Bendeburyf8536032014-06-22 12:42:18 -0700911
Vadim Bendebury4bcd9fa2014-08-07 12:27:37 -0700912def _run_checkpatch_coreboot(project, commit):
913 """Runs checkpatch with options for coreboot."""
914 return _run_checkpatch(project, commit, [
Vadim Bendeburyac4bc6c2014-08-29 19:56:43 -0700915 '--min-conf-desc-length=2',
Vadim Bendebury4bcd9fa2014-08-07 12:27:37 -0700916 '--no-tree',
917 '--ignore=NEW_TYPEDEFS,PREFER_PACKED,PREFER_PRINTF,PREFER_ALIGNED,'
Shawn Nematbakhsh6442c582014-08-22 14:32:06 -0700918 'GLOBAL_INITIALISERS,INITIALISED_STATIC,C99_COMMENTS'])
Vadim Bendebury4bcd9fa2014-08-07 12:27:37 -0700919
Vadim Bendeburyf8536032014-06-22 12:42:18 -0700920
Mike Frysingerae409522014-02-01 03:16:11 -0500921def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -0700922 """Makes sure kernel config changes are not mixed with code changes"""
923 files = _get_affected_files(commit)
924 if not len(_filter_files(files, [r'chromeos/config'])) in [0, len(files)]:
925 return HookFailure('Changes to chromeos/config/ and regular files must '
926 'be in separate commits:\n%s' % '\n'.join(files))
Anton Staaf815d6852011-08-22 10:08:45 -0700927
Mike Frysingerae409522014-02-01 03:16:11 -0500928
929def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -0700930 """Checks that all JSON files are syntactically valid."""
Dale Curtisa039cfd2011-05-04 12:01:05 -0700931 for f in _filter_files(_get_affected_files(commit), [r'.*\.json']):
Dale Curtis2975c432011-05-03 17:25:20 -0700932 try:
933 json.load(open(f))
934 except Exception, e:
Ryan Cui1562fb82011-05-09 11:01:31 -0700935 return HookFailure('Invalid JSON in %s: %s' % (f, e))
Dale Curtis2975c432011-05-03 17:25:20 -0700936
937
Mike Frysingerae409522014-02-01 03:16:11 -0500938def _check_manifests(_project, commit):
Mike Frysinger52b537e2013-08-22 22:59:53 -0400939 """Make sure Manifest files only have DIST lines"""
940 paths = []
941
942 for path in _get_affected_files(commit):
943 if os.path.basename(path) != 'Manifest':
944 continue
945 if not os.path.exists(path):
946 continue
947
948 with open(path, 'r') as f:
949 for line in f.readlines():
950 if not line.startswith('DIST '):
951 paths.append(path)
952 break
953
954 if paths:
955 return HookFailure('Please remove lines that do not start with DIST:\n%s' %
956 ('\n'.join(paths),))
957
958
Mike Frysingerae409522014-02-01 03:16:11 -0500959def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -0700960 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700961 if commit == PRE_SUBMIT:
962 return
Puneet Kumarc80e3f62012-08-13 19:01:18 -0700963 BRANCH_RE = r'\nBRANCH=\S+'
964
965 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
966 msg = ('Changelist description needs BRANCH field (after first line)\n'
967 'E.g. BRANCH=none or BRANCH=link,snow')
968 return HookFailure(msg)
969
970
Mike Frysingerae409522014-02-01 03:16:11 -0500971def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -0800972 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700973 if commit == PRE_SUBMIT:
974 return
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -0800975 SIGNOFF_RE = r'\nSigned-off-by: \S+'
976
977 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
978 msg = ('Changelist description needs Signed-off-by: field\n'
979 'E.g. Signed-off-by: My Name <me@chromium.org>')
980 return HookFailure(msg)
981
982
Jon Salz3ee59de2012-08-18 13:54:22 +0800983def _run_project_hook_script(script, project, commit):
984 """Runs a project hook script.
985
986 The script is run with the following environment variables set:
987 PRESUBMIT_PROJECT: The affected project
988 PRESUBMIT_COMMIT: The affected commit
989 PRESUBMIT_FILES: A newline-separated list of affected files
990
991 The script is considered to fail if the exit code is non-zero. It should
992 write an error message to stdout.
993 """
994 env = dict(os.environ)
995 env['PRESUBMIT_PROJECT'] = project
996 env['PRESUBMIT_COMMIT'] = commit
997
998 # Put affected files in an environment variable
999 files = _get_affected_files(commit)
1000 env['PRESUBMIT_FILES'] = '\n'.join(files)
1001
1002 process = subprocess.Popen(script, env=env, shell=True,
1003 stdin=open(os.devnull),
Jon Salz7b618af2012-08-31 06:03:16 +08001004 stdout=subprocess.PIPE,
1005 stderr=subprocess.STDOUT)
Jon Salz3ee59de2012-08-18 13:54:22 +08001006 stdout, _ = process.communicate()
1007 if process.wait():
Jon Salz7b618af2012-08-31 06:03:16 +08001008 if stdout:
1009 stdout = re.sub('(?m)^', ' ', stdout)
1010 return HookFailure('Hook script "%s" failed with code %d%s' %
Jon Salz3ee59de2012-08-18 13:54:22 +08001011 (script, process.returncode,
1012 ':\n' + stdout if stdout else ''))
1013
1014
Bertrand SIMONNET6ec83f92014-05-30 10:42:34 -07001015def _moved_to_platform2(project, _commit):
1016 """Forbids commits to legacy repo in src/platform."""
1017 return HookFailure('%s has been moved to platform2. This change should be '
1018 'made there.' % project)
1019
1020
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001021def _check_project_prefix(_project, commit):
1022 """Fails if the change is project specific and the commit message is not
1023 prefixed by the project_name.
1024 """
1025
1026 files = _get_affected_files(commit, relative=True)
1027 prefix = os.path.commonprefix(files)
1028 prefix = os.path.dirname(prefix)
1029
1030 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07001031 if not prefix:
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001032 return
1033
1034 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07001035
1036 # The common files may all be within a subdirectory of the main project
1037 # directory, so walk up the tree until we find an alias file.
1038 # _get_affected_files() should return relative paths, but check against '/' to
1039 # ensure that this loop terminates even if it receives an absolute path.
1040 while prefix and prefix != '/':
1041 alias_file = os.path.join(prefix, '.project_alias')
1042
1043 # If an alias exists, use it.
1044 if os.path.isfile(alias_file):
1045 project_name = osutils.ReadFile(alias_file).strip()
1046
1047 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001048
1049 if not _get_commit_desc(commit).startswith(project_name + ': '):
1050 return HookFailure('The commit title for changes affecting only %s'
1051 ' should start with \"%s: \"'
1052 % (project_name, project_name))
1053
1054
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001055# Base
1056
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001057# A list of hooks which are not project specific and check patch description
1058# (as opposed to patch body).
1059_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07001060 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07001061 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07001062 _check_change_has_test_field,
1063 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001064 _check_commit_message_style,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001065]
1066
1067
1068# A list of hooks that are not project-specific
1069_COMMON_HOOKS = [
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001070 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05001071 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001072 _check_ebuild_licenses,
Mike Frysingercd363c82014-02-01 05:20:18 -05001073 _check_ebuild_virtual_pv,
Ryan Cui9b651632011-05-11 11:38:58 -07001074 _check_no_stray_whitespace,
1075 _check_no_long_lines,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001076 _check_layout_conf,
Ryan Cui9b651632011-05-11 11:38:58 -07001077 _check_license,
1078 _check_no_tabs,
Doug Anderson42b8a052013-06-26 10:45:36 -07001079 _check_for_uprev,
Ryan Cui9b651632011-05-11 11:38:58 -07001080]
Ryan Cuiec4d6332011-05-02 14:15:25 -07001081
Ryan Cui1562fb82011-05-09 11:01:31 -07001082
Ryan Cui9b651632011-05-11 11:38:58 -07001083# A dictionary of project-specific hooks(callbacks), indexed by project name.
1084# dict[project] = [callback1, callback2]
1085_PROJECT_SPECIFIC_HOOKS = {
Mike Frysingerdf980702013-08-22 22:25:22 -04001086 "chromeos/autotest-tools": [_run_json_check],
Mike Frysinger52b537e2013-08-22 22:59:53 -04001087 "chromeos/overlays/chromeos-overlay": [_check_manifests],
1088 "chromeos/overlays/chromeos-partner-overlay": [_check_manifests],
Randall Spangler7318fd62013-11-21 12:16:58 -08001089 "chromeos/platform/ec-private": [_run_checkpatch_ec,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001090 _check_change_has_branch_field],
Puneet Kumar57b9c092012-08-14 18:58:29 -07001091 "chromeos/third_party/intel-framework": [_check_change_has_branch_field],
Mike Frysingerdf980702013-08-22 22:25:22 -04001092 "chromeos/vendor/kernel-exynos-staging": [_run_checkpatch,
1093 _kernel_configcheck],
Mike Frysinger52b537e2013-08-22 22:59:53 -04001094 "chromiumos/overlays/board-overlays": [_check_manifests],
1095 "chromiumos/overlays/chromiumos-overlay": [_check_manifests],
1096 "chromiumos/overlays/portage-stable": [_check_manifests],
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001097 "chromiumos/platform2": [_check_project_prefix],
Vadim Bendebury42052852014-10-06 16:02:38 -07001098 "chromiumos/platform/depthcharge": [_check_change_has_branch_field,
1099 _check_change_has_signoff_field,
Vadim Bendebury4bcd9fa2014-08-07 12:27:37 -07001100 _run_checkpatch_depthcharge],
Randall Spangler7318fd62013-11-21 12:16:58 -08001101 "chromiumos/platform/ec": [_run_checkpatch_ec,
Mike Frysingerdf980702013-08-22 22:25:22 -04001102 _check_change_has_branch_field],
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001103 "chromiumos/platform/mosys": [_check_change_has_branch_field],
Mike Frysingerdf980702013-08-22 22:25:22 -04001104 "chromiumos/platform/vboot_reference": [_check_change_has_branch_field],
Vadim Bendebury42052852014-10-06 16:02:38 -07001105 "chromiumos/third_party/coreboot": [_check_change_has_branch_field,
1106 _check_change_has_signoff_field,
Vadim Bendebury4bcd9fa2014-08-07 12:27:37 -07001107 _run_checkpatch_coreboot],
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001108 "chromiumos/third_party/flashrom": [_check_change_has_branch_field],
Mike Frysingerdf980702013-08-22 22:25:22 -04001109 "chromiumos/third_party/kernel": [_run_checkpatch, _kernel_configcheck],
1110 "chromiumos/third_party/kernel-next": [_run_checkpatch,
1111 _kernel_configcheck],
Vadim Bendebury203fbc22014-04-22 11:58:14 -07001112 "chromiumos/third_party/u-boot": [_run_checkpatch_no_tree],
Ryan Cui9b651632011-05-11 11:38:58 -07001113}
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001114
Ryan Cui1562fb82011-05-09 11:01:31 -07001115
Ryan Cui9b651632011-05-11 11:38:58 -07001116# A dictionary of flags (keys) that can appear in the config file, and the hook
1117# that the flag disables (value)
1118_DISABLE_FLAGS = {
1119 'stray_whitespace_check': _check_no_stray_whitespace,
1120 'long_line_check': _check_no_long_lines,
1121 'cros_license_check': _check_license,
1122 'tab_check': _check_no_tabs,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001123 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001124 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07001125 'bug_field_check': _check_change_has_bug_field,
1126 'test_field_check': _check_change_has_test_field,
Ryan Cui9b651632011-05-11 11:38:58 -07001127}
1128
1129
Jon Salz3ee59de2012-08-18 13:54:22 +08001130def _get_disabled_hooks(config):
Ryan Cui9b651632011-05-11 11:38:58 -07001131 """Returns a set of hooks disabled by the current project's config file.
1132
1133 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08001134
1135 Args:
1136 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001137 """
1138 SECTION = 'Hook Overrides'
Jon Salz3ee59de2012-08-18 13:54:22 +08001139 if not config.has_section(SECTION):
1140 return set()
Ryan Cui9b651632011-05-11 11:38:58 -07001141
1142 disable_flags = []
Jon Salz3ee59de2012-08-18 13:54:22 +08001143 for flag in config.options(SECTION):
Ryan Cui9b651632011-05-11 11:38:58 -07001144 try:
Mike Frysingerae409522014-02-01 03:16:11 -05001145 if not config.getboolean(SECTION, flag):
1146 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001147 except ValueError as e:
1148 msg = "Error parsing flag \'%s\' in %s file - " % (flag, _CONFIG_FILE)
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04001149 print(msg + str(e))
Ryan Cui9b651632011-05-11 11:38:58 -07001150
1151 disabled_keys = set(_DISABLE_FLAGS.iterkeys()).intersection(disable_flags)
1152 return set([_DISABLE_FLAGS[key] for key in disabled_keys])
1153
1154
Jon Salz3ee59de2012-08-18 13:54:22 +08001155def _get_project_hook_scripts(config):
1156 """Returns a list of project-specific hook scripts.
1157
1158 Args:
1159 config: A ConfigParser for the project's config file.
1160 """
1161 SECTION = 'Hook Scripts'
1162 if not config.has_section(SECTION):
1163 return []
1164
1165 hook_names_values = config.items(SECTION)
1166 hook_names_values.sort(key=lambda x: x[0])
1167 return [x[1] for x in hook_names_values]
1168
1169
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001170def _get_project_hooks(project, presubmit):
Ryan Cui9b651632011-05-11 11:38:58 -07001171 """Returns a list of hooks that need to be run for a project.
1172
1173 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001174
1175 Args:
1176 project: A string, name of the project.
1177 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui9b651632011-05-11 11:38:58 -07001178 """
Jon Salz3ee59de2012-08-18 13:54:22 +08001179 config = ConfigParser.RawConfigParser()
1180 try:
1181 config.read(_CONFIG_FILE)
1182 except ConfigParser.Error:
1183 # Just use an empty config file
1184 config = ConfigParser.RawConfigParser()
1185
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001186 if presubmit:
1187 hook_list = _COMMON_HOOKS
1188 else:
1189 hook_list = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
1190
Jon Salz3ee59de2012-08-18 13:54:22 +08001191 disabled_hooks = _get_disabled_hooks(config)
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001192 hooks = [hook for hook in hook_list if hook not in disabled_hooks]
Ryan Cui9b651632011-05-11 11:38:58 -07001193
1194 if project in _PROJECT_SPECIFIC_HOOKS:
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001195 hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project]
1196 if hook not in disabled_hooks)
Ryan Cui9b651632011-05-11 11:38:58 -07001197
Jon Salz3ee59de2012-08-18 13:54:22 +08001198 for script in _get_project_hook_scripts(config):
1199 hooks.append(functools.partial(_run_project_hook_script, script))
1200
Ryan Cui9b651632011-05-11 11:38:58 -07001201 return hooks
1202
1203
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001204def _run_project_hooks(project, proj_dir=None,
1205 commit_list=None, presubmit=False):
Ryan Cui1562fb82011-05-09 11:01:31 -07001206 """For each project run its project specific hook from the hooks dictionary.
1207
1208 Args:
Doug Anderson44a644f2011-11-02 10:37:37 -07001209 project: The name of project to run hooks for.
1210 proj_dir: If non-None, this is the directory the project is in. If None,
1211 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07001212 commit_list: A list of commits to run hooks against. If None or empty list
1213 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001214 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui1562fb82011-05-09 11:01:31 -07001215
1216 Returns:
1217 Boolean value of whether any errors were ecountered while running the hooks.
1218 """
Doug Anderson44a644f2011-11-02 10:37:37 -07001219 if proj_dir is None:
David James2edd9002013-10-11 14:09:19 -07001220 proj_dirs = _run_command(['repo', 'forall', project, '-c', 'pwd']).split()
1221 if len(proj_dirs) == 0:
1222 print('%s cannot be found.' % project, file=sys.stderr)
1223 print('Please specify a valid project.', file=sys.stderr)
1224 return True
1225 if len(proj_dirs) > 1:
1226 print('%s is associated with multiple directories.' % project,
1227 file=sys.stderr)
1228 print('Please specify a directory to help disambiguate.', file=sys.stderr)
1229 return True
1230 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07001231
Ryan Cuiec4d6332011-05-02 14:15:25 -07001232 pwd = os.getcwd()
1233 # hooks assume they are run from the root of the project
1234 os.chdir(proj_dir)
1235
Doug Anderson14749562013-06-26 13:38:29 -07001236 if not commit_list:
1237 try:
1238 commit_list = _get_commits()
1239 except VerifyException as e:
1240 PrintErrorForProject(project, HookFailure(str(e)))
1241 os.chdir(pwd)
1242 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07001243
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001244 hooks = _get_project_hooks(project, presubmit)
Ryan Cui1562fb82011-05-09 11:01:31 -07001245 error_found = False
Ryan Cuifa55df52011-05-06 11:16:55 -07001246 for commit in commit_list:
Ryan Cui1562fb82011-05-09 11:01:31 -07001247 error_list = []
Ryan Cui9b651632011-05-11 11:38:58 -07001248 for hook in hooks:
Ryan Cui1562fb82011-05-09 11:01:31 -07001249 hook_error = hook(project, commit)
1250 if hook_error:
1251 error_list.append(hook_error)
1252 error_found = True
1253 if error_list:
1254 PrintErrorsForCommit(project, commit, _get_commit_desc(commit),
1255 error_list)
Don Garrettdba548a2011-05-05 15:17:14 -07001256
Ryan Cuiec4d6332011-05-02 14:15:25 -07001257 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07001258 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001259
Mike Frysingerae409522014-02-01 03:16:11 -05001260
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001261# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07001262
Ryan Cui1562fb82011-05-09 11:01:31 -07001263
Mike Frysingerae409522014-02-01 03:16:11 -05001264def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08001265 """Main function invoked directly by repo.
1266
1267 This function will exit directly upon error so that repo doesn't print some
1268 obscure error message.
1269
1270 Args:
1271 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07001272 worktree_list: A list of directories. It should be the same length as
1273 project_list, so that each entry in project_list matches with a directory
1274 in worktree_list. If None, we will attempt to calculate the directories
1275 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08001276 kwargs: Leave this here for forward-compatibility.
1277 """
Ryan Cui1562fb82011-05-09 11:01:31 -07001278 found_error = False
David James2edd9002013-10-11 14:09:19 -07001279 if not worktree_list:
1280 worktree_list = [None] * len(project_list)
1281 for project, worktree in zip(project_list, worktree_list):
1282 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07001283 found_error = True
1284
Mike Frysingerae409522014-02-01 03:16:11 -05001285 if found_error:
Ryan Cui1562fb82011-05-09 11:01:31 -07001286 msg = ('Preupload failed due to errors in project(s). HINTS:\n'
Ryan Cui9b651632011-05-11 11:38:58 -07001287 '- To disable some source style checks, and for other hints, see '
1288 '<checkout_dir>/src/repohooks/README\n'
1289 '- To upload only current project, run \'repo upload .\'')
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04001290 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07001291 sys.exit(1)
Anush Elangovan63afad72011-03-23 00:41:27 -07001292
Ryan Cui1562fb82011-05-09 11:01:31 -07001293
Doug Anderson44a644f2011-11-02 10:37:37 -07001294def _identify_project(path):
1295 """Identify the repo project associated with the given path.
1296
1297 Returns:
1298 A string indicating what project is associated with the path passed in or
1299 a blank string upon failure.
1300 """
1301 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Mike Frysingerb81102f2014-11-21 00:33:35 -05001302 stderr=subprocess.PIPE, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07001303
1304
1305def direct_main(args, verbose=False):
1306 """Run hooks directly (outside of the context of repo).
1307
1308 # Setup for doctests below.
1309 # ...note that some tests assume that running pre-upload on this CWD is fine.
1310 # TODO: Use mock and actually mock out _run_project_hooks() for tests.
1311 >>> mydir = os.path.dirname(os.path.abspath(__file__))
1312 >>> olddir = os.getcwd()
1313
1314 # OK to run w/ no arugments; will run with CWD.
1315 >>> os.chdir(mydir)
1316 >>> direct_main(['prog_name'], verbose=True)
1317 Running hooks on chromiumos/repohooks
1318 0
1319 >>> os.chdir(olddir)
1320
1321 # Run specifying a dir
1322 >>> direct_main(['prog_name', '--dir=%s' % mydir], verbose=True)
1323 Running hooks on chromiumos/repohooks
1324 0
1325
1326 # Not a problem to use a bogus project; we'll just get default settings.
1327 >>> direct_main(['prog_name', '--dir=%s' % mydir, '--project=X'],verbose=True)
1328 Running hooks on X
1329 0
1330
1331 # Run with project but no dir
1332 >>> os.chdir(mydir)
1333 >>> direct_main(['prog_name', '--project=X'], verbose=True)
1334 Running hooks on X
1335 0
1336 >>> os.chdir(olddir)
1337
1338 # Try with a non-git CWD
1339 >>> os.chdir('/tmp')
1340 >>> direct_main(['prog_name'])
1341 Traceback (most recent call last):
1342 ...
1343 BadInvocation: The current directory is not part of a git project.
1344
1345 # Check various bad arguments...
1346 >>> direct_main(['prog_name', 'bogus'])
1347 Traceback (most recent call last):
1348 ...
1349 BadInvocation: Unexpected arguments: bogus
1350 >>> direct_main(['prog_name', '--project=bogus', '--dir=bogusdir'])
1351 Traceback (most recent call last):
1352 ...
1353 BadInvocation: Invalid dir: bogusdir
1354 >>> direct_main(['prog_name', '--project=bogus', '--dir=/tmp'])
1355 Traceback (most recent call last):
1356 ...
1357 BadInvocation: Not a git directory: /tmp
1358
1359 Args:
1360 args: The value of sys.argv
Mike Frysingerae409522014-02-01 03:16:11 -05001361 verbose: Log verbose info while running
Doug Anderson44a644f2011-11-02 10:37:37 -07001362
1363 Returns:
1364 0 if no pre-upload failures, 1 if failures.
1365
1366 Raises:
1367 BadInvocation: On some types of invocation errors.
1368 """
1369 desc = 'Run Chromium OS pre-upload hooks on changes compared to upstream.'
1370 parser = optparse.OptionParser(description=desc)
1371
1372 parser.add_option('--dir', default=None,
1373 help='The directory that the project lives in. If not '
1374 'specified, use the git project root based on the cwd.')
1375 parser.add_option('--project', default=None,
1376 help='The project repo path; this can affect how the hooks '
1377 'get run, since some hooks are project-specific. For '
1378 'chromite this is chromiumos/chromite. If not specified, '
1379 'the repo tool will be used to figure this out based on '
1380 'the dir.')
Doug Anderson14749562013-06-26 13:38:29 -07001381 parser.add_option('--rerun-since', default=None,
1382 help='Rerun hooks on old commits since the given date. '
1383 'The date should match git log\'s concept of a date. '
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001384 'e.g. 2012-06-20. This option is mutually exclusive '
1385 'with --pre-submit.')
1386 parser.add_option('--pre-submit', action="store_true",
1387 help='Run the check against the pending commit. '
1388 'This option should be used at the \'git commit\' '
1389 'phase as opposed to \'repo upload\'. This option '
1390 'is mutually exclusive with --rerun-since.')
Doug Anderson14749562013-06-26 13:38:29 -07001391
1392 parser.usage = "pre-upload.py [options] [commits]"
Doug Anderson44a644f2011-11-02 10:37:37 -07001393
1394 opts, args = parser.parse_args(args[1:])
1395
Doug Anderson14749562013-06-26 13:38:29 -07001396 if opts.rerun_since:
1397 if args:
1398 raise BadInvocation('Can\'t pass commits and use rerun-since: %s' %
1399 ' '.join(args))
1400
1401 cmd = ['git', 'log', '--since="%s"' % opts.rerun_since, '--pretty=%H']
1402 all_commits = _run_command(cmd).splitlines()
1403 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
1404
1405 # Eliminate chrome-bot commits but keep ordering the same...
1406 bot_commits = set(bot_commits)
1407 args = [c for c in all_commits if c not in bot_commits]
1408
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001409 if opts.pre_submit:
1410 raise BadInvocation('rerun-since and pre-submit can not be '
1411 'used together')
1412 if opts.pre_submit:
1413 if args:
1414 raise BadInvocation('Can\'t pass commits and use pre-submit: %s' %
1415 ' '.join(args))
1416 args = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07001417
1418 # Check/normlaize git dir; if unspecified, we'll use the root of the git
1419 # project from CWD
1420 if opts.dir is None:
1421 git_dir = _run_command(['git', 'rev-parse', '--git-dir'],
1422 stderr=subprocess.PIPE).strip()
1423 if not git_dir:
1424 raise BadInvocation('The current directory is not part of a git project.')
1425 opts.dir = os.path.dirname(os.path.abspath(git_dir))
1426 elif not os.path.isdir(opts.dir):
1427 raise BadInvocation('Invalid dir: %s' % opts.dir)
1428 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
1429 raise BadInvocation('Not a git directory: %s' % opts.dir)
1430
1431 # Identify the project if it wasn't specified; this _requires_ the repo
1432 # tool to be installed and for the project to be part of a repo checkout.
1433 if not opts.project:
1434 opts.project = _identify_project(opts.dir)
1435 if not opts.project:
1436 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
1437
1438 if verbose:
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04001439 print("Running hooks on %s" % (opts.project))
Doug Anderson44a644f2011-11-02 10:37:37 -07001440
Doug Anderson14749562013-06-26 13:38:29 -07001441 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001442 commit_list=args,
1443 presubmit=opts.pre_submit)
Doug Anderson44a644f2011-11-02 10:37:37 -07001444 if found_error:
1445 return 1
1446 return 0
1447
1448
1449def _test():
1450 """Run any built-in tests."""
1451 import doctest
1452 doctest.testmod()
1453
1454
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07001455if __name__ == '__main__':
Doug Anderson44a644f2011-11-02 10:37:37 -07001456 if sys.argv[1:2] == ["--test"]:
1457 _test()
1458 exit_code = 0
1459 else:
1460 prog_name = os.path.basename(sys.argv[0])
1461 try:
1462 exit_code = direct_main(sys.argv)
Bertrand SIMONNET6ec83f92014-05-30 10:42:34 -07001463 except BadInvocation, err:
1464 print("%s: %s" % (prog_name, str(err)), file=sys.stderr)
Doug Anderson44a644f2011-11-02 10:37:37 -07001465 exit_code = 1
1466 sys.exit(exit_code)