blob: efc6f5f0a397dd910900852071f4f32ec233befc [file] [log] [blame]
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08001#!/usr/bin/env python2
Jon Salz98255932012-08-18 14:48:02 +08002# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
Mike Frysingerae409522014-02-01 03:16:11 -05006"""Presubmit checks to run when doing `repo upload`.
7
8You can add new checks by adding a functions to the HOOKS constants.
9"""
10
Mike Frysinger09d6a3d2013-10-08 22:21:03 -040011from __future__ import print_function
12
Filipe Brandenburger4b542b12015-10-09 12:46:31 -070013import argparse
Alex Deymo643ac4c2015-09-03 10:40:50 -070014import collections
Ryan Cui9b651632011-05-11 11:38:58 -070015import ConfigParser
Daniel Erate3ea3fc2015-02-13 15:27:52 -070016import fnmatch
Jon Salz3ee59de2012-08-18 13:54:22 +080017import functools
Dale Curtis2975c432011-05-03 17:25:20 -070018import json
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070019import os
Ryan Cuiec4d6332011-05-02 14:15:25 -070020import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070021import sys
Peter Ammon811f6702014-06-12 15:45:38 -070022import stat
Aviv Keshet5ac59522017-01-31 14:28:27 -080023import StringIO
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070024
Ryan Cui1562fb82011-05-09 11:01:31 -070025from errors import (VerifyException, HookFailure, PrintErrorForProject,
26 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070027
David Jamesc3b68b32013-04-03 09:17:03 -070028# If repo imports us, the __name__ will be __builtin__, and the wrapper will
29# be in $CHROMEOS_CHECKOUT/.repo/repo/main.py, so we need to go two directories
30# up. The same logic also happens to work if we're executed directly.
31if __name__ in ('__builtin__', '__main__'):
32 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
33
Mike Frysinger66142932014-12-18 14:55:57 -050034from chromite.lib import commandline
Aviv Keshet5ac59522017-01-31 14:28:27 -080035from chromite.lib import constants
Rahul Chaudhry0e515342015-08-07 12:00:43 -070036from chromite.lib import cros_build_lib
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050037from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070038from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070039from chromite.lib import patch
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040040from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070041
Vadim Bendebury2b62d742014-06-22 13:14:51 -070042PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070043
44COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050045 # C++ and friends
46 r".*\.c$", r".*\.cc$", r".*\.cpp$", r".*\.h$", r".*\.m$", r".*\.mm$",
47 r".*\.inl$", r".*\.asm$", r".*\.hxx$", r".*\.hpp$", r".*\.s$", r".*\.S$",
48 # Scripts
49 r".*\.js$", r".*\.py$", r".*\.sh$", r".*\.rb$", r".*\.pl$", r".*\.pm$",
50 # No extension at all, note that ALL CAPS files are black listed in
51 # COMMON_EXCLUDED_LIST below.
52 r"(^|.*[\\\/])[^.]+$",
53 # Other
54 r".*\.java$", r".*\.mk$", r".*\.am$",
Brian Norrisfdbac8e2016-06-16 11:09:05 -070055 r".*\.policy$", r".*\.conf$",
Ryan Cuiec4d6332011-05-02 14:15:25 -070056]
57
Ryan Cui1562fb82011-05-09 11:01:31 -070058
Ryan Cuiec4d6332011-05-02 14:15:25 -070059COMMON_EXCLUDED_PATHS = [
Daniel Erate3ea3fc2015-02-13 15:27:52 -070060 # Avoid doing source file checks for kernel.
Mike Frysingerae409522014-02-01 03:16:11 -050061 r"/src/third_party/kernel/",
62 r"/src/third_party/kernel-next/",
63 r"/src/third_party/ktop/",
64 r"/src/third_party/punybench/",
65 r".*\bexperimental[\\\/].*",
66 r".*\b[A-Z0-9_]{2,}$",
67 r".*[\\\/]debian[\\\/]rules$",
Daniel Erate3ea3fc2015-02-13 15:27:52 -070068
69 # For ebuild trees, ignore any caches and manifest data.
Mike Frysingerae409522014-02-01 03:16:11 -050070 r".*/Manifest$",
71 r".*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$",
Doug Anderson5bfb6792011-10-25 16:45:41 -070072
Daniel Erate3ea3fc2015-02-13 15:27:52 -070073 # Ignore profiles data (like overlay-tegra2/profiles).
Mike Frysinger94a670c2014-09-19 12:46:26 -040074 r"(^|.*/)overlay-.*/profiles/.*",
Mike Frysinger98638102014-08-28 00:15:08 -040075 r"^profiles/.*$",
76
C Shapiro8f90e9b2017-06-28 09:54:50 -060077 # Ignore config files in ebuild setup.
78 r"(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*",
79 r"^chromeos-base/chromeos-bsp.*/files/.*",
80
Daniel Erate3ea3fc2015-02-13 15:27:52 -070081 # Ignore minified js and jquery.
Mike Frysingerae409522014-02-01 03:16:11 -050082 r".*\.min\.js",
83 r".*jquery.*\.js",
Mike Frysinger33a458d2014-03-03 17:00:51 -050084
85 # Ignore license files as the content is often taken verbatim.
Daniel Erate3ea3fc2015-02-13 15:27:52 -070086 r".*/licenses/.*",
Ryan Cuiec4d6332011-05-02 14:15:25 -070087]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070088
Ryan Cui1562fb82011-05-09 11:01:31 -070089
Ryan Cui9b651632011-05-11 11:38:58 -070090_CONFIG_FILE = 'PRESUBMIT.cfg'
91
92
Daniel Erate3ea3fc2015-02-13 15:27:52 -070093# File containing wildcards, one per line, matching files that should be
94# excluded from presubmit checks. Lines beginning with '#' are ignored.
95_IGNORE_FILE = '.presubmitignore'
96
97
Doug Anderson44a644f2011-11-02 10:37:37 -070098# Exceptions
99
100
101class BadInvocation(Exception):
102 """An Exception indicating a bad invocation of the program."""
103 pass
104
105
Ryan Cui1562fb82011-05-09 11:01:31 -0700106# General Helpers
107
Sean Paulba01d402011-05-05 11:36:23 -0400108
Alex Deymo643ac4c2015-09-03 10:40:50 -0700109Project = collections.namedtuple('Project', ['name', 'dir', 'remote'])
110
111
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700112# pylint: disable=redefined-builtin
113def _run_command(cmd, cwd=None, input=None,
114 redirect_stderr=False, combine_stdout_stderr=False):
Doug Anderson44a644f2011-11-02 10:37:37 -0700115 """Executes the passed in command and returns raw stdout output.
116
117 Args:
118 cmd: The command to run; should be a list of strings.
119 cwd: The directory to switch to for running the command.
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700120 input: The data to pipe into this command through stdin. If a file object
121 or file descriptor, stdin will be connected directly to that.
122 redirect_stderr: Redirect stderr away from console.
123 combine_stdout_stderr: Combines stdout and stderr streams into stdout.
Doug Anderson44a644f2011-11-02 10:37:37 -0700124
125 Returns:
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700126 The stdout from the process (discards stderr and returncode).
Doug Anderson44a644f2011-11-02 10:37:37 -0700127 """
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700128 return cros_build_lib.RunCommand(cmd=cmd,
129 cwd=cwd,
130 print_cmd=False,
131 input=input,
132 stdout_to_pipe=True,
133 redirect_stderr=redirect_stderr,
134 combine_stdout_stderr=combine_stdout_stderr,
135 error_code_ok=True).output
136# pylint: enable=redefined-builtin
Ryan Cui72834d12011-05-05 14:51:33 -0700137
Ryan Cui1562fb82011-05-09 11:01:31 -0700138
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700139def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700140 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700141 if __name__ == '__main__':
142 # Works when file is run on its own (__file__ is defined)...
143 return os.path.abspath(os.path.dirname(__file__))
144 else:
145 # We need to do this when we're run through repo. Since repo executes
146 # us with execfile(), we don't get __file__ defined.
147 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
148 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700149
Ryan Cui1562fb82011-05-09 11:01:31 -0700150
Ryan Cuiec4d6332011-05-02 14:15:25 -0700151def _match_regex_list(subject, expressions):
152 """Try to match a list of regular expressions to a string.
153
154 Args:
155 subject: The string to match regexes on
156 expressions: A list of regular expressions to check for matches with.
157
158 Returns:
159 Whether the passed in subject matches any of the passed in regexes.
160 """
161 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500162 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700163 return True
164 return False
165
Ryan Cui1562fb82011-05-09 11:01:31 -0700166
Mike Frysingerae409522014-02-01 03:16:11 -0500167def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700168 """Filter out files based on the conditions passed in.
169
170 Args:
171 files: list of filepaths to filter
172 include_list: list of regex that when matched with a file path will cause it
173 to be added to the output list unless the file is also matched with a
174 regex in the exclude_list.
175 exclude_list: list of regex that when matched with a file will prevent it
176 from being added to the output list, even if it is also matched with a
177 regex in the include_list.
178
179 Returns:
180 A list of filepaths that contain files matched in the include_list and not
181 in the exclude_list.
182 """
183 filtered = []
184 for f in files:
185 if (_match_regex_list(f, include_list) and
186 not _match_regex_list(f, exclude_list)):
187 filtered.append(f)
188 return filtered
189
Ryan Cuiec4d6332011-05-02 14:15:25 -0700190
191# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700192
193
Ryan Cui4725d952011-05-05 15:41:19 -0700194def _get_upstream_branch():
195 """Returns the upstream tracking branch of the current branch.
196
197 Raises:
198 Error if there is no tracking branch
199 """
200 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
201 current_branch = current_branch.replace('refs/heads/', '')
202 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700203 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700204
205 cfg_option = 'branch.' + current_branch + '.%s'
206 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
207 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
208 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700209 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700210
211 return full_upstream.replace('heads', 'remotes/' + remote)
212
Ryan Cui1562fb82011-05-09 11:01:31 -0700213
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700214def _get_patch(commit):
215 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700216 if commit == PRE_SUBMIT:
217 return _run_command(['git', 'diff', '--cached', 'HEAD'])
218 else:
219 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700220
Ryan Cui1562fb82011-05-09 11:01:31 -0700221
Jon Salz98255932012-08-18 14:48:02 +0800222def _try_utf8_decode(data):
223 """Attempts to decode a string as UTF-8.
224
225 Returns:
226 The decoded Unicode object, or the original string if parsing fails.
227 """
228 try:
229 return unicode(data, 'utf-8', 'strict')
230 except UnicodeDecodeError:
231 return data
232
233
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500234def _get_file_content(path, commit):
235 """Returns the content of a file at a specific commit.
236
237 We can't rely on the file as it exists in the filesystem as people might be
238 uploading a series of changes which modifies the file multiple times.
239
240 Note: The "content" of a symlink is just the target. So if you're expecting
241 a full file, you should check that first. One way to detect is that the
242 content will not have any newlines.
243 """
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700244 if commit == PRE_SUBMIT:
245 return _run_command(['git', 'diff', 'HEAD', path])
246 else:
247 return _run_command(['git', 'show', '%s:%s' % (commit, path)])
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500248
249
Mike Frysingerae409522014-02-01 03:16:11 -0500250def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700251 """Returns a list of (linenum, lines) tuples that the commit touched."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700252 if commit == PRE_SUBMIT:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800253 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD',
254 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700255 else:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800256 command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit,
257 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700258 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700259
260 new_lines = []
261 line_num = 0
262 for line in output.splitlines():
263 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
264 if m:
265 line_num = int(m.groups(1)[0])
266 continue
267 if line.startswith('+') and not line.startswith('++'):
Jon Salz98255932012-08-18 14:48:02 +0800268 new_lines.append((line_num, _try_utf8_decode(line[1:])))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700269 if not line.startswith('-'):
270 line_num += 1
271 return new_lines
272
Ryan Cui1562fb82011-05-09 11:01:31 -0700273
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700274def _get_ignore_wildcards(directory, cache):
275 """Get wildcards listed in a directory's _IGNORE_FILE.
276
277 Args:
278 directory: A string containing a directory path.
279 cache: A dictionary (opaque to caller) caching previously-read wildcards.
280
281 Returns:
282 A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE
283 wasn't present.
284 """
285 # In the cache, keys are directories and values are lists of wildcards from
286 # _IGNORE_FILE within those directories (and empty if no file was present).
287 if directory not in cache:
288 wildcards = []
289 dotfile_path = os.path.join(directory, _IGNORE_FILE)
290 if os.path.exists(dotfile_path):
291 # TODO(derat): Consider using _get_file_content() to get the file as of
292 # this commit instead of the on-disk version. This may have a noticeable
293 # performance impact, as each call to _get_file_content() runs git.
294 with open(dotfile_path, 'r') as dotfile:
295 for line in dotfile.readlines():
296 line = line.strip()
297 if line.startswith('#'):
298 continue
299 if line.endswith('/'):
300 line += '*'
301 wildcards.append(line)
302 cache[directory] = wildcards
303
304 return cache[directory]
305
306
307def _path_is_ignored(path, cache):
308 """Check whether a path is ignored by _IGNORE_FILE.
309
310 Args:
311 path: A string containing a path.
312 cache: A dictionary (opaque to caller) caching previously-read wildcards.
313
314 Returns:
315 True if a file named _IGNORE_FILE in one of the passed-in path's parent
316 directories contains a wildcard matching the path.
317 """
318 # Skip ignore files.
319 if os.path.basename(path) == _IGNORE_FILE:
320 return True
321
322 path = os.path.abspath(path)
323 base = os.getcwd()
324
325 prefix = os.path.dirname(path)
326 while prefix.startswith(base):
327 rel_path = path[len(prefix) + 1:]
328 for wildcard in _get_ignore_wildcards(prefix, cache):
329 if fnmatch.fnmatch(rel_path, wildcard):
330 return True
331 prefix = os.path.dirname(prefix)
332
333 return False
334
335
Mike Frysinger292b45d2014-11-25 01:17:10 -0500336def _get_affected_files(commit, include_deletes=False, relative=False,
337 include_symlinks=False, include_adds=True,
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700338 full_details=False, use_ignore_files=True):
Peter Ammon811f6702014-06-12 15:45:38 -0700339 """Returns list of file paths that were modified/added, excluding symlinks.
340
341 Args:
342 commit: The commit
343 include_deletes: If true, we'll include deleted files in the result
344 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500345 include_symlinks: If true, we'll include symlinks in the result
346 include_adds: If true, we'll include new files in the result
347 full_details: If False, return filenames, else return structured results.
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700348 use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files.
Peter Ammon811f6702014-06-12 15:45:38 -0700349
350 Returns:
351 A list of modified/added (and perhaps deleted) files
352 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500353 if not relative and full_details:
354 raise ValueError('full_details only supports relative paths currently')
355
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700356 if commit == PRE_SUBMIT:
357 return _run_command(['git', 'diff-index', '--cached',
358 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500359
360 path = os.getcwd()
361 files = git.RawDiff(path, '%s^!' % commit)
362
363 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500364 if not include_symlinks:
365 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500366
367 if not include_deletes:
368 files = [x for x in files if x.status != 'D']
369
Mike Frysinger292b45d2014-11-25 01:17:10 -0500370 if not include_adds:
371 files = [x for x in files if x.status != 'A']
372
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700373 if use_ignore_files:
374 cache = {}
375 is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache)
376 files = [x for x in files if not is_ignored(x)]
377
Mike Frysinger292b45d2014-11-25 01:17:10 -0500378 if full_details:
379 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500380 return files
381 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500382 # Caller only cares about filenames.
383 files = [x.dst_file if x.dst_file else x.src_file for x in files]
384 if relative:
385 return files
386 else:
387 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700388
389
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700390def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700391 """Returns a list of commits for this review."""
Ryan Cui4725d952011-05-05 15:41:19 -0700392 cmd = ['git', 'log', '%s..' % _get_upstream_branch(), '--format=%H']
Ryan Cui72834d12011-05-05 14:51:33 -0700393 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700394
Ryan Cui1562fb82011-05-09 11:01:31 -0700395
Ryan Cuiec4d6332011-05-02 14:15:25 -0700396def _get_commit_desc(commit):
397 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700398 if commit == PRE_SUBMIT:
399 return ''
Sean Paul23a2c582011-05-06 13:10:44 -0400400 return _run_command(['git', 'log', '--format=%s%n%n%b', commit + '^!'])
Ryan Cuiec4d6332011-05-02 14:15:25 -0700401
402
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800403def _check_lines_in_diff(commit, files, check_callable, error_description):
404 """Checks given file for errors via the given check.
405
406 This is a convenience function for common per-line checks. It goes through all
407 files and returns a HookFailure with the error description listing all the
408 failures.
409
410 Args:
411 commit: The commit we're working on.
412 files: The files to check.
413 check_callable: A callable that takes a line and returns True if this line
414 _fails_ the check.
415 error_description: A string describing the error.
416 """
417 errors = []
418 for afile in files:
419 for line_num, line in _get_file_diff(afile, commit):
420 if check_callable(line):
421 errors.append('%s, line %s' % (afile, line_num))
422 if errors:
423 return HookFailure(error_description, errors)
424
425
Ryan Cuiec4d6332011-05-02 14:15:25 -0700426# Common Hooks
427
Ryan Cui1562fb82011-05-09 11:01:31 -0700428
Mike Frysingerae409522014-02-01 03:16:11 -0500429def _check_no_long_lines(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -0500430 """Checks there are no lines longer than MAX_LEN in any of the text files."""
431
Ryan Cuiec4d6332011-05-02 14:15:25 -0700432 MAX_LEN = 80
Jon Salz98255932012-08-18 14:48:02 +0800433 SKIP_REGEXP = re.compile('|'.join([
434 r'https?://',
435 r'^#\s*(define|include|import|pragma|if|endif)\b']))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700436
437 errors = []
438 files = _filter_files(_get_affected_files(commit),
439 COMMON_INCLUDED_PATHS,
440 COMMON_EXCLUDED_PATHS)
441
442 for afile in files:
443 for line_num, line in _get_file_diff(afile, commit):
444 # Allow certain lines to exceed the maxlen rule.
Mike Frysingerae409522014-02-01 03:16:11 -0500445 if len(line) <= MAX_LEN or SKIP_REGEXP.search(line):
Jon Salz98255932012-08-18 14:48:02 +0800446 continue
447
448 errors.append('%s, line %s, %s chars' % (afile, line_num, len(line)))
449 if len(errors) == 5: # Just show the first 5 errors.
450 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700451
452 if errors:
453 msg = 'Found lines longer than %s characters (first 5 shown):' % MAX_LEN
Ryan Cui1562fb82011-05-09 11:01:31 -0700454 return HookFailure(msg, errors)
455
Ryan Cuiec4d6332011-05-02 14:15:25 -0700456
Mike Frysingerae409522014-02-01 03:16:11 -0500457def _check_no_stray_whitespace(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700458 """Checks that there is no stray whitespace at source lines end."""
Ryan Cuiec4d6332011-05-02 14:15:25 -0700459 files = _filter_files(_get_affected_files(commit),
Mike Frysingerae409522014-02-01 03:16:11 -0500460 COMMON_INCLUDED_PATHS,
461 COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800462 return _check_lines_in_diff(commit, files,
463 lambda line: line.rstrip() != line,
464 'Found line ending with white space in:')
Ryan Cui1562fb82011-05-09 11:01:31 -0700465
Ryan Cuiec4d6332011-05-02 14:15:25 -0700466
Mike Frysingerae409522014-02-01 03:16:11 -0500467def _check_no_tabs(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700468 """Checks there are no unexpanded tabs."""
469 TAB_OK_PATHS = [
Ryan Cui31e0c172011-05-04 21:00:45 -0700470 r"/src/third_party/u-boot/",
Ryan Cuiec4d6332011-05-02 14:15:25 -0700471 r".*\.ebuild$",
472 r".*\.eclass$",
Elly Jones5ab34192011-11-15 14:57:06 -0500473 r".*/[M|m]akefile$",
474 r".*\.mk$"
Ryan Cuiec4d6332011-05-02 14:15:25 -0700475 ]
476
Ryan Cuiec4d6332011-05-02 14:15:25 -0700477 files = _filter_files(_get_affected_files(commit),
478 COMMON_INCLUDED_PATHS,
479 COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800480 return _check_lines_in_diff(commit, files,
481 lambda line: '\t' in line,
482 'Found a tab character in:')
Ryan Cuiec4d6332011-05-02 14:15:25 -0700483
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800484
485def _check_tabbed_indents(_project, commit):
486 """Checks that indents use tabs only."""
487 TABS_REQUIRED_PATHS = [
488 r".*\.ebuild$",
489 r".*\.eclass$",
490 ]
491 LEADING_SPACE_RE = re.compile('[\t]* ')
492
493 files = _filter_files(_get_affected_files(commit),
494 TABS_REQUIRED_PATHS,
495 COMMON_EXCLUDED_PATHS)
496 return _check_lines_in_diff(
497 commit, files,
498 lambda line: LEADING_SPACE_RE.match(line) is not None,
499 'Found a space in indentation (must be all tabs):')
Ryan Cui1562fb82011-05-09 11:01:31 -0700500
Ryan Cuiec4d6332011-05-02 14:15:25 -0700501
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700502def _check_gofmt(_project, commit):
503 """Checks that Go files are formatted with gofmt."""
504 errors = []
505 files = _filter_files(_get_affected_files(commit, relative=True),
506 [r'\.go$'])
507
508 for gofile in files:
509 contents = _get_file_content(gofile, commit)
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700510 output = _run_command(cmd=['gofmt', '-l'], input=contents,
511 combine_stdout_stderr=True)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700512 if output:
513 errors.append(gofile)
514 if errors:
515 return HookFailure('Files not formatted with gofmt:', errors)
516
517
Mike Frysingerae409522014-02-01 03:16:11 -0500518def _check_change_has_test_field(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700519 """Check for a non-empty 'TEST=' field in the commit message."""
David McMahon8f6553e2011-06-10 15:46:36 -0700520 TEST_RE = r'\nTEST=\S+'
Ryan Cuiec4d6332011-05-02 14:15:25 -0700521
Mandeep Singh Baines96a53be2011-05-03 11:10:25 -0700522 if not re.search(TEST_RE, _get_commit_desc(commit)):
Ryan Cui1562fb82011-05-09 11:01:31 -0700523 msg = 'Changelist description needs TEST field (after first line)'
524 return HookFailure(msg)
525
Ryan Cuiec4d6332011-05-02 14:15:25 -0700526
Mike Frysingerae409522014-02-01 03:16:11 -0500527def _check_change_has_valid_cq_depend(_project, commit):
David Jamesc3b68b32013-04-03 09:17:03 -0700528 """Check for a correctly formatted CQ-DEPEND field in the commit message."""
529 msg = 'Changelist has invalid CQ-DEPEND target.'
530 example = 'Example: CQ-DEPEND=CL:1234, CL:2345'
531 try:
532 patch.GetPaladinDeps(_get_commit_desc(commit))
533 except ValueError as ex:
534 return HookFailure(msg, [example, str(ex)])
535
536
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800537def _check_change_is_contribution(_project, commit):
538 """Check that the change is a contribution."""
539 NO_CONTRIB = 'not a contribution'
540 if NO_CONTRIB in _get_commit_desc(commit).lower():
541 msg = ('Changelist is not a contribution, this cannot be accepted.\n'
542 'Please remove the "%s" text from the commit message.') % NO_CONTRIB
543 return HookFailure(msg)
544
545
Alex Deymo643ac4c2015-09-03 10:40:50 -0700546def _check_change_has_bug_field(project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700547 """Check for a correctly formatted 'BUG=' field in the commit message."""
David James5c0073d2013-04-03 08:48:52 -0700548 OLD_BUG_RE = r'\nBUG=.*chromium-os'
549 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
550 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
551 'the chromium tracker in your BUG= line now.')
552 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700553
Alex Deymo643ac4c2015-09-03 10:40:50 -0700554 # Android internal and external projects use "Bug: " to track bugs in
555 # buganizer.
556 BUG_COLON_REMOTES = (
557 'aosp',
558 'goog',
559 )
560 if project.remote in BUG_COLON_REMOTES:
561 BUG_RE = r'\nBug: ?([Nn]one|\d+)'
562 if not re.search(BUG_RE, _get_commit_desc(commit)):
563 msg = ('Changelist description needs BUG field (after first line):\n'
564 'Bug: 9999 (for buganizer)\n'
565 'BUG=None')
566 return HookFailure(msg)
567 else:
568 BUG_RE = r'\nBUG=([Nn]one|(chrome-os-partner|chromium|brillo|b):\d+)'
569 if not re.search(BUG_RE, _get_commit_desc(commit)):
570 msg = ('Changelist description needs BUG field (after first line):\n'
571 'BUG=brillo:9999 (for Brillo tracker)\n'
572 'BUG=chromium:9999 (for public tracker)\n'
573 'BUG=chrome-os-partner:9999 (for partner tracker)\n'
574 'BUG=b:9999 (for buganizer)\n'
575 'BUG=None')
576 return HookFailure(msg)
Ryan Cui1562fb82011-05-09 11:01:31 -0700577
Ryan Cuiec4d6332011-05-02 14:15:25 -0700578
Mike Frysinger292b45d2014-11-25 01:17:10 -0500579def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -0700580 """Check that we're not missing a revbump of an ebuild in the given commit.
581
582 If the given commit touches files in a directory that has ebuilds somewhere
583 up the directory hierarchy, it's very likely that we need an ebuild revbump
584 in order for those changes to take effect.
585
586 It's not totally trivial to detect a revbump, so at least detect that an
587 ebuild with a revision number in it was touched. This should handle the
588 common case where we use a symlink to do the revbump.
589
590 TODO: it would be nice to enhance this hook to:
591 * Handle cases where people revbump with a slightly different syntax. I see
592 one ebuild (puppy) that revbumps with _pN. This is a false positive.
593 * Catches cases where people aren't using symlinks for revbumps. If they
594 edit a revisioned file directly (and are expected to rename it for revbump)
595 we'll miss that. Perhaps we could detect that the file touched is a
596 symlink?
597
598 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
599 still better off than without this check.
600
601 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700602 project: The Project to look at
Doug Anderson42b8a052013-06-26 10:45:36 -0700603 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -0500604 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -0700605
606 Returns:
607 A HookFailure or None.
608 """
Mike Frysinger011af942014-01-17 16:12:22 -0500609 # If this is the portage-stable overlay, then ignore the check. It's rare
610 # that we're doing anything other than importing files from upstream, so
611 # forcing a rev bump makes no sense.
612 whitelist = (
613 'chromiumos/overlays/portage-stable',
614 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700615 if project.name in whitelist:
Mike Frysinger011af942014-01-17 16:12:22 -0500616 return None
617
Mike Frysinger292b45d2014-11-25 01:17:10 -0500618 def FinalName(obj):
619 # If the file is being deleted, then the dst_file is not set.
620 if obj.dst_file is None:
621 return obj.src_file
622 else:
623 return obj.dst_file
624
625 affected_path_objs = _get_affected_files(
626 commit, include_deletes=True, include_symlinks=True, relative=True,
627 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -0700628
629 # Don't yell about changes to whitelisted files...
Aviv Keshet272f2e52016-04-25 14:49:44 -0700630 whitelist = ('ChangeLog', 'Manifest', 'metadata.xml', 'COMMIT-QUEUE.ini')
Mike Frysinger292b45d2014-11-25 01:17:10 -0500631 affected_path_objs = [x for x in affected_path_objs
632 if os.path.basename(FinalName(x)) not in whitelist]
633 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -0700634 return None
635
636 # If we've touched any file named with a -rN.ebuild then we'll say we're
637 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500638 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
639 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700640 if touched_revved_ebuild:
641 return None
642
Mike Frysinger292b45d2014-11-25 01:17:10 -0500643 # If we're creating new ebuilds from scratch, then we don't need an uprev.
644 # Find all the dirs that new ebuilds and ignore their files/.
645 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
646 if FinalName(x).endswith('.ebuild') and x.status == 'A']
647 affected_path_objs = [obj for obj in affected_path_objs
648 if not any(FinalName(obj).startswith(x)
649 for x in ebuild_dirs)]
650 if not affected_path_objs:
651 return
652
Doug Anderson42b8a052013-06-26 10:45:36 -0700653 # We want to examine the current contents of all directories that are parents
654 # of files that were touched (up to the top of the project).
655 #
656 # ...note: we use the current directory contents even though it may have
657 # changed since the commit we're looking at. This is just a heuristic after
658 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500659 if project_top is None:
660 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -0700661 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -0500662 for obj in affected_path_objs:
663 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -0700664 while os.path.exists(path) and not os.path.samefile(path, project_top):
665 dirs_to_check.add(path)
666 path = os.path.dirname(path)
667
668 # Look through each directory. If it's got an ebuild in it then we'll
669 # consider this as a case when we need a revbump.
Gwendal Grignoua3086c32014-12-09 11:17:22 -0800670 affected_paths = set(os.path.join(project_top, FinalName(x))
671 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700672 for dir_path in dirs_to_check:
673 contents = os.listdir(dir_path)
674 ebuilds = [os.path.join(dir_path, path)
675 for path in contents if path.endswith('.ebuild')]
676 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
677
678 # If the -9999.ebuild file was touched the bot will uprev for us.
679 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -0500680 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -0700681 continue
682
683 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500684 return HookFailure('Changelist probably needs a revbump of an ebuild, '
685 'or a -r1.ebuild symlink if this is a new ebuild:\n'
686 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -0700687
688 return None
689
690
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500691def _check_ebuild_eapi(project, commit):
692 """Make sure we have people use EAPI=4 or newer with custom ebuilds.
693
694 We want to get away from older EAPI's as it makes life confusing and they
695 have less builtin error checking.
696
697 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700698 project: The Project to look at
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500699 commit: The commit to look at
700
701 Returns:
702 A HookFailure or None.
703 """
704 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500705 # that we're doing anything other than importing files from upstream, and
706 # we shouldn't be rewriting things fundamentally anyways.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500707 whitelist = (
708 'chromiumos/overlays/portage-stable',
709 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700710 if project.name in whitelist:
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500711 return None
712
713 BAD_EAPIS = ('0', '1', '2', '3')
714
715 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
716
717 ebuilds_re = [r'\.ebuild$']
718 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
719 ebuilds_re)
720 bad_ebuilds = []
721
722 for ebuild in ebuilds:
723 # If the ebuild does not specify an EAPI, it defaults to 0.
724 eapi = '0'
725
726 lines = _get_file_content(ebuild, commit).splitlines()
727 if len(lines) == 1:
728 # This is most likely a symlink, so skip it entirely.
729 continue
730
731 for line in lines:
732 m = get_eapi.match(line)
733 if m:
734 # Once we hit the first EAPI line in this ebuild, stop processing.
735 # The spec requires that there only be one and it be first, so
736 # checking all possible values is pointless. We also assume that
737 # it's "the" EAPI line and not something in the middle of a heredoc.
738 eapi = m.group(1)
739 break
740
741 if eapi in BAD_EAPIS:
742 bad_ebuilds.append((ebuild, eapi))
743
744 if bad_ebuilds:
745 # pylint: disable=C0301
746 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
747 # pylint: enable=C0301
748 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500749 'These ebuilds are using old EAPIs. If these are imported from\n'
750 'Gentoo, then you may ignore and upload once with the --no-verify\n'
751 'flag. Otherwise, please update to 4 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500752 '\t%s\n'
753 'See this guide for more details:\n%s\n' %
754 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
755
756
Mike Frysinger89bdb852014-02-01 05:26:26 -0500757def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -0500758 """Make sure we use the new style KEYWORDS when possible in ebuilds.
759
760 If an ebuild generally does not care about the arch it is running on, then
761 ebuilds should flag it with one of:
762 KEYWORDS="*" # A stable ebuild.
763 KEYWORDS="~*" # An unstable ebuild.
764 KEYWORDS="-* ..." # Is known to only work on specific arches.
765
766 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700767 project: The Project to look at
Mike Frysingerc51ece72014-01-17 16:23:40 -0500768 commit: The commit to look at
769
770 Returns:
771 A HookFailure or None.
772 """
773 WHITELIST = set(('*', '-*', '~*'))
774
775 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
776
Mike Frysinger89bdb852014-02-01 05:26:26 -0500777 ebuilds_re = [r'\.ebuild$']
778 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
779 ebuilds_re)
780
Mike Frysinger8d42d742014-09-22 15:50:21 -0400781 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -0500782 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -0400783 # We get the full content rather than a diff as the latter does not work
784 # on new files (like when adding new ebuilds).
785 lines = _get_file_content(ebuild, commit).splitlines()
786 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -0500787 m = get_keywords.match(line)
788 if m:
789 keywords = set(m.group(1).split())
790 if not keywords or WHITELIST - keywords != WHITELIST:
791 continue
792
Mike Frysinger8d42d742014-09-22 15:50:21 -0400793 bad_ebuilds.append(ebuild)
794
795 if bad_ebuilds:
796 return HookFailure(
797 '%s\n'
798 'Please update KEYWORDS to use a glob:\n'
799 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
800 ' KEYWORDS="*"\n'
801 'If the ebuild should be marked unstable (normal for '
802 'cros-workon / 9999 ebuilds):\n'
803 ' KEYWORDS="~*"\n'
Mike Frysingerde8efea2015-05-17 03:42:26 -0400804 'If the ebuild needs to be marked for only specific arches, '
Mike Frysinger8d42d742014-09-22 15:50:21 -0400805 'then use -* like so:\n'
806 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -0500807
808
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800809def _check_ebuild_licenses(_project, commit):
810 """Check if the LICENSE field in the ebuild is correct."""
Brian Norris7a610e82016-02-17 12:24:54 -0800811 affected_paths = _get_affected_files(commit, relative=True)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800812 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
813
814 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -0800815 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800816
817 for ebuild in touched_ebuilds:
818 # Skip virutal packages.
819 if ebuild.split('/')[-3] == 'virtual':
820 continue
821
822 try:
Brian Norris7a610e82016-02-17 12:24:54 -0800823 ebuild_content = _get_file_content(ebuild, commit)
824 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800825 except ValueError as e:
826 return HookFailure(e.message, [ebuild])
827
828 # Also ignore licenses ending with '?'
829 for license_type in [x for x in license_types
830 if x not in LICENSES_IGNORE and not x.endswith('?')]:
831 try:
Mike Frysinger2ec70ed2014-08-17 19:28:34 -0400832 licenses_lib.Licensing.FindLicenseType(license_type)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800833 except AssertionError as e:
834 return HookFailure(e.message, [ebuild])
835
836
Mike Frysingercd363c82014-02-01 05:20:18 -0500837def _check_ebuild_virtual_pv(project, commit):
838 """Enforce the virtual PV policies."""
839 # If this is the portage-stable overlay, then ignore the check.
840 # We want to import virtuals as-is from upstream Gentoo.
841 whitelist = (
842 'chromiumos/overlays/portage-stable',
843 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700844 if project.name in whitelist:
Mike Frysingercd363c82014-02-01 05:20:18 -0500845 return None
846
847 # We assume the repo name is the same as the dir name on disk.
848 # It would be dumb to not have them match though.
Alex Deymo643ac4c2015-09-03 10:40:50 -0700849 project_base = os.path.basename(project.name)
Mike Frysingercd363c82014-02-01 05:20:18 -0500850
851 is_variant = lambda x: x.startswith('overlay-variant-')
852 is_board = lambda x: x.startswith('overlay-')
853 is_private = lambda x: x.endswith('-private')
854
855 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
856
857 ebuilds_re = [r'\.ebuild$']
858 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
859 ebuilds_re)
860 bad_ebuilds = []
861
862 for ebuild in ebuilds:
863 m = get_pv.match(ebuild)
864 if m:
865 overlay = m.group(1)
866 if not overlay or not is_board(overlay):
Alex Deymo643ac4c2015-09-03 10:40:50 -0700867 overlay = project_base
Mike Frysingercd363c82014-02-01 05:20:18 -0500868
869 pv = m.group(3).split('-', 1)[0]
870
Bernie Thompsone5ee1822016-01-12 14:22:23 -0800871 # Virtual versions >= 4 are special cases used above the standard
872 # versioning structure, e.g. if one has a board inheriting a board.
873 if float(pv) >= 4:
874 want_pv = pv
875 elif is_private(overlay):
Mike Frysingercd363c82014-02-01 05:20:18 -0500876 want_pv = '3.5' if is_variant(overlay) else '3'
877 elif is_board(overlay):
878 want_pv = '2.5' if is_variant(overlay) else '2'
879 else:
880 want_pv = '1'
881
882 if pv != want_pv:
883 bad_ebuilds.append((ebuild, pv, want_pv))
884
885 if bad_ebuilds:
886 # pylint: disable=C0301
887 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
888 # pylint: enable=C0301
889 return HookFailure(
890 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
891 '\t%s\n'
892 'If this is an upstream Gentoo virtual, then you may ignore this\n'
893 'check (and re-run w/--no-verify). Otherwise, please see this\n'
894 'page for more details:\n%s\n' %
895 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
896 for x in bad_ebuilds]), url))
897
898
Daniel Erat9d203ff2015-02-17 10:12:21 -0700899def _check_portage_make_use_var(_project, commit):
900 """Verify that $USE is set correctly in make.conf and make.defaults."""
901 files = _filter_files(_get_affected_files(commit, relative=True),
902 [r'(^|/)make.(conf|defaults)$'])
903
904 errors = []
905 for path in files:
906 basename = os.path.basename(path)
907
908 # Has a USE= line already been encountered in this file?
909 saw_use = False
910
911 for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1):
912 if not line.startswith('USE='):
913 continue
914
915 preserves_use = '${USE}' in line or '$USE' in line
916
917 if (basename == 'make.conf' or
918 (basename == 'make.defaults' and saw_use)) and not preserves_use:
919 errors.append('%s:%d: missing ${USE}' % (path, i))
920 elif basename == 'make.defaults' and not saw_use and preserves_use:
921 errors.append('%s:%d: ${USE} referenced in initial declaration' %
922 (path, i))
923
924 saw_use = True
925
926 if errors:
927 return HookFailure(
928 'One or more Portage make files appear to set USE incorrectly.\n'
929 '\n'
930 'All USE assignments in make.conf and all assignments after the\n'
931 'initial declaration in make.defaults should contain "${USE}" to\n'
932 'preserve previously-set flags.\n'
933 '\n'
934 'The initial USE declaration in make.defaults should not contain\n'
935 '"${USE}".\n',
936 errors)
937
938
Mike Frysingerae409522014-02-01 03:16:11 -0500939def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -0700940 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -0400941 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -0700942 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -0400943 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -0500944 if not m:
Vadim Bendebury20532ba2017-05-23 17:26:15 -0700945 return HookFailure('Last paragraph of description must include Change-Id.')
Ryan Cui1562fb82011-05-09 11:01:31 -0700946
Vadim Bendebury20532ba2017-05-23 17:26:15 -0700947 # S-o-b tags always allowed to follow Change-ID.
948 allowed_tags = ['Signed-off-by']
949
Mike Frysinger02b88bd2014-11-21 00:29:38 -0500950 end = desc[m.end():].strip().splitlines()
Vadim Bendebury20532ba2017-05-23 17:26:15 -0700951 if end and end[-1].startswith('(cherry picked from commit'):
952 # Cherry picked patches allow more tags in the last paragraph.
953 allowed_tags += ['Reviewed-on', 'Reviewed-by', 'Commit-Ready', 'Tested-by']
954 end = end[:-1]
955
956 tag_search = '^(%s): ' % '|'.join(allowed_tags)
957
958 if [x for x in end if not re.search(tag_search, x)]:
959 return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' %
960 ':", "'.join(allowed_tags))
Mike Frysinger02b88bd2014-11-21 00:29:38 -0500961
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -0700962
Mike Frysinger36b2ebc2014-10-31 14:02:03 -0400963def _check_commit_message_style(_project, commit):
964 """Verify that the commit message matches our style.
965
966 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
967 commit hooks.
968 """
969 desc = _get_commit_desc(commit)
970
971 # The first line should be by itself.
972 lines = desc.splitlines()
973 if len(lines) > 1 and lines[1]:
974 return HookFailure('The second line of the commit message must be blank.')
975
976 # The first line should be one sentence.
977 if '. ' in lines[0]:
978 return HookFailure('The first line cannot be more than one sentence.')
979
980 # The first line cannot be too long.
981 MAX_FIRST_LINE_LEN = 100
982 if len(lines[0]) > MAX_FIRST_LINE_LEN:
983 return HookFailure('The first line must be less than %i chars.' %
984 MAX_FIRST_LINE_LEN)
985
986
Filipe Brandenburger4b542b12015-10-09 12:46:31 -0700987def _check_cros_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -0700988 """Verifies the Chromium OS license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700989
Mike Frysinger98638102014-08-28 00:15:08 -0400990 Should be following the spec:
991 http://dev.chromium.org/developers/coding-style#TOC-File-headers
992 """
993 # For older years, be a bit more flexible as our policy says leave them be.
994 LICENSE_HEADER = (
995 r'.* Copyright( \(c\))? 20[-0-9]{2,7} The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -0500996 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -0400997 r'.* Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -0500998 r'be\n'
Mike Frysinger98638102014-08-28 00:15:08 -0400999 r'.* found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -05001000 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001001 )
1002 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1003
1004 # For newer years, be stricter.
1005 COPYRIGHT_LINE = (
1006 r'.* Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001007 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001008 )
1009 copyright_re = re.compile(COPYRIGHT_LINE)
1010
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001011 parser = argparse.ArgumentParser()
1012 parser.add_argument('--exclude_regex', action='append')
1013 parser.add_argument('--include_regex', action='append')
1014 opts = parser.parse_args(options)
1015 included = opts.include_regex or []
1016 excluded = opts.exclude_regex or []
1017
Mike Frysinger98638102014-08-28 00:15:08 -04001018 bad_files = []
1019 bad_copyright_files = []
1020 files = _filter_files(_get_affected_files(commit, relative=True),
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001021 included + COMMON_INCLUDED_PATHS,
1022 excluded + COMMON_EXCLUDED_PATHS)
Mike Frysinger98638102014-08-28 00:15:08 -04001023
1024 for f in files:
1025 contents = _get_file_content(f, commit)
1026 if not contents:
1027 # Ignore empty files.
1028 continue
1029
1030 if not license_re.search(contents):
1031 bad_files.append(f)
1032 elif copyright_re.search(contents):
1033 bad_copyright_files.append(f)
1034
1035 if bad_files:
1036 msg = '%s:\n%s\n%s' % (
1037 'License must match', license_re.pattern,
1038 'Found a bad header in these files:')
1039 return HookFailure(msg, bad_files)
1040
1041 if bad_copyright_files:
1042 msg = 'Do not use (c) in copyright headers in new files:'
1043 return HookFailure(msg, bad_copyright_files)
Ryan Cuiec4d6332011-05-02 14:15:25 -07001044
1045
Alex Deymof5792ce2015-08-24 22:50:08 -07001046def _check_aosp_license(_project, commit):
1047 """Verifies the AOSP license/copyright header.
1048
1049 AOSP uses the Apache2 License:
1050 https://source.android.com/source/licenses.html
1051 """
1052 LICENSE_HEADER = (
1053 r"""^[#/\*]*
1054[#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project
1055[#/\*]* ?
1056[#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\);
1057[#/\*]* ?you may not use this file except in compliance with the License\.
1058[#/\*]* ?You may obtain a copy of the License at
1059[#/\*]* ?
1060[#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0
1061[#/\*]* ?
1062[#/\*]* ?Unless required by applicable law or agreed to in writing, software
1063[#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS,
1064[#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """
1065 r"""implied\.
1066[#/\*]* ?See the License for the specific language governing permissions and
1067[#/\*]* ?limitations under the License\.
1068[#/\*]*$
1069"""
1070 )
1071 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1072
1073 files = _filter_files(_get_affected_files(commit, relative=True),
1074 COMMON_INCLUDED_PATHS,
1075 COMMON_EXCLUDED_PATHS)
1076
1077 bad_files = []
1078 for f in files:
1079 contents = _get_file_content(f, commit)
1080 if not contents:
1081 # Ignore empty files.
1082 continue
1083
1084 if not license_re.search(contents):
1085 bad_files.append(f)
1086
1087 if bad_files:
1088 msg = ('License must match:\n%s\nFound a bad header in these files:' %
1089 license_re.pattern)
1090 return HookFailure(msg, bad_files)
1091
1092
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001093def _check_layout_conf(_project, commit):
1094 """Verifies the metadata/layout.conf file."""
1095 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001096 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001097 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001098 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001099
Mike Frysinger94a670c2014-09-19 12:46:26 -04001100 # Handle multiple overlays in a single commit (like the public tree).
1101 for f in _get_affected_files(commit, relative=True):
1102 if f.endswith(repo_name):
1103 repo_names.append(f)
1104 elif f.endswith(layout_path):
1105 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001106
1107 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -04001108 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001109 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -04001110 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001111
Mike Frysinger94a670c2014-09-19 12:46:26 -04001112 # Gather all the errors in one pass so we show one full message.
1113 all_errors = {}
1114 for layout_path in layout_paths:
1115 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001116
Mike Frysinger94a670c2014-09-19 12:46:26 -04001117 # Make sure the config file is sorted.
1118 data = [x for x in _get_file_content(layout_path, commit).splitlines()
1119 if x and x[0] != '#']
1120 if sorted(data) != data:
1121 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001122
Mike Frysinger94a670c2014-09-19 12:46:26 -04001123 # Require people to set specific values all the time.
1124 settings = (
1125 # TODO: Enable this for everyone. http://crbug.com/408038
1126 #('fast caching', 'cache-format = md5-dict'),
1127 ('fast manifests', 'thin-manifests = true'),
Mike Frysingerd7734522015-02-26 16:12:43 -05001128 ('extra features', 'profile-formats = portage-2 profile-default-eapi'),
1129 ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001130 )
1131 for reason, line in settings:
1132 if line not in data:
1133 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001134
Mike Frysinger94a670c2014-09-19 12:46:26 -04001135 # Require one of these settings.
Mike Frysinger5fae62d2015-11-11 20:12:15 -05001136 if 'use-manifests = strict' not in data:
1137 errors += ['enable file checking with: use-manifests = strict']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001138
Mike Frysinger94a670c2014-09-19 12:46:26 -04001139 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -04001140 for line in data:
1141 if line.startswith('repo-name = '):
1142 break
1143 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -04001144 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001145
Mike Frysinger94a670c2014-09-19 12:46:26 -04001146 # Summarize all the errors we saw (if any).
1147 lines = ''
1148 for layout_path, errors in all_errors.items():
1149 if errors:
1150 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
1151 if lines:
1152 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
1153 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001154
1155
Ryan Cuiec4d6332011-05-02 14:15:25 -07001156# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001157
Ryan Cui1562fb82011-05-09 11:01:31 -07001158
Mike Frysingerae409522014-02-01 03:16:11 -05001159def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001160 """Runs checkpatch.pl on the given project"""
1161 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001162 options = list(options)
1163 if commit == PRE_SUBMIT:
1164 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
1165 # this case.
1166 options.append('--ignore=MISSING_SIGN_OFF')
Filipe Brandenburger28d48d62015-10-07 09:48:54 -07001167 # Always ignore the check for the MAINTAINERS file. We do not track that
1168 # information on that file in our source trees, so let's suppress the
1169 # warning.
1170 options.append('--ignore=FILE_PATH_CHANGES')
Filipe Brandenburgerce978322015-10-09 10:04:15 -07001171 # Do not complain about the Change-Id: fields, since we use Gerrit.
1172 # Upstream does not want those lines (since they do not use Gerrit), but
1173 # we always do, so disable the check globally.
Daisuke Nojiri4844f892015-10-08 09:54:33 -07001174 options.append('--ignore=GERRIT_CHANGE_ID')
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001175 cmd = ['%s/checkpatch.pl' % hooks_dir] + options + ['-']
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001176 cmd_result = cros_build_lib.RunCommand(cmd=cmd,
1177 print_cmd=False,
1178 input=_get_patch(commit),
1179 stdout_to_pipe=True,
1180 combine_stdout_stderr=True,
1181 error_code_ok=True)
1182 if cmd_result.returncode:
1183 return HookFailure('checkpatch.pl errors/warnings\n\n' + cmd_result.output)
Ryan Cuiec4d6332011-05-02 14:15:25 -07001184
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001185
Mike Frysingerae409522014-02-01 03:16:11 -05001186def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -07001187 """Makes sure kernel config changes are not mixed with code changes"""
1188 files = _get_affected_files(commit)
1189 if not len(_filter_files(files, [r'chromeos/config'])) in [0, len(files)]:
1190 return HookFailure('Changes to chromeos/config/ and regular files must '
1191 'be in separate commits:\n%s' % '\n'.join(files))
Anton Staaf815d6852011-08-22 10:08:45 -07001192
Mike Frysingerae409522014-02-01 03:16:11 -05001193
1194def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -07001195 """Checks that all JSON files are syntactically valid."""
Dale Curtisa039cfd2011-05-04 12:01:05 -07001196 for f in _filter_files(_get_affected_files(commit), [r'.*\.json']):
Dale Curtis2975c432011-05-03 17:25:20 -07001197 try:
1198 json.load(open(f))
1199 except Exception, e:
Ryan Cui1562fb82011-05-09 11:01:31 -07001200 return HookFailure('Invalid JSON in %s: %s' % (f, e))
Dale Curtis2975c432011-05-03 17:25:20 -07001201
1202
Mike Frysingerae409522014-02-01 03:16:11 -05001203def _check_manifests(_project, commit):
Mike Frysinger52b537e2013-08-22 22:59:53 -04001204 """Make sure Manifest files only have DIST lines"""
1205 paths = []
1206
1207 for path in _get_affected_files(commit):
1208 if os.path.basename(path) != 'Manifest':
1209 continue
1210 if not os.path.exists(path):
1211 continue
1212
1213 with open(path, 'r') as f:
1214 for line in f.readlines():
1215 if not line.startswith('DIST '):
1216 paths.append(path)
1217 break
1218
1219 if paths:
1220 return HookFailure('Please remove lines that do not start with DIST:\n%s' %
1221 ('\n'.join(paths),))
1222
1223
Mike Frysingerae409522014-02-01 03:16:11 -05001224def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001225 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001226 if commit == PRE_SUBMIT:
1227 return
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001228 BRANCH_RE = r'\nBRANCH=\S+'
1229
1230 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
1231 msg = ('Changelist description needs BRANCH field (after first line)\n'
1232 'E.g. BRANCH=none or BRANCH=link,snow')
1233 return HookFailure(msg)
1234
1235
Mike Frysingerae409522014-02-01 03:16:11 -05001236def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001237 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001238 if commit == PRE_SUBMIT:
1239 return
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001240 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1241
1242 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1243 msg = ('Changelist description needs Signed-off-by: field\n'
1244 'E.g. Signed-off-by: My Name <me@chromium.org>')
1245 return HookFailure(msg)
1246
1247
Aviv Keshet5ac59522017-01-31 14:28:27 -08001248def _check_cq_ini_well_formed(_project, commit):
1249 """Check that any modified COMMIT-QUEUE.ini files are well formed."""
1250 pattern = '.*' + constants.CQ_CONFIG_FILENAME
1251 files = _filter_files(_get_affected_files(commit), (pattern,))
1252
1253 # TODO(akeshet): Check not only that the file is parseable, but that all the
1254 # pre-cq configs it requests are existing ones.
1255 for f in files:
1256 try:
1257 parser = ConfigParser.SafeConfigParser()
1258 # Prior to python3, ConfigParser has no read_string method, so we must
1259 # pass it either a file path or file like object. And we must use
1260 # _get_file_content to fetch file contents to ensure we are examining the
1261 # commit diff, rather than whatever's on disk.
1262 contents = _get_file_content(f, commit)
1263 parser.readfp(StringIO.StringIO(contents))
1264 except ConfigParser.Error as e:
1265 msg = ('Unable to parse COMMIT-QUEUE.ini file at %s due to %s.' %
1266 (f, e))
1267 return HookFailure(msg)
1268
1269
Jon Salz3ee59de2012-08-18 13:54:22 +08001270def _run_project_hook_script(script, project, commit):
1271 """Runs a project hook script.
1272
1273 The script is run with the following environment variables set:
1274 PRESUBMIT_PROJECT: The affected project
1275 PRESUBMIT_COMMIT: The affected commit
1276 PRESUBMIT_FILES: A newline-separated list of affected files
1277
1278 The script is considered to fail if the exit code is non-zero. It should
1279 write an error message to stdout.
1280 """
1281 env = dict(os.environ)
Alex Deymo643ac4c2015-09-03 10:40:50 -07001282 env['PRESUBMIT_PROJECT'] = project.name
Jon Salz3ee59de2012-08-18 13:54:22 +08001283 env['PRESUBMIT_COMMIT'] = commit
1284
1285 # Put affected files in an environment variable
1286 files = _get_affected_files(commit)
1287 env['PRESUBMIT_FILES'] = '\n'.join(files)
1288
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001289 cmd_result = cros_build_lib.RunCommand(cmd=script,
1290 env=env,
1291 shell=True,
1292 print_cmd=False,
1293 input=os.devnull,
1294 stdout_to_pipe=True,
1295 combine_stdout_stderr=True,
1296 error_code_ok=True)
1297 if cmd_result.returncode:
1298 stdout = cmd_result.output
Jon Salz7b618af2012-08-31 06:03:16 +08001299 if stdout:
1300 stdout = re.sub('(?m)^', ' ', stdout)
1301 return HookFailure('Hook script "%s" failed with code %d%s' %
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001302 (script, cmd_result.returncode,
Jon Salz3ee59de2012-08-18 13:54:22 +08001303 ':\n' + stdout if stdout else ''))
1304
1305
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001306def _check_project_prefix(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -05001307 """Require the commit message have a project specific prefix as needed."""
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001308
1309 files = _get_affected_files(commit, relative=True)
1310 prefix = os.path.commonprefix(files)
1311 prefix = os.path.dirname(prefix)
1312
1313 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07001314 if not prefix:
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001315 return
1316
1317 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07001318
1319 # The common files may all be within a subdirectory of the main project
1320 # directory, so walk up the tree until we find an alias file.
1321 # _get_affected_files() should return relative paths, but check against '/' to
1322 # ensure that this loop terminates even if it receives an absolute path.
1323 while prefix and prefix != '/':
1324 alias_file = os.path.join(prefix, '.project_alias')
1325
1326 # If an alias exists, use it.
1327 if os.path.isfile(alias_file):
1328 project_name = osutils.ReadFile(alias_file).strip()
1329
1330 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001331
1332 if not _get_commit_desc(commit).startswith(project_name + ': '):
1333 return HookFailure('The commit title for changes affecting only %s'
1334 ' should start with \"%s: \"'
1335 % (project_name, project_name))
1336
1337
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001338def _check_exec_files(_project, commit):
1339 """Make +x bits on files."""
1340 # List of files that should never be +x.
1341 NO_EXEC = (
1342 'ChangeLog*',
1343 'COPYING',
1344 'make.conf',
1345 'make.defaults',
1346 'Manifest',
1347 'OWNERS',
1348 'package.use',
1349 'package.keywords',
1350 'package.mask',
1351 'parent',
1352 'README',
1353 'TODO',
1354 '.gitignore',
1355 '*.[achly]',
1356 '*.[ch]xx',
1357 '*.boto',
1358 '*.cc',
1359 '*.cfg',
1360 '*.conf',
1361 '*.config',
1362 '*.cpp',
1363 '*.css',
1364 '*.ebuild',
1365 '*.eclass',
1366 '*.gyp',
1367 '*.gypi',
1368 '*.htm',
1369 '*.html',
1370 '*.ini',
1371 '*.js',
1372 '*.json',
1373 '*.md',
1374 '*.mk',
1375 '*.patch',
1376 '*.policy',
1377 '*.proto',
1378 '*.raw',
1379 '*.rules',
1380 '*.service',
1381 '*.target',
1382 '*.txt',
1383 '*.xml',
1384 '*.yaml',
1385 )
1386
1387 def FinalName(obj):
1388 # If the file is being deleted, then the dst_file is not set.
1389 if obj.dst_file is None:
1390 return obj.src_file
1391 else:
1392 return obj.dst_file
1393
1394 bad_files = []
1395 files = _get_affected_files(commit, relative=True, full_details=True)
1396 for f in files:
1397 mode = int(f.dst_mode, 8)
1398 if not mode & 0o111:
1399 continue
1400 name = FinalName(f)
1401 for no_exec in NO_EXEC:
1402 if fnmatch.fnmatch(name, no_exec):
1403 bad_files.append(name)
1404 break
1405
1406 if bad_files:
1407 return HookFailure('These files should not be executable. '
1408 'Please `chmod -x` them.', bad_files)
1409
1410
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001411# Base
1412
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001413# A list of hooks which are not project specific and check patch description
1414# (as opposed to patch body).
1415_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07001416 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07001417 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07001418 _check_change_has_test_field,
1419 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001420 _check_commit_message_style,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001421 _check_change_is_contribution,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001422]
1423
1424
1425# A list of hooks that are not project-specific
1426_COMMON_HOOKS = [
Aviv Keshet5ac59522017-01-31 14:28:27 -08001427 _check_cq_ini_well_formed,
1428 _check_cros_license,
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001429 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05001430 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001431 _check_ebuild_licenses,
Mike Frysingercd363c82014-02-01 05:20:18 -05001432 _check_ebuild_virtual_pv,
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001433 _check_exec_files,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001434 _check_for_uprev,
Rahul Chaudhry09f61372015-07-31 17:14:26 -07001435 _check_gofmt,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001436 _check_layout_conf,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001437 _check_no_long_lines,
1438 _check_no_stray_whitespace,
Ryan Cui9b651632011-05-11 11:38:58 -07001439 _check_no_tabs,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001440 _check_portage_make_use_var,
Aviv Keshet5ac59522017-01-31 14:28:27 -08001441 _check_tabbed_indents,
Ryan Cui9b651632011-05-11 11:38:58 -07001442]
Ryan Cuiec4d6332011-05-02 14:15:25 -07001443
Ryan Cui1562fb82011-05-09 11:01:31 -07001444
Ryan Cui9b651632011-05-11 11:38:58 -07001445# A dictionary of project-specific hooks(callbacks), indexed by project name.
1446# dict[project] = [callback1, callback2]
1447_PROJECT_SPECIFIC_HOOKS = {
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001448 "chromiumos/platform2": [_check_project_prefix],
Mike Frysingeraf891292015-03-25 19:46:53 -04001449 "chromiumos/third_party/kernel": [_kernel_configcheck],
1450 "chromiumos/third_party/kernel-next": [_kernel_configcheck],
Ryan Cui9b651632011-05-11 11:38:58 -07001451}
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001452
Ryan Cui1562fb82011-05-09 11:01:31 -07001453
Ryan Cui9b651632011-05-11 11:38:58 -07001454# A dictionary of flags (keys) that can appear in the config file, and the hook
Mike Frysinger3554bc92015-03-11 04:59:21 -04001455# that the flag controls (value).
1456_HOOK_FLAGS = {
Mike Frysingera7642f52015-03-25 18:31:42 -04001457 'checkpatch_check': _run_checkpatch,
Ryan Cui9b651632011-05-11 11:38:58 -07001458 'stray_whitespace_check': _check_no_stray_whitespace,
Mike Frysingerff6c7d62015-03-24 13:49:46 -04001459 'json_check': _run_json_check,
Ryan Cui9b651632011-05-11 11:38:58 -07001460 'long_line_check': _check_no_long_lines,
Alex Deymof5792ce2015-08-24 22:50:08 -07001461 'cros_license_check': _check_cros_license,
1462 'aosp_license_check': _check_aosp_license,
Ryan Cui9b651632011-05-11 11:38:58 -07001463 'tab_check': _check_no_tabs,
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08001464 'tabbed_indent_required_check': _check_tabbed_indents,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001465 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001466 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07001467 'bug_field_check': _check_change_has_bug_field,
1468 'test_field_check': _check_change_has_test_field,
Steve Fung49ec7e92015-03-23 16:07:12 -07001469 'manifest_check': _check_manifests,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001470 'contribution_check': _check_change_is_contribution,
Ryan Cui9b651632011-05-11 11:38:58 -07001471}
1472
1473
Mike Frysinger3554bc92015-03-11 04:59:21 -04001474def _get_override_hooks(config):
1475 """Returns a set of hooks controlled by the current project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001476
1477 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08001478
1479 Args:
1480 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001481 """
1482 SECTION = 'Hook Overrides'
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001483 SECTION_OPTIONS = 'Hook Overrides Options'
Jon Salz3ee59de2012-08-18 13:54:22 +08001484 if not config.has_section(SECTION):
Mike Frysinger3554bc92015-03-11 04:59:21 -04001485 return set(), set()
Ryan Cui9b651632011-05-11 11:38:58 -07001486
Mike Frysinger3554bc92015-03-11 04:59:21 -04001487 valid_keys = set(_HOOK_FLAGS.iterkeys())
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001488 hooks = _HOOK_FLAGS.copy()
Mike Frysinger3554bc92015-03-11 04:59:21 -04001489
1490 enable_flags = []
Ryan Cui9b651632011-05-11 11:38:58 -07001491 disable_flags = []
Jon Salz3ee59de2012-08-18 13:54:22 +08001492 for flag in config.options(SECTION):
Mike Frysinger3554bc92015-03-11 04:59:21 -04001493 if flag not in valid_keys:
1494 raise ValueError('Error: unknown key "%s" in hook section of "%s"' %
1495 (flag, _CONFIG_FILE))
1496
Ryan Cui9b651632011-05-11 11:38:58 -07001497 try:
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001498 enabled = config.getboolean(SECTION, flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001499 except ValueError as e:
Mike Frysinger3554bc92015-03-11 04:59:21 -04001500 raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' %
1501 (flag, _CONFIG_FILE, e))
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001502 if enabled:
1503 enable_flags.append(flag)
1504 else:
1505 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001506
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001507 # See if this hook has custom options.
1508 if enabled:
1509 try:
1510 options = config.get(SECTION_OPTIONS, flag)
1511 hooks[flag] = functools.partial(hooks[flag], options=options.split())
1512 except (ConfigParser.NoOptionError, ConfigParser.NoSectionError):
1513 pass
1514
1515 enabled_hooks = set(hooks[x] for x in enable_flags)
1516 disabled_hooks = set(hooks[x] for x in disable_flags)
Mike Frysinger3554bc92015-03-11 04:59:21 -04001517 return enabled_hooks, disabled_hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001518
1519
Jon Salz3ee59de2012-08-18 13:54:22 +08001520def _get_project_hook_scripts(config):
1521 """Returns a list of project-specific hook scripts.
1522
1523 Args:
1524 config: A ConfigParser for the project's config file.
1525 """
1526 SECTION = 'Hook Scripts'
1527 if not config.has_section(SECTION):
1528 return []
1529
1530 hook_names_values = config.items(SECTION)
1531 hook_names_values.sort(key=lambda x: x[0])
1532 return [x[1] for x in hook_names_values]
1533
1534
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001535def _get_project_hooks(project, presubmit):
Ryan Cui9b651632011-05-11 11:38:58 -07001536 """Returns a list of hooks that need to be run for a project.
1537
1538 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001539
1540 Args:
1541 project: A string, name of the project.
1542 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui9b651632011-05-11 11:38:58 -07001543 """
Jon Salz3ee59de2012-08-18 13:54:22 +08001544 config = ConfigParser.RawConfigParser()
1545 try:
1546 config.read(_CONFIG_FILE)
1547 except ConfigParser.Error:
1548 # Just use an empty config file
1549 config = ConfigParser.RawConfigParser()
1550
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001551 if presubmit:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001552 hooks = _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001553 else:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001554 hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001555
Mike Frysinger3554bc92015-03-11 04:59:21 -04001556 enabled_hooks, disabled_hooks = _get_override_hooks(config)
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001557 hooks = [hook for hook in hooks if hook not in disabled_hooks]
1558
1559 # If a list is both in _COMMON_HOOKS and also enabled explicitly through an
1560 # override, keep the override only. Note that the override may end up being
1561 # a functools.partial, in which case we need to extract the .func to compare
1562 # it to the common hooks.
1563 unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks]
1564 hooks = [hook for hook in hooks if hook not in unwrapped_hooks]
1565
1566 hooks = list(enabled_hooks) + hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001567
1568 if project in _PROJECT_SPECIFIC_HOOKS:
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001569 hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project]
1570 if hook not in disabled_hooks)
Ryan Cui9b651632011-05-11 11:38:58 -07001571
Jon Salz3ee59de2012-08-18 13:54:22 +08001572 for script in _get_project_hook_scripts(config):
1573 hooks.append(functools.partial(_run_project_hook_script, script))
1574
Ryan Cui9b651632011-05-11 11:38:58 -07001575 return hooks
1576
1577
Alex Deymo643ac4c2015-09-03 10:40:50 -07001578def _run_project_hooks(project_name, proj_dir=None,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001579 commit_list=None, presubmit=False):
Ryan Cui1562fb82011-05-09 11:01:31 -07001580 """For each project run its project specific hook from the hooks dictionary.
1581
1582 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001583 project_name: The name of project to run hooks for.
Doug Anderson44a644f2011-11-02 10:37:37 -07001584 proj_dir: If non-None, this is the directory the project is in. If None,
1585 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07001586 commit_list: A list of commits to run hooks against. If None or empty list
1587 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001588 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui1562fb82011-05-09 11:01:31 -07001589
1590 Returns:
1591 Boolean value of whether any errors were ecountered while running the hooks.
1592 """
Doug Anderson44a644f2011-11-02 10:37:37 -07001593 if proj_dir is None:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001594 proj_dirs = _run_command(
1595 ['repo', 'forall', project_name, '-c', 'pwd']).split()
David James2edd9002013-10-11 14:09:19 -07001596 if len(proj_dirs) == 0:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001597 print('%s cannot be found.' % project_name, file=sys.stderr)
David James2edd9002013-10-11 14:09:19 -07001598 print('Please specify a valid project.', file=sys.stderr)
1599 return True
1600 if len(proj_dirs) > 1:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001601 print('%s is associated with multiple directories.' % project_name,
David James2edd9002013-10-11 14:09:19 -07001602 file=sys.stderr)
1603 print('Please specify a directory to help disambiguate.', file=sys.stderr)
1604 return True
1605 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07001606
Ryan Cuiec4d6332011-05-02 14:15:25 -07001607 pwd = os.getcwd()
1608 # hooks assume they are run from the root of the project
1609 os.chdir(proj_dir)
1610
Alex Deymo643ac4c2015-09-03 10:40:50 -07001611 remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref',
1612 '--symbolic-full-name', '@{u}']).strip()
1613 if not remote_branch:
1614 print('Your project %s doesn\'t track any remote repo.' % project_name,
1615 file=sys.stderr)
1616 remote = None
1617 else:
1618 remote, _branch = remote_branch.split('/', 1)
1619
1620 project = Project(name=project_name, dir=proj_dir, remote=remote)
1621
Doug Anderson14749562013-06-26 13:38:29 -07001622 if not commit_list:
1623 try:
1624 commit_list = _get_commits()
1625 except VerifyException as e:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001626 PrintErrorForProject(project.name, HookFailure(str(e)))
Doug Anderson14749562013-06-26 13:38:29 -07001627 os.chdir(pwd)
1628 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07001629
Alex Deymo643ac4c2015-09-03 10:40:50 -07001630 hooks = _get_project_hooks(project.name, presubmit)
Ryan Cui1562fb82011-05-09 11:01:31 -07001631 error_found = False
Ryan Cuifa55df52011-05-06 11:16:55 -07001632 for commit in commit_list:
Ryan Cui1562fb82011-05-09 11:01:31 -07001633 error_list = []
Ryan Cui9b651632011-05-11 11:38:58 -07001634 for hook in hooks:
Ryan Cui1562fb82011-05-09 11:01:31 -07001635 hook_error = hook(project, commit)
1636 if hook_error:
1637 error_list.append(hook_error)
1638 error_found = True
1639 if error_list:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001640 PrintErrorsForCommit(project.name, commit, _get_commit_desc(commit),
Ryan Cui1562fb82011-05-09 11:01:31 -07001641 error_list)
Don Garrettdba548a2011-05-05 15:17:14 -07001642
Ryan Cuiec4d6332011-05-02 14:15:25 -07001643 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07001644 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001645
Mike Frysingerae409522014-02-01 03:16:11 -05001646
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001647# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07001648
Ryan Cui1562fb82011-05-09 11:01:31 -07001649
Mike Frysingerae409522014-02-01 03:16:11 -05001650def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08001651 """Main function invoked directly by repo.
1652
1653 This function will exit directly upon error so that repo doesn't print some
1654 obscure error message.
1655
1656 Args:
1657 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07001658 worktree_list: A list of directories. It should be the same length as
1659 project_list, so that each entry in project_list matches with a directory
1660 in worktree_list. If None, we will attempt to calculate the directories
1661 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08001662 kwargs: Leave this here for forward-compatibility.
1663 """
Ryan Cui1562fb82011-05-09 11:01:31 -07001664 found_error = False
David James2edd9002013-10-11 14:09:19 -07001665 if not worktree_list:
1666 worktree_list = [None] * len(project_list)
1667 for project, worktree in zip(project_list, worktree_list):
1668 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07001669 found_error = True
1670
Mike Frysingerae409522014-02-01 03:16:11 -05001671 if found_error:
Ryan Cui1562fb82011-05-09 11:01:31 -07001672 msg = ('Preupload failed due to errors in project(s). HINTS:\n'
Ryan Cui9b651632011-05-11 11:38:58 -07001673 '- To disable some source style checks, and for other hints, see '
1674 '<checkout_dir>/src/repohooks/README\n'
1675 '- To upload only current project, run \'repo upload .\'')
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04001676 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07001677 sys.exit(1)
Anush Elangovan63afad72011-03-23 00:41:27 -07001678
Ryan Cui1562fb82011-05-09 11:01:31 -07001679
Doug Anderson44a644f2011-11-02 10:37:37 -07001680def _identify_project(path):
1681 """Identify the repo project associated with the given path.
1682
1683 Returns:
1684 A string indicating what project is associated with the path passed in or
1685 a blank string upon failure.
1686 """
1687 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001688 redirect_stderr=True, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07001689
1690
Mike Frysinger55f85b52014-12-18 14:45:21 -05001691def direct_main(argv):
Doug Anderson44a644f2011-11-02 10:37:37 -07001692 """Run hooks directly (outside of the context of repo).
1693
Doug Anderson44a644f2011-11-02 10:37:37 -07001694 Args:
Mike Frysinger55f85b52014-12-18 14:45:21 -05001695 argv: The command line args to process
Doug Anderson44a644f2011-11-02 10:37:37 -07001696
1697 Returns:
1698 0 if no pre-upload failures, 1 if failures.
1699
1700 Raises:
1701 BadInvocation: On some types of invocation errors.
1702 """
Mike Frysinger66142932014-12-18 14:55:57 -05001703 parser = commandline.ArgumentParser(description=__doc__)
1704 parser.add_argument('--dir', default=None,
1705 help='The directory that the project lives in. If not '
1706 'specified, use the git project root based on the cwd.')
1707 parser.add_argument('--project', default=None,
1708 help='The project repo path; this can affect how the '
1709 'hooks get run, since some hooks are project-specific. '
1710 'For chromite this is chromiumos/chromite. If not '
1711 'specified, the repo tool will be used to figure this '
1712 'out based on the dir.')
1713 parser.add_argument('--rerun-since', default=None,
1714 help='Rerun hooks on old commits since the given date. '
1715 'The date should match git log\'s concept of a date. '
1716 'e.g. 2012-06-20. This option is mutually exclusive '
1717 'with --pre-submit.')
1718 parser.add_argument('--pre-submit', action="store_true",
1719 help='Run the check against the pending commit. '
1720 'This option should be used at the \'git commit\' '
1721 'phase as opposed to \'repo upload\'. This option '
1722 'is mutually exclusive with --rerun-since.')
1723 parser.add_argument('commits', nargs='*',
1724 help='Check specific commits')
1725 opts = parser.parse_args(argv)
Doug Anderson44a644f2011-11-02 10:37:37 -07001726
Doug Anderson14749562013-06-26 13:38:29 -07001727 if opts.rerun_since:
Mike Frysinger66142932014-12-18 14:55:57 -05001728 if opts.commits:
Doug Anderson14749562013-06-26 13:38:29 -07001729 raise BadInvocation('Can\'t pass commits and use rerun-since: %s' %
Mike Frysinger66142932014-12-18 14:55:57 -05001730 ' '.join(opts.commits))
Doug Anderson14749562013-06-26 13:38:29 -07001731
1732 cmd = ['git', 'log', '--since="%s"' % opts.rerun_since, '--pretty=%H']
1733 all_commits = _run_command(cmd).splitlines()
1734 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
1735
1736 # Eliminate chrome-bot commits but keep ordering the same...
1737 bot_commits = set(bot_commits)
Mike Frysinger66142932014-12-18 14:55:57 -05001738 opts.commits = [c for c in all_commits if c not in bot_commits]
Doug Anderson14749562013-06-26 13:38:29 -07001739
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001740 if opts.pre_submit:
1741 raise BadInvocation('rerun-since and pre-submit can not be '
1742 'used together')
1743 if opts.pre_submit:
Mike Frysinger66142932014-12-18 14:55:57 -05001744 if opts.commits:
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001745 raise BadInvocation('Can\'t pass commits and use pre-submit: %s' %
Mike Frysinger66142932014-12-18 14:55:57 -05001746 ' '.join(opts.commits))
1747 opts.commits = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07001748
1749 # Check/normlaize git dir; if unspecified, we'll use the root of the git
1750 # project from CWD
1751 if opts.dir is None:
1752 git_dir = _run_command(['git', 'rev-parse', '--git-dir'],
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001753 redirect_stderr=True).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07001754 if not git_dir:
1755 raise BadInvocation('The current directory is not part of a git project.')
1756 opts.dir = os.path.dirname(os.path.abspath(git_dir))
1757 elif not os.path.isdir(opts.dir):
1758 raise BadInvocation('Invalid dir: %s' % opts.dir)
1759 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
1760 raise BadInvocation('Not a git directory: %s' % opts.dir)
1761
1762 # Identify the project if it wasn't specified; this _requires_ the repo
1763 # tool to be installed and for the project to be part of a repo checkout.
1764 if not opts.project:
1765 opts.project = _identify_project(opts.dir)
1766 if not opts.project:
1767 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
1768
Doug Anderson14749562013-06-26 13:38:29 -07001769 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Mike Frysinger66142932014-12-18 14:55:57 -05001770 commit_list=opts.commits,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001771 presubmit=opts.pre_submit)
Doug Anderson44a644f2011-11-02 10:37:37 -07001772 if found_error:
1773 return 1
1774 return 0
1775
1776
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07001777if __name__ == '__main__':
Mike Frysinger55f85b52014-12-18 14:45:21 -05001778 sys.exit(direct_main(sys.argv[1:]))