| commit | 7ca67f609784ad277517a416bf86b7fdd679fa3d | [log] [tgz] |
|---|---|---|
| author | Dmitry Torokhov <dtor@chromium.org> | Mon Feb 22 16:01:59 2021 -0800 |
| committer | Jack Neus <jackneus@google.com> | Wed Sep 22 16:25:58 2021 +0000 |
| tree | ab19ba9b885896d2ba22ee457b1a3eda7e9aac8e | |
| parent | 24a62028395c3136ee216f85939752c7a81097b1 [diff] |
system_api: allocate "not enough space" status for VM concierge To allow clients better handle scenarios with not enough storage space let's define DISK_STATUS_NOT_ENOUGH_SPACE status for disk image operations. BUG=b:179455689 TEST=CQ Change-Id: Idfdc9881c4ac7d63bc689d810bfcbc721a3bb0b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2713193 Reviewed-by: Stephen Barber <smbarber@chromium.org> Tested-by: Dmitry Torokhov <dtor@chromium.org> Commit-Queue: Dmitry Torokhov <dtor@chromium.org> NOKEYCHECK=True GitOrigin-RevId: 8ad5817e856177dfae005848ab9ff5512c7b277b
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. "Required is Forever" and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.