| commit | e55c51aed157f23c17eeba211d358e1e142c9864 | [log] [tgz] |
|---|---|---|
| author | Allen Webb <allenwebb@google.com> | Wed Dec 23 18:51:56 2020 -0600 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Dec 29 12:46:08 2020 -0800 |
| tree | 387973a8bbed27df7295f540ee9684a0d5913a6c | |
| parent | 53cef77b6e86796000e3e94b3ebe020253d443ae [diff] |
Renamed chromeos_dbus_bindings to chromeos-dbus-bindings.
This also bumps the version of the system_api crate to 0.24.53.
BUG=chromium:1161583
TEST=./build_packages --board=${BOARD}
Cq-Depend: chromium:2602782
Change-Id: If7f5324bc9fb2bfe5c368a4e11ba702bde9eee7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2602582
Reviewed-by: Nicole Anderson-Au <nvaa@google.com>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Allen Webb <allenwebb@google.com>
Tested-by: Allen Webb <allenwebb@google.com>
GitOrigin-RevId: be79e6e1f1d7dcefb52f654027b1096266528ca4
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. "Required is Forever" and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.