| commit | f506e569b776345e254ac800b5b67b4789c3fc85 | [log] [tgz] |
|---|---|---|
| author | David Greenaway <dgreenaway@google.com> | Mon Nov 21 16:12:12 2022 +1100 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Nov 24 14:43:22 2022 -0800 |
| tree | a6721d6fb9cadeb0c2a28cb9b21d0b4121fae0db | |
| parent | 1e068798f44ee31a62d5a718a3e8d564efbc571f [diff] |
power: Add `SetKeyboardBrightness` DBus call Add a powerd DBus call to allow clients to set the brightness of the keyboard backlight. No actual implementation yet, just the DBus boilerplate and a simple test to exercise the call. BUG=b:254292590 TEST=`cros_workon_make --board=$BOARD --test chromeos-base/power_manager` Change-Id: I933ef3412c025261aa63b83c19d1ad7ca114b3f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/4041771 Commit-Queue: David Greenaway <dgreenaway@google.com> Tested-by: David Greenaway <dgreenaway@google.com> Reviewed-by: Mengqi Guo <mqg@chromium.org> Reviewed-by: Phil Kiossoglou <pkiossoglou@chromium.org> NOKEYCHECK=True GitOrigin-RevId: 20bf4f1b0258779074eeac7db0eba01f90a62bac
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. "Required is Forever" and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.