| commit | e658b4c35a333ea1fb025b5907971e608e63088f | [log] [tgz] |
|---|---|---|
| author | Hardik Goyal <hardikgoyal@google.com> | Wed Jan 18 15:05:49 2023 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Jan 19 01:49:31 2023 -0800 |
| tree | 3d13016d06a72fe5aef9491bfef48d5ff7296abc | |
| parent | 74799e2b19b31b823f8fc1573eb24bb1deadddef [diff] |
cryptohome: Remove Add/ Update Credential from AuthSession BUG=b:261090735 TEST=FEATURES=test emerge-zork cryptohome Change-Id: I77d8002b348227f632bf52ee2872668648ab62d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/4179315 Tested-by: Hardik Goyal <hardikgoyal@chromium.org> Reviewed-by: John Admanski <jadmanski@chromium.org> Commit-Queue: Hardik Goyal <hardikgoyal@chromium.org> NOKEYCHECK=True GitOrigin-RevId: 60031b2d1003974e511075ce755e0779a1e8fc8a
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. "Required is Forever" and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.