| commit | b4314bb7f7fbecb4f1cb18f99ed2af89c6d20b19 | [log] [tgz] |
|---|---|---|
| author | Jintao Lin <jintaolin@chromium.org> | Wed Jan 11 23:48:32 2023 +0000 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Jan 16 14:18:07 2023 -0800 |
| tree | 08bea982d1191d04a23a0c69169e5042f6e2d8b7 | |
| parent | 3f919062c452d4420abfdb6becbdfc475fa0e163 [diff] |
shill: Tethering: Remove channel in TetheringStatus which is not used by Chrome BUG=b:235763297 TEST=FEATURES=test emerge-$BOARD shill Change-Id: Ie2867a1768b239a775c1e598730d1d2bc0528e57 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/4158837 Tested-by: Jintao Lin <jintaolin@chromium.org> Commit-Queue: Jintao Lin <jintaolin@chromium.org> Reviewed-by: Matthew Wang <matthewmwang@chromium.org> NOKEYCHECK=True GitOrigin-RevId: 48b6ed6eef2f175f1aa02826202c34df27de64be
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. "Required is Forever" and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.