commit | a05559581a38748c6669a3ea749f80bf94cbc65c | [log] [tgz] |
---|---|---|
author | Eric Wang <qianwan@google.com> | Wed Jan 04 16:24:30 2023 -0800 |
committer | Copybara-Service <copybara-worker@google.com> | Thu Jan 05 07:14:59 2023 -0800 |
tree | f480bfb4ddbd62ebc09eeeb424cae799600c6148 | |
parent | 8f4d2b5e1110dae61881acaa8c9ce736a5ef9873 [diff] |
system_api: Add the churn enums in private computing use case. Add churn enum values in private_computing_service proto. BUG=chromium:1405080 TEST=USE=test emerge-hatch chromeos-base/system_api Change-Id: Ied07a2e49ff5399e7992902bd9e38086a638e0f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/4137196 Reviewed-by: Hirthanan Subenderan <hirthanan@google.com> Commit-Queue: Eric Wang <qianwan@google.com> Tested-by: Eric Wang <qianwan@google.com> NOKEYCHECK=True GitOrigin-RevId: 033a5d9d2f9c4bf4762eb9d171632e1a6ef8a730
This directory (platform2/system_api
) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. "Required is Forever" and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.