| commit | 8f45ad4bdd176f6e656d05e11bbab0031026fabc | [log] [tgz] |
|---|---|---|
| author | Jie Jiang <jiejiang@chromium.org> | Fri Jan 27 03:10:18 2023 +0000 |
| committer | Copybara-Service <copybara-worker@google.com> | Sun Jan 29 17:47:13 2023 -0800 |
| tree | 15cd088c8133b59038f79d330e0c09758f9dfced | |
| parent | 24e9b32c89b50d9d67acbc65f9f03cc71275c4de [diff] |
shill: vpn: Add WireGuard.IPAddress in service-api.txt
No functional changes.
BUG=b:262662603
TEST=FEATURES="test" emerge-${BOARD} chromeos-base/system_api shill
Change-Id: I7ad3c290ae1a146846d60a999751a7975d05255e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/4196462
Reviewed-by: Taoyu Li <taoyl@chromium.org>
Tested-by: Jie Jiang <jiejiang@chromium.org>
Reviewed-by: Hugo Benichi <hugobenichi@google.com>
Commit-Queue: Jie Jiang <jiejiang@chromium.org>
NOKEYCHECK=True
GitOrigin-RevId: 3101c87ccd876b5881a85d98f2dc7ab46a6b65e9
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. "Required is Forever" and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.