| commit | 48281573dd5b83ed380affe6be11716f2be36e89 | [log] [tgz] |
|---|---|---|
| author | Anton Swifton <swifton@google.com> | Thu Nov 24 02:27:32 2022 +0000 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Nov 28 13:06:46 2022 -0800 |
| tree | 87efd4ab77d225c1cec1a5f06405662c9df0de07 | |
| parent | 1e6ab7a91ba4462329c4a4b9aa1423298bff9844 [diff] |
rgbkbd: Add SetZoneColor stub API BUG=b:259589687 TEST=local Change-Id: Ic23e7d167ed082fe806251cc00bbafa55fecd328 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/4053891 Tested-by: Anton Swifton <swifton@google.com> Reviewed-by: David Padlipsky <dpad@google.com> Commit-Queue: Anton Swifton <swifton@google.com> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> NOKEYCHECK=True GitOrigin-RevId: aacd4ee2165a0e92a95e6239b8c45c1c712b468e
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. "Required is Forever" and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.