| commit | 3285592d6af0dec278d5874e37874fb974bb1a84 | [log] [tgz] |
|---|---|---|
| author | Tim Van Patten <timvp@google.com> | Mon Nov 14 14:47:36 2022 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Nov 30 12:20:01 2022 -0800 |
| tree | 54f2a7ae50550fd54f97b5e6edccd0f0cd8f96fc | |
| parent | 8d96a5a90c68f343faa23dbc7267a8e532fbe031 [diff] |
power_manager: Add dbus method HandleGetTabletModeMethod() Add dbus method HandleGetTabletModeMethod(), which returns powerd's current TabletMode status. This will be used to add a tast test that validates EC tabletmode notifications are received and processed by powerd. BUG=b:259134792 TEST=dbus-send --system --print-reply=literal --type=method_call \ --dest=org.chromium.PowerManager /org/chromium/PowerManager \ org.chromium.PowerManager.GetTabletMode TEST=tast run <IP> power.TabletModeNotification Cq-Depend: chromium:4026790 Change-Id: I2ea0e16272dddb23be27870899925121c25d7ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/4020834 Reviewed-by: Eric Caruso <ejcaruso@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Raul Rangel <rrangel@chromium.org> Tested-by: Tim Van Patten <timvp@google.com> NOKEYCHECK=True GitOrigin-RevId: addb864cd19558f7a37b428b72a4b969023ab7d5
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. "Required is Forever" and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.