| commit | 2021cee6746a23db9562062c1aaa165a6f36f506 | [log] [tgz] |
|---|---|---|
| author | John Admanski <jadmanski@google.com> | Fri Jan 20 13:50:04 2023 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Jan 23 15:31:08 2023 -0800 |
| tree | fac93b343900c986a8dd1ab1b89ad434f9d6bdb3 | |
| parent | e0bfd3d75917adfa22e401805f9f9793cec82559 [diff] |
system_api: Remove AuthenticateAuthSession References to this are now gone from chromium and so with the cryptohome implementation and test references also gone, we can delete this. BUG=b:261090370 TEST=emerge-$BOARD cryptohome-client chromeos-base/system_api cryptohome Change-Id: I07969710df85479d029b82f15c07897f736bbd66 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/4183457 Commit-Queue: John Admanski <jadmanski@chromium.org> Tested-by: John Admanski <jadmanski@chromium.org> Reviewed-by: Hardik Goyal <hardikgoyal@chromium.org> NOKEYCHECK=True GitOrigin-RevId: 9e4386fad806f1f8a5f3d6c74b8656119912d60d
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. "Required is Forever" and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.