| commit | 1ee4534d0cbd571431dc8d65d84495e541f4dd57 | [log] [tgz] |
|---|---|---|
| author | Nigel Tao <nigeltao@chromium.org> | Fri Nov 04 17:02:28 2022 +1100 |
| committer | Copybara-Service <copybara-worker@google.com> | Sat Nov 12 22:50:40 2022 -0800 |
| tree | 9b34fdbf19af2ed208b92c867d4405b63e280d54 | |
| parent | ca1cd5d1bb30fbbd5c8b3eddeac77f0892b38516 [diff] |
system_api: update FuseBox D-Bus names This removes the "debug method" names. Debugging information is now exposed as a chrome://files-internals/ WebUI page instead of over D-Bus. This adds Read2 and Write2 method names. We are considering moving from path (string) based read/write APIs to handle (integer) based ones, where a handle is analogous to a file descriptor. This deletes the FuseBoxReverseService names, unused since crrev.com/c/3995289 This deletes the "dummy://moniker" names, unused since crrev.com/c/4005705 BUG=b:255520076 TEST=CQ Change-Id: I769af57b0c8114be644e38a59e201bca8dcfbd42 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/4005426 Tested-by: Nigel Tao <nigeltao@chromium.org> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> Reviewed-by: Ben Reich <benreich@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> NOKEYCHECK=True GitOrigin-RevId: 32c27b133df30494bef344dc4e7811775ce4eb74
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. "Required is Forever" and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.