| commit | 1d6f77248fbfa6a6e54eb0ac1c90e202a686f715 | [log] [tgz] |
|---|---|---|
| author | Chuwei He <chuweih@google.com> | Fri Nov 11 16:52:15 2022 +0900 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Jan 12 23:21:50 2023 -0800 |
| tree | 4675280567f5eb6644b7b5b3e36eba5835da66eb | |
| parent | 7c6624ef8db0c9c060f3210e09aaf27b714f71d6 [diff] |
shill: retrieve real link speed for Ethernet, WiFi, and cellular Currently link speed in ARC in a static populated fake value. This patch provides real link speed value for ARC by retrieving them in shill and propagate to back to ARC. related patch in Chrome: https://crrev.com/c/4080013 related patch in ARC: http://ag/20661030 BUG=b:242589950 TEST=Log getConnectionInfo.getLinkSpeed() on ARC side by testing on real hardware (WiFi, ethernet, cellular) unit test: (chroot) cros_run_unit_tests --board ${BOARD} --packages chromeos-base/shill Change-Id: Ia3b8f0660fbae6f27122fe69d055ea130e3aa954 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/4022562 Reviewed-by: Eric Caruso <ejcaruso@chromium.org> Tested-by: Chuwei He <chuweih@google.com> Reviewed-by: Nicolas Norvez <norvez@chromium.org> Reviewed-by: Hugo Benichi <hugobenichi@google.com> Reviewed-by: David Ruth <druth@chromium.org> Reviewed-by: Matthew Wang <matthewmwang@chromium.org> Commit-Queue: Chuwei He <chuweih@google.com> NOKEYCHECK=True GitOrigin-RevId: 4415a8ba2ddca1ed83fadac50c01d38ea723cfab
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. "Required is Forever" and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.