commit | 10a77d0d9d2f15ff5c2bb52fef83e86bf317e75b | [log] [tgz] |
---|---|---|
author | Jae Hoon Kim <kimjae@chromium.org> | Wed Dec 21 21:09:25 2022 +0000 |
committer | Copybara-Service <copybara-worker@google.com> | Wed Jan 04 07:11:28 2023 -0800 |
tree | dcb7c4a23ec1b34f5fc11e1e7577b00a51380741 | |
parent | 81ae5becd2b8b69a59396759c6d2677bddd59b28 [diff] |
system_api: Add `force_fw_update` field .. to UpdateCheckParams to allow clients/callers into update_engine to force a FW update. BUG=b:228121045 TEST=emerge Change-Id: I4fe391fac328841046c7a88c106a56c03b8d408c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/4119740 Reviewed-by: Henry Barnor <hbarnor@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> Tested-by: Jae Hoon Kim <kimjae@chromium.org> Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> NOKEYCHECK=True GitOrigin-RevId: cfa626a0843f32389c6a0134277289aeab5b7aab
This directory (platform2/system_api
) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. "Required is Forever" and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.