commit a0011d89287b4bdcb8fcc7f07071be1e94c20f90
author Ben Chan <benchan@chromium.org> Tue May 13 00:19:29 2014 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Wed Jun 18 23:44:04 2014 +0000
tree ad296554d258a44aad511faa75c11505593e104f
parent 4ca36ad3f6664d3ba464c4022cd1501c310c21a4

debugd: Fix coding style and cpplint issues.

BUG=chromium:385849
TEST=`FEATURES=test emerge-$BOARD platform2`
TEST=`cpplint.py --root=src --filter=-build/include src/{*.h,*.cc,*/*.cc}`

Change-Id: Ia2475d6ee287dc727c3b2ffe139e9cc8bfe2e2e5
Reviewed-on: https://chromium-review.googlesource.com/204391
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>

debugd/src/subprocess_tool.cc

diff --git a/debugd/src/subprocess_tool.cc b/debugd/src/subprocess_tool.cc
index 1adeca0..a409455 100644
--- a/debugd/src/subprocess_tool.cc
+++ b/debugd/src/subprocess_tool.cc
@@ -4,15 +4,19 @@
 
 #include "subprocess_tool.h"
 
-#include <dbus-c++/dbus.h>
 #include <signal.h>
 
+#include <dbus-c++/dbus.h>
+
 #include "process_with_id.h"
 
 namespace debugd {
 
-const char* kErrorNoSuchProcess =
-    "org.chromium.debugd.error.NoSuchProcess";
+namespace {
+
+const char kErrorNoSuchProcess[] = "org.chromium.debugd.error.NoSuchProcess";
+
+}  // namespace
 
 SubprocessTool::SubprocessTool() { }
 SubprocessTool::~SubprocessTool() { }
@@ -27,9 +31,9 @@
   return p;
 }
 
-void SubprocessTool::Stop(const std::string& handle, DBus::Error& error) {
+void SubprocessTool::Stop(const std::string& handle, DBus::Error* error) {
   if (processes_.count(handle) != 1) {
-    error.set(kErrorNoSuchProcess, handle.c_str());
+    error->set(kErrorNoSuchProcess, handle.c_str());
     return;
   }
   ProcessWithId* p = processes_[handle];
@@ -39,4 +43,4 @@
   delete p;
 }
 
-};  // namespace debugd
+}  // namespace debugd