debugd: Fix coding style and cpplint issues.
BUG=chromium:385849
TEST=`FEATURES=test emerge-$BOARD platform2`
TEST=`cpplint.py --root=src --filter=-build/include src/{*.h,*.cc,*/*.cc}`
Change-Id: Ia2475d6ee287dc727c3b2ffe139e9cc8bfe2e2e5
Reviewed-on: https://chromium-review.googlesource.com/204391
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
diff --git a/debugd/src/example_tool.cc b/debugd/src/example_tool.cc
index 8917367..19ba7f9 100644
--- a/debugd/src/example_tool.cc
+++ b/debugd/src/example_tool.cc
@@ -10,21 +10,19 @@
#include "process_with_output.h"
-using base::StringPrintf;
-
namespace debugd {
ExampleTool::ExampleTool() { }
ExampleTool::~ExampleTool() { }
-// Tool methods have the same signature as the generated DBus adaptors. Most
-// pertinently, this means they take their DBus::Error argument as a non-const
-// reference (hence the NOLINT). Tool methods are generally written in
-// can't-fail style, since their output is usually going to be displayed to the
-// user; instead of returning a DBus exception, we tend to return a string
-// indicating what went wrong.
-std::string ExampleTool::GetExample(DBus::Error& error) { // NOLINT
+// Tool methods have a similar signature as the generated DBus adaptors, except
+// for the DBus::Error argument, which is passed in as a pointer instead of a
+// reference. Tool methods are generally written in can't-fail style, since
+// their output is usually going to be displayed to the user; instead of
+// returning a DBus exception, we tend to return a string indicating what went
+// wrong.
+std::string ExampleTool::GetExample(DBus::Error* error) {
std::string path;
if (!SandboxedProcess::GetHelperPath("example", &path))
return "<path too long>";
@@ -46,4 +44,4 @@
return output;
}
-}; // namespace debugd
+} // namespace debugd