ml: add missing "return" when nondevice hwr is not supported.
We should let the LoadWebPlatformHandwritingModel function return if
ondevice hwr is not supported.
Also added a unit test to catch such case.
BUG=none
TEST=on pyro, nocturne, strongbad, it works as expected
Change-Id: Ifd069a079160aaa3f11049182fbc4fb8d437c47b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2890149
Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Commit-Queue: Honglin Yu <honglinyu@chromium.org>
Tested-by: Honglin Yu <honglinyu@chromium.org>
diff --git a/ml/machine_learning_service_impl.cc b/ml/machine_learning_service_impl.cc
index 7e1babd..de8abb8 100644
--- a/ml/machine_learning_service_impl.cc
+++ b/ml/machine_learning_service_impl.cc
@@ -516,6 +516,7 @@
LOG(ERROR) << "Calling LoadWebPlatformHandwritingModel without Handwriting "
"enabled should never happen.";
std::move(callback).Run(LoadHandwritingModelResult::LOAD_MODEL_ERROR);
+ return;
}
// If it is run in the control process, spawn a worker process and forward the