Touchpad-Tests: Fixed errornous test results
Some tests that should fail reported a zero score with success instead.
Fixed the issue and updated the result visualization:
- lines are now colored based on their result to make it easier to find
failures
- score < 0.5 is not reported as flaky instead of success. Success just
sounds wrong with a bad score!
BUG=chromium:222468
TEST=just run touchtests and look at the new output
Change-Id: I07cb9606c23228a8d8402b1438595e4f1ad17928
Reviewed-on: https://gerrit.chromium.org/gerrit/46161
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
diff --git a/framework/src/main.py b/framework/src/main.py
index d346349..95d4eb8 100644
--- a/framework/src/main.py
+++ b/framework/src/main.py
@@ -144,7 +144,8 @@
def ResultStr(value):
# format result to string
if value["result"] == "success":
- return "%s (%.4f)" % (value["result"], value["score"])
+ msg = "success" if value["score"] >= 0.5 else "bad"
+ return "%s (%.4f)" % (msg, value["score"])
elif value["disabled"]:
return "disabled"
else:
@@ -157,15 +158,15 @@
ref_score = ResultStr(ref[key])
delta = value["score"] - ref[key]["score"]
if math.fabs(delta) < 1e-10:
- # don't color, but line up with other values
- delta_str = " %.4f " % delta
+ # default color
+ delta_str = "\x1b[0m%.4f\x1b[0m" % delta
elif delta < 0:
regression = True
# color red
- delta_str = "\x1b[91m%+.4f\x1b[0m" % delta
+ delta_str = "\x1b[31m%+.4f\x1b[0m" % delta
else:
# color green
- delta_str = "\x1b[92m%+.4f\x1b[0m" % delta
+ delta_str = "\x1b[32m%+.4f\x1b[0m" % delta
table.row(key, ref_score, ResultStr(value), delta_str)
print table