blob: a355dc4dc2e8962dca226e193c6358d3e80401a9 [file] [log] [blame]
Derek Beckettf73baca2020-08-19 15:08:47 -07001# Lint as: python2, python3
Fang Deng5d518f42013-08-02 14:04:32 -07002# Copyright (c) 2013 The Chromium OS Authors. All rights reserved.
3# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5#
6# Expects to be run in an environment with sudo and no interactive password
7# prompt, such as within the Chromium OS development chroot.
8
9
10"""This file provides core logic for servo verify/repair process."""
11
12
Derek Beckettf73baca2020-08-19 15:08:47 -070013from __future__ import absolute_import
14from __future__ import division
15from __future__ import print_function
16
Fang Deng5d518f42013-08-02 14:04:32 -070017import logging
Raul E Rangel52ca2e82018-07-03 14:10:14 -060018import os
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -080019import re
20import tarfile
Andrew McRaef0679932020-08-13 09:15:23 +100021import threading
Garry Wang2b5eef92020-08-21 16:23:35 -070022import json
Garry Wangc1288cf2019-12-17 14:58:00 -080023import time
Derek Beckettf73baca2020-08-19 15:08:47 -070024import six
25import six.moves.xmlrpc_client
Otabek Kasimov120b6fa2020-07-03 00:15:27 -070026import calendar
Fang Deng5d518f42013-08-02 14:04:32 -070027
28from autotest_lib.client.bin import utils
Garry Wang79e9af62019-06-12 15:19:19 -070029from autotest_lib.client.common_lib import error
Richard Barnette9a26ad62016-06-10 12:03:08 -070030from autotest_lib.client.common_lib import hosts
Garry Wang7b0e1b72020-03-25 19:08:59 -070031from autotest_lib.client.common_lib import lsbrelease_utils
Fang Deng5d518f42013-08-02 14:04:32 -070032from autotest_lib.client.common_lib.cros import retry
Christopher Wileycef1f902014-06-19 11:11:23 -070033from autotest_lib.client.common_lib.cros.network import ping_runner
Richard Barnette9a26ad62016-06-10 12:03:08 -070034from autotest_lib.server.cros.servo import servo
Richard Barnetted31580e2018-05-14 19:58:00 +000035from autotest_lib.server.hosts import servo_repair
Garry Wangebc015b2019-06-06 17:45:06 -070036from autotest_lib.server.hosts import base_servohost
Garry Wang11b5e872020-03-11 15:14:08 -070037from autotest_lib.server.hosts import servo_constants
Otabek Kasimov4ea636e2020-04-14 23:35:06 -070038from autotest_lib.server.cros.faft.utils import config
Garry Wang11b5e872020-03-11 15:14:08 -070039from autotest_lib.client.common_lib import global_config
Otabek Kasimov8475cce2020-07-14 12:11:31 -070040from autotest_lib.site_utils.admin_audit import servo_updater
Garry Wangd7367482020-02-27 13:52:40 -080041
Otabek Kasimov15963492020-06-23 21:10:51 -070042try:
43 from chromite.lib import metrics
44except ImportError:
45 metrics = utils.metrics_mock
46
Dan Shi3b2adf62015-09-02 17:46:54 -070047_CONFIG = global_config.global_config
Fang Deng5d518f42013-08-02 14:04:32 -070048
Otabek Kasimova7ba91a2020-03-09 08:31:01 -070049
Garry Wangebc015b2019-06-06 17:45:06 -070050class ServoHost(base_servohost.BaseServoHost):
51 """Host class for a servo host(e.g. beaglebone, labstation)
Dana Goyette0b6e6402019-10-04 11:09:24 -070052 that with a servo instance for a specific port.
53
54 @type _servo: servo.Servo | None
55 """
Fang Deng5d518f42013-08-02 14:04:32 -070056
Raul E Rangel52ca2e82018-07-03 14:10:14 -060057 DEFAULT_PORT = int(os.getenv('SERVOD_PORT', '9999'))
Richard Barnette9a26ad62016-06-10 12:03:08 -070058
Dan Shie5b3c512014-08-21 12:12:09 -070059 # Timeout for initializing servo signals.
Wai-Hong Tam37b6ed32017-09-19 15:52:39 -070060 INITIALIZE_SERVO_TIMEOUT_SECS = 60
Richard Barnette9a26ad62016-06-10 12:03:08 -070061
Otabek Kasimov545739c2020-08-20 00:24:21 -070062 # Default timeout for run terminal command.
63 DEFAULT_TERMINAL_TIMEOUT = 30
64
xixuan6cf6d2f2016-01-29 15:29:00 -080065 # Ready test function
66 SERVO_READY_METHOD = 'get_version'
Fang Deng5d518f42013-08-02 14:04:32 -070067
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -080068 # Directory prefix on the servo host where the servod logs are stored.
69 SERVOD_LOG_PREFIX = '/var/log/servod'
70
71 # Exit code to use when symlinks for servod logs are not found.
72 NO_SYMLINKS_CODE = 9
73
74 # Directory in the job's results directory to dump the logs into.
75 LOG_DIR = 'servod'
76
77 # Prefix for joint loglevel files in the logs.
78 JOINT_LOG_PREFIX = 'log'
79
80 # Regex group to extract timestamp from logfile name.
81 TS_GROUP = 'ts'
82
83 # This regex is used to extract the timestamp from servod logs.
Garry Wang22f2e842020-09-09 20:19:19 -070084 # files always start with log.
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -080085 TS_RE = (r'log.'
86 # The timestamp is of format %Y-%m-%d--%H-%M-%S.MS
87 r'(?P<%s>\d{4}(\-\d{2}){2}\-(-\d{2}){3}.\d{3})'
88 # The loglevel is optional depending on labstation version.
89 r'(.(INFO|DEBUG|WARNING))?' % TS_GROUP)
90 TS_EXTRACTOR = re.compile(TS_RE)
91
92 # Regex group to extract MCU name from logline in servod logs.
93 MCU_GROUP = 'mcu'
94
95 # Regex group to extract logline from MCU logline in servod logs.
96 LINE_GROUP = 'line'
97
98 # This regex is used to extract the mcu and the line content from an
99 # MCU logline in servod logs. e.g. EC or servo_v4 console logs.
100 # Here is an example log-line:
101 #
102 # 2020-01-23 13:15:12,223 - servo_v4 - EC3PO.Console - DEBUG -
103 # console.py:219:LogConsoleOutput - /dev/pts/9 - cc polarity: cc1
104 #
105 # Here is conceptually how they are formatted:
106 #
107 # <time> - <MCU> - EC3PO.Console - <LVL> - <file:line:func> - <pts> -
108 # <output>
109 #
Garry Wang22f2e842020-09-09 20:19:19 -0700110 # The log format starts with a timestamp
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800111 MCU_RE = (r'[\d\-]+ [\d:,]+ '
112 # The mcu that is logging this is next.
113 r'- (?P<%s>\w+) - '
114 # Next, we have more log outputs before the actual line.
115 # Information about the file line, logging function etc.
116 # Anchor on EC3PO Console, LogConsoleOutput and dev/pts.
117 # NOTE: if the log format changes, this regex needs to be
118 # adjusted.
119 r'EC3PO\.Console[\s\-\w\d:.]+LogConsoleOutput - /dev/pts/\d+ - '
120 # Lastly, we get the MCU's console line.
121 r'(?P<%s>.+$)' % (MCU_GROUP, LINE_GROUP))
122 MCU_EXTRACTOR = re.compile(MCU_RE)
123
Otabek Kasimov545739c2020-08-20 00:24:21 -0700124 # Regex to detect timeout messages when USBC pigtail has timeout issue.
125 # e.g.: [475635.427072 PD TMOUT RX 1/1]
126 USBC_PIGTAIL_TIMEOUT_RE = r'\[[\d \.]{1,20}(PD TMOUT RX 1\/1)\]'
127
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800128 # Suffix to identify compressed logfiles.
129 COMPRESSION_SUFFIX = '.tbz2'
130
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700131 # A suffix to mark servod log directories that came from instance that
132 # ran during this servo_host, but are not the last one running e.g. when
133 # an instance (on purpose, or due to a bug) restarted in the middle of the
134 # run.
135 OLD_LOG_SUFFIX = 'old'
136
Otabek Kasimovc6f30412020-06-30 20:08:12 -0700137 # Mapping servo board with their vid-pid
138 SERVO_VID_PID = {
139 'servo_v4':'18d1:501b',
140 'ccd_cr50':'18d1:5014',
141 'servo_micro':'18d1:501a',
142 'servo_v3':['18d1:5004', '0403:6014'],
143 }
144
Otabek Kasimovcc9738e2020-02-14 16:17:15 -0800145 def _init_attributes(self):
146 self._servo_state = None
147 self.servo_port = None
148 self.servo_board = None
149 self.servo_model = None
150 self.servo_serial = None
Garry Wangcb06f3b2020-10-08 20:56:21 -0700151 self.servo_setup = None
Garry Wang000c6c02020-05-11 21:27:23 -0700152 # The flag that indicate if a servo is connected to a smart usbhub.
153 # TODO(xianuowang@) remove this flag once all usbhubs in the lab
154 # get replaced.
155 self.smart_usbhub = None
Otabek Kasimovcc9738e2020-02-14 16:17:15 -0800156 self._servo = None
Andrew McRaef0679932020-08-13 09:15:23 +1000157 self._tunnel_proxy = None
158 self._tunnel_proxy_lock = threading.Lock()
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700159 self._initial_instance_ts = None
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800160 # Flag to make sure that multiple calls to close do not result in the
161 # logic executing multiple times.
162 self._closed = False
Andrew McRaef0679932020-08-13 09:15:23 +1000163 # Per-thread local data
164 self._local = threading.local()
Fang Deng5d518f42013-08-02 14:04:32 -0700165
Garry Wangcb06f3b2020-10-08 20:56:21 -0700166 def _initialize(self,
167 servo_host='localhost',
168 servo_port=DEFAULT_PORT,
169 servo_board=None,
170 servo_model=None,
171 servo_serial=None,
172 servo_setup=None,
173 is_in_lab=None,
174 *args,
175 **dargs):
Fang Deng5d518f42013-08-02 14:04:32 -0700176 """Initialize a ServoHost instance.
177
178 A ServoHost instance represents a host that controls a servo.
179
180 @param servo_host: Name of the host where the servod process
181 is running.
Raul E Rangel52ca2e82018-07-03 14:10:14 -0600182 @param servo_port: Port the servod process is listening on. Defaults
183 to the SERVOD_PORT environment variable if set,
184 otherwise 9999.
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -0700185 @param servo_board: Board that the servo is connected to.
Nick Sanders2f3c9852018-10-24 12:10:24 -0700186 @param servo_model: Model that the servo is connected to.
Garry Wangcb06f3b2020-10-08 20:56:21 -0700187 @param servo_serial: Serial number of the servo device.
188 @param servo_setup: Type of servo setup, e.g. REGULAR or DUAL_V4.
Dan Shi4d478522014-02-14 13:46:32 -0800189 @param is_in_lab: True if the servo host is in Cros Lab. Default is set
190 to None, for which utils.host_is_in_lab_zone will be
191 called to check if the servo host is in Cros lab.
Fang Deng5d518f42013-08-02 14:04:32 -0700192
193 """
194 super(ServoHost, self)._initialize(hostname=servo_host,
Garry Wangebc015b2019-06-06 17:45:06 -0700195 is_in_lab=is_in_lab, *args, **dargs)
Otabek Kasimovcc9738e2020-02-14 16:17:15 -0800196 self._init_attributes()
Richard Barnette42f4db92018-08-23 15:05:15 -0700197 self.servo_port = int(servo_port)
Richard Barnettee519dcd2016-08-15 17:37:17 -0700198 self.servo_board = servo_board
Nick Sanders2f3c9852018-10-24 12:10:24 -0700199 self.servo_model = servo_model
Kevin Cheng643ce8a2016-09-15 15:42:12 -0700200 self.servo_serial = servo_serial
Garry Wangcb06f3b2020-10-08 20:56:21 -0700201 self.servo_setup = servo_setup
Wai-Hong Tam3a8a2552019-11-19 14:28:04 +0800202
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800203 # The location of the log files on the servo host for this instance.
204 self.remote_log_dir = '%s_%s' % (self.SERVOD_LOG_PREFIX,
205 self.servo_port)
Garry Wang79e9af62019-06-12 15:19:19 -0700206 # Path of the servo host lock file.
Derek Beckettf73baca2020-08-19 15:08:47 -0700207 self._lock_file = (self.TEMP_FILE_DIR + str(self.servo_port) +
208 self.LOCK_FILE_POSTFIX)
Garry Wang79e9af62019-06-12 15:19:19 -0700209 # File path to declare a reboot request.
Derek Beckettf73baca2020-08-19 15:08:47 -0700210 self._reboot_file = (self.TEMP_FILE_DIR + str(self.servo_port) +
211 self.REBOOT_FILE_POSTFIX)
Garry Wang79e9af62019-06-12 15:19:19 -0700212
213 # Lock the servo host if it's an in-lab labstation to prevent other
214 # task to reboot it until current task completes. We also wait and
215 # make sure the labstation is up here, in the case of the labstation is
216 # in the middle of reboot.
Garry Wang7c00b0f2019-06-25 17:28:17 -0700217 self._is_locked = False
Garry Wang42b4d862019-06-25 15:50:49 -0700218 if (self.wait_up(self.REBOOT_TIMEOUT) and self.is_in_lab()
219 and self.is_labstation()):
Garry Wang79e9af62019-06-12 15:19:19 -0700220 self._lock()
Garry Wangebc015b2019-06-06 17:45:06 -0700221
Richard Barnette9a26ad62016-06-10 12:03:08 -0700222 self._repair_strategy = (
223 servo_repair.create_servo_repair_strategy())
Richard Barnettee519dcd2016-08-15 17:37:17 -0700224
Dana Goyetteafa62fd2020-03-16 13:45:27 -0700225 def __str__(self):
226 return "<%s '%s:%s'>" % (
227 type(self).__name__, self.hostname, self.servo_port)
228
Richard Barnette9a26ad62016-06-10 12:03:08 -0700229 def connect_servo(self):
Garry Wang8c8dc972020-06-09 13:41:51 -0700230 """ Initialize and setup servo for later use.
231 """
232 self.initilize_servo()
233 self.initialize_dut_for_servo()
234
Garry Wang8c8dc972020-06-09 13:41:51 -0700235 def initilize_servo(self):
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -0700236 """Establish a connection to the servod server on this host.
Richard Barnette9a26ad62016-06-10 12:03:08 -0700237
238 Initializes `self._servo` and then verifies that all network
239 connections are working. This will create an ssh tunnel if
240 it's required.
Garry Wang8c8dc972020-06-09 13:41:51 -0700241 """
242 self._servo = servo.Servo(servo_host=self,
243 servo_serial=self.servo_serial)
Richard Barnette9a26ad62016-06-10 12:03:08 -0700244
Garry Wang8c8dc972020-06-09 13:41:51 -0700245 def initialize_dut_for_servo(self):
246 """This method will do some setup for dut control, e.g. setup
247 main servo_v4 device, and also testing the connection between servo
248 and DUT. As a side effect of testing the connection, all signals on
249 the target servo are reset to default values, and the USB stick is
Richard Barnette9a26ad62016-06-10 12:03:08 -0700250 set to the neutral (off) position.
251 """
Garry Wang8c8dc972020-06-09 13:41:51 -0700252 if not self._servo:
253 raise hosts.AutoservVerifyError('Servo object needs to be'
254 ' initialized before initialize'
255 ' DUT.')
Richard Barnette9a26ad62016-06-10 12:03:08 -0700256 timeout, _ = retry.timeout(
Garry Wang8c8dc972020-06-09 13:41:51 -0700257 self._servo.initialize_dut,
258 timeout_sec=self.INITIALIZE_SERVO_TIMEOUT_SECS)
Richard Barnette9a26ad62016-06-10 12:03:08 -0700259 if timeout:
Garry Wang8c8dc972020-06-09 13:41:51 -0700260 raise hosts.AutoservVerifyError('Initialize dut for servo timed'
261 ' out.')
Richard Barnette9a26ad62016-06-10 12:03:08 -0700262
Richard Barnette9a26ad62016-06-10 12:03:08 -0700263 def disconnect_servo(self):
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -0700264 """Disconnect our servo if it exists.
Richard Barnette9a26ad62016-06-10 12:03:08 -0700265
266 If we've previously successfully connected to our servo,
267 disconnect any established ssh tunnel, and set `self._servo`
268 back to `None`.
269 """
270 if self._servo:
271 # N.B. This call is safe even without a tunnel:
272 # rpc_server_tracker.disconnect() silently ignores
273 # unknown ports.
274 self.rpc_server_tracker.disconnect(self.servo_port)
275 self._servo = None
Fang Deng5d518f42013-08-02 14:04:32 -0700276
Andrew McRaef0679932020-08-13 09:15:23 +1000277 def _maybe_create_servod_ssh_tunnel_proxy(self):
278 """Create a xmlrpc proxy for use with a ssh tunnel.
279 A lock is used to safely create a singleton proxy.
280 """
281 with self._tunnel_proxy_lock:
282 if self._tunnel_proxy is None:
283 self._tunnel_proxy = self.rpc_server_tracker.xmlrpc_connect(
284 None,
285 self.servo_port,
286 ready_test_name=self.SERVO_READY_METHOD,
287 timeout_seconds=60,
288 request_timeout_seconds=3600,
289 server_desc=str(self))
290
Andrew McRaef0679932020-08-13 09:15:23 +1000291 def get_servod_server_proxy(self):
292 """Return a proxy if it exists; otherwise, create a new one.
293 A proxy can either be a ssh tunnel based proxy, or a httplib
294 based proxy.
Fang Deng5d518f42013-08-02 14:04:32 -0700295
296 @returns: An xmlrpclib.ServerProxy that is connected to the servod
297 server on the host.
Fang Deng5d518f42013-08-02 14:04:32 -0700298 """
Garry Wang11b5e872020-03-11 15:14:08 -0700299 if (servo_constants.ENABLE_SSH_TUNNEL_FOR_SERVO
300 and not self.is_localhost()):
Andrew McRaef0679932020-08-13 09:15:23 +1000301 # Check for existing ssh tunnel proxy.
302 if self._tunnel_proxy is None:
303 self._maybe_create_servod_ssh_tunnel_proxy()
304 return self._tunnel_proxy
Richard Barnette9a26ad62016-06-10 12:03:08 -0700305 else:
Andrew McRaef0679932020-08-13 09:15:23 +1000306 # xmlrpc/httplib is not thread-safe, so each thread must have its
307 # own separate proxy connection.
308 if not hasattr(self._local, "_per_thread_proxy"):
309 remote = 'http://%s:%s' % (self.hostname, self.servo_port)
Derek Beckettf73baca2020-08-19 15:08:47 -0700310 self._local._per_thread_proxy = six.moves.xmlrpc_client.ServerProxy(remote)
Andrew McRaef0679932020-08-13 09:15:23 +1000311 return self._local._per_thread_proxy
Wai-Hong Tam3a8a2552019-11-19 14:28:04 +0800312
Richard Barnette1edbb162016-11-01 11:47:50 -0700313 def verify(self, silent=False):
314 """Update the servo host and verify it's in a good state.
315
316 @param silent If true, suppress logging in `status.log`.
317 """
Richard Barnetteabbdc252018-07-26 16:57:42 -0700318 message = 'Beginning verify for servo host %s port %s serial %s'
319 message %= (self.hostname, self.servo_port, self.servo_serial)
320 self.record('INFO', None, None, message)
Richard Barnette9a26ad62016-06-10 12:03:08 -0700321 try:
Richard Barnette1edbb162016-11-01 11:47:50 -0700322 self._repair_strategy.verify(self, silent)
Garry Wang11b5e872020-03-11 15:14:08 -0700323 self._servo_state = servo_constants.SERVO_STATE_WORKING
324 self.record('INFO', None, None,
325 'ServoHost verify set servo_state as WORKING')
Garry Wang63b8c382020-03-11 22:28:40 -0700326 except Exception as e:
Otabek Kasimov120b6fa2020-07-03 00:15:27 -0700327 if not self.is_localhost():
Otabek Kasimovc6f30412020-06-30 20:08:12 -0700328 self._servo_state = self.determine_servo_state()
329 self.record('INFO', None, None,
330 'ServoHost verify set servo_state as %s'
331 % self._servo_state)
Garry Wang63b8c382020-03-11 22:28:40 -0700332 if self._is_critical_error(e):
333 raise
Fang Deng5d518f42013-08-02 14:04:32 -0700334
Garry Wang2b5eef92020-08-21 16:23:35 -0700335 def _get_default_usbkey_mount_path(self):
336 return '/media/servo_usb/%s' % self.servo_port
Fang Deng5d518f42013-08-02 14:04:32 -0700337
Garry Wang7b0e1b72020-03-25 19:08:59 -0700338 def get_image_name_from_usbkey(self, usbkey_dev):
339 """Mount usb drive and check ChromeOS image name on it if there is
340 one. This method assumes the image_usbkey_direction is already set
341 to servo side.
342
Garry Wang4b980202020-09-24 17:00:17 -0700343 @param usbkey_dev: usbkey dev path(e.g. /dev/sdb).
Garry Wang7b0e1b72020-03-25 19:08:59 -0700344
345 @returns: image_name on the usbkey, e.g. nami-release/R82.10138.0.0,
346 or empty string if no test image detected, or unexpected
347 error occurred.
Garry Wang7b0e1b72020-03-25 19:08:59 -0700348 """
Garry Wang70e5d062020-04-03 18:01:05 -0700349 logging.info('Checking ChromeOS image name on usbkey.')
Garry Wang2b5eef92020-08-21 16:23:35 -0700350 mount_dst = self._get_default_usbkey_mount_path()
Garry Wang7b0e1b72020-03-25 19:08:59 -0700351 # Unmount if there is an existing stale mount.
Garry Wang2b5eef92020-08-21 16:23:35 -0700352 self._unmount_drive(mount_dst)
353 # ChromeOS root fs is in /dev/sdx3
354 mount_src = usbkey_dev + '3'
Garry Wang7b0e1b72020-03-25 19:08:59 -0700355 try:
Garry Wang2b5eef92020-08-21 16:23:35 -0700356 if not self._mount_drive(mount_src, mount_dst):
357 logging.debug('Unexpected error occurred on mount usb drive.')
Garry Wang7b0e1b72020-03-25 19:08:59 -0700358 return ''
Garry Wang70e5d062020-04-03 18:01:05 -0700359
360 release_content = self.run(
Garry Wang2b5eef92020-08-21 16:23:35 -0700361 'cat %s/etc/lsb-release' % mount_dst,
Garry Wang70e5d062020-04-03 18:01:05 -0700362 ignore_status=True).stdout.strip()
363
364 if not re.search(r'RELEASE_TRACK=.*test', release_content):
365 logging.info('The image on usbkey is not a test image')
366 return ''
367
368 return lsbrelease_utils.get_chromeos_release_builder_path(
369 lsb_release_content=release_content)
Garry Wang7b0e1b72020-03-25 19:08:59 -0700370 finally:
Garry Wang70e5d062020-04-03 18:01:05 -0700371 logging.debug('Image check compeleted, unmounting the usb drive.')
Garry Wang2b5eef92020-08-21 16:23:35 -0700372 self._unmount_drive(mount_dst)
Garry Wang7b0e1b72020-03-25 19:08:59 -0700373
Garry Wang2b5eef92020-08-21 16:23:35 -0700374 def _extract_firmware_image_from_usbkey(self, fw_dst):
375 """Extract firmware images from the usbkey on servo, this method
376 assumes there is already a ChromeOS test image staged on servo.
377
Garry Wang4b980202020-09-24 17:00:17 -0700378 @param fw_dst: the path that we'll copy firmware images to.
Garry Wang2b5eef92020-08-21 16:23:35 -0700379
380 @returns: a json format string of firmware manifest data.
381 """
382 usbkey_dev = self._probe_and_validate_usb_dev()
383 if not usbkey_dev:
384 raise hosts.AutoservRepairError('Unexpected error occurred when'
385 ' probe usbkey dev path, please check logs for detail.')
386
387 mount_dst = self._get_default_usbkey_mount_path()
388 # Unmount if there is an existing stale mount.
389 self._unmount_drive(mount_dst)
390 # ChromeOS root fs is in /dev/sdx3
391 mount_src = usbkey_dev + '3'
392 try:
393 if not self._mount_drive(mount_src, mount_dst):
394 raise hosts.AutoservRepairError('Failed to extract firmware'
395 ' image; Unable to mount %s.' % usbkey_dev,
396 'unable to mount usbkey')
397 updater_bin = os.path.join(mount_dst,
398 'usr/sbin/chromeos-firmwareupdate')
399 self.run('%s --unpack %s' % (updater_bin, fw_dst))
400 return self.run('%s --manifest' % updater_bin).stdout
401 finally:
402 self._unmount_drive(mount_dst)
403
404 def prepare_repair_firmware_image(self, fw_dst=None):
405 """Prepare firmware image on the servohost for auto repair process
406 to consume.
407
Garry Wang4b980202020-09-24 17:00:17 -0700408 @param fw_dst: the path that we want to store firmware image on
409 the servohost.
Garry Wang2b5eef92020-08-21 16:23:35 -0700410
411 @returns: A tuple that containes ec firmware image path and bios
412 firmware image path on the servohost, or None if type of
413 image is not available based on manifest and dut's model.
414 """
415 model = self.servo_model or self._dut_host_info.model
416 if not model:
417 raise hosts.AutoservRepairError(
418 'Could not determine DUT\'s model.',
419 'model infomation unknown')
420
421 if not fw_dst:
422 fw_dst = '/tmp/firmware_image/%s' % self.servo_port
423 # Cleanup and re-create dst path to have a fresh start.
424 self.run('rm -rf %s' % fw_dst)
425 self.run('mkdir -p %s' % fw_dst)
426
427 manifest = json.loads(self._extract_firmware_image_from_usbkey(fw_dst))
Garry Wang50b56c12020-09-24 17:26:52 -0700428 # For models that have packed $MODEL_signed variant, we want use the
429 # 'signed' variant once we get DVT devices, so try to read manifest
430 # from $MODEL_signed first.
431 build = manifest.get('%s_signed' % model) or manifest.get(model)
432 if not build:
Garry Wang2b5eef92020-08-21 16:23:35 -0700433 raise hosts.AutoservRepairError('Could not find firmware manifest'
434 ' for model:%s' % model, 'model manifest not found')
435 try:
Garry Wang50b56c12020-09-24 17:26:52 -0700436 ec_image = os.path.join(fw_dst, build['ec']['image'])
Garry Wang2b5eef92020-08-21 16:23:35 -0700437 except KeyError:
438 ec_image = None
439 try:
Garry Wang50b56c12020-09-24 17:26:52 -0700440 bios_image = os.path.join(fw_dst, build['host']['image'])
Garry Wang2b5eef92020-08-21 16:23:35 -0700441 except KeyError:
442 bios_image = None
443 if not ec_image and not bios_image:
444 raise hosts.AutoservRepairError('Could not find any firmware image'
445 ' for model:%s' % model, 'cannot find firmware image')
446 return ec_image, bios_image
Garry Wang7b0e1b72020-03-25 19:08:59 -0700447
Garry Wang4b980202020-09-24 17:00:17 -0700448 def flash_ap_firmware_via_servo(self, image):
449 """Flash AP firmware by use a provided image.
450
451 This is will be a short term enhanment for infra repair use, it use
452 'futility update' which will automatically determine various parameters
453 needed for flashrom, and will preserve the GBB, VPD, and HWID for
454 AP firmware update.
455 @TODO(xianuowang@) Remove this method once b/148403277 implemented.
456
457 @param image: the firmware image path on servohost.
458 """
459 cmd = 'futility update -i %s --servo_port=%s'
460 self.run(cmd % (image, self.servo_port), timeout=900)
461
Garry Wang70e5d062020-04-03 18:01:05 -0700462 def _probe_and_validate_usb_dev(self):
463 """This method probe the usb dev path by talking to servo, and then
464 validate the dev path is valid block device to servohost.
465 Possible output:
466 1. Encounter error during probe usb dev, returns empty string.
467 2. probe usb dev completed without error but cannot find usb dev,
468 raise AutoservRepairError.
469 3. probe usb dev find a usb dev path, but failed validation in this
470 method, raise AutoservRepairError.
Garry Wang7b0e1b72020-03-25 19:08:59 -0700471
Garry Wang70e5d062020-04-03 18:01:05 -0700472 @returns: A string of usb dev path(e.g. '/dev/sdb'), or empty string
473 if unexpected error occurred during probe.
474 @raises: AutoservRepairError if servo couldn't probe the usb dev path
475 (servo.probe_host_usb_dev() returns empty string), or the dev path is
476 not valid block device to servohost.
Garry Wang7b0e1b72020-03-25 19:08:59 -0700477 """
478 logging.info('Validating image usbkey on servo.')
Garry Wang7b0e1b72020-03-25 19:08:59 -0700479 try:
Garry Wang70e5d062020-04-03 18:01:05 -0700480 usb_dev = self._servo.probe_host_usb_dev()
Garry Wang7b0e1b72020-03-25 19:08:59 -0700481 except Exception as e:
482 # We don't want any unexpected or transient servo communicating
483 # failure block usb repair, so capture all errors here.
484 logging.error(e, exc_info=True)
485 logging.error('Unexpected error occurred on get usbkey dev path,'
486 ' skipping usbkey validation.')
487 return ''
488
Garry Wang70e5d062020-04-03 18:01:05 -0700489 if usb_dev:
490 # probe_host_usb_dev() sometimes return stale record,
491 # so we need to make sure the path exists in fdisk.
Otabek Kasimov77bff672020-10-08 15:52:03 -0700492 validate_cmd = 'fdisk -l %s' % usb_dev
Garry Wang11441182020-06-16 18:34:14 -0700493 try:
Otabek Kasimov77bff672020-10-08 15:52:03 -0700494 resp = self.run(validate_cmd, ignore_status=True, timeout=30)
Garry Wang11441182020-06-16 18:34:14 -0700495 if resp.exit_status == 0:
496 return usb_dev
Garry Wang11441182020-06-16 18:34:14 -0700497 logging.error('%s is reported from "image_usbkey_dev" control'
498 ' but not detected by fdisk!', usb_dev)
499 except error.AutoservRunError as e:
500 if 'Timeout encountered' in str(e):
501 logging.warning('Timeout encountered during fdisk run,'
502 ' skipping usbkey validation.')
503 return ''
504 raise
Garry Wang70e5d062020-04-03 18:01:05 -0700505
506 raise hosts.AutoservRepairError(
507 'No usbkey detected on servo, the usbkey may be either missing'
508 ' or broken. Please replace usbkey on the servo and retry.',
509 'missing usbkey')
510
Otabek Kasimov4ea636e2020-04-14 23:35:06 -0700511 def is_ec_supported(self):
Garry Wang9b8f2342020-04-17 16:34:09 -0700512 """Check if ec is supported on the servo_board"""
Otabek Kasimov4ea636e2020-04-14 23:35:06 -0700513 if self.servo_board:
514 try:
515 frm_config = config.Config(self.servo_board, self.servo_model)
516 return frm_config.chrome_ec
517 except Exception as e:
518 logging.error('Unexpected error when read from firmware'
519 ' configs; %s', str(e))
520 return False
521
Garry Wang70e5d062020-04-03 18:01:05 -0700522 def validate_image_usbkey(self):
523 """This method first validate if there is a recover usbkey on servo
524 that accessible to servohost, and second check if a ChromeOS image is
525 already on the usb drive and return the image_name so we can avoid
526 unnecessary download and flash to the recover usbkey on servo.
527
528 Please note that, there is special error handling logic here:
529 1. If unexpected error happens, we return empty string. So repair
530 actions will not get blocked.
531 2. If no working usbkey present on servo, but no errors, we'll raise
532 AutoservRepairError here.
533
534 @returns: image_name on the usbkey, e.g. nami-release/R82.10138.0.0,
535 or empty string if no test image detected, or unexpected
536 error occurred.
537 @raises: AutoservRepairError if the usbkey is not detected on servo.
538 """
539 usb_dev = self._probe_and_validate_usb_dev()
540 if usb_dev:
541 return self.get_image_name_from_usbkey(usb_dev)
542 else:
543 return ''
Garry Wang7b0e1b72020-03-25 19:08:59 -0700544
Richard Barnette1edbb162016-11-01 11:47:50 -0700545 def repair(self, silent=False):
546 """Attempt to repair servo host.
547
548 @param silent If true, suppress logging in `status.log`.
549 """
Richard Barnetteabbdc252018-07-26 16:57:42 -0700550 message = 'Beginning repair for servo host %s port %s serial %s'
551 message %= (self.hostname, self.servo_port, self.servo_serial)
552 self.record('INFO', None, None, message)
Richard Barnette9a26ad62016-06-10 12:03:08 -0700553 try:
Richard Barnette1edbb162016-11-01 11:47:50 -0700554 self._repair_strategy.repair(self, silent)
Garry Wang11b5e872020-03-11 15:14:08 -0700555 self._servo_state = servo_constants.SERVO_STATE_WORKING
556 self.record('INFO', None, None,
557 'ServoHost repair set servo_state as WORKING')
Garry Wang464ff1e2019-07-18 17:20:34 -0700558 # If target is a labstation then try to withdraw any existing
559 # reboot request created by this servo because it passed repair.
560 if self.is_labstation():
561 self.withdraw_reboot_request()
Garry Wang63b8c382020-03-11 22:28:40 -0700562 except Exception as e:
Otabek Kasimov120b6fa2020-07-03 00:15:27 -0700563 if not self.is_localhost():
Otabek Kasimovc6f30412020-06-30 20:08:12 -0700564 self._servo_state = self.determine_servo_state()
565 self.record('INFO', None, None,
566 'ServoHost repair set servo_state as %s'
567 % self._servo_state)
Garry Wang63b8c382020-03-11 22:28:40 -0700568 if self._is_critical_error(e):
569 self.disconnect_servo()
570 self.stop_servod()
571 raise
572
Garry Wang63b8c382020-03-11 22:28:40 -0700573 def _is_critical_error(self, error):
574 if (isinstance(error, hosts.AutoservVerifyDependencyError)
575 and not error.is_critical()):
576 logging.warning('Non-critical verify failure(s) detected during'
577 ' verify/repair servo, servo connection will'
578 ' still up but may not fully functional.'
579 ' Some repair actions and servo depended'
580 ' tests may not run.')
581 return False
582 logging.info('Critical verify failure(s) detected during repair/verify'
583 ' servo. Disconnecting servo and stop servod, all repair '
584 'action and tests that depends on servo will not run.')
585 return True
Fang Deng5d518f42013-08-02 14:04:32 -0700586
Dan Shi4d478522014-02-14 13:46:32 -0800587 def get_servo(self):
588 """Get the cached servo.Servo object.
Fang Deng5d518f42013-08-02 14:04:32 -0700589
Dan Shi4d478522014-02-14 13:46:32 -0800590 @return: a servo.Servo object.
Dana Goyette353d1d92019-06-27 10:43:59 -0700591 @rtype: autotest_lib.server.cros.servo.servo.Servo
Fang Deng5d518f42013-08-02 14:04:32 -0700592 """
Dan Shi4d478522014-02-14 13:46:32 -0800593 return self._servo
594
Garry Wang79e9af62019-06-12 15:19:19 -0700595 def request_reboot(self):
596 """Request servohost to be rebooted when it's safe to by touch a file.
597 """
598 logging.debug('Request to reboot servohost %s has been created by '
Garry Wang464ff1e2019-07-18 17:20:34 -0700599 'servo with port # %s', self.hostname, self.servo_port)
Garry Wang79e9af62019-06-12 15:19:19 -0700600 self.run('touch %s' % self._reboot_file, ignore_status=True)
601
Garry Wang464ff1e2019-07-18 17:20:34 -0700602 def withdraw_reboot_request(self):
603 """Withdraw a servohost reboot request if exists by remove the flag
604 file.
605 """
606 logging.debug('Withdrawing request to reboot servohost %s that created'
607 ' by servo with port # %s if exists.',
608 self.hostname, self.servo_port)
609 self.run('rm -f %s' % self._reboot_file, ignore_status=True)
610
Garry Wangc1288cf2019-12-17 14:58:00 -0800611 def start_servod(self, quick_startup=False):
612 """Start the servod process on servohost.
613 """
Garry Wang2ac15ee2019-12-30 19:03:02 -0800614 # Skip if running on the localhost.(crbug.com/1038168)
615 if self.is_localhost():
616 logging.debug("Servohost is a localhost, skipping start servod.")
617 return
618
619 cmd = 'start servod'
Garry Wangc1288cf2019-12-17 14:58:00 -0800620 if self.servo_board:
Garry Wang2ac15ee2019-12-30 19:03:02 -0800621 cmd += ' BOARD=%s' % self.servo_board
Garry Wangc1288cf2019-12-17 14:58:00 -0800622 if self.servo_model:
623 cmd += ' MODEL=%s' % self.servo_model
Garry Wangc1288cf2019-12-17 14:58:00 -0800624 else:
Garry Wang2ac15ee2019-12-30 19:03:02 -0800625 logging.warning('Board for DUT is unknown; starting servod'
626 ' assuming a pre-configured board.')
627
628 cmd += ' PORT=%d' % self.servo_port
629 if self.servo_serial:
630 cmd += ' SERIAL=%s' % self.servo_serial
Garry Wangd7367482020-02-27 13:52:40 -0800631
Garry Wangcb06f3b2020-10-08 20:56:21 -0700632 # Start servod with dual_v4 based on servo_setup.
633 if self.servo_setup == servo_constants.SERVO_SETUP_VALUE_DUAL_V4:
634 cmd += ' DUAL_V4=1'
Garry Wangd7367482020-02-27 13:52:40 -0800635
Garry Wangcb06f3b2020-10-08 20:56:21 -0700636 # Start servod with CONFIG=cr50.xml which required for some pools.
637 if self._require_cr50_servod_config():
638 cmd += ' CONFIG=cr50.xml'
Garry Wangb5cee3e2020-09-16 14:58:13 -0700639
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800640 # Remove the symbolic links from the logs. This helps ensure that
641 # a failed servod instantiation does not cause us to grab old logs
642 # by mistake.
643 self.remove_latest_log_symlinks()
Garry Wangcdd27b22020-01-13 14:59:11 -0800644 self.run(cmd, timeout=60)
Garry Wangc1288cf2019-12-17 14:58:00 -0800645
646 # There's a lag between when `start servod` completes and when
647 # the _ServodConnectionVerifier trigger can actually succeed.
648 # The call to time.sleep() below gives time to make sure that
649 # the trigger won't fail after we return.
650
651 # Normally servod on servo_v3 and labstation take ~10 seconds to ready,
652 # But in the rare case all servo on a labstation are in heavy use they
653 # may take ~30 seconds. So the timeout value will double these value,
654 # and we'll try quick start up when first time initialize servohost,
655 # and use standard start up timeout in repair.
656 if quick_startup:
Garry Wang11b5e872020-03-11 15:14:08 -0700657 timeout = servo_constants.SERVOD_QUICK_STARTUP_TIMEOUT
Garry Wangc1288cf2019-12-17 14:58:00 -0800658 else:
Garry Wang11b5e872020-03-11 15:14:08 -0700659 timeout = servo_constants.SERVOD_STARTUP_TIMEOUT
Garry Wangc1288cf2019-12-17 14:58:00 -0800660 logging.debug('Wait %s seconds for servod process fully up.', timeout)
661 time.sleep(timeout)
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700662 # Cache the initial instance timestamp to check against servod restarts
663 self._initial_instance_ts = self.get_instance_logs_ts()
Garry Wangc1288cf2019-12-17 14:58:00 -0800664
Garry Wangc1288cf2019-12-17 14:58:00 -0800665 def stop_servod(self):
666 """Stop the servod process on servohost.
667 """
Garry Wang2ac15ee2019-12-30 19:03:02 -0800668 # Skip if running on the localhost.(crbug.com/1038168)
669 if self.is_localhost():
670 logging.debug("Servohost is a localhost, skipping stop servod.")
671 return
672
Garry Wangc1288cf2019-12-17 14:58:00 -0800673 logging.debug('Stopping servod on port %s', self.servo_port)
Garry Wangcdd27b22020-01-13 14:59:11 -0800674 self.run('stop servod PORT=%d' % self.servo_port,
675 timeout=60, ignore_status=True)
Garry Wangc1288cf2019-12-17 14:58:00 -0800676 logging.debug('Wait %s seconds for servod process fully teardown.',
Garry Wang11b5e872020-03-11 15:14:08 -0700677 servo_constants.SERVOD_TEARDOWN_TIMEOUT)
678 time.sleep(servo_constants.SERVOD_TEARDOWN_TIMEOUT)
Garry Wangc1288cf2019-12-17 14:58:00 -0800679
Garry Wangc1288cf2019-12-17 14:58:00 -0800680 def restart_servod(self, quick_startup=False):
681 """Restart the servod process on servohost.
682 """
683 self.stop_servod()
684 self.start_servod(quick_startup)
685
Garry Wangffbd2162020-04-17 16:13:48 -0700686 def _process_servodtool_error(self, response):
687 """Helper function to handle non-zero servodtool response.
688 """
689 if re.search(servo_constants.ERROR_MESSAGE_USB_HUB_NOT_COMPATIBLE,
Garry Wangad245002020-05-15 15:20:23 -0700690 response.stdout):
Garry Wangffbd2162020-04-17 16:13:48 -0700691 logging.error('The servo is not plugged on a usb hub that supports'
692 ' power-cycle!')
Garry Wang000c6c02020-05-11 21:27:23 -0700693 # change the flag so we can update this label in later process.
694 self.smart_usbhub = False
Garry Wangffbd2162020-04-17 16:13:48 -0700695 return
696
697 if re.search(servo_constants.ERROR_MESSAGE_DEVICE_NOT_FOUND %
698 self.servo_serial, response.stdout):
699 logging.error('No servo with serial %s found!', self.servo_serial)
700 return
701
702 logging.error('Unexpected error occurred from usbhub control, please'
703 ' file a bug and inform chrome-fleet-software@ team!')
704
Garry Wangffbd2162020-04-17 16:13:48 -0700705 def _get_servo_usb_devnum(self):
706 """Helper function to collect current usb devnum of servo.
707 """
Otabek Kasimov09192682020-06-01 18:17:44 -0700708 # TODO remove try-except when fix crbug.com/1087964
709 try:
710 cmd = 'servodtool device -s %s usb-path' % self.servo_serial
711 resp = self.run(cmd, ignore_status=True, timeout=30)
712 except Exception as e:
713 # Here we catch only timeout errors.
714 # Other errors is filtered by ignore_status=True
715 logging.debug('Attempt to get servo usb-path failed due to '
716 'timeout; %s', e)
717 return ''
718
Garry Wangffbd2162020-04-17 16:13:48 -0700719 if resp.exit_status != 0:
720 self._process_servodtool_error(resp)
721 return ''
722 usb_path = resp.stdout.strip()
723 logging.info('Usb path of servo %s is %s', self.servo_serial, usb_path)
724
725 resp = self.run('cat %s/devnum' % usb_path,
726 ignore_status=True)
727 if resp.exit_status != 0:
728 self._process_servodtool_error(resp)
729 return ''
730 return resp.stdout.strip()
731
Garry Wang358aad42020-08-02 20:56:04 -0700732 def reboot_servo_v3_on_need(self):
733 """Check and reboot servo_v3 based on below conditions.
734 1. If there is an update pending on reboot.
735 2. Servo_v3 has been up for more than 96 hours.
736 """
737 if self.get_board() != 'beaglebone_servo':
738 logging.info('Servo reboot is only applicable for servo V3.')
Otabek Kasimove6df8102020-07-21 20:15:25 -0700739 return
740
Garry Wang358aad42020-08-02 20:56:04 -0700741 update_pending_reboot = (self._check_update_status() ==
742 self.UPDATE_STATE.PENDING_REBOOT)
743 uptime_hours = float(self.check_uptime())/3600
744 logging.info('Uptime of servo_v3: %s hour(s)', uptime_hours)
745 long_up_time = uptime_hours > 96
746
747 # Skip reboot if neither condition are met.
748 if not (update_pending_reboot or long_up_time):
Otabek Kasimove6df8102020-07-21 20:15:25 -0700749 return
750
Garry Wang358aad42020-08-02 20:56:04 -0700751 if update_pending_reboot:
752 message = 'Starting reboot servo_v3 because an update is pending.'
753 reboot_method = self._post_update_reboot
754 elif long_up_time:
755 message = 'Starting reboot servo_v3 because uptime > 96 hours.'
756 reboot_method = self._servo_host_reboot
757 self.record('INFO', None, None, message)
758 logging.info(message)
Otabek Kasimove6df8102020-07-21 20:15:25 -0700759 try:
Garry Wang358aad42020-08-02 20:56:04 -0700760 reboot_method()
Otabek Kasimove6df8102020-07-21 20:15:25 -0700761 message = 'Servo_v3 reboot completed successfully.'
762 except Exception as e:
763 logging.debug("Fail to reboot servo_v3; %s", e)
764 message = ('Servo_v3 reboot failed, please check debug log '
765 'for details.')
766 logging.info(message)
767 self.record('INFO', None, None, message)
Garry Wangffbd2162020-04-17 16:13:48 -0700768
769 def _reset_servo(self):
770 logging.info('Resetting servo through smart usbhub.')
Otabek Kasimov09192682020-06-01 18:17:44 -0700771 # TODO remove try-except when fix crbug.com/1087964
772 try:
773 resp = self.run('servodtool device -s %s power-cycle' %
774 self.servo_serial, ignore_status=True,
775 timeout=30)
776 if resp.exit_status != 0:
777 self._process_servodtool_error(resp)
778 return False
779 except Exception as e:
780 # Here we catch only timeout errors.
781 # Other errors is filtered by ignore_status=True
782 logging.debug('Attempt to reset servo failed due to timeout;'
783 ' %s', e)
Garry Wangffbd2162020-04-17 16:13:48 -0700784 return False
785
786 logging.debug('Wait %s seconds for servo to come back from reset.',
787 servo_constants.SERVO_RESET_TIMEOUT_SECONDS)
788 time.sleep(servo_constants.SERVO_RESET_TIMEOUT_SECONDS)
Garry Wang000c6c02020-05-11 21:27:23 -0700789 # change the flag so we can update this label in later process.
790 self.smart_usbhub = True
Garry Wangffbd2162020-04-17 16:13:48 -0700791 return True
792
Garry Wangffbd2162020-04-17 16:13:48 -0700793 def reset_servo(self):
794 """Reset(power-cycle) the servo via smart usbhub.
795 """
796 if not self.is_labstation():
797 logging.info('Servo reset is not applicable to servo_v3.')
798 return
799
800 pre_reset_devnum = self._get_servo_usb_devnum()
801 logging.info('Servo usb devnum before reset: %s', pre_reset_devnum)
802 result = self._reset_servo()
803 if not result:
Garry Wangfd5c8b62020-06-08 15:36:54 -0700804 message = ('Failed to reset servo with serial: %s. (Please ignore'
805 ' this error if the DUT is not connected to a smart'
806 ' usbhub).' % self.servo_serial)
Garry Wangffbd2162020-04-17 16:13:48 -0700807 logging.warning(message)
808 self.record('INFO', None, None, message)
809 return
810
811 post_reset_devnum = self._get_servo_usb_devnum()
812 logging.info('Servo usb devnum after reset: %s', post_reset_devnum)
813 if not (pre_reset_devnum and post_reset_devnum):
814 message = ('Servo reset completed but unable to verify'
815 ' devnum change!')
816 elif pre_reset_devnum != post_reset_devnum:
817 message = ('Reset servo with serial %s completed successfully!'
818 % self.servo_serial)
819 else:
820 message = 'Servo reset completed but devnum is still not changed!'
821 logging.info(message)
822 self.record('INFO', None, None, message)
823
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800824 def _extract_compressed_logs(self, logdir, relevant_files):
825 """Decompress servod logs in |logdir|.
826
827 @param logdir: directory containing compressed servod logs.
828 @param relevant_files: list of files in |logdir| to consider.
829
830 @returns: tuple, (tarfiles, files) where
831 tarfiles: list of the compressed filenames that have been
832 extracted and deleted
833 files: list of the uncompressed files that were generated
834 """
835 # For all tar-files, first extract them to the directory, and
836 # then let the common flow handle them.
837 tarfiles = [cf for cf in relevant_files if
838 cf.endswith(self.COMPRESSION_SUFFIX)]
839 files = []
840 for f in tarfiles:
841 norm_name = os.path.basename(f)[:-len(self.COMPRESSION_SUFFIX)]
842 with tarfile.open(f) as tf:
843 # Each tarfile has only one member, as
844 # that's the compressed log.
845 member = tf.members[0]
846 # Manipulate so that it only extracts the basename, and not
847 # the directories etc.
848 member.name = norm_name
849 files.append(os.path.join(logdir, member.name))
850 tf.extract(member, logdir)
851 # File has been extracted: remove the compressed file.
852 os.remove(f)
853 return tarfiles, files
854
855 def _extract_mcu_logs(self, log_subdir):
856 """Extract MCU (EC, Cr50, etc) console output from servod debug logs.
857
858 Using the MCU_EXTRACTOR regex (above) extract and split out MCU console
859 lines from the logs to generate invidiual console logs e.g. after
860 this method, you can find an ec.txt and servo_v4.txt in |log_dir| if
861 those MCUs had any console input/output.
862
863 @param log_subdir: directory with log.DEBUG.txt main servod debug logs.
864 """
865 # Extract the MCU for each one. The MCU logs are only in the .DEBUG
866 # files
867 mcu_lines_file = os.path.join(log_subdir, 'log.DEBUG.txt')
868 if not os.path.exists(mcu_lines_file):
869 logging.info('No DEBUG logs found to extract MCU logs from.')
870 return
871 mcu_files = {}
872 mcu_file_template = '%s.txt'
873 with open(mcu_lines_file, 'r') as f:
874 for line in f:
875 match = self.MCU_EXTRACTOR.match(line)
876 if match:
877 mcu = match.group(self.MCU_GROUP).lower()
878 line = match.group(self.LINE_GROUP)
879 if mcu not in mcu_files:
880 mcu_file = os.path.join(log_subdir,
881 mcu_file_template % mcu)
882 mcu_files[mcu] = open(mcu_file, 'a')
883 fd = mcu_files[mcu]
884 fd.write(line + '\n')
885 for f in mcu_files:
886 mcu_files[f].close()
887
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800888 def remove_latest_log_symlinks(self):
889 """Remove the conveninence symlinks 'latest' servod logs."""
890 symlink_wildcard = '%s/latest*' % self.remote_log_dir
891 cmd = 'rm ' + symlink_wildcard
892 self.run(cmd, stderr_tee=None, ignore_status=True)
893
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700894 def probe_servod_restart(self, instance_ts, outdir):
895 """Grab servod logs from previous instances if part of this session.
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800896
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700897 If since the last time this host called start_servod() servod crashed
898 and restarted, this helper finds those logs as well, and stores them
899 with the |OLD_LOG_SUFFIX| to investigate if necessary.
Prasad Vuppalapu5bd9da12020-03-31 01:46:47 +0000900
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700901 It also issues a panicinfo command to servo devices after the restart
902 to try and collect reboot information for debugging.
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800903
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700904 @param instance_ts: the log timestamp that the current instance uses
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800905 @param outdir: directory to create a subdirectory into to place the
906 servod logs into.
907 """
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700908 if self._initial_instance_ts is None:
909 logging.info('No log timestamp grabbed successfully on servod '
910 'startup. Cannot check device restarts. Ignoring.')
911 return
912 if instance_ts == self._initial_instance_ts:
913 logging.debug('Servod appears to have run without restarting')
914 return
915 # Servod seems to have restarted (at least once). |_initial_instance_ts|
916 # is the first timestamp, and instance_ts is the current timestamp. Find
917 # all timestamps in between them, and grab the logs for each.
918 tss = self._find_instance_timestamps_between(self._initial_instance_ts,
919 instance_ts)
920 logging.info('Servod has restarted %d times between the start and the '
921 'end of this servo_host.', len(tss))
922 logging.info('This might be an issue. Will extract all logs from each '
923 'instance.')
924 logging.info('Logs that are not the currently running (about to turn '
925 'down) instance are maked with a .%s in their folder.',
926 self.OLD_LOG_SUFFIX)
927 for ts in tss:
928 self.get_instance_logs(ts, outdir, old=True)
929 # Lastly, servod has restarted due to a potential issue. Try to get
930 # panic information from servo micro and servo v4 for the current logs.
931 # This can only happen if the |_servo| attribute is initialized.
932 if self._servo:
933 for mcu in ['servo_micro', 'servo_v4']:
934 ctrl = '%s_uart_cmd' % mcu
935 if self._servo.has_control(ctrl):
936 logging.info('Trying to retrieve %r panicinfo into logs',
937 mcu)
938 try:
939 self._servo.set_nocheck(ctrl, 'panicinfo')
940 except error.TestFail as e:
941 logging.error('Failed to generate panicinfo for %r '
942 'logs. %s', mcu, str(e))
943
944 def _find_instance_timestamps_between(self, start_ts, end_ts):
945 """Find all log timestamps between [start_ts, end_ts).
946
947 @param start_ts: str, earliest log timestamp of interest
948 @param end_ts: str, latest log timestamp of interest
949
950 @returns: list, all timestamps between start_ts and end_ts, end_ts
951 exclusive, on the servo_host. An empty list on errors
952 """
953 # Simply get all timestamp, and then sort and remove
954 cmd = 'ls %s' % self.remote_log_dir
955 res = self.run(cmd, stderr_tee=None, ignore_status=True)
956 if res.exit_status != 0:
957 # Here we failed to find anything.
958 logging.info('Failed to find remote servod logs. Ignoring.')
959 return []
960 logfiles = res.stdout.strip().split()
961 timestamps = set()
962 for logfile in logfiles:
963 ts_match = self.TS_EXTRACTOR.match(logfile)
964 if not ts_match:
965 # Simply ignore files that fail the check. It might be the
966 # 'latest' symlinks or random files.
967 continue
968 timestamps.add(ts_match.group(self.TS_GROUP))
969 # At this point we have all unique timestamps.
970 timestamps = sorted(timestamps)
971 for ts in [start_ts, end_ts]:
972 if ts not in timestamps:
973 logging.error('Timestamp %r not in servod logs. Cannot query '
974 'for timestamps in between %r and %r', ts,
975 start_ts, end_ts)
976 return []
977 return timestamps[timestamps.index(start_ts):timestamps.index(end_ts)]
978
979 def get_instance_logs_ts(self):
980 """Retrieve the currently running servod instance's log timestamp
981
982 @returns: str, timestamp for current instance, or None on failure
983 """
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800984 # First, extract the timestamp. This cmd gives the real filename of
985 # the latest aka current log file.
986 cmd = ('if [ -f %(dir)s/latest.DEBUG ];'
987 'then realpath %(dir)s/latest.DEBUG;'
988 'elif [ -f %(dir)s/latest ];'
989 'then realpath %(dir)s/latest;'
990 'else exit %(code)d;'
991 'fi' % {'dir': self.remote_log_dir,
992 'code': self.NO_SYMLINKS_CODE})
993 res = self.run(cmd, stderr_tee=None, ignore_status=True)
994 if res.exit_status != 0:
995 if res.exit_status == self.NO_SYMLINKS_CODE:
996 logging.warning('servod log latest symlinks not found. '
997 'This is likely due to an error starting up '
998 'servod. Ignoring..')
999 else:
1000 logging.warning('Failed to find servod logs on servo host.')
1001 logging.warning(res.stderr.strip())
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001002 return None
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001003 fname = os.path.basename(res.stdout.strip())
1004 # From the fname, ought to extract the timestamp using the TS_EXTRACTOR
Ruben Rodriguez Buchillone9aa2b02020-03-04 12:14:28 -08001005 ts_match = self.TS_EXTRACTOR.match(fname)
1006 if not ts_match:
1007 logging.warning('Failed to extract timestamp from servod log file '
1008 '%r. Skipping. The servo host is using outdated '
1009 'servod logging and needs to be updated.', fname)
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001010 return None
1011 return ts_match.group(self.TS_GROUP)
1012
1013 def get_instance_logs(self, instance_ts, outdir, old=False):
1014 """Collect all logs with |instance_ts| and dump into a dir in |outdir|
1015
1016 This method first collects all logs on the servo_host side pertaining
1017 to this servod instance (port, instatiation). It glues them together
1018 into combined log.[level].txt files and extracts all available MCU
1019 console I/O from the logs into individual files e.g. servo_v4.txt
1020
1021 All the output can be found in a directory inside |outdir| that
1022 this generates based on |LOG_DIR|, the servod port, and the instance
1023 timestamp on the servo_host side.
1024
1025 @param instance_ts: log timestamp to grab logfiles for
1026 @param outdir: directory to create a subdirectory into to place the
1027 servod logs into.
1028 @param old: bool, whether to append |OLD_LOG_SUFFIX| to output dir
1029 """
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001030 # Create the local results log dir.
1031 log_dir = os.path.join(outdir, '%s_%s.%s' % (self.LOG_DIR,
1032 str(self.servo_port),
1033 instance_ts))
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001034 if old:
Garry Wang22f2e842020-09-09 20:19:19 -07001035 log_dir = '%s.%s' % (log_dir, self.OLD_LOG_SUFFIX)
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001036 logging.info('Saving servod logs to %r.', log_dir)
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001037 os.mkdir(log_dir)
1038 # Now, get all files with that timestamp.
1039 cmd = 'find %s -maxdepth 1 -name "log.%s*"' % (self.remote_log_dir,
1040 instance_ts)
1041 res = self.run(cmd, stderr_tee=None, ignore_status=True)
1042 files = res.stdout.strip().split()
1043 try:
1044 self.get_file(files, log_dir, try_rsync=False)
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001045 if not os.listdir(log_dir):
1046 logging.info('No servod logs retrieved. Ignoring, and removing '
1047 '%r again.', log_dir)
1048 os.rmdir(log_dir)
1049 return
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001050 except error.AutoservRunError as e:
1051 result = e.result_obj
1052 if result.exit_status != 0:
1053 stderr = result.stderr.strip()
1054 logging.warning("Couldn't retrieve servod logs. Ignoring: %s",
1055 stderr or '\n%s' % result)
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001056 # Remove the log_dir as nothing was added to it.
1057 os.rmdir(log_dir)
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001058 return
1059 local_files = [os.path.join(log_dir, f) for f in os.listdir(log_dir)]
1060 # TODO(crrev.com/c/1793030): remove no-level case once CL is pushed
1061 for level_name in ('DEBUG', 'INFO', 'WARNING', ''):
1062 # Create the joint files for each loglevel. i.e log.DEBUG
1063 joint_file = self.JOINT_LOG_PREFIX
1064 if level_name:
1065 joint_file = '%s.%s' % (self.JOINT_LOG_PREFIX, level_name)
1066 # This helps with some online tools to avoid complaints about an
1067 # unknown filetype.
1068 joint_file = joint_file + '.txt'
1069 joint_path = os.path.join(log_dir, joint_file)
1070 files = [f for f in local_files if level_name in f]
1071 if not files:
1072 # TODO(crrev.com/c/1793030): remove no-level case once CL
1073 # is pushed
1074 continue
1075 # Extract compressed logs if any.
1076 compressed, extracted = self._extract_compressed_logs(log_dir,
1077 files)
1078 files = list(set(files) - set(compressed))
1079 files.extend(extracted)
1080 # Need to sort. As they all share the same timestamp, and
1081 # loglevel, the index itself is sufficient. The highest index
1082 # is the oldest file, therefore we need a descending sort.
1083 def sortkey(f, level=level_name):
1084 """Custom sortkey to sort based on rotation number int."""
1085 if f.endswith(level_name): return 0
1086 return int(f.split('.')[-1])
1087
1088 files.sort(reverse=True, key=sortkey)
1089 # Just rename the first file rather than building from scratch.
1090 os.rename(files[0], joint_path)
1091 with open(joint_path, 'a') as joint_f:
1092 for logfile in files[1:]:
1093 # Transfer the file to the joint file line by line.
1094 with open(logfile, 'r') as log_f:
1095 for line in log_f:
1096 joint_f.write(line)
1097 # File has been written over. Delete safely.
1098 os.remove(logfile)
1099 # Need to remove all files form |local_files| so we don't
1100 # analyze them again.
1101 local_files = list(set(local_files) - set(files) - set(compressed))
1102 # Lastly, extract MCU logs from the joint logs.
1103 self._extract_mcu_logs(log_dir)
1104
Garry Wang79e9af62019-06-12 15:19:19 -07001105 def _lock(self):
1106 """lock servohost by touching a file.
1107 """
1108 logging.debug('Locking servohost %s by touching %s file',
1109 self.hostname, self._lock_file)
1110 self.run('touch %s' % self._lock_file, ignore_status=True)
Garry Wang7c00b0f2019-06-25 17:28:17 -07001111 self._is_locked = True
Garry Wang79e9af62019-06-12 15:19:19 -07001112
Garry Wang79e9af62019-06-12 15:19:19 -07001113 def _unlock(self):
1114 """Unlock servohost by removing the lock file.
1115 """
1116 logging.debug('Unlocking servohost by removing %s file',
1117 self._lock_file)
1118 self.run('rm %s' % self._lock_file, ignore_status=True)
Garry Wang7c00b0f2019-06-25 17:28:17 -07001119 self._is_locked = False
Garry Wang79e9af62019-06-12 15:19:19 -07001120
Congbin Guoa1f9cba2018-07-03 11:36:59 -07001121 def close(self):
Congbin Guofc3b8962019-03-22 17:38:46 -07001122 """Close the associated servo and the host object."""
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001123 # NOTE: throughout this method there are multiple attempts to catch
1124 # all errors. This is WAI as log grabbing should not fail tests.
1125 # However, the goal is to catch and handle/process all errors, thus
1126 # we print the traceback and ask for a bug.
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001127 if self._closed:
1128 logging.debug('ServoHost is already closed.')
1129 return
Garry Wang22f2e842020-09-09 20:19:19 -07001130
1131 # Only attempt ssh related actions if servohost is sshable. We call
1132 # check_cached_up_status() first because it's lightweighted and return
1133 # much faster in the case servohost is down, however, we still want
1134 # to call is_up() later since check_cached_up_status() is ping based check
1135 # and not guarantee the servohost is sshable.
1136 servo_host_ready = self.check_cached_up_status() and self.is_up()
1137
1138 if servo_host_ready:
1139 instance_ts = self.get_instance_logs_ts()
1140 else:
1141 logging.info('Servohost is down, will skip servod log collecting.')
1142 instance_ts = None
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001143 # TODO(crbug.com/1011516): once enabled, remove the check against
1144 # localhost and instead check against log-rotiation enablement.
1145 logs_available = (instance_ts is not None and
1146 self.job and
1147 not self.is_localhost())
1148 if logs_available:
1149 # Probe whether there was a servod restart, and grab those old
1150 # logs as well.
1151 try:
1152 self.probe_servod_restart(instance_ts, self.job.resultdir)
1153 except (error.AutoservRunError, error.TestFail) as e:
1154 logging.info('Failed to grab servo logs due to: %s. '
1155 'This error is forgiven.', str(e))
1156 except Exception as e:
1157 logging.error('Unexpected error probing for old logs. %s. '
1158 'Forgiven. Please file a bug and fix or catch '
1159 'in log probing function', str(e),
1160 exc_info=True)
Congbin Guoa1f9cba2018-07-03 11:36:59 -07001161 if self._servo:
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001162 outdir = None if not self.job else self.job.resultdir
Congbin Guo2e5e2a22018-07-27 10:32:48 -07001163 # In some cases when we run as lab-tools, the job object is None.
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001164 self._servo.close(outdir)
1165
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001166 if logs_available:
1167 # Grab current (not old like above) logs after the servo instance
1168 # was closed out.
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001169 try:
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001170 self.get_instance_logs(instance_ts, self.job.resultdir)
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001171 except error.AutoservRunError as e:
1172 logging.info('Failed to grab servo logs due to: %s. '
1173 'This error is forgiven.', str(e))
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001174 except Exception as e:
1175 logging.error('Unexpected error grabbing servod logs. %s. '
1176 'Forgiven. Please file a bug and fix or catch '
1177 'in log grabbing function', str(e), exc_info=True)
Congbin Guoa1f9cba2018-07-03 11:36:59 -07001178
Garry Wang22f2e842020-09-09 20:19:19 -07001179 if self._is_locked and servo_host_ready:
Garry Wang7c00b0f2019-06-25 17:28:17 -07001180 # Remove the lock if the servohost has been locked.
Garry Wang79e9af62019-06-12 15:19:19 -07001181 try:
1182 self._unlock()
1183 except error.AutoservSSHTimeout:
1184 logging.error('Unlock servohost failed due to ssh timeout.'
1185 ' It may caused by servohost went down during'
1186 ' the task.')
Garry Wangc1288cf2019-12-17 14:58:00 -08001187 # We want always stop servod after task to minimum the impact of bad
1188 # servod process interfere other servods.(see crbug.com/1028665)
Garry Wang22f2e842020-09-09 20:19:19 -07001189 if servo_host_ready:
1190 try:
1191 self.stop_servod()
1192 except error.AutoservRunError as e:
1193 logging.info(
1194 "Failed to stop servod due to:\n%s\n"
1195 "This error is forgiven.", str(e))
Garry Wangc1288cf2019-12-17 14:58:00 -08001196
Congbin Guoa1f9cba2018-07-03 11:36:59 -07001197 super(ServoHost, self).close()
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001198 # Mark closed.
1199 self._closed = True
Congbin Guoa1f9cba2018-07-03 11:36:59 -07001200
Otabek Kasimovcc9738e2020-02-14 16:17:15 -08001201 def get_servo_state(self):
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001202 return self._servo_state
Otabek Kasimovcc9738e2020-02-14 16:17:15 -08001203
Otabek Kasimovc6f30412020-06-30 20:08:12 -07001204 def _get_host_metrics_data(self):
1205 return {'port': self.servo_port,
Otabek Kasimov0ea47362020-07-11 20:55:09 -07001206 'host': self.get_dut_hostname() or self.hostname,
Otabek Kasimovc6f30412020-06-30 20:08:12 -07001207 'board': self.servo_board or ''}
1208
1209 def _is_servo_device_connected(self, servo_type, serial):
1210 """Check if device is connected to the labstation.
1211
1212 Works for all servo devices connected to the labstation.
1213 For servo_v3 please use 'self._is_servo_board_present_on_servo_v3'
1214
1215 @param servo_type: The type of servo device. Expecting value can be
1216 servo_v4 or servo_micro.
1217 @param serial: The serial number of the device to detect it.
1218 """
1219 vid_pid = self.SERVO_VID_PID.get(servo_type)
1220 if not vid_pid or not serial:
1221 # device cannot detected without VID/PID or serial number
1222 return False
1223 logging.debug('Started to detect %s', servo_type)
1224 try:
1225 cmd = 'lsusb -v -d %s |grep iSerial |grep %s' % (vid_pid, serial)
1226 result = self.run(cmd, ignore_status=True, timeout=30)
1227 if result.exit_status == 0 and result.stdout.strip():
1228 logging.debug('The %s is plugged in to the host.', servo_type)
1229 return True
1230 logging.debug('%s device is not detected; %s', servo_type, result)
1231 return False
1232 except Exception as e:
1233 # can be triggered by timeout issue due running the script
1234 metrics.Counter(
1235 'chromeos/autotest/repair/servo_detection/timeout'
1236 ).increment(fields=self._get_host_metrics_data())
1237 logging.error('%s device is not detected; %s', servo_type, str(e))
1238 return None
1239
1240 def _is_servo_board_present_on_servo_v3(self):
1241 """Check if servo board is detected on servo_v3"""
1242 vid_pids = self.SERVO_VID_PID['servo_v3']
1243 if not vid_pids or len(vid_pids) == 0:
1244 # device cannot detected without VID/PID
1245 return False
1246 logging.debug('Started to detect servo board on servo_v3')
1247 not_detected = 'The servo board is not detected on servo_v3'
1248 try:
1249 cmd = 'lsusb | grep "%s"' % "\|".join(vid_pids)
1250 result = self.run(cmd, ignore_status=True, timeout=30)
1251 if result.exit_status == 0 and result.stdout.strip():
1252 logging.debug('The servo board is detected on servo_v3')
1253 return True
1254 logging.debug('%s; %s', not_detected, result)
1255 return False
1256 except Exception as e:
1257 # can be triggered by timeout issue due running the script
1258 metrics.Counter(
1259 'chromeos/autotest/repair/servo_detection/timeout'
1260 ).increment(fields=self._get_host_metrics_data())
1261 logging.error('%s; %s', not_detected, str(e))
1262 return None
1263
Otabek Kasimov120b6fa2020-07-03 00:15:27 -07001264 def _is_main_device_not_detected_on_servo_v4(self):
1265 """Check if servod cannot find main device on servo.
1266
1267 The check based on reading servod logs for servo_v4.
1268 """
1269 if not self._initial_instance_ts:
1270 # latest log not found
1271 return False
1272 logging.debug('latest log for servod created at %s',
1273 self._initial_instance_ts)
1274 try:
1275 log_created = calendar.timegm(time.strptime(
1276 self._initial_instance_ts,
1277 "%Y-%m-%d--%H-%M-%S.%f"))
1278 except ValueError as e:
1279 logging.debug('Cannot read time from log file name: %s',
1280 self._initial_instance_ts)
1281 return False
1282 min_time_created = calendar.timegm(time.gmtime())
1283 if min_time_created > log_created + 3600:
1284 # the log file is old we cannot use it
1285 logging.debug('log file was created more than hour ago, too old')
1286 return False
1287 logging.debug('latest log was created not longer then 1 hour ago')
1288
1289 # check if servod can detect main device by servo_v4
1290 message = 'ERROR - No servo micro or CCD detected for board'
1291 cmd = ('cat /var/log/servod_%s/log.%s.INFO |grep "%s"'
1292 % (self.servo_port, self._initial_instance_ts, message))
1293 result = self.run(cmd, ignore_status=True)
1294 if result.stdout.strip():
1295 logging.info('Servod cannot detect main device on the servo; '
1296 'Can be caused by bad hardware of servo or '
1297 'issue on the DUT side.')
1298 return True
1299 logging.debug('The main device is detected')
1300 return False
1301
Garry Wangb5cee3e2020-09-16 14:58:13 -07001302 def _require_cr50_servod_config(self):
1303 """Check whether we need start servod with CONFIG=cr50.xml"""
1304 dut_host_info = self.get_dut_host_info()
1305 if not dut_host_info:
1306 return False
1307 for pool in dut_host_info.pools:
1308 if pool.startswith(servo_constants.CR50_CONFIG_POOL_PREFIX):
1309 return True
1310 return False
1311
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001312 def get_verifier_state(self, tag):
Otabek Kasimov15963492020-06-23 21:10:51 -07001313 """Return the state of servo verifier.
1314
1315 @returns: bool or None
1316 """
1317 return self._repair_strategy.verifier_is_good(tag)
1318
1319 def determine_servo_state(self):
1320 """Determine servo state based on the failed verifier.
1321
1322 @returns: servo state value
1323 The state detecting based on first fail verifier or collecting of
1324 them.
1325 """
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001326 ssh = self.get_verifier_state('servo_ssh')
1327 disk_space = self.get_verifier_state('disk_space')
1328 start_servod = self.get_verifier_state('servod_job')
1329 create_servo = self.get_verifier_state('servod_connection')
1330 init_servo = self.get_verifier_state('servod_control')
1331 dut_connected = self.get_verifier_state('dut_connected')
1332 pwr_button = self.get_verifier_state('pwr_button')
1333 lid_open = self.get_verifier_state('lid_open')
1334 ec_board = self.get_verifier_state('ec_board')
1335 ccd_testlab = self.get_verifier_state('ccd_testlab')
Otabek Kasimov15963492020-06-23 21:10:51 -07001336
1337 if not ssh:
1338 return servo_constants.SERVO_STATE_NO_SSH
1339
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001340 if (start_servod == hosts.VERIFY_FAILED
1341 or create_servo == hosts.VERIFY_FAILED):
Otabek Kasimov066bdb82020-08-12 15:57:44 -07001342 # sometimes servo can start with out present servo
Otabek Kasimovc6f30412020-06-30 20:08:12 -07001343 if self.is_labstation():
1344 if not self.servo_serial:
1345 return servo_constants.SERVO_STATE_WRONG_CONFIG
1346 if self._is_servo_device_connected(
1347 'servo_v4',
1348 self.servo_serial) == False:
1349 return servo_constants.SERVO_STATE_NOT_CONNECTED
1350 elif self._is_servo_board_present_on_servo_v3() == False:
1351 return servo_constants.SERVO_STATE_NOT_CONNECTED
Otabek Kasimov066bdb82020-08-12 15:57:44 -07001352
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001353 if dut_connected == hosts.VERIFY_FAILED:
1354 if pwr_button == hosts.VERIFY_SUCCESS:
Otabek Kasimova7eb4dc2020-09-16 10:25:17 -07001355 # unexpected case
1356 metrics.Counter(
1357 'chromeos/autotest/repair/servo_unexpected/pwr_button'
1358 ).increment(fields=self._get_host_metrics_data())
1359 return servo_constants.SERVO_STATE_DUT_NOT_CONNECTED
1360
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001361 if start_servod == hosts.VERIFY_FAILED:
Otabek Kasimovc6f30412020-06-30 20:08:12 -07001362 return servo_constants.SERVO_STATE_SERVOD_ISSUE
1363
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001364 if create_servo == hosts.VERIFY_FAILED:
Otabek Kasimov120b6fa2020-07-03 00:15:27 -07001365 if (self.is_labstation()
1366 and self._is_main_device_not_detected_on_servo_v4()):
1367 servo_type = None
1368 if self.get_dut_host_info():
1369 servo_type = self.get_dut_host_info().get_label_value(
1370 servo_constants.SERVO_TYPE_LABEL_PREFIX)
1371 if servo_type and 'servo_micro' in servo_type:
1372 serial = self.get_servo_micro_serial_number()
1373 logging.debug('servo_micro serial: %s', serial)
1374 if self._is_servo_device_detected('servo_micro',
1375 serial):
1376 return servo_constants.SERVO_STATE_BAD_RIBBON_CABLE
1377 # Device can be not detected because of DUT
1378 # TODO (otabek) update after b/159755652 and b/159754985
1379 metrics.Counter(
1380 'chromeos/autotest/repair/servo_state/needs_replacement'
1381 ).increment(fields=self._get_host_metrics_data())
1382 elif not self.is_labstation():
1383 # Here need logic to check if flex cable is connected
1384 pass
1385
Otabek Kasimov15963492020-06-23 21:10:51 -07001386 # one of the reason why servo can not initialized
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001387 if ccd_testlab == hosts.VERIFY_FAILED:
Otabek Kasimov15963492020-06-23 21:10:51 -07001388 return servo_constants.SERVO_STATE_CCD_TESTLAB_ISSUE
1389
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001390 if (create_servo == hosts.VERIFY_FAILED
1391 or init_servo == hosts.VERIFY_FAILED):
Otabek Kasimov15963492020-06-23 21:10:51 -07001392 return servo_constants.SERVO_STATE_SERVOD_ISSUE
1393
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001394 if ec_board == hosts.VERIFY_FAILED:
Otabek Kasimov015c15c2020-08-20 00:40:42 -07001395 return servo_constants.SERVO_STATE_EC_BROKEN
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001396 if pwr_button == hosts.VERIFY_FAILED:
Otabek Kasimov15963492020-06-23 21:10:51 -07001397 return servo_constants.SERVO_STATE_BAD_RIBBON_CABLE
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001398 if lid_open == hosts.VERIFY_FAILED:
Otabek Kasimov15963492020-06-23 21:10:51 -07001399 return servo_constants.SERVO_STATE_LID_OPEN_FAILED
Otabek Kasimov15963492020-06-23 21:10:51 -07001400
Otabek Kasimov15963492020-06-23 21:10:51 -07001401 metrics.Counter(
1402 'chromeos/autotest/repair/unknown_servo_state'
Otabek Kasimovc6f30412020-06-30 20:08:12 -07001403 ).increment(fields=self._get_host_metrics_data())
Otabek Kasimov15963492020-06-23 21:10:51 -07001404 logging.info('We do not have special state for this failure yet :)')
1405 return servo_constants.SERVO_STATE_BROKEN
1406
Otabek Kasimovcc9738e2020-02-14 16:17:15 -08001407
Richard Barnetteea3e4602016-06-10 12:36:41 -07001408def make_servo_hostname(dut_hostname):
1409 """Given a DUT's hostname, return the hostname of its servo.
1410
1411 @param dut_hostname: hostname of a DUT.
1412
1413 @return hostname of the DUT's servo.
1414
1415 """
1416 host_parts = dut_hostname.split('.')
1417 host_parts[0] = host_parts[0] + '-servo'
1418 return '.'.join(host_parts)
1419
1420
1421def servo_host_is_up(servo_hostname):
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -07001422 """Given a servo host name, return if it's up or not.
Richard Barnetteea3e4602016-06-10 12:36:41 -07001423
1424 @param servo_hostname: hostname of the servo host.
1425
1426 @return True if it's up, False otherwise
1427 """
1428 # Technically, this duplicates the SSH ping done early in the servo
1429 # proxy initialization code. However, this ping ends in a couple
1430 # seconds when if fails, rather than the 60 seconds it takes to decide
1431 # that an SSH ping has timed out. Specifically, that timeout happens
1432 # when our servo DNS name resolves, but there is no host at that IP.
1433 logging.info('Pinging servo host at %s', servo_hostname)
1434 ping_config = ping_runner.PingConfig(
1435 servo_hostname, count=3,
1436 ignore_result=True, ignore_status=True)
1437 return ping_runner.PingRunner().ping(ping_config).received > 0
1438
1439
Richard Barnettee519dcd2016-08-15 17:37:17 -07001440def _map_afe_board_to_servo_board(afe_board):
1441 """Map a board we get from the AFE to a servo appropriate value.
1442
1443 Many boards are identical to other boards for servo's purposes.
1444 This function makes that mapping.
1445
1446 @param afe_board string board name received from AFE.
1447 @return board we expect servo to have.
1448
1449 """
1450 KNOWN_SUFFIXES = ['-freon', '_freon', '_moblab', '-cheets']
1451 BOARD_MAP = {'gizmo': 'panther'}
1452 mapped_board = afe_board
1453 if afe_board in BOARD_MAP:
1454 mapped_board = BOARD_MAP[afe_board]
1455 else:
1456 for suffix in KNOWN_SUFFIXES:
1457 if afe_board.endswith(suffix):
1458 mapped_board = afe_board[0:-len(suffix)]
1459 break
1460 if mapped_board != afe_board:
1461 logging.info('Mapping AFE board=%s to %s', afe_board, mapped_board)
1462 return mapped_board
1463
1464
Prathmesh Prabhub4810232018-09-07 13:24:08 -07001465def get_servo_args_for_host(dut_host):
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -07001466 """Return servo data associated with a given DUT.
Richard Barnetteea3e4602016-06-10 12:36:41 -07001467
Richard Barnetteea3e4602016-06-10 12:36:41 -07001468 @param dut_host Instance of `Host` on which to find the servo
1469 attributes.
Prathmesh Prabhuf605dd32018-08-28 17:09:04 -07001470 @return `servo_args` dict with host and an optional port.
Richard Barnetteea3e4602016-06-10 12:36:41 -07001471 """
Prathmesh Prabhucba44292018-08-28 17:44:45 -07001472 info = dut_host.host_info_store.get()
Derek Beckettf73baca2020-08-19 15:08:47 -07001473 servo_args = {k: v for k, v in six.iteritems(info.attributes)
Garry Wang11b5e872020-03-11 15:14:08 -07001474 if k in servo_constants.SERVO_ATTR_KEYS}
Richard Barnetteea3e4602016-06-10 12:36:41 -07001475
Garry Wang11b5e872020-03-11 15:14:08 -07001476 if servo_constants.SERVO_PORT_ATTR in servo_args:
Prathmesh Prabhucba44292018-08-28 17:44:45 -07001477 try:
Garry Wang11b5e872020-03-11 15:14:08 -07001478 servo_args[servo_constants.SERVO_PORT_ATTR] = int(
1479 servo_args[servo_constants.SERVO_PORT_ATTR])
Prathmesh Prabhucba44292018-08-28 17:44:45 -07001480 except ValueError:
1481 logging.error('servo port is not an int: %s',
Garry Wang11b5e872020-03-11 15:14:08 -07001482 servo_args[servo_constants.SERVO_PORT_ATTR])
Prathmesh Prabhucba44292018-08-28 17:44:45 -07001483 # Reset servo_args because we don't want to use an invalid port.
Garry Wang11b5e872020-03-11 15:14:08 -07001484 servo_args.pop(servo_constants.SERVO_HOST_ATTR, None)
Prathmesh Prabhucba44292018-08-28 17:44:45 -07001485
1486 if info.board:
Garry Wang11b5e872020-03-11 15:14:08 -07001487 servo_board = _map_afe_board_to_servo_board(info.board)
1488 servo_args[servo_constants.SERVO_BOARD_ATTR] = servo_board
Nick Sanders2f3c9852018-10-24 12:10:24 -07001489 if info.model:
Garry Wang11b5e872020-03-11 15:14:08 -07001490 servo_args[servo_constants.SERVO_MODEL_ATTR] = info.model
1491 return servo_args if servo_constants.SERVO_HOST_ATTR in servo_args else None
Richard Barnetteea3e4602016-06-10 12:36:41 -07001492
1493
Prathmesh Prabhuefb1b482018-08-28 17:15:05 -07001494def _tweak_args_for_ssp_moblab(servo_args):
Garry Wang11b5e872020-03-11 15:14:08 -07001495 if (servo_args[servo_constants.SERVO_HOST_ATTR]
1496 in ['localhost', '127.0.0.1']):
1497 servo_args[servo_constants.SERVO_HOST_ATTR] = _CONFIG.get_config_value(
Prathmesh Prabhuefb1b482018-08-28 17:15:05 -07001498 'SSP', 'host_container_ip', type=str, default=None)
1499
1500
Dan Shi023aae32016-05-25 11:13:01 -07001501def create_servo_host(dut, servo_args, try_lab_servo=False,
Gregory Nisbetde13e2a2019-12-09 22:44:00 -08001502 try_servo_repair=False, dut_host_info=None):
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -07001503 """Create a ServoHost object for a given DUT, if appropriate.
Dan Shi4d478522014-02-14 13:46:32 -08001504
Richard Barnette9a26ad62016-06-10 12:03:08 -07001505 This function attempts to create and verify or repair a `ServoHost`
1506 object for a servo connected to the given `dut`, subject to various
1507 constraints imposed by the parameters:
1508 * When the `servo_args` parameter is not `None`, a servo
1509 host must be created, and must be checked with `repair()`.
1510 * Otherwise, if a servo exists in the lab and `try_lab_servo` is
1511 true:
1512 * If `try_servo_repair` is true, then create a servo host and
1513 check it with `repair()`.
1514 * Otherwise, if the servo responds to `ping` then create a
1515 servo host and check it with `verify()`.
Fang Denge545abb2014-12-30 18:43:47 -08001516
Richard Barnette9a26ad62016-06-10 12:03:08 -07001517 In cases where `servo_args` was not `None`, repair failure
1518 exceptions are passed back to the caller; otherwise, exceptions
Richard Barnette07c2e1d2016-10-26 14:24:28 -07001519 are logged and then discarded. Note that this only happens in cases
1520 where we're called from a test (not special task) control file that
1521 has an explicit dependency on servo. In that case, we require that
1522 repair not write to `status.log`, so as to avoid polluting test
1523 results.
1524
1525 TODO(jrbarnette): The special handling for servo in test control
1526 files is a thorn in my flesh; I dearly hope to see it cut out before
1527 my retirement.
Richard Barnette9a26ad62016-06-10 12:03:08 -07001528
1529 Parameters for a servo host consist of a host name, port number, and
1530 DUT board, and are determined from one of these sources, in order of
1531 priority:
Richard Barnetteea3e4602016-06-10 12:36:41 -07001532 * Servo attributes from the `dut` parameter take precedence over
1533 all other sources of information.
1534 * If a DNS entry for the servo based on the DUT hostname exists in
1535 the CrOS lab network, that hostname is used with the default
Richard Barnette9a26ad62016-06-10 12:03:08 -07001536 port and the DUT's board.
Richard Barnetteea3e4602016-06-10 12:36:41 -07001537 * If no other options are found, the parameters will be taken
Richard Barnette9a26ad62016-06-10 12:03:08 -07001538 from the `servo_args` dict passed in from the caller.
Richard Barnetteea3e4602016-06-10 12:36:41 -07001539
1540 @param dut An instance of `Host` from which to take
1541 servo parameters (if available).
1542 @param servo_args A dictionary with servo parameters to use if
1543 they can't be found from `dut`. If this
1544 argument is supplied, unrepaired exceptions
1545 from `verify()` will be passed back to the
1546 caller.
1547 @param try_lab_servo If not true, servo host creation will be
1548 skipped unless otherwise required by the
1549 caller.
Richard Barnette9a26ad62016-06-10 12:03:08 -07001550 @param try_servo_repair If true, check a servo host with
1551 `repair()` instead of `verify()`.
Otabek Kasimov8475cce2020-07-14 12:11:31 -07001552 @param dut_host_info: A HostInfo object of the DUT that connected
1553 to this servo.
Dan Shi4d478522014-02-14 13:46:32 -08001554
1555 @returns: A ServoHost object or None. See comments above.
1556
1557 """
Richard Barnette07c2e1d2016-10-26 14:24:28 -07001558 servo_dependency = servo_args is not None
Richard Barnette07c2e1d2016-10-26 14:24:28 -07001559 if dut is not None and (try_lab_servo or servo_dependency):
Prathmesh Prabhub4810232018-09-07 13:24:08 -07001560 servo_args_override = get_servo_args_for_host(dut)
Richard Barnetteea3e4602016-06-10 12:36:41 -07001561 if servo_args_override is not None:
Prathmesh Prabhuefb1b482018-08-28 17:15:05 -07001562 if utils.in_moblab_ssp():
1563 _tweak_args_for_ssp_moblab(servo_args_override)
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001564 logging.debug(
1565 'Overriding provided servo_args (%s) with arguments'
1566 ' determined from the host (%s)',
1567 servo_args,
1568 servo_args_override,
1569 )
Richard Barnetteea3e4602016-06-10 12:36:41 -07001570 servo_args = servo_args_override
Prathmesh Prabhucba44292018-08-28 17:44:45 -07001571
Richard Barnetteea3e4602016-06-10 12:36:41 -07001572 if servo_args is None:
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001573 logging.debug('No servo_args provided, and failed to find overrides.')
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001574 if try_lab_servo or servo_dependency:
Otabek Kasimov646812c2020-06-23 20:01:36 -07001575 return None, servo_constants.SERVO_STATE_MISSING_CONFIG
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001576 else:
1577 # For regular test case which not required the servo
1578 return None, None
1579
Garry Wang11b5e872020-03-11 15:14:08 -07001580 servo_hostname = servo_args.get(servo_constants.SERVO_HOST_ATTR)
1581 servo_port = servo_args.get(servo_constants.SERVO_PORT_ATTR)
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001582 if not _is_servo_host_information_exist(servo_hostname, servo_port):
1583 logging.debug(
1584 'Servo connection info missed hostname: %s , port: %s',
1585 servo_hostname, servo_port)
Otabek Kasimov646812c2020-06-23 20:01:36 -07001586 return None, servo_constants.SERVO_STATE_MISSING_CONFIG
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001587 if not is_servo_host_information_valid(servo_hostname, servo_port):
1588 logging.debug(
1589 'Servo connection info is incorrect hostname: %s , port: %s',
1590 servo_hostname, servo_port)
Garry Wang11b5e872020-03-11 15:14:08 -07001591 return None, servo_constants.SERVO_STATE_WRONG_CONFIG
Richard Barnette07c2e1d2016-10-26 14:24:28 -07001592 if (not servo_dependency and not try_servo_repair and
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001593 not servo_host_is_up(servo_hostname)):
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001594 logging.debug('ServoHost is not up.')
Otabek Kasimov646812c2020-06-23 20:01:36 -07001595 return None, servo_constants.SERVO_STATE_NO_SSH
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001596
Garry Wangebc015b2019-06-06 17:45:06 -07001597 newhost = ServoHost(**servo_args)
Garry Wangffbd2162020-04-17 16:13:48 -07001598
Otabek Kasimove6df8102020-07-21 20:15:25 -07001599 # Reset or reboot servo device only during AdminRepair tasks.
1600 if try_servo_repair:
1601 if newhost._is_locked:
1602 # Reset servo if the servo is locked, as we check if the servohost
1603 # is up, if the servohost is labstation and if the servohost is in
1604 # lab inside the locking logic.
1605 newhost.reset_servo()
1606 else:
Garry Wang358aad42020-08-02 20:56:04 -07001607 try:
1608 newhost.reboot_servo_v3_on_need()
Garry Wang1f0d5332020-08-10 19:32:32 -07001609 except Exception as e:
1610 logging.info('[Non-critical] Unexpected error while trying to'
1611 ' reboot servo_v3, skipping the reboot; %s', e)
Otabek Kasimove6df8102020-07-21 20:15:25 -07001612
Otabek Kasimov2b50cdb2020-07-06 19:16:06 -07001613 if dut:
1614 newhost.set_dut_hostname(dut.hostname)
Otabek Kasimov9e90ae12020-08-14 03:01:19 -07001615 if dut_host_info:
1616 newhost.set_dut_host_info(dut_host_info)
Garry Wangffbd2162020-04-17 16:13:48 -07001617
Otabek Kasimov8475cce2020-07-14 12:11:31 -07001618 if try_lab_servo or try_servo_repair:
1619 try:
1620 logging.info("Check and update servo firmware.")
1621 servo_updater.update_servo_firmware(
1622 newhost,
1623 force_update=False)
1624 except Exception as e:
1625 logging.error("Servo device update error: %s", e)
1626
Garry Wangcdd27b22020-01-13 14:59:11 -08001627 try:
1628 newhost.restart_servod(quick_startup=True)
1629 except error.AutoservSSHTimeout:
1630 logging.warning("Restart servod failed due ssh connection "
1631 "to servohost timed out. This error is forgiven"
1632 " here, we will retry in servo repair process.")
1633 except error.AutoservRunError as e:
1634 logging.warning("Restart servod failed due to:\n%s\n"
1635 "This error is forgiven here, we will retry"
1636 " in servo repair process.", str(e))
Garry Wangebc015b2019-06-06 17:45:06 -07001637
Richard Barnette9a26ad62016-06-10 12:03:08 -07001638 # Note that the logic of repair() includes everything done
1639 # by verify(). It's sufficient to call one or the other;
1640 # we don't need both.
Richard Barnette07c2e1d2016-10-26 14:24:28 -07001641 if servo_dependency:
1642 newhost.repair(silent=True)
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001643 return newhost, newhost.get_servo_state()
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001644
1645 if try_servo_repair:
1646 try:
1647 newhost.repair()
1648 except Exception:
1649 logging.exception('servo repair failed for %s', newhost.hostname)
Richard Barnette9a26ad62016-06-10 12:03:08 -07001650 else:
1651 try:
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001652 newhost.verify()
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -07001653 except Exception:
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001654 logging.exception('servo verify failed for %s', newhost.hostname)
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001655 return newhost, newhost.get_servo_state()
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001656
1657
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001658def _is_servo_host_information_exist(hostname, port):
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001659 if hostname is None or len(hostname.strip()) == 0:
1660 return False
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001661 if port is None:
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001662 return False
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001663 if not type(port) is int:
1664 try:
1665 int(port)
1666 except ValueError:
1667 return False
1668
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001669 return True
1670
1671
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001672def is_servo_host_information_valid(hostname, port):
Garry Wang9b8f2342020-04-17 16:34:09 -07001673 """Check if provided servo attributes are valid.
1674
1675 @param hostname Hostname of the servohost.
1676 @param port servo port number.
1677
1678 @returns: A bool value to indicate if provided servo attribute valid.
1679 """
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001680 if not _is_servo_host_information_exist(hostname, port):
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001681 return False
1682 # checking range and correct of the port
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001683 port_int = int(port)
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001684 if port_int < 1 or port_int > 65000:
1685 return False
1686 # we expecting host contain only latters, digits and '-' or '_'
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001687 if not re.match('[a-zA-Z0-9-_\.]*$', hostname) or len(hostname) < 5:
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001688 return False
1689 return True