blob: 063b217f8d336f96cb101338afc176443090793f [file] [log] [blame]
Derek Beckettf73baca2020-08-19 15:08:47 -07001# Lint as: python2, python3
Fang Deng5d518f42013-08-02 14:04:32 -07002# Copyright (c) 2013 The Chromium OS Authors. All rights reserved.
3# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5#
6# Expects to be run in an environment with sudo and no interactive password
7# prompt, such as within the Chromium OS development chroot.
8
9
10"""This file provides core logic for servo verify/repair process."""
11
12
Derek Beckettf73baca2020-08-19 15:08:47 -070013from __future__ import absolute_import
14from __future__ import division
15from __future__ import print_function
16
Fang Deng5d518f42013-08-02 14:04:32 -070017import logging
Raul E Rangel52ca2e82018-07-03 14:10:14 -060018import os
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -080019import re
20import tarfile
Andrew McRaef0679932020-08-13 09:15:23 +100021import threading
Garry Wang2b5eef92020-08-21 16:23:35 -070022import json
Garry Wangc1288cf2019-12-17 14:58:00 -080023import time
Derek Beckettf73baca2020-08-19 15:08:47 -070024import six
25import six.moves.xmlrpc_client
Otabek Kasimov120b6fa2020-07-03 00:15:27 -070026import calendar
Fang Deng5d518f42013-08-02 14:04:32 -070027
28from autotest_lib.client.bin import utils
Garry Wang79e9af62019-06-12 15:19:19 -070029from autotest_lib.client.common_lib import error
Richard Barnette9a26ad62016-06-10 12:03:08 -070030from autotest_lib.client.common_lib import hosts
Garry Wang7b0e1b72020-03-25 19:08:59 -070031from autotest_lib.client.common_lib import lsbrelease_utils
Fang Deng5d518f42013-08-02 14:04:32 -070032from autotest_lib.client.common_lib.cros import retry
Christopher Wileycef1f902014-06-19 11:11:23 -070033from autotest_lib.client.common_lib.cros.network import ping_runner
Richard Barnette9a26ad62016-06-10 12:03:08 -070034from autotest_lib.server.cros.servo import servo
Richard Barnetted31580e2018-05-14 19:58:00 +000035from autotest_lib.server.hosts import servo_repair
Garry Wangebc015b2019-06-06 17:45:06 -070036from autotest_lib.server.hosts import base_servohost
Garry Wang11b5e872020-03-11 15:14:08 -070037from autotest_lib.server.hosts import servo_constants
Otabek Kasimov4ea636e2020-04-14 23:35:06 -070038from autotest_lib.server.cros.faft.utils import config
Garry Wang11b5e872020-03-11 15:14:08 -070039from autotest_lib.client.common_lib import global_config
Otabek Kasimov8475cce2020-07-14 12:11:31 -070040from autotest_lib.site_utils.admin_audit import servo_updater
Garry Wangd7367482020-02-27 13:52:40 -080041
Otabek Kasimov15963492020-06-23 21:10:51 -070042try:
43 from chromite.lib import metrics
44except ImportError:
45 metrics = utils.metrics_mock
46
Dan Shi3b2adf62015-09-02 17:46:54 -070047_CONFIG = global_config.global_config
Fang Deng5d518f42013-08-02 14:04:32 -070048
Otabek Kasimova7ba91a2020-03-09 08:31:01 -070049
Garry Wangebc015b2019-06-06 17:45:06 -070050class ServoHost(base_servohost.BaseServoHost):
51 """Host class for a servo host(e.g. beaglebone, labstation)
Dana Goyette0b6e6402019-10-04 11:09:24 -070052 that with a servo instance for a specific port.
53
54 @type _servo: servo.Servo | None
55 """
Fang Deng5d518f42013-08-02 14:04:32 -070056
Raul E Rangel52ca2e82018-07-03 14:10:14 -060057 DEFAULT_PORT = int(os.getenv('SERVOD_PORT', '9999'))
Richard Barnette9a26ad62016-06-10 12:03:08 -070058
Dan Shie5b3c512014-08-21 12:12:09 -070059 # Timeout for initializing servo signals.
Wai-Hong Tam37b6ed32017-09-19 15:52:39 -070060 INITIALIZE_SERVO_TIMEOUT_SECS = 60
Richard Barnette9a26ad62016-06-10 12:03:08 -070061
Otabek Kasimov545739c2020-08-20 00:24:21 -070062 # Default timeout for run terminal command.
63 DEFAULT_TERMINAL_TIMEOUT = 30
64
xixuan6cf6d2f2016-01-29 15:29:00 -080065 # Ready test function
66 SERVO_READY_METHOD = 'get_version'
Fang Deng5d518f42013-08-02 14:04:32 -070067
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -080068 # Directory prefix on the servo host where the servod logs are stored.
69 SERVOD_LOG_PREFIX = '/var/log/servod'
70
71 # Exit code to use when symlinks for servod logs are not found.
72 NO_SYMLINKS_CODE = 9
73
74 # Directory in the job's results directory to dump the logs into.
75 LOG_DIR = 'servod'
76
77 # Prefix for joint loglevel files in the logs.
78 JOINT_LOG_PREFIX = 'log'
79
80 # Regex group to extract timestamp from logfile name.
81 TS_GROUP = 'ts'
82
83 # This regex is used to extract the timestamp from servod logs.
Garry Wang22f2e842020-09-09 20:19:19 -070084 # files always start with log.
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -080085 TS_RE = (r'log.'
86 # The timestamp is of format %Y-%m-%d--%H-%M-%S.MS
87 r'(?P<%s>\d{4}(\-\d{2}){2}\-(-\d{2}){3}.\d{3})'
88 # The loglevel is optional depending on labstation version.
89 r'(.(INFO|DEBUG|WARNING))?' % TS_GROUP)
90 TS_EXTRACTOR = re.compile(TS_RE)
91
92 # Regex group to extract MCU name from logline in servod logs.
93 MCU_GROUP = 'mcu'
94
95 # Regex group to extract logline from MCU logline in servod logs.
96 LINE_GROUP = 'line'
97
98 # This regex is used to extract the mcu and the line content from an
99 # MCU logline in servod logs. e.g. EC or servo_v4 console logs.
100 # Here is an example log-line:
101 #
102 # 2020-01-23 13:15:12,223 - servo_v4 - EC3PO.Console - DEBUG -
103 # console.py:219:LogConsoleOutput - /dev/pts/9 - cc polarity: cc1
104 #
105 # Here is conceptually how they are formatted:
106 #
107 # <time> - <MCU> - EC3PO.Console - <LVL> - <file:line:func> - <pts> -
108 # <output>
109 #
Garry Wang22f2e842020-09-09 20:19:19 -0700110 # The log format starts with a timestamp
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800111 MCU_RE = (r'[\d\-]+ [\d:,]+ '
112 # The mcu that is logging this is next.
113 r'- (?P<%s>\w+) - '
114 # Next, we have more log outputs before the actual line.
115 # Information about the file line, logging function etc.
116 # Anchor on EC3PO Console, LogConsoleOutput and dev/pts.
117 # NOTE: if the log format changes, this regex needs to be
118 # adjusted.
119 r'EC3PO\.Console[\s\-\w\d:.]+LogConsoleOutput - /dev/pts/\d+ - '
120 # Lastly, we get the MCU's console line.
121 r'(?P<%s>.+$)' % (MCU_GROUP, LINE_GROUP))
122 MCU_EXTRACTOR = re.compile(MCU_RE)
123
Otabek Kasimov545739c2020-08-20 00:24:21 -0700124 # Regex to detect timeout messages when USBC pigtail has timeout issue.
125 # e.g.: [475635.427072 PD TMOUT RX 1/1]
126 USBC_PIGTAIL_TIMEOUT_RE = r'\[[\d \.]{1,20}(PD TMOUT RX 1\/1)\]'
127
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800128 # Suffix to identify compressed logfiles.
129 COMPRESSION_SUFFIX = '.tbz2'
130
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700131 # A suffix to mark servod log directories that came from instance that
132 # ran during this servo_host, but are not the last one running e.g. when
133 # an instance (on purpose, or due to a bug) restarted in the middle of the
134 # run.
135 OLD_LOG_SUFFIX = 'old'
136
Otabek Kasimovc6f30412020-06-30 20:08:12 -0700137 # Mapping servo board with their vid-pid
138 SERVO_VID_PID = {
139 'servo_v4':'18d1:501b',
140 'ccd_cr50':'18d1:5014',
141 'servo_micro':'18d1:501a',
142 'servo_v3':['18d1:5004', '0403:6014'],
143 }
144
Otabek Kasimov15963492020-06-23 21:10:51 -0700145 # States of verifiers
146 # True - verifier run and passed
147 # False - verifier run and failed
148 # None - verifier did not run or dependency failed
149 VERIFY_SUCCESS = True
150 VERIFY_FAILED = False
151 VERIFY_NOT_RUN = None
152
Otabek Kasimovcc9738e2020-02-14 16:17:15 -0800153 def _init_attributes(self):
154 self._servo_state = None
155 self.servo_port = None
156 self.servo_board = None
157 self.servo_model = None
158 self.servo_serial = None
Garry Wang000c6c02020-05-11 21:27:23 -0700159 # The flag that indicate if a servo is connected to a smart usbhub.
160 # TODO(xianuowang@) remove this flag once all usbhubs in the lab
161 # get replaced.
162 self.smart_usbhub = None
Otabek Kasimovcc9738e2020-02-14 16:17:15 -0800163 self._servo = None
Andrew McRaef0679932020-08-13 09:15:23 +1000164 self._tunnel_proxy = None
165 self._tunnel_proxy_lock = threading.Lock()
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700166 self._initial_instance_ts = None
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800167 # Flag to make sure that multiple calls to close do not result in the
168 # logic executing multiple times.
169 self._closed = False
Andrew McRaef0679932020-08-13 09:15:23 +1000170 # Per-thread local data
171 self._local = threading.local()
Fang Deng5d518f42013-08-02 14:04:32 -0700172
Richard Barnette17bfc6c2016-08-04 18:41:43 -0700173 def _initialize(self, servo_host='localhost',
Richard Barnettee519dcd2016-08-15 17:37:17 -0700174 servo_port=DEFAULT_PORT, servo_board=None,
Nick Sanders2f3c9852018-10-24 12:10:24 -0700175 servo_model=None, servo_serial=None, is_in_lab=None,
176 *args, **dargs):
Fang Deng5d518f42013-08-02 14:04:32 -0700177 """Initialize a ServoHost instance.
178
179 A ServoHost instance represents a host that controls a servo.
180
181 @param servo_host: Name of the host where the servod process
182 is running.
Raul E Rangel52ca2e82018-07-03 14:10:14 -0600183 @param servo_port: Port the servod process is listening on. Defaults
184 to the SERVOD_PORT environment variable if set,
185 otherwise 9999.
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -0700186 @param servo_board: Board that the servo is connected to.
Nick Sanders2f3c9852018-10-24 12:10:24 -0700187 @param servo_model: Model that the servo is connected to.
Dan Shi4d478522014-02-14 13:46:32 -0800188 @param is_in_lab: True if the servo host is in Cros Lab. Default is set
189 to None, for which utils.host_is_in_lab_zone will be
190 called to check if the servo host is in Cros lab.
Fang Deng5d518f42013-08-02 14:04:32 -0700191
192 """
193 super(ServoHost, self)._initialize(hostname=servo_host,
Garry Wangebc015b2019-06-06 17:45:06 -0700194 is_in_lab=is_in_lab, *args, **dargs)
Otabek Kasimovcc9738e2020-02-14 16:17:15 -0800195 self._init_attributes()
Richard Barnette42f4db92018-08-23 15:05:15 -0700196 self.servo_port = int(servo_port)
Richard Barnettee519dcd2016-08-15 17:37:17 -0700197 self.servo_board = servo_board
Nick Sanders2f3c9852018-10-24 12:10:24 -0700198 self.servo_model = servo_model
Kevin Cheng643ce8a2016-09-15 15:42:12 -0700199 self.servo_serial = servo_serial
Wai-Hong Tam3a8a2552019-11-19 14:28:04 +0800200
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800201 # The location of the log files on the servo host for this instance.
202 self.remote_log_dir = '%s_%s' % (self.SERVOD_LOG_PREFIX,
203 self.servo_port)
Garry Wang79e9af62019-06-12 15:19:19 -0700204 # Path of the servo host lock file.
Derek Beckettf73baca2020-08-19 15:08:47 -0700205 self._lock_file = (self.TEMP_FILE_DIR + str(self.servo_port) +
206 self.LOCK_FILE_POSTFIX)
Garry Wang79e9af62019-06-12 15:19:19 -0700207 # File path to declare a reboot request.
Derek Beckettf73baca2020-08-19 15:08:47 -0700208 self._reboot_file = (self.TEMP_FILE_DIR + str(self.servo_port) +
209 self.REBOOT_FILE_POSTFIX)
Garry Wang79e9af62019-06-12 15:19:19 -0700210
211 # Lock the servo host if it's an in-lab labstation to prevent other
212 # task to reboot it until current task completes. We also wait and
213 # make sure the labstation is up here, in the case of the labstation is
214 # in the middle of reboot.
Garry Wang7c00b0f2019-06-25 17:28:17 -0700215 self._is_locked = False
Garry Wang42b4d862019-06-25 15:50:49 -0700216 if (self.wait_up(self.REBOOT_TIMEOUT) and self.is_in_lab()
217 and self.is_labstation()):
Garry Wang79e9af62019-06-12 15:19:19 -0700218 self._lock()
Garry Wangebc015b2019-06-06 17:45:06 -0700219
Richard Barnette9a26ad62016-06-10 12:03:08 -0700220 self._repair_strategy = (
221 servo_repair.create_servo_repair_strategy())
Richard Barnettee519dcd2016-08-15 17:37:17 -0700222
Dana Goyetteafa62fd2020-03-16 13:45:27 -0700223 def __str__(self):
224 return "<%s '%s:%s'>" % (
225 type(self).__name__, self.hostname, self.servo_port)
226
Richard Barnette9a26ad62016-06-10 12:03:08 -0700227 def connect_servo(self):
Garry Wang8c8dc972020-06-09 13:41:51 -0700228 """ Initialize and setup servo for later use.
229 """
230 self.initilize_servo()
231 self.initialize_dut_for_servo()
232
Garry Wang8c8dc972020-06-09 13:41:51 -0700233 def initilize_servo(self):
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -0700234 """Establish a connection to the servod server on this host.
Richard Barnette9a26ad62016-06-10 12:03:08 -0700235
236 Initializes `self._servo` and then verifies that all network
237 connections are working. This will create an ssh tunnel if
238 it's required.
Garry Wang8c8dc972020-06-09 13:41:51 -0700239 """
240 self._servo = servo.Servo(servo_host=self,
241 servo_serial=self.servo_serial)
Richard Barnette9a26ad62016-06-10 12:03:08 -0700242
Garry Wang8c8dc972020-06-09 13:41:51 -0700243 def initialize_dut_for_servo(self):
244 """This method will do some setup for dut control, e.g. setup
245 main servo_v4 device, and also testing the connection between servo
246 and DUT. As a side effect of testing the connection, all signals on
247 the target servo are reset to default values, and the USB stick is
Richard Barnette9a26ad62016-06-10 12:03:08 -0700248 set to the neutral (off) position.
249 """
Garry Wang8c8dc972020-06-09 13:41:51 -0700250 if not self._servo:
251 raise hosts.AutoservVerifyError('Servo object needs to be'
252 ' initialized before initialize'
253 ' DUT.')
Richard Barnette9a26ad62016-06-10 12:03:08 -0700254 timeout, _ = retry.timeout(
Garry Wang8c8dc972020-06-09 13:41:51 -0700255 self._servo.initialize_dut,
256 timeout_sec=self.INITIALIZE_SERVO_TIMEOUT_SECS)
Richard Barnette9a26ad62016-06-10 12:03:08 -0700257 if timeout:
Garry Wang8c8dc972020-06-09 13:41:51 -0700258 raise hosts.AutoservVerifyError('Initialize dut for servo timed'
259 ' out.')
Richard Barnette9a26ad62016-06-10 12:03:08 -0700260
Richard Barnette9a26ad62016-06-10 12:03:08 -0700261 def disconnect_servo(self):
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -0700262 """Disconnect our servo if it exists.
Richard Barnette9a26ad62016-06-10 12:03:08 -0700263
264 If we've previously successfully connected to our servo,
265 disconnect any established ssh tunnel, and set `self._servo`
266 back to `None`.
267 """
268 if self._servo:
269 # N.B. This call is safe even without a tunnel:
270 # rpc_server_tracker.disconnect() silently ignores
271 # unknown ports.
272 self.rpc_server_tracker.disconnect(self.servo_port)
273 self._servo = None
Fang Deng5d518f42013-08-02 14:04:32 -0700274
Andrew McRaef0679932020-08-13 09:15:23 +1000275 def _maybe_create_servod_ssh_tunnel_proxy(self):
276 """Create a xmlrpc proxy for use with a ssh tunnel.
277 A lock is used to safely create a singleton proxy.
278 """
279 with self._tunnel_proxy_lock:
280 if self._tunnel_proxy is None:
281 self._tunnel_proxy = self.rpc_server_tracker.xmlrpc_connect(
282 None,
283 self.servo_port,
284 ready_test_name=self.SERVO_READY_METHOD,
285 timeout_seconds=60,
286 request_timeout_seconds=3600,
287 server_desc=str(self))
288
Andrew McRaef0679932020-08-13 09:15:23 +1000289 def get_servod_server_proxy(self):
290 """Return a proxy if it exists; otherwise, create a new one.
291 A proxy can either be a ssh tunnel based proxy, or a httplib
292 based proxy.
Fang Deng5d518f42013-08-02 14:04:32 -0700293
294 @returns: An xmlrpclib.ServerProxy that is connected to the servod
295 server on the host.
Fang Deng5d518f42013-08-02 14:04:32 -0700296 """
Garry Wang11b5e872020-03-11 15:14:08 -0700297 if (servo_constants.ENABLE_SSH_TUNNEL_FOR_SERVO
298 and not self.is_localhost()):
Andrew McRaef0679932020-08-13 09:15:23 +1000299 # Check for existing ssh tunnel proxy.
300 if self._tunnel_proxy is None:
301 self._maybe_create_servod_ssh_tunnel_proxy()
302 return self._tunnel_proxy
Richard Barnette9a26ad62016-06-10 12:03:08 -0700303 else:
Andrew McRaef0679932020-08-13 09:15:23 +1000304 # xmlrpc/httplib is not thread-safe, so each thread must have its
305 # own separate proxy connection.
306 if not hasattr(self._local, "_per_thread_proxy"):
307 remote = 'http://%s:%s' % (self.hostname, self.servo_port)
Derek Beckettf73baca2020-08-19 15:08:47 -0700308 self._local._per_thread_proxy = six.moves.xmlrpc_client.ServerProxy(remote)
Andrew McRaef0679932020-08-13 09:15:23 +1000309 return self._local._per_thread_proxy
Wai-Hong Tam3a8a2552019-11-19 14:28:04 +0800310
Richard Barnette1edbb162016-11-01 11:47:50 -0700311 def verify(self, silent=False):
312 """Update the servo host and verify it's in a good state.
313
314 @param silent If true, suppress logging in `status.log`.
315 """
Richard Barnetteabbdc252018-07-26 16:57:42 -0700316 message = 'Beginning verify for servo host %s port %s serial %s'
317 message %= (self.hostname, self.servo_port, self.servo_serial)
318 self.record('INFO', None, None, message)
Richard Barnette9a26ad62016-06-10 12:03:08 -0700319 try:
Richard Barnette1edbb162016-11-01 11:47:50 -0700320 self._repair_strategy.verify(self, silent)
Garry Wang11b5e872020-03-11 15:14:08 -0700321 self._servo_state = servo_constants.SERVO_STATE_WORKING
322 self.record('INFO', None, None,
323 'ServoHost verify set servo_state as WORKING')
Garry Wang63b8c382020-03-11 22:28:40 -0700324 except Exception as e:
Otabek Kasimov120b6fa2020-07-03 00:15:27 -0700325 if not self.is_localhost():
Otabek Kasimovc6f30412020-06-30 20:08:12 -0700326 self._servo_state = self.determine_servo_state()
327 self.record('INFO', None, None,
328 'ServoHost verify set servo_state as %s'
329 % self._servo_state)
Garry Wang63b8c382020-03-11 22:28:40 -0700330 if self._is_critical_error(e):
331 raise
Fang Deng5d518f42013-08-02 14:04:32 -0700332
Garry Wang2b5eef92020-08-21 16:23:35 -0700333 def _get_default_usbkey_mount_path(self):
334 return '/media/servo_usb/%s' % self.servo_port
Fang Deng5d518f42013-08-02 14:04:32 -0700335
Garry Wang7b0e1b72020-03-25 19:08:59 -0700336 def get_image_name_from_usbkey(self, usbkey_dev):
337 """Mount usb drive and check ChromeOS image name on it if there is
338 one. This method assumes the image_usbkey_direction is already set
339 to servo side.
340
Garry Wang4b980202020-09-24 17:00:17 -0700341 @param usbkey_dev: usbkey dev path(e.g. /dev/sdb).
Garry Wang7b0e1b72020-03-25 19:08:59 -0700342
343 @returns: image_name on the usbkey, e.g. nami-release/R82.10138.0.0,
344 or empty string if no test image detected, or unexpected
345 error occurred.
Garry Wang7b0e1b72020-03-25 19:08:59 -0700346 """
Garry Wang70e5d062020-04-03 18:01:05 -0700347 logging.info('Checking ChromeOS image name on usbkey.')
Garry Wang2b5eef92020-08-21 16:23:35 -0700348 mount_dst = self._get_default_usbkey_mount_path()
Garry Wang7b0e1b72020-03-25 19:08:59 -0700349 # Unmount if there is an existing stale mount.
Garry Wang2b5eef92020-08-21 16:23:35 -0700350 self._unmount_drive(mount_dst)
351 # ChromeOS root fs is in /dev/sdx3
352 mount_src = usbkey_dev + '3'
Garry Wang7b0e1b72020-03-25 19:08:59 -0700353 try:
Garry Wang2b5eef92020-08-21 16:23:35 -0700354 if not self._mount_drive(mount_src, mount_dst):
355 logging.debug('Unexpected error occurred on mount usb drive.')
Garry Wang7b0e1b72020-03-25 19:08:59 -0700356 return ''
Garry Wang70e5d062020-04-03 18:01:05 -0700357
358 release_content = self.run(
Garry Wang2b5eef92020-08-21 16:23:35 -0700359 'cat %s/etc/lsb-release' % mount_dst,
Garry Wang70e5d062020-04-03 18:01:05 -0700360 ignore_status=True).stdout.strip()
361
362 if not re.search(r'RELEASE_TRACK=.*test', release_content):
363 logging.info('The image on usbkey is not a test image')
364 return ''
365
366 return lsbrelease_utils.get_chromeos_release_builder_path(
367 lsb_release_content=release_content)
Garry Wang7b0e1b72020-03-25 19:08:59 -0700368 finally:
Garry Wang70e5d062020-04-03 18:01:05 -0700369 logging.debug('Image check compeleted, unmounting the usb drive.')
Garry Wang2b5eef92020-08-21 16:23:35 -0700370 self._unmount_drive(mount_dst)
Garry Wang7b0e1b72020-03-25 19:08:59 -0700371
Garry Wang2b5eef92020-08-21 16:23:35 -0700372 def _extract_firmware_image_from_usbkey(self, fw_dst):
373 """Extract firmware images from the usbkey on servo, this method
374 assumes there is already a ChromeOS test image staged on servo.
375
Garry Wang4b980202020-09-24 17:00:17 -0700376 @param fw_dst: the path that we'll copy firmware images to.
Garry Wang2b5eef92020-08-21 16:23:35 -0700377
378 @returns: a json format string of firmware manifest data.
379 """
380 usbkey_dev = self._probe_and_validate_usb_dev()
381 if not usbkey_dev:
382 raise hosts.AutoservRepairError('Unexpected error occurred when'
383 ' probe usbkey dev path, please check logs for detail.')
384
385 mount_dst = self._get_default_usbkey_mount_path()
386 # Unmount if there is an existing stale mount.
387 self._unmount_drive(mount_dst)
388 # ChromeOS root fs is in /dev/sdx3
389 mount_src = usbkey_dev + '3'
390 try:
391 if not self._mount_drive(mount_src, mount_dst):
392 raise hosts.AutoservRepairError('Failed to extract firmware'
393 ' image; Unable to mount %s.' % usbkey_dev,
394 'unable to mount usbkey')
395 updater_bin = os.path.join(mount_dst,
396 'usr/sbin/chromeos-firmwareupdate')
397 self.run('%s --unpack %s' % (updater_bin, fw_dst))
398 return self.run('%s --manifest' % updater_bin).stdout
399 finally:
400 self._unmount_drive(mount_dst)
401
402 def prepare_repair_firmware_image(self, fw_dst=None):
403 """Prepare firmware image on the servohost for auto repair process
404 to consume.
405
Garry Wang4b980202020-09-24 17:00:17 -0700406 @param fw_dst: the path that we want to store firmware image on
407 the servohost.
Garry Wang2b5eef92020-08-21 16:23:35 -0700408
409 @returns: A tuple that containes ec firmware image path and bios
410 firmware image path on the servohost, or None if type of
411 image is not available based on manifest and dut's model.
412 """
413 model = self.servo_model or self._dut_host_info.model
414 if not model:
415 raise hosts.AutoservRepairError(
416 'Could not determine DUT\'s model.',
417 'model infomation unknown')
418
419 if not fw_dst:
420 fw_dst = '/tmp/firmware_image/%s' % self.servo_port
421 # Cleanup and re-create dst path to have a fresh start.
422 self.run('rm -rf %s' % fw_dst)
423 self.run('mkdir -p %s' % fw_dst)
424
425 manifest = json.loads(self._extract_firmware_image_from_usbkey(fw_dst))
Garry Wang50b56c12020-09-24 17:26:52 -0700426 # For models that have packed $MODEL_signed variant, we want use the
427 # 'signed' variant once we get DVT devices, so try to read manifest
428 # from $MODEL_signed first.
429 build = manifest.get('%s_signed' % model) or manifest.get(model)
430 if not build:
Garry Wang2b5eef92020-08-21 16:23:35 -0700431 raise hosts.AutoservRepairError('Could not find firmware manifest'
432 ' for model:%s' % model, 'model manifest not found')
433 try:
Garry Wang50b56c12020-09-24 17:26:52 -0700434 ec_image = os.path.join(fw_dst, build['ec']['image'])
Garry Wang2b5eef92020-08-21 16:23:35 -0700435 except KeyError:
436 ec_image = None
437 try:
Garry Wang50b56c12020-09-24 17:26:52 -0700438 bios_image = os.path.join(fw_dst, build['host']['image'])
Garry Wang2b5eef92020-08-21 16:23:35 -0700439 except KeyError:
440 bios_image = None
441 if not ec_image and not bios_image:
442 raise hosts.AutoservRepairError('Could not find any firmware image'
443 ' for model:%s' % model, 'cannot find firmware image')
444 return ec_image, bios_image
Garry Wang7b0e1b72020-03-25 19:08:59 -0700445
Garry Wang4b980202020-09-24 17:00:17 -0700446 def flash_ap_firmware_via_servo(self, image):
447 """Flash AP firmware by use a provided image.
448
449 This is will be a short term enhanment for infra repair use, it use
450 'futility update' which will automatically determine various parameters
451 needed for flashrom, and will preserve the GBB, VPD, and HWID for
452 AP firmware update.
453 @TODO(xianuowang@) Remove this method once b/148403277 implemented.
454
455 @param image: the firmware image path on servohost.
456 """
457 cmd = 'futility update -i %s --servo_port=%s'
458 self.run(cmd % (image, self.servo_port), timeout=900)
459
Garry Wang70e5d062020-04-03 18:01:05 -0700460 def _probe_and_validate_usb_dev(self):
461 """This method probe the usb dev path by talking to servo, and then
462 validate the dev path is valid block device to servohost.
463 Possible output:
464 1. Encounter error during probe usb dev, returns empty string.
465 2. probe usb dev completed without error but cannot find usb dev,
466 raise AutoservRepairError.
467 3. probe usb dev find a usb dev path, but failed validation in this
468 method, raise AutoservRepairError.
Garry Wang7b0e1b72020-03-25 19:08:59 -0700469
Garry Wang70e5d062020-04-03 18:01:05 -0700470 @returns: A string of usb dev path(e.g. '/dev/sdb'), or empty string
471 if unexpected error occurred during probe.
472 @raises: AutoservRepairError if servo couldn't probe the usb dev path
473 (servo.probe_host_usb_dev() returns empty string), or the dev path is
474 not valid block device to servohost.
Garry Wang7b0e1b72020-03-25 19:08:59 -0700475 """
476 logging.info('Validating image usbkey on servo.')
Garry Wang7b0e1b72020-03-25 19:08:59 -0700477 try:
Garry Wang70e5d062020-04-03 18:01:05 -0700478 usb_dev = self._servo.probe_host_usb_dev()
Garry Wang7b0e1b72020-03-25 19:08:59 -0700479 except Exception as e:
480 # We don't want any unexpected or transient servo communicating
481 # failure block usb repair, so capture all errors here.
482 logging.error(e, exc_info=True)
483 logging.error('Unexpected error occurred on get usbkey dev path,'
484 ' skipping usbkey validation.')
485 return ''
486
Garry Wang70e5d062020-04-03 18:01:05 -0700487 if usb_dev:
488 # probe_host_usb_dev() sometimes return stale record,
489 # so we need to make sure the path exists in fdisk.
490 validate_cmd = 'fdisk -l | grep %s' % usb_dev
Garry Wang11441182020-06-16 18:34:14 -0700491 try:
492 resp = self.run(validate_cmd, ignore_status=True, timeout=60)
493 if resp.exit_status == 0:
494 return usb_dev
Garry Wang70e5d062020-04-03 18:01:05 -0700495
Garry Wang11441182020-06-16 18:34:14 -0700496 logging.error('%s is reported from "image_usbkey_dev" control'
497 ' but not detected by fdisk!', usb_dev)
498 except error.AutoservRunError as e:
499 if 'Timeout encountered' in str(e):
500 logging.warning('Timeout encountered during fdisk run,'
501 ' skipping usbkey validation.')
502 return ''
503 raise
Garry Wang70e5d062020-04-03 18:01:05 -0700504
505 raise hosts.AutoservRepairError(
506 'No usbkey detected on servo, the usbkey may be either missing'
507 ' or broken. Please replace usbkey on the servo and retry.',
508 'missing usbkey')
509
Otabek Kasimov4ea636e2020-04-14 23:35:06 -0700510 def is_ec_supported(self):
Garry Wang9b8f2342020-04-17 16:34:09 -0700511 """Check if ec is supported on the servo_board"""
Otabek Kasimov4ea636e2020-04-14 23:35:06 -0700512 if self.servo_board:
513 try:
514 frm_config = config.Config(self.servo_board, self.servo_model)
515 return frm_config.chrome_ec
516 except Exception as e:
517 logging.error('Unexpected error when read from firmware'
518 ' configs; %s', str(e))
519 return False
520
Garry Wang70e5d062020-04-03 18:01:05 -0700521 def validate_image_usbkey(self):
522 """This method first validate if there is a recover usbkey on servo
523 that accessible to servohost, and second check if a ChromeOS image is
524 already on the usb drive and return the image_name so we can avoid
525 unnecessary download and flash to the recover usbkey on servo.
526
527 Please note that, there is special error handling logic here:
528 1. If unexpected error happens, we return empty string. So repair
529 actions will not get blocked.
530 2. If no working usbkey present on servo, but no errors, we'll raise
531 AutoservRepairError here.
532
533 @returns: image_name on the usbkey, e.g. nami-release/R82.10138.0.0,
534 or empty string if no test image detected, or unexpected
535 error occurred.
536 @raises: AutoservRepairError if the usbkey is not detected on servo.
537 """
538 usb_dev = self._probe_and_validate_usb_dev()
539 if usb_dev:
540 return self.get_image_name_from_usbkey(usb_dev)
541 else:
542 return ''
Garry Wang7b0e1b72020-03-25 19:08:59 -0700543
Richard Barnette1edbb162016-11-01 11:47:50 -0700544 def repair(self, silent=False):
545 """Attempt to repair servo host.
546
547 @param silent If true, suppress logging in `status.log`.
548 """
Richard Barnetteabbdc252018-07-26 16:57:42 -0700549 message = 'Beginning repair for servo host %s port %s serial %s'
550 message %= (self.hostname, self.servo_port, self.servo_serial)
551 self.record('INFO', None, None, message)
Richard Barnette9a26ad62016-06-10 12:03:08 -0700552 try:
Richard Barnette1edbb162016-11-01 11:47:50 -0700553 self._repair_strategy.repair(self, silent)
Garry Wang11b5e872020-03-11 15:14:08 -0700554 self._servo_state = servo_constants.SERVO_STATE_WORKING
555 self.record('INFO', None, None,
556 'ServoHost repair set servo_state as WORKING')
Garry Wang464ff1e2019-07-18 17:20:34 -0700557 # If target is a labstation then try to withdraw any existing
558 # reboot request created by this servo because it passed repair.
559 if self.is_labstation():
560 self.withdraw_reboot_request()
Garry Wang63b8c382020-03-11 22:28:40 -0700561 except Exception as e:
Otabek Kasimov120b6fa2020-07-03 00:15:27 -0700562 if not self.is_localhost():
Otabek Kasimovc6f30412020-06-30 20:08:12 -0700563 self._servo_state = self.determine_servo_state()
564 self.record('INFO', None, None,
565 'ServoHost repair set servo_state as %s'
566 % self._servo_state)
Garry Wang63b8c382020-03-11 22:28:40 -0700567 if self._is_critical_error(e):
568 self.disconnect_servo()
569 self.stop_servod()
570 raise
571
Garry Wang63b8c382020-03-11 22:28:40 -0700572 def _is_critical_error(self, error):
573 if (isinstance(error, hosts.AutoservVerifyDependencyError)
574 and not error.is_critical()):
575 logging.warning('Non-critical verify failure(s) detected during'
576 ' verify/repair servo, servo connection will'
577 ' still up but may not fully functional.'
578 ' Some repair actions and servo depended'
579 ' tests may not run.')
580 return False
581 logging.info('Critical verify failure(s) detected during repair/verify'
582 ' servo. Disconnecting servo and stop servod, all repair '
583 'action and tests that depends on servo will not run.')
584 return True
Fang Deng5d518f42013-08-02 14:04:32 -0700585
Dan Shi4d478522014-02-14 13:46:32 -0800586 def get_servo(self):
587 """Get the cached servo.Servo object.
Fang Deng5d518f42013-08-02 14:04:32 -0700588
Dan Shi4d478522014-02-14 13:46:32 -0800589 @return: a servo.Servo object.
Dana Goyette353d1d92019-06-27 10:43:59 -0700590 @rtype: autotest_lib.server.cros.servo.servo.Servo
Fang Deng5d518f42013-08-02 14:04:32 -0700591 """
Dan Shi4d478522014-02-14 13:46:32 -0800592 return self._servo
593
Garry Wang79e9af62019-06-12 15:19:19 -0700594 def request_reboot(self):
595 """Request servohost to be rebooted when it's safe to by touch a file.
596 """
597 logging.debug('Request to reboot servohost %s has been created by '
Garry Wang464ff1e2019-07-18 17:20:34 -0700598 'servo with port # %s', self.hostname, self.servo_port)
Garry Wang79e9af62019-06-12 15:19:19 -0700599 self.run('touch %s' % self._reboot_file, ignore_status=True)
600
Garry Wang464ff1e2019-07-18 17:20:34 -0700601 def withdraw_reboot_request(self):
602 """Withdraw a servohost reboot request if exists by remove the flag
603 file.
604 """
605 logging.debug('Withdrawing request to reboot servohost %s that created'
606 ' by servo with port # %s if exists.',
607 self.hostname, self.servo_port)
608 self.run('rm -f %s' % self._reboot_file, ignore_status=True)
609
Garry Wangc1288cf2019-12-17 14:58:00 -0800610 def start_servod(self, quick_startup=False):
611 """Start the servod process on servohost.
612 """
Garry Wang2ac15ee2019-12-30 19:03:02 -0800613 # Skip if running on the localhost.(crbug.com/1038168)
614 if self.is_localhost():
615 logging.debug("Servohost is a localhost, skipping start servod.")
616 return
617
618 cmd = 'start servod'
Garry Wangc1288cf2019-12-17 14:58:00 -0800619 if self.servo_board:
Garry Wang2ac15ee2019-12-30 19:03:02 -0800620 cmd += ' BOARD=%s' % self.servo_board
Garry Wangc1288cf2019-12-17 14:58:00 -0800621 if self.servo_model:
622 cmd += ' MODEL=%s' % self.servo_model
Garry Wangc1288cf2019-12-17 14:58:00 -0800623 else:
Garry Wang2ac15ee2019-12-30 19:03:02 -0800624 logging.warning('Board for DUT is unknown; starting servod'
625 ' assuming a pre-configured board.')
626
627 cmd += ' PORT=%d' % self.servo_port
628 if self.servo_serial:
629 cmd += ' SERIAL=%s' % self.servo_serial
Garry Wangd7367482020-02-27 13:52:40 -0800630
631 # Start servod with dual_v4 if the DUT/servo from designated pools.
632 dut_host_info = self.get_dut_host_info()
633 if dut_host_info:
Otabek Kasimovf10a7052020-08-14 03:09:23 -0700634 # DUAL_V4: servo setup includes servo_micro and ccd_cr50
635 # connection to the DUT
636 is_dual_setup = False
Garry Wang11b5e872020-03-11 15:14:08 -0700637 if bool(dut_host_info.pools &
638 servo_constants.POOLS_SUPPORT_DUAL_V4):
Garry Wangd7367482020-02-27 13:52:40 -0800639 logging.debug('The DUT is detected in following designated'
640 ' pools %s,starting servod with DUAL_V4 option.',
Garry Wang11b5e872020-03-11 15:14:08 -0700641 servo_constants.POOLS_SUPPORT_DUAL_V4)
Otabek Kasimovf10a7052020-08-14 03:09:23 -0700642 is_dual_setup = True
643 elif dut_host_info.attributes.get('servo_setup') == 'DUAL_V4':
644 logging.debug('The DUT servo setup specified in config as '
645 ' "DUAL_V4"')
646 is_dual_setup = True
647 if is_dual_setup:
Garry Wangd7367482020-02-27 13:52:40 -0800648 cmd += ' DUAL_V4=1'
649
Garry Wangb5cee3e2020-09-16 14:58:13 -0700650 # Start servod with CONFIG=cr50.xml which required for some pools.
651 if self._require_cr50_servod_config():
652 cmd += ' CONFIG=cr50.xml'
653
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800654 # Remove the symbolic links from the logs. This helps ensure that
655 # a failed servod instantiation does not cause us to grab old logs
656 # by mistake.
657 self.remove_latest_log_symlinks()
Garry Wangcdd27b22020-01-13 14:59:11 -0800658 self.run(cmd, timeout=60)
Garry Wangc1288cf2019-12-17 14:58:00 -0800659
660 # There's a lag between when `start servod` completes and when
661 # the _ServodConnectionVerifier trigger can actually succeed.
662 # The call to time.sleep() below gives time to make sure that
663 # the trigger won't fail after we return.
664
665 # Normally servod on servo_v3 and labstation take ~10 seconds to ready,
666 # But in the rare case all servo on a labstation are in heavy use they
667 # may take ~30 seconds. So the timeout value will double these value,
668 # and we'll try quick start up when first time initialize servohost,
669 # and use standard start up timeout in repair.
670 if quick_startup:
Garry Wang11b5e872020-03-11 15:14:08 -0700671 timeout = servo_constants.SERVOD_QUICK_STARTUP_TIMEOUT
Garry Wangc1288cf2019-12-17 14:58:00 -0800672 else:
Garry Wang11b5e872020-03-11 15:14:08 -0700673 timeout = servo_constants.SERVOD_STARTUP_TIMEOUT
Garry Wangc1288cf2019-12-17 14:58:00 -0800674 logging.debug('Wait %s seconds for servod process fully up.', timeout)
675 time.sleep(timeout)
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700676 # Cache the initial instance timestamp to check against servod restarts
677 self._initial_instance_ts = self.get_instance_logs_ts()
Garry Wangc1288cf2019-12-17 14:58:00 -0800678
Garry Wangc1288cf2019-12-17 14:58:00 -0800679 def stop_servod(self):
680 """Stop the servod process on servohost.
681 """
Garry Wang2ac15ee2019-12-30 19:03:02 -0800682 # Skip if running on the localhost.(crbug.com/1038168)
683 if self.is_localhost():
684 logging.debug("Servohost is a localhost, skipping stop servod.")
685 return
686
Garry Wangc1288cf2019-12-17 14:58:00 -0800687 logging.debug('Stopping servod on port %s', self.servo_port)
Garry Wangcdd27b22020-01-13 14:59:11 -0800688 self.run('stop servod PORT=%d' % self.servo_port,
689 timeout=60, ignore_status=True)
Garry Wangc1288cf2019-12-17 14:58:00 -0800690 logging.debug('Wait %s seconds for servod process fully teardown.',
Garry Wang11b5e872020-03-11 15:14:08 -0700691 servo_constants.SERVOD_TEARDOWN_TIMEOUT)
692 time.sleep(servo_constants.SERVOD_TEARDOWN_TIMEOUT)
Garry Wangc1288cf2019-12-17 14:58:00 -0800693
Garry Wangc1288cf2019-12-17 14:58:00 -0800694 def restart_servod(self, quick_startup=False):
695 """Restart the servod process on servohost.
696 """
697 self.stop_servod()
698 self.start_servod(quick_startup)
699
Garry Wangffbd2162020-04-17 16:13:48 -0700700 def _process_servodtool_error(self, response):
701 """Helper function to handle non-zero servodtool response.
702 """
703 if re.search(servo_constants.ERROR_MESSAGE_USB_HUB_NOT_COMPATIBLE,
Garry Wangad245002020-05-15 15:20:23 -0700704 response.stdout):
Garry Wangffbd2162020-04-17 16:13:48 -0700705 logging.error('The servo is not plugged on a usb hub that supports'
706 ' power-cycle!')
Garry Wang000c6c02020-05-11 21:27:23 -0700707 # change the flag so we can update this label in later process.
708 self.smart_usbhub = False
Garry Wangffbd2162020-04-17 16:13:48 -0700709 return
710
711 if re.search(servo_constants.ERROR_MESSAGE_DEVICE_NOT_FOUND %
712 self.servo_serial, response.stdout):
713 logging.error('No servo with serial %s found!', self.servo_serial)
714 return
715
716 logging.error('Unexpected error occurred from usbhub control, please'
717 ' file a bug and inform chrome-fleet-software@ team!')
718
Garry Wangffbd2162020-04-17 16:13:48 -0700719 def _get_servo_usb_devnum(self):
720 """Helper function to collect current usb devnum of servo.
721 """
Otabek Kasimov09192682020-06-01 18:17:44 -0700722 # TODO remove try-except when fix crbug.com/1087964
723 try:
724 cmd = 'servodtool device -s %s usb-path' % self.servo_serial
725 resp = self.run(cmd, ignore_status=True, timeout=30)
726 except Exception as e:
727 # Here we catch only timeout errors.
728 # Other errors is filtered by ignore_status=True
729 logging.debug('Attempt to get servo usb-path failed due to '
730 'timeout; %s', e)
731 return ''
732
Garry Wangffbd2162020-04-17 16:13:48 -0700733 if resp.exit_status != 0:
734 self._process_servodtool_error(resp)
735 return ''
736 usb_path = resp.stdout.strip()
737 logging.info('Usb path of servo %s is %s', self.servo_serial, usb_path)
738
739 resp = self.run('cat %s/devnum' % usb_path,
740 ignore_status=True)
741 if resp.exit_status != 0:
742 self._process_servodtool_error(resp)
743 return ''
744 return resp.stdout.strip()
745
Garry Wang358aad42020-08-02 20:56:04 -0700746 def reboot_servo_v3_on_need(self):
747 """Check and reboot servo_v3 based on below conditions.
748 1. If there is an update pending on reboot.
749 2. Servo_v3 has been up for more than 96 hours.
750 """
751 if self.get_board() != 'beaglebone_servo':
752 logging.info('Servo reboot is only applicable for servo V3.')
Otabek Kasimove6df8102020-07-21 20:15:25 -0700753 return
754
Garry Wang358aad42020-08-02 20:56:04 -0700755 update_pending_reboot = (self._check_update_status() ==
756 self.UPDATE_STATE.PENDING_REBOOT)
757 uptime_hours = float(self.check_uptime())/3600
758 logging.info('Uptime of servo_v3: %s hour(s)', uptime_hours)
759 long_up_time = uptime_hours > 96
760
761 # Skip reboot if neither condition are met.
762 if not (update_pending_reboot or long_up_time):
Otabek Kasimove6df8102020-07-21 20:15:25 -0700763 return
764
Garry Wang358aad42020-08-02 20:56:04 -0700765 if update_pending_reboot:
766 message = 'Starting reboot servo_v3 because an update is pending.'
767 reboot_method = self._post_update_reboot
768 elif long_up_time:
769 message = 'Starting reboot servo_v3 because uptime > 96 hours.'
770 reboot_method = self._servo_host_reboot
771 self.record('INFO', None, None, message)
772 logging.info(message)
Otabek Kasimove6df8102020-07-21 20:15:25 -0700773 try:
Garry Wang358aad42020-08-02 20:56:04 -0700774 reboot_method()
Otabek Kasimove6df8102020-07-21 20:15:25 -0700775 message = 'Servo_v3 reboot completed successfully.'
776 except Exception as e:
777 logging.debug("Fail to reboot servo_v3; %s", e)
778 message = ('Servo_v3 reboot failed, please check debug log '
779 'for details.')
780 logging.info(message)
781 self.record('INFO', None, None, message)
Garry Wangffbd2162020-04-17 16:13:48 -0700782
783 def _reset_servo(self):
784 logging.info('Resetting servo through smart usbhub.')
Otabek Kasimov09192682020-06-01 18:17:44 -0700785 # TODO remove try-except when fix crbug.com/1087964
786 try:
787 resp = self.run('servodtool device -s %s power-cycle' %
788 self.servo_serial, ignore_status=True,
789 timeout=30)
790 if resp.exit_status != 0:
791 self._process_servodtool_error(resp)
792 return False
793 except Exception as e:
794 # Here we catch only timeout errors.
795 # Other errors is filtered by ignore_status=True
796 logging.debug('Attempt to reset servo failed due to timeout;'
797 ' %s', e)
Garry Wangffbd2162020-04-17 16:13:48 -0700798 return False
799
800 logging.debug('Wait %s seconds for servo to come back from reset.',
801 servo_constants.SERVO_RESET_TIMEOUT_SECONDS)
802 time.sleep(servo_constants.SERVO_RESET_TIMEOUT_SECONDS)
Garry Wang000c6c02020-05-11 21:27:23 -0700803 # change the flag so we can update this label in later process.
804 self.smart_usbhub = True
Garry Wangffbd2162020-04-17 16:13:48 -0700805 return True
806
Garry Wangffbd2162020-04-17 16:13:48 -0700807 def reset_servo(self):
808 """Reset(power-cycle) the servo via smart usbhub.
809 """
810 if not self.is_labstation():
811 logging.info('Servo reset is not applicable to servo_v3.')
812 return
813
814 pre_reset_devnum = self._get_servo_usb_devnum()
815 logging.info('Servo usb devnum before reset: %s', pre_reset_devnum)
816 result = self._reset_servo()
817 if not result:
Garry Wangfd5c8b62020-06-08 15:36:54 -0700818 message = ('Failed to reset servo with serial: %s. (Please ignore'
819 ' this error if the DUT is not connected to a smart'
820 ' usbhub).' % self.servo_serial)
Garry Wangffbd2162020-04-17 16:13:48 -0700821 logging.warning(message)
822 self.record('INFO', None, None, message)
823 return
824
825 post_reset_devnum = self._get_servo_usb_devnum()
826 logging.info('Servo usb devnum after reset: %s', post_reset_devnum)
827 if not (pre_reset_devnum and post_reset_devnum):
828 message = ('Servo reset completed but unable to verify'
829 ' devnum change!')
830 elif pre_reset_devnum != post_reset_devnum:
831 message = ('Reset servo with serial %s completed successfully!'
832 % self.servo_serial)
833 else:
834 message = 'Servo reset completed but devnum is still not changed!'
835 logging.info(message)
836 self.record('INFO', None, None, message)
837
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800838 def _extract_compressed_logs(self, logdir, relevant_files):
839 """Decompress servod logs in |logdir|.
840
841 @param logdir: directory containing compressed servod logs.
842 @param relevant_files: list of files in |logdir| to consider.
843
844 @returns: tuple, (tarfiles, files) where
845 tarfiles: list of the compressed filenames that have been
846 extracted and deleted
847 files: list of the uncompressed files that were generated
848 """
849 # For all tar-files, first extract them to the directory, and
850 # then let the common flow handle them.
851 tarfiles = [cf for cf in relevant_files if
852 cf.endswith(self.COMPRESSION_SUFFIX)]
853 files = []
854 for f in tarfiles:
855 norm_name = os.path.basename(f)[:-len(self.COMPRESSION_SUFFIX)]
856 with tarfile.open(f) as tf:
857 # Each tarfile has only one member, as
858 # that's the compressed log.
859 member = tf.members[0]
860 # Manipulate so that it only extracts the basename, and not
861 # the directories etc.
862 member.name = norm_name
863 files.append(os.path.join(logdir, member.name))
864 tf.extract(member, logdir)
865 # File has been extracted: remove the compressed file.
866 os.remove(f)
867 return tarfiles, files
868
869 def _extract_mcu_logs(self, log_subdir):
870 """Extract MCU (EC, Cr50, etc) console output from servod debug logs.
871
872 Using the MCU_EXTRACTOR regex (above) extract and split out MCU console
873 lines from the logs to generate invidiual console logs e.g. after
874 this method, you can find an ec.txt and servo_v4.txt in |log_dir| if
875 those MCUs had any console input/output.
876
877 @param log_subdir: directory with log.DEBUG.txt main servod debug logs.
878 """
879 # Extract the MCU for each one. The MCU logs are only in the .DEBUG
880 # files
881 mcu_lines_file = os.path.join(log_subdir, 'log.DEBUG.txt')
882 if not os.path.exists(mcu_lines_file):
883 logging.info('No DEBUG logs found to extract MCU logs from.')
884 return
885 mcu_files = {}
886 mcu_file_template = '%s.txt'
887 with open(mcu_lines_file, 'r') as f:
888 for line in f:
889 match = self.MCU_EXTRACTOR.match(line)
890 if match:
891 mcu = match.group(self.MCU_GROUP).lower()
892 line = match.group(self.LINE_GROUP)
893 if mcu not in mcu_files:
894 mcu_file = os.path.join(log_subdir,
895 mcu_file_template % mcu)
896 mcu_files[mcu] = open(mcu_file, 'a')
897 fd = mcu_files[mcu]
898 fd.write(line + '\n')
899 for f in mcu_files:
900 mcu_files[f].close()
901
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800902 def remove_latest_log_symlinks(self):
903 """Remove the conveninence symlinks 'latest' servod logs."""
904 symlink_wildcard = '%s/latest*' % self.remote_log_dir
905 cmd = 'rm ' + symlink_wildcard
906 self.run(cmd, stderr_tee=None, ignore_status=True)
907
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700908 def probe_servod_restart(self, instance_ts, outdir):
909 """Grab servod logs from previous instances if part of this session.
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800910
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700911 If since the last time this host called start_servod() servod crashed
912 and restarted, this helper finds those logs as well, and stores them
913 with the |OLD_LOG_SUFFIX| to investigate if necessary.
Prasad Vuppalapu5bd9da12020-03-31 01:46:47 +0000914
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700915 It also issues a panicinfo command to servo devices after the restart
916 to try and collect reboot information for debugging.
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800917
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700918 @param instance_ts: the log timestamp that the current instance uses
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800919 @param outdir: directory to create a subdirectory into to place the
920 servod logs into.
921 """
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700922 if self._initial_instance_ts is None:
923 logging.info('No log timestamp grabbed successfully on servod '
924 'startup. Cannot check device restarts. Ignoring.')
925 return
926 if instance_ts == self._initial_instance_ts:
927 logging.debug('Servod appears to have run without restarting')
928 return
929 # Servod seems to have restarted (at least once). |_initial_instance_ts|
930 # is the first timestamp, and instance_ts is the current timestamp. Find
931 # all timestamps in between them, and grab the logs for each.
932 tss = self._find_instance_timestamps_between(self._initial_instance_ts,
933 instance_ts)
934 logging.info('Servod has restarted %d times between the start and the '
935 'end of this servo_host.', len(tss))
936 logging.info('This might be an issue. Will extract all logs from each '
937 'instance.')
938 logging.info('Logs that are not the currently running (about to turn '
939 'down) instance are maked with a .%s in their folder.',
940 self.OLD_LOG_SUFFIX)
941 for ts in tss:
942 self.get_instance_logs(ts, outdir, old=True)
943 # Lastly, servod has restarted due to a potential issue. Try to get
944 # panic information from servo micro and servo v4 for the current logs.
945 # This can only happen if the |_servo| attribute is initialized.
946 if self._servo:
947 for mcu in ['servo_micro', 'servo_v4']:
948 ctrl = '%s_uart_cmd' % mcu
949 if self._servo.has_control(ctrl):
950 logging.info('Trying to retrieve %r panicinfo into logs',
951 mcu)
952 try:
953 self._servo.set_nocheck(ctrl, 'panicinfo')
954 except error.TestFail as e:
955 logging.error('Failed to generate panicinfo for %r '
956 'logs. %s', mcu, str(e))
957
958 def _find_instance_timestamps_between(self, start_ts, end_ts):
959 """Find all log timestamps between [start_ts, end_ts).
960
961 @param start_ts: str, earliest log timestamp of interest
962 @param end_ts: str, latest log timestamp of interest
963
964 @returns: list, all timestamps between start_ts and end_ts, end_ts
965 exclusive, on the servo_host. An empty list on errors
966 """
967 # Simply get all timestamp, and then sort and remove
968 cmd = 'ls %s' % self.remote_log_dir
969 res = self.run(cmd, stderr_tee=None, ignore_status=True)
970 if res.exit_status != 0:
971 # Here we failed to find anything.
972 logging.info('Failed to find remote servod logs. Ignoring.')
973 return []
974 logfiles = res.stdout.strip().split()
975 timestamps = set()
976 for logfile in logfiles:
977 ts_match = self.TS_EXTRACTOR.match(logfile)
978 if not ts_match:
979 # Simply ignore files that fail the check. It might be the
980 # 'latest' symlinks or random files.
981 continue
982 timestamps.add(ts_match.group(self.TS_GROUP))
983 # At this point we have all unique timestamps.
984 timestamps = sorted(timestamps)
985 for ts in [start_ts, end_ts]:
986 if ts not in timestamps:
987 logging.error('Timestamp %r not in servod logs. Cannot query '
988 'for timestamps in between %r and %r', ts,
989 start_ts, end_ts)
990 return []
991 return timestamps[timestamps.index(start_ts):timestamps.index(end_ts)]
992
993 def get_instance_logs_ts(self):
994 """Retrieve the currently running servod instance's log timestamp
995
996 @returns: str, timestamp for current instance, or None on failure
997 """
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800998 # First, extract the timestamp. This cmd gives the real filename of
999 # the latest aka current log file.
1000 cmd = ('if [ -f %(dir)s/latest.DEBUG ];'
1001 'then realpath %(dir)s/latest.DEBUG;'
1002 'elif [ -f %(dir)s/latest ];'
1003 'then realpath %(dir)s/latest;'
1004 'else exit %(code)d;'
1005 'fi' % {'dir': self.remote_log_dir,
1006 'code': self.NO_SYMLINKS_CODE})
1007 res = self.run(cmd, stderr_tee=None, ignore_status=True)
1008 if res.exit_status != 0:
1009 if res.exit_status == self.NO_SYMLINKS_CODE:
1010 logging.warning('servod log latest symlinks not found. '
1011 'This is likely due to an error starting up '
1012 'servod. Ignoring..')
1013 else:
1014 logging.warning('Failed to find servod logs on servo host.')
1015 logging.warning(res.stderr.strip())
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001016 return None
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001017 fname = os.path.basename(res.stdout.strip())
1018 # From the fname, ought to extract the timestamp using the TS_EXTRACTOR
Ruben Rodriguez Buchillone9aa2b02020-03-04 12:14:28 -08001019 ts_match = self.TS_EXTRACTOR.match(fname)
1020 if not ts_match:
1021 logging.warning('Failed to extract timestamp from servod log file '
1022 '%r. Skipping. The servo host is using outdated '
1023 'servod logging and needs to be updated.', fname)
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001024 return None
1025 return ts_match.group(self.TS_GROUP)
1026
1027 def get_instance_logs(self, instance_ts, outdir, old=False):
1028 """Collect all logs with |instance_ts| and dump into a dir in |outdir|
1029
1030 This method first collects all logs on the servo_host side pertaining
1031 to this servod instance (port, instatiation). It glues them together
1032 into combined log.[level].txt files and extracts all available MCU
1033 console I/O from the logs into individual files e.g. servo_v4.txt
1034
1035 All the output can be found in a directory inside |outdir| that
1036 this generates based on |LOG_DIR|, the servod port, and the instance
1037 timestamp on the servo_host side.
1038
1039 @param instance_ts: log timestamp to grab logfiles for
1040 @param outdir: directory to create a subdirectory into to place the
1041 servod logs into.
1042 @param old: bool, whether to append |OLD_LOG_SUFFIX| to output dir
1043 """
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001044 # Create the local results log dir.
1045 log_dir = os.path.join(outdir, '%s_%s.%s' % (self.LOG_DIR,
1046 str(self.servo_port),
1047 instance_ts))
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001048 if old:
Garry Wang22f2e842020-09-09 20:19:19 -07001049 log_dir = '%s.%s' % (log_dir, self.OLD_LOG_SUFFIX)
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001050 logging.info('Saving servod logs to %r.', log_dir)
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001051 os.mkdir(log_dir)
1052 # Now, get all files with that timestamp.
1053 cmd = 'find %s -maxdepth 1 -name "log.%s*"' % (self.remote_log_dir,
1054 instance_ts)
1055 res = self.run(cmd, stderr_tee=None, ignore_status=True)
1056 files = res.stdout.strip().split()
1057 try:
1058 self.get_file(files, log_dir, try_rsync=False)
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001059 if not os.listdir(log_dir):
1060 logging.info('No servod logs retrieved. Ignoring, and removing '
1061 '%r again.', log_dir)
1062 os.rmdir(log_dir)
1063 return
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001064 except error.AutoservRunError as e:
1065 result = e.result_obj
1066 if result.exit_status != 0:
1067 stderr = result.stderr.strip()
1068 logging.warning("Couldn't retrieve servod logs. Ignoring: %s",
1069 stderr or '\n%s' % result)
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001070 # Remove the log_dir as nothing was added to it.
1071 os.rmdir(log_dir)
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001072 return
1073 local_files = [os.path.join(log_dir, f) for f in os.listdir(log_dir)]
1074 # TODO(crrev.com/c/1793030): remove no-level case once CL is pushed
1075 for level_name in ('DEBUG', 'INFO', 'WARNING', ''):
1076 # Create the joint files for each loglevel. i.e log.DEBUG
1077 joint_file = self.JOINT_LOG_PREFIX
1078 if level_name:
1079 joint_file = '%s.%s' % (self.JOINT_LOG_PREFIX, level_name)
1080 # This helps with some online tools to avoid complaints about an
1081 # unknown filetype.
1082 joint_file = joint_file + '.txt'
1083 joint_path = os.path.join(log_dir, joint_file)
1084 files = [f for f in local_files if level_name in f]
1085 if not files:
1086 # TODO(crrev.com/c/1793030): remove no-level case once CL
1087 # is pushed
1088 continue
1089 # Extract compressed logs if any.
1090 compressed, extracted = self._extract_compressed_logs(log_dir,
1091 files)
1092 files = list(set(files) - set(compressed))
1093 files.extend(extracted)
1094 # Need to sort. As they all share the same timestamp, and
1095 # loglevel, the index itself is sufficient. The highest index
1096 # is the oldest file, therefore we need a descending sort.
1097 def sortkey(f, level=level_name):
1098 """Custom sortkey to sort based on rotation number int."""
1099 if f.endswith(level_name): return 0
1100 return int(f.split('.')[-1])
1101
1102 files.sort(reverse=True, key=sortkey)
1103 # Just rename the first file rather than building from scratch.
1104 os.rename(files[0], joint_path)
1105 with open(joint_path, 'a') as joint_f:
1106 for logfile in files[1:]:
1107 # Transfer the file to the joint file line by line.
1108 with open(logfile, 'r') as log_f:
1109 for line in log_f:
1110 joint_f.write(line)
1111 # File has been written over. Delete safely.
1112 os.remove(logfile)
1113 # Need to remove all files form |local_files| so we don't
1114 # analyze them again.
1115 local_files = list(set(local_files) - set(files) - set(compressed))
1116 # Lastly, extract MCU logs from the joint logs.
1117 self._extract_mcu_logs(log_dir)
1118
Garry Wang79e9af62019-06-12 15:19:19 -07001119 def _lock(self):
1120 """lock servohost by touching a file.
1121 """
1122 logging.debug('Locking servohost %s by touching %s file',
1123 self.hostname, self._lock_file)
1124 self.run('touch %s' % self._lock_file, ignore_status=True)
Garry Wang7c00b0f2019-06-25 17:28:17 -07001125 self._is_locked = True
Garry Wang79e9af62019-06-12 15:19:19 -07001126
Garry Wang79e9af62019-06-12 15:19:19 -07001127 def _unlock(self):
1128 """Unlock servohost by removing the lock file.
1129 """
1130 logging.debug('Unlocking servohost by removing %s file',
1131 self._lock_file)
1132 self.run('rm %s' % self._lock_file, ignore_status=True)
Garry Wang7c00b0f2019-06-25 17:28:17 -07001133 self._is_locked = False
Garry Wang79e9af62019-06-12 15:19:19 -07001134
Congbin Guoa1f9cba2018-07-03 11:36:59 -07001135 def close(self):
Congbin Guofc3b8962019-03-22 17:38:46 -07001136 """Close the associated servo and the host object."""
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001137 # NOTE: throughout this method there are multiple attempts to catch
1138 # all errors. This is WAI as log grabbing should not fail tests.
1139 # However, the goal is to catch and handle/process all errors, thus
1140 # we print the traceback and ask for a bug.
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001141 if self._closed:
1142 logging.debug('ServoHost is already closed.')
1143 return
Garry Wang22f2e842020-09-09 20:19:19 -07001144
1145 # Only attempt ssh related actions if servohost is sshable. We call
1146 # check_cached_up_status() first because it's lightweighted and return
1147 # much faster in the case servohost is down, however, we still want
1148 # to call is_up() later since check_cached_up_status() is ping based check
1149 # and not guarantee the servohost is sshable.
1150 servo_host_ready = self.check_cached_up_status() and self.is_up()
1151
1152 if servo_host_ready:
1153 instance_ts = self.get_instance_logs_ts()
1154 else:
1155 logging.info('Servohost is down, will skip servod log collecting.')
1156 instance_ts = None
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001157 # TODO(crbug.com/1011516): once enabled, remove the check against
1158 # localhost and instead check against log-rotiation enablement.
1159 logs_available = (instance_ts is not None and
1160 self.job and
1161 not self.is_localhost())
1162 if logs_available:
1163 # Probe whether there was a servod restart, and grab those old
1164 # logs as well.
1165 try:
1166 self.probe_servod_restart(instance_ts, self.job.resultdir)
1167 except (error.AutoservRunError, error.TestFail) as e:
1168 logging.info('Failed to grab servo logs due to: %s. '
1169 'This error is forgiven.', str(e))
1170 except Exception as e:
1171 logging.error('Unexpected error probing for old logs. %s. '
1172 'Forgiven. Please file a bug and fix or catch '
1173 'in log probing function', str(e),
1174 exc_info=True)
Congbin Guoa1f9cba2018-07-03 11:36:59 -07001175 if self._servo:
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001176 outdir = None if not self.job else self.job.resultdir
Congbin Guo2e5e2a22018-07-27 10:32:48 -07001177 # In some cases when we run as lab-tools, the job object is None.
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001178 self._servo.close(outdir)
1179
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001180 if logs_available:
1181 # Grab current (not old like above) logs after the servo instance
1182 # was closed out.
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001183 try:
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001184 self.get_instance_logs(instance_ts, self.job.resultdir)
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001185 except error.AutoservRunError as e:
1186 logging.info('Failed to grab servo logs due to: %s. '
1187 'This error is forgiven.', str(e))
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001188 except Exception as e:
1189 logging.error('Unexpected error grabbing servod logs. %s. '
1190 'Forgiven. Please file a bug and fix or catch '
1191 'in log grabbing function', str(e), exc_info=True)
Congbin Guoa1f9cba2018-07-03 11:36:59 -07001192
Garry Wang22f2e842020-09-09 20:19:19 -07001193 if self._is_locked and servo_host_ready:
Garry Wang7c00b0f2019-06-25 17:28:17 -07001194 # Remove the lock if the servohost has been locked.
Garry Wang79e9af62019-06-12 15:19:19 -07001195 try:
1196 self._unlock()
1197 except error.AutoservSSHTimeout:
1198 logging.error('Unlock servohost failed due to ssh timeout.'
1199 ' It may caused by servohost went down during'
1200 ' the task.')
Garry Wangc1288cf2019-12-17 14:58:00 -08001201 # We want always stop servod after task to minimum the impact of bad
1202 # servod process interfere other servods.(see crbug.com/1028665)
Garry Wang22f2e842020-09-09 20:19:19 -07001203 if servo_host_ready:
1204 try:
1205 self.stop_servod()
1206 except error.AutoservRunError as e:
1207 logging.info(
1208 "Failed to stop servod due to:\n%s\n"
1209 "This error is forgiven.", str(e))
Garry Wangc1288cf2019-12-17 14:58:00 -08001210
Congbin Guoa1f9cba2018-07-03 11:36:59 -07001211 super(ServoHost, self).close()
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001212 # Mark closed.
1213 self._closed = True
Congbin Guoa1f9cba2018-07-03 11:36:59 -07001214
Otabek Kasimovcc9738e2020-02-14 16:17:15 -08001215 def get_servo_state(self):
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001216 return self._servo_state
Otabek Kasimovcc9738e2020-02-14 16:17:15 -08001217
Otabek Kasimovc6f30412020-06-30 20:08:12 -07001218 def _get_host_metrics_data(self):
1219 return {'port': self.servo_port,
Otabek Kasimov0ea47362020-07-11 20:55:09 -07001220 'host': self.get_dut_hostname() or self.hostname,
Otabek Kasimovc6f30412020-06-30 20:08:12 -07001221 'board': self.servo_board or ''}
1222
1223 def _is_servo_device_connected(self, servo_type, serial):
1224 """Check if device is connected to the labstation.
1225
1226 Works for all servo devices connected to the labstation.
1227 For servo_v3 please use 'self._is_servo_board_present_on_servo_v3'
1228
1229 @param servo_type: The type of servo device. Expecting value can be
1230 servo_v4 or servo_micro.
1231 @param serial: The serial number of the device to detect it.
1232 """
1233 vid_pid = self.SERVO_VID_PID.get(servo_type)
1234 if not vid_pid or not serial:
1235 # device cannot detected without VID/PID or serial number
1236 return False
1237 logging.debug('Started to detect %s', servo_type)
1238 try:
1239 cmd = 'lsusb -v -d %s |grep iSerial |grep %s' % (vid_pid, serial)
1240 result = self.run(cmd, ignore_status=True, timeout=30)
1241 if result.exit_status == 0 and result.stdout.strip():
1242 logging.debug('The %s is plugged in to the host.', servo_type)
1243 return True
1244 logging.debug('%s device is not detected; %s', servo_type, result)
1245 return False
1246 except Exception as e:
1247 # can be triggered by timeout issue due running the script
1248 metrics.Counter(
1249 'chromeos/autotest/repair/servo_detection/timeout'
1250 ).increment(fields=self._get_host_metrics_data())
1251 logging.error('%s device is not detected; %s', servo_type, str(e))
1252 return None
1253
1254 def _is_servo_board_present_on_servo_v3(self):
1255 """Check if servo board is detected on servo_v3"""
1256 vid_pids = self.SERVO_VID_PID['servo_v3']
1257 if not vid_pids or len(vid_pids) == 0:
1258 # device cannot detected without VID/PID
1259 return False
1260 logging.debug('Started to detect servo board on servo_v3')
1261 not_detected = 'The servo board is not detected on servo_v3'
1262 try:
1263 cmd = 'lsusb | grep "%s"' % "\|".join(vid_pids)
1264 result = self.run(cmd, ignore_status=True, timeout=30)
1265 if result.exit_status == 0 and result.stdout.strip():
1266 logging.debug('The servo board is detected on servo_v3')
1267 return True
1268 logging.debug('%s; %s', not_detected, result)
1269 return False
1270 except Exception as e:
1271 # can be triggered by timeout issue due running the script
1272 metrics.Counter(
1273 'chromeos/autotest/repair/servo_detection/timeout'
1274 ).increment(fields=self._get_host_metrics_data())
1275 logging.error('%s; %s', not_detected, str(e))
1276 return None
1277
Otabek Kasimov120b6fa2020-07-03 00:15:27 -07001278 def _is_main_device_not_detected_on_servo_v4(self):
1279 """Check if servod cannot find main device on servo.
1280
1281 The check based on reading servod logs for servo_v4.
1282 """
1283 if not self._initial_instance_ts:
1284 # latest log not found
1285 return False
1286 logging.debug('latest log for servod created at %s',
1287 self._initial_instance_ts)
1288 try:
1289 log_created = calendar.timegm(time.strptime(
1290 self._initial_instance_ts,
1291 "%Y-%m-%d--%H-%M-%S.%f"))
1292 except ValueError as e:
1293 logging.debug('Cannot read time from log file name: %s',
1294 self._initial_instance_ts)
1295 return False
1296 min_time_created = calendar.timegm(time.gmtime())
1297 if min_time_created > log_created + 3600:
1298 # the log file is old we cannot use it
1299 logging.debug('log file was created more than hour ago, too old')
1300 return False
1301 logging.debug('latest log was created not longer then 1 hour ago')
1302
1303 # check if servod can detect main device by servo_v4
1304 message = 'ERROR - No servo micro or CCD detected for board'
1305 cmd = ('cat /var/log/servod_%s/log.%s.INFO |grep "%s"'
1306 % (self.servo_port, self._initial_instance_ts, message))
1307 result = self.run(cmd, ignore_status=True)
1308 if result.stdout.strip():
1309 logging.info('Servod cannot detect main device on the servo; '
1310 'Can be caused by bad hardware of servo or '
1311 'issue on the DUT side.')
1312 return True
1313 logging.debug('The main device is detected')
1314 return False
1315
Garry Wangb5cee3e2020-09-16 14:58:13 -07001316 def _require_cr50_servod_config(self):
1317 """Check whether we need start servod with CONFIG=cr50.xml"""
1318 dut_host_info = self.get_dut_host_info()
1319 if not dut_host_info:
1320 return False
1321 for pool in dut_host_info.pools:
1322 if pool.startswith(servo_constants.CR50_CONFIG_POOL_PREFIX):
1323 return True
1324 return False
1325
Otabek Kasimov15963492020-06-23 21:10:51 -07001326 def get_verify_state(self, tag):
1327 """Return the state of servo verifier.
1328
1329 @returns: bool or None
1330 """
1331 return self._repair_strategy.verifier_is_good(tag)
1332
1333 def determine_servo_state(self):
1334 """Determine servo state based on the failed verifier.
1335
1336 @returns: servo state value
1337 The state detecting based on first fail verifier or collecting of
1338 them.
1339 """
1340 ssh = self.get_verify_state('servo_ssh')
1341 disk_space = self.get_verify_state('disk_space')
1342 start_servod = self.get_verify_state('servod_job')
1343 create_servo = self.get_verify_state('servod_connection')
1344 init_servo = self.get_verify_state('servod_control')
Otabek Kasimova7eb4dc2020-09-16 10:25:17 -07001345 dut_connected = self.get_verify_state('dut_connected')
Otabek Kasimov15963492020-06-23 21:10:51 -07001346 pwr_button = self.get_verify_state('pwr_button')
1347 lid_open = self.get_verify_state('lid_open')
1348 ec_board = self.get_verify_state('ec_board')
1349 ccd_testlab = self.get_verify_state('ccd_testlab')
1350
1351 if not ssh:
1352 return servo_constants.SERVO_STATE_NO_SSH
1353
Otabek Kasimov066bdb82020-08-12 15:57:44 -07001354 if (start_servod == self.VERIFY_FAILED
1355 or create_servo == self.VERIFY_FAILED):
1356 # sometimes servo can start with out present servo
Otabek Kasimovc6f30412020-06-30 20:08:12 -07001357 if self.is_labstation():
1358 if not self.servo_serial:
1359 return servo_constants.SERVO_STATE_WRONG_CONFIG
1360 if self._is_servo_device_connected(
1361 'servo_v4',
1362 self.servo_serial) == False:
1363 return servo_constants.SERVO_STATE_NOT_CONNECTED
1364 elif self._is_servo_board_present_on_servo_v3() == False:
1365 return servo_constants.SERVO_STATE_NOT_CONNECTED
Otabek Kasimov066bdb82020-08-12 15:57:44 -07001366
Otabek Kasimova7eb4dc2020-09-16 10:25:17 -07001367 if dut_connected == self.VERIFY_FAILED:
1368 if pwr_button == self.VERIFY_SUCCESS:
1369 # unexpected case
1370 metrics.Counter(
1371 'chromeos/autotest/repair/servo_unexpected/pwr_button'
1372 ).increment(fields=self._get_host_metrics_data())
1373 return servo_constants.SERVO_STATE_DUT_NOT_CONNECTED
1374
Otabek Kasimov066bdb82020-08-12 15:57:44 -07001375 if start_servod == self.VERIFY_FAILED:
Otabek Kasimovc6f30412020-06-30 20:08:12 -07001376 return servo_constants.SERVO_STATE_SERVOD_ISSUE
1377
Otabek Kasimov120b6fa2020-07-03 00:15:27 -07001378 if create_servo == self.VERIFY_FAILED:
1379 if (self.is_labstation()
1380 and self._is_main_device_not_detected_on_servo_v4()):
1381 servo_type = None
1382 if self.get_dut_host_info():
1383 servo_type = self.get_dut_host_info().get_label_value(
1384 servo_constants.SERVO_TYPE_LABEL_PREFIX)
1385 if servo_type and 'servo_micro' in servo_type:
1386 serial = self.get_servo_micro_serial_number()
1387 logging.debug('servo_micro serial: %s', serial)
1388 if self._is_servo_device_detected('servo_micro',
1389 serial):
1390 return servo_constants.SERVO_STATE_BAD_RIBBON_CABLE
1391 # Device can be not detected because of DUT
1392 # TODO (otabek) update after b/159755652 and b/159754985
1393 metrics.Counter(
1394 'chromeos/autotest/repair/servo_state/needs_replacement'
1395 ).increment(fields=self._get_host_metrics_data())
1396 elif not self.is_labstation():
1397 # Here need logic to check if flex cable is connected
1398 pass
1399
Otabek Kasimov15963492020-06-23 21:10:51 -07001400 # one of the reason why servo can not initialized
1401 if ccd_testlab == self.VERIFY_FAILED:
1402 return servo_constants.SERVO_STATE_CCD_TESTLAB_ISSUE
1403
Otabek Kasimov120b6fa2020-07-03 00:15:27 -07001404 if (create_servo == self.VERIFY_FAILED
1405 or init_servo == self.VERIFY_FAILED):
Otabek Kasimov15963492020-06-23 21:10:51 -07001406 return servo_constants.SERVO_STATE_SERVOD_ISSUE
1407
Otabek Kasimov015c15c2020-08-20 00:40:42 -07001408 if ec_board == self.VERIFY_FAILED:
1409 return servo_constants.SERVO_STATE_EC_BROKEN
Otabek Kasimov15963492020-06-23 21:10:51 -07001410 if pwr_button == self.VERIFY_FAILED:
1411 return servo_constants.SERVO_STATE_BAD_RIBBON_CABLE
1412 if lid_open == self.VERIFY_FAILED:
1413 return servo_constants.SERVO_STATE_LID_OPEN_FAILED
Otabek Kasimov15963492020-06-23 21:10:51 -07001414
Otabek Kasimov15963492020-06-23 21:10:51 -07001415 metrics.Counter(
1416 'chromeos/autotest/repair/unknown_servo_state'
Otabek Kasimovc6f30412020-06-30 20:08:12 -07001417 ).increment(fields=self._get_host_metrics_data())
Otabek Kasimov15963492020-06-23 21:10:51 -07001418 logging.info('We do not have special state for this failure yet :)')
1419 return servo_constants.SERVO_STATE_BROKEN
1420
Otabek Kasimovcc9738e2020-02-14 16:17:15 -08001421
Richard Barnetteea3e4602016-06-10 12:36:41 -07001422def make_servo_hostname(dut_hostname):
1423 """Given a DUT's hostname, return the hostname of its servo.
1424
1425 @param dut_hostname: hostname of a DUT.
1426
1427 @return hostname of the DUT's servo.
1428
1429 """
1430 host_parts = dut_hostname.split('.')
1431 host_parts[0] = host_parts[0] + '-servo'
1432 return '.'.join(host_parts)
1433
1434
1435def servo_host_is_up(servo_hostname):
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -07001436 """Given a servo host name, return if it's up or not.
Richard Barnetteea3e4602016-06-10 12:36:41 -07001437
1438 @param servo_hostname: hostname of the servo host.
1439
1440 @return True if it's up, False otherwise
1441 """
1442 # Technically, this duplicates the SSH ping done early in the servo
1443 # proxy initialization code. However, this ping ends in a couple
1444 # seconds when if fails, rather than the 60 seconds it takes to decide
1445 # that an SSH ping has timed out. Specifically, that timeout happens
1446 # when our servo DNS name resolves, but there is no host at that IP.
1447 logging.info('Pinging servo host at %s', servo_hostname)
1448 ping_config = ping_runner.PingConfig(
1449 servo_hostname, count=3,
1450 ignore_result=True, ignore_status=True)
1451 return ping_runner.PingRunner().ping(ping_config).received > 0
1452
1453
Richard Barnettee519dcd2016-08-15 17:37:17 -07001454def _map_afe_board_to_servo_board(afe_board):
1455 """Map a board we get from the AFE to a servo appropriate value.
1456
1457 Many boards are identical to other boards for servo's purposes.
1458 This function makes that mapping.
1459
1460 @param afe_board string board name received from AFE.
1461 @return board we expect servo to have.
1462
1463 """
1464 KNOWN_SUFFIXES = ['-freon', '_freon', '_moblab', '-cheets']
1465 BOARD_MAP = {'gizmo': 'panther'}
1466 mapped_board = afe_board
1467 if afe_board in BOARD_MAP:
1468 mapped_board = BOARD_MAP[afe_board]
1469 else:
1470 for suffix in KNOWN_SUFFIXES:
1471 if afe_board.endswith(suffix):
1472 mapped_board = afe_board[0:-len(suffix)]
1473 break
1474 if mapped_board != afe_board:
1475 logging.info('Mapping AFE board=%s to %s', afe_board, mapped_board)
1476 return mapped_board
1477
1478
Prathmesh Prabhub4810232018-09-07 13:24:08 -07001479def get_servo_args_for_host(dut_host):
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -07001480 """Return servo data associated with a given DUT.
Richard Barnetteea3e4602016-06-10 12:36:41 -07001481
Richard Barnetteea3e4602016-06-10 12:36:41 -07001482 @param dut_host Instance of `Host` on which to find the servo
1483 attributes.
Prathmesh Prabhuf605dd32018-08-28 17:09:04 -07001484 @return `servo_args` dict with host and an optional port.
Richard Barnetteea3e4602016-06-10 12:36:41 -07001485 """
Prathmesh Prabhucba44292018-08-28 17:44:45 -07001486 info = dut_host.host_info_store.get()
Derek Beckettf73baca2020-08-19 15:08:47 -07001487 servo_args = {k: v for k, v in six.iteritems(info.attributes)
Garry Wang11b5e872020-03-11 15:14:08 -07001488 if k in servo_constants.SERVO_ATTR_KEYS}
Richard Barnetteea3e4602016-06-10 12:36:41 -07001489
Garry Wang11b5e872020-03-11 15:14:08 -07001490 if servo_constants.SERVO_PORT_ATTR in servo_args:
Prathmesh Prabhucba44292018-08-28 17:44:45 -07001491 try:
Garry Wang11b5e872020-03-11 15:14:08 -07001492 servo_args[servo_constants.SERVO_PORT_ATTR] = int(
1493 servo_args[servo_constants.SERVO_PORT_ATTR])
Prathmesh Prabhucba44292018-08-28 17:44:45 -07001494 except ValueError:
1495 logging.error('servo port is not an int: %s',
Garry Wang11b5e872020-03-11 15:14:08 -07001496 servo_args[servo_constants.SERVO_PORT_ATTR])
Prathmesh Prabhucba44292018-08-28 17:44:45 -07001497 # Reset servo_args because we don't want to use an invalid port.
Garry Wang11b5e872020-03-11 15:14:08 -07001498 servo_args.pop(servo_constants.SERVO_HOST_ATTR, None)
Prathmesh Prabhucba44292018-08-28 17:44:45 -07001499
1500 if info.board:
Garry Wang11b5e872020-03-11 15:14:08 -07001501 servo_board = _map_afe_board_to_servo_board(info.board)
1502 servo_args[servo_constants.SERVO_BOARD_ATTR] = servo_board
Nick Sanders2f3c9852018-10-24 12:10:24 -07001503 if info.model:
Garry Wang11b5e872020-03-11 15:14:08 -07001504 servo_args[servo_constants.SERVO_MODEL_ATTR] = info.model
1505 return servo_args if servo_constants.SERVO_HOST_ATTR in servo_args else None
Richard Barnetteea3e4602016-06-10 12:36:41 -07001506
1507
Prathmesh Prabhuefb1b482018-08-28 17:15:05 -07001508def _tweak_args_for_ssp_moblab(servo_args):
Garry Wang11b5e872020-03-11 15:14:08 -07001509 if (servo_args[servo_constants.SERVO_HOST_ATTR]
1510 in ['localhost', '127.0.0.1']):
1511 servo_args[servo_constants.SERVO_HOST_ATTR] = _CONFIG.get_config_value(
Prathmesh Prabhuefb1b482018-08-28 17:15:05 -07001512 'SSP', 'host_container_ip', type=str, default=None)
1513
1514
Dan Shi023aae32016-05-25 11:13:01 -07001515def create_servo_host(dut, servo_args, try_lab_servo=False,
Gregory Nisbetde13e2a2019-12-09 22:44:00 -08001516 try_servo_repair=False, dut_host_info=None):
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -07001517 """Create a ServoHost object for a given DUT, if appropriate.
Dan Shi4d478522014-02-14 13:46:32 -08001518
Richard Barnette9a26ad62016-06-10 12:03:08 -07001519 This function attempts to create and verify or repair a `ServoHost`
1520 object for a servo connected to the given `dut`, subject to various
1521 constraints imposed by the parameters:
1522 * When the `servo_args` parameter is not `None`, a servo
1523 host must be created, and must be checked with `repair()`.
1524 * Otherwise, if a servo exists in the lab and `try_lab_servo` is
1525 true:
1526 * If `try_servo_repair` is true, then create a servo host and
1527 check it with `repair()`.
1528 * Otherwise, if the servo responds to `ping` then create a
1529 servo host and check it with `verify()`.
Fang Denge545abb2014-12-30 18:43:47 -08001530
Richard Barnette9a26ad62016-06-10 12:03:08 -07001531 In cases where `servo_args` was not `None`, repair failure
1532 exceptions are passed back to the caller; otherwise, exceptions
Richard Barnette07c2e1d2016-10-26 14:24:28 -07001533 are logged and then discarded. Note that this only happens in cases
1534 where we're called from a test (not special task) control file that
1535 has an explicit dependency on servo. In that case, we require that
1536 repair not write to `status.log`, so as to avoid polluting test
1537 results.
1538
1539 TODO(jrbarnette): The special handling for servo in test control
1540 files is a thorn in my flesh; I dearly hope to see it cut out before
1541 my retirement.
Richard Barnette9a26ad62016-06-10 12:03:08 -07001542
1543 Parameters for a servo host consist of a host name, port number, and
1544 DUT board, and are determined from one of these sources, in order of
1545 priority:
Richard Barnetteea3e4602016-06-10 12:36:41 -07001546 * Servo attributes from the `dut` parameter take precedence over
1547 all other sources of information.
1548 * If a DNS entry for the servo based on the DUT hostname exists in
1549 the CrOS lab network, that hostname is used with the default
Richard Barnette9a26ad62016-06-10 12:03:08 -07001550 port and the DUT's board.
Richard Barnetteea3e4602016-06-10 12:36:41 -07001551 * If no other options are found, the parameters will be taken
Richard Barnette9a26ad62016-06-10 12:03:08 -07001552 from the `servo_args` dict passed in from the caller.
Richard Barnetteea3e4602016-06-10 12:36:41 -07001553
1554 @param dut An instance of `Host` from which to take
1555 servo parameters (if available).
1556 @param servo_args A dictionary with servo parameters to use if
1557 they can't be found from `dut`. If this
1558 argument is supplied, unrepaired exceptions
1559 from `verify()` will be passed back to the
1560 caller.
1561 @param try_lab_servo If not true, servo host creation will be
1562 skipped unless otherwise required by the
1563 caller.
Richard Barnette9a26ad62016-06-10 12:03:08 -07001564 @param try_servo_repair If true, check a servo host with
1565 `repair()` instead of `verify()`.
Otabek Kasimov8475cce2020-07-14 12:11:31 -07001566 @param dut_host_info: A HostInfo object of the DUT that connected
1567 to this servo.
Dan Shi4d478522014-02-14 13:46:32 -08001568
1569 @returns: A ServoHost object or None. See comments above.
1570
1571 """
Richard Barnette07c2e1d2016-10-26 14:24:28 -07001572 servo_dependency = servo_args is not None
Richard Barnette07c2e1d2016-10-26 14:24:28 -07001573 if dut is not None and (try_lab_servo or servo_dependency):
Prathmesh Prabhub4810232018-09-07 13:24:08 -07001574 servo_args_override = get_servo_args_for_host(dut)
Richard Barnetteea3e4602016-06-10 12:36:41 -07001575 if servo_args_override is not None:
Prathmesh Prabhuefb1b482018-08-28 17:15:05 -07001576 if utils.in_moblab_ssp():
1577 _tweak_args_for_ssp_moblab(servo_args_override)
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001578 logging.debug(
1579 'Overriding provided servo_args (%s) with arguments'
1580 ' determined from the host (%s)',
1581 servo_args,
1582 servo_args_override,
1583 )
Richard Barnetteea3e4602016-06-10 12:36:41 -07001584 servo_args = servo_args_override
Prathmesh Prabhucba44292018-08-28 17:44:45 -07001585
Richard Barnetteea3e4602016-06-10 12:36:41 -07001586 if servo_args is None:
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001587 logging.debug('No servo_args provided, and failed to find overrides.')
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001588 if try_lab_servo or servo_dependency:
Otabek Kasimov646812c2020-06-23 20:01:36 -07001589 return None, servo_constants.SERVO_STATE_MISSING_CONFIG
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001590 else:
1591 # For regular test case which not required the servo
1592 return None, None
1593
Garry Wang11b5e872020-03-11 15:14:08 -07001594 servo_hostname = servo_args.get(servo_constants.SERVO_HOST_ATTR)
1595 servo_port = servo_args.get(servo_constants.SERVO_PORT_ATTR)
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001596 if not _is_servo_host_information_exist(servo_hostname, servo_port):
1597 logging.debug(
1598 'Servo connection info missed hostname: %s , port: %s',
1599 servo_hostname, servo_port)
Otabek Kasimov646812c2020-06-23 20:01:36 -07001600 return None, servo_constants.SERVO_STATE_MISSING_CONFIG
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001601 if not is_servo_host_information_valid(servo_hostname, servo_port):
1602 logging.debug(
1603 'Servo connection info is incorrect hostname: %s , port: %s',
1604 servo_hostname, servo_port)
Garry Wang11b5e872020-03-11 15:14:08 -07001605 return None, servo_constants.SERVO_STATE_WRONG_CONFIG
Richard Barnette07c2e1d2016-10-26 14:24:28 -07001606 if (not servo_dependency and not try_servo_repair and
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001607 not servo_host_is_up(servo_hostname)):
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001608 logging.debug('ServoHost is not up.')
Otabek Kasimov646812c2020-06-23 20:01:36 -07001609 return None, servo_constants.SERVO_STATE_NO_SSH
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001610
Garry Wangebc015b2019-06-06 17:45:06 -07001611 newhost = ServoHost(**servo_args)
Garry Wangffbd2162020-04-17 16:13:48 -07001612
Otabek Kasimove6df8102020-07-21 20:15:25 -07001613 # Reset or reboot servo device only during AdminRepair tasks.
1614 if try_servo_repair:
1615 if newhost._is_locked:
1616 # Reset servo if the servo is locked, as we check if the servohost
1617 # is up, if the servohost is labstation and if the servohost is in
1618 # lab inside the locking logic.
1619 newhost.reset_servo()
1620 else:
Garry Wang358aad42020-08-02 20:56:04 -07001621 try:
1622 newhost.reboot_servo_v3_on_need()
Garry Wang1f0d5332020-08-10 19:32:32 -07001623 except Exception as e:
1624 logging.info('[Non-critical] Unexpected error while trying to'
1625 ' reboot servo_v3, skipping the reboot; %s', e)
Otabek Kasimove6df8102020-07-21 20:15:25 -07001626
Otabek Kasimov2b50cdb2020-07-06 19:16:06 -07001627 if dut:
1628 newhost.set_dut_hostname(dut.hostname)
Otabek Kasimov9e90ae12020-08-14 03:01:19 -07001629 if dut_host_info:
1630 newhost.set_dut_host_info(dut_host_info)
Garry Wangffbd2162020-04-17 16:13:48 -07001631
Otabek Kasimov8475cce2020-07-14 12:11:31 -07001632 if try_lab_servo or try_servo_repair:
1633 try:
1634 logging.info("Check and update servo firmware.")
1635 servo_updater.update_servo_firmware(
1636 newhost,
1637 force_update=False)
1638 except Exception as e:
1639 logging.error("Servo device update error: %s", e)
1640
Garry Wangcdd27b22020-01-13 14:59:11 -08001641 try:
1642 newhost.restart_servod(quick_startup=True)
1643 except error.AutoservSSHTimeout:
1644 logging.warning("Restart servod failed due ssh connection "
1645 "to servohost timed out. This error is forgiven"
1646 " here, we will retry in servo repair process.")
1647 except error.AutoservRunError as e:
1648 logging.warning("Restart servod failed due to:\n%s\n"
1649 "This error is forgiven here, we will retry"
1650 " in servo repair process.", str(e))
Garry Wangebc015b2019-06-06 17:45:06 -07001651
Richard Barnette9a26ad62016-06-10 12:03:08 -07001652 # Note that the logic of repair() includes everything done
1653 # by verify(). It's sufficient to call one or the other;
1654 # we don't need both.
Richard Barnette07c2e1d2016-10-26 14:24:28 -07001655 if servo_dependency:
1656 newhost.repair(silent=True)
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001657 return newhost, newhost.get_servo_state()
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001658
1659 if try_servo_repair:
1660 try:
1661 newhost.repair()
1662 except Exception:
1663 logging.exception('servo repair failed for %s', newhost.hostname)
Richard Barnette9a26ad62016-06-10 12:03:08 -07001664 else:
1665 try:
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001666 newhost.verify()
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -07001667 except Exception:
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001668 logging.exception('servo verify failed for %s', newhost.hostname)
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001669 return newhost, newhost.get_servo_state()
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001670
1671
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001672def _is_servo_host_information_exist(hostname, port):
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001673 if hostname is None or len(hostname.strip()) == 0:
1674 return False
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001675 if port is None:
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001676 return False
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001677 if not type(port) is int:
1678 try:
1679 int(port)
1680 except ValueError:
1681 return False
1682
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001683 return True
1684
1685
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001686def is_servo_host_information_valid(hostname, port):
Garry Wang9b8f2342020-04-17 16:34:09 -07001687 """Check if provided servo attributes are valid.
1688
1689 @param hostname Hostname of the servohost.
1690 @param port servo port number.
1691
1692 @returns: A bool value to indicate if provided servo attribute valid.
1693 """
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001694 if not _is_servo_host_information_exist(hostname, port):
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001695 return False
1696 # checking range and correct of the port
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001697 port_int = int(port)
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001698 if port_int < 1 or port_int > 65000:
1699 return False
1700 # we expecting host contain only latters, digits and '-' or '_'
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001701 if not re.match('[a-zA-Z0-9-_\.]*$', hostname) or len(hostname) < 5:
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001702 return False
1703 return True