blob: 848caa51d839f1e1c9080cee8a9b529338335443 [file] [log] [blame]
Derek Beckettf73baca2020-08-19 15:08:47 -07001# Lint as: python2, python3
Fang Deng5d518f42013-08-02 14:04:32 -07002# Copyright (c) 2013 The Chromium OS Authors. All rights reserved.
3# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5#
6# Expects to be run in an environment with sudo and no interactive password
7# prompt, such as within the Chromium OS development chroot.
8
9
10"""This file provides core logic for servo verify/repair process."""
11
12
Derek Beckettf73baca2020-08-19 15:08:47 -070013from __future__ import absolute_import
14from __future__ import division
15from __future__ import print_function
16
Fang Deng5d518f42013-08-02 14:04:32 -070017import logging
Raul E Rangel52ca2e82018-07-03 14:10:14 -060018import os
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -080019import re
20import tarfile
Andrew McRaef0679932020-08-13 09:15:23 +100021import threading
Garry Wang2b5eef92020-08-21 16:23:35 -070022import json
Garry Wangc1288cf2019-12-17 14:58:00 -080023import time
Derek Beckettf73baca2020-08-19 15:08:47 -070024import six
25import six.moves.xmlrpc_client
Otabek Kasimov120b6fa2020-07-03 00:15:27 -070026import calendar
Fang Deng5d518f42013-08-02 14:04:32 -070027
28from autotest_lib.client.bin import utils
Garry Wang79e9af62019-06-12 15:19:19 -070029from autotest_lib.client.common_lib import error
Richard Barnette9a26ad62016-06-10 12:03:08 -070030from autotest_lib.client.common_lib import hosts
Garry Wang7b0e1b72020-03-25 19:08:59 -070031from autotest_lib.client.common_lib import lsbrelease_utils
Fang Deng5d518f42013-08-02 14:04:32 -070032from autotest_lib.client.common_lib.cros import retry
Christopher Wileycef1f902014-06-19 11:11:23 -070033from autotest_lib.client.common_lib.cros.network import ping_runner
Richard Barnette9a26ad62016-06-10 12:03:08 -070034from autotest_lib.server.cros.servo import servo
Richard Barnetted31580e2018-05-14 19:58:00 +000035from autotest_lib.server.hosts import servo_repair
Garry Wangebc015b2019-06-06 17:45:06 -070036from autotest_lib.server.hosts import base_servohost
Garry Wang11b5e872020-03-11 15:14:08 -070037from autotest_lib.server.hosts import servo_constants
Otabek Kasimov4ea636e2020-04-14 23:35:06 -070038from autotest_lib.server.cros.faft.utils import config
Garry Wang11b5e872020-03-11 15:14:08 -070039from autotest_lib.client.common_lib import global_config
Otabek Kasimov8475cce2020-07-14 12:11:31 -070040from autotest_lib.site_utils.admin_audit import servo_updater
Garry Wangd7367482020-02-27 13:52:40 -080041
Otabek Kasimov15963492020-06-23 21:10:51 -070042try:
43 from chromite.lib import metrics
44except ImportError:
45 metrics = utils.metrics_mock
46
Dan Shi3b2adf62015-09-02 17:46:54 -070047_CONFIG = global_config.global_config
Fang Deng5d518f42013-08-02 14:04:32 -070048
Otabek Kasimova7ba91a2020-03-09 08:31:01 -070049
Garry Wangebc015b2019-06-06 17:45:06 -070050class ServoHost(base_servohost.BaseServoHost):
51 """Host class for a servo host(e.g. beaglebone, labstation)
Dana Goyette0b6e6402019-10-04 11:09:24 -070052 that with a servo instance for a specific port.
53
54 @type _servo: servo.Servo | None
55 """
Fang Deng5d518f42013-08-02 14:04:32 -070056
Raul E Rangel52ca2e82018-07-03 14:10:14 -060057 DEFAULT_PORT = int(os.getenv('SERVOD_PORT', '9999'))
Richard Barnette9a26ad62016-06-10 12:03:08 -070058
Dan Shie5b3c512014-08-21 12:12:09 -070059 # Timeout for initializing servo signals.
Wai-Hong Tam37b6ed32017-09-19 15:52:39 -070060 INITIALIZE_SERVO_TIMEOUT_SECS = 60
Richard Barnette9a26ad62016-06-10 12:03:08 -070061
Otabek Kasimov545739c2020-08-20 00:24:21 -070062 # Default timeout for run terminal command.
63 DEFAULT_TERMINAL_TIMEOUT = 30
64
xixuan6cf6d2f2016-01-29 15:29:00 -080065 # Ready test function
66 SERVO_READY_METHOD = 'get_version'
Fang Deng5d518f42013-08-02 14:04:32 -070067
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -080068 # Directory prefix on the servo host where the servod logs are stored.
69 SERVOD_LOG_PREFIX = '/var/log/servod'
70
71 # Exit code to use when symlinks for servod logs are not found.
72 NO_SYMLINKS_CODE = 9
73
74 # Directory in the job's results directory to dump the logs into.
75 LOG_DIR = 'servod'
76
77 # Prefix for joint loglevel files in the logs.
78 JOINT_LOG_PREFIX = 'log'
79
80 # Regex group to extract timestamp from logfile name.
81 TS_GROUP = 'ts'
82
83 # This regex is used to extract the timestamp from servod logs.
Garry Wang22f2e842020-09-09 20:19:19 -070084 # files always start with log.
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -080085 TS_RE = (r'log.'
86 # The timestamp is of format %Y-%m-%d--%H-%M-%S.MS
87 r'(?P<%s>\d{4}(\-\d{2}){2}\-(-\d{2}){3}.\d{3})'
88 # The loglevel is optional depending on labstation version.
89 r'(.(INFO|DEBUG|WARNING))?' % TS_GROUP)
90 TS_EXTRACTOR = re.compile(TS_RE)
91
92 # Regex group to extract MCU name from logline in servod logs.
93 MCU_GROUP = 'mcu'
94
95 # Regex group to extract logline from MCU logline in servod logs.
96 LINE_GROUP = 'line'
97
98 # This regex is used to extract the mcu and the line content from an
99 # MCU logline in servod logs. e.g. EC or servo_v4 console logs.
100 # Here is an example log-line:
101 #
102 # 2020-01-23 13:15:12,223 - servo_v4 - EC3PO.Console - DEBUG -
103 # console.py:219:LogConsoleOutput - /dev/pts/9 - cc polarity: cc1
104 #
105 # Here is conceptually how they are formatted:
106 #
107 # <time> - <MCU> - EC3PO.Console - <LVL> - <file:line:func> - <pts> -
108 # <output>
109 #
Garry Wang22f2e842020-09-09 20:19:19 -0700110 # The log format starts with a timestamp
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800111 MCU_RE = (r'[\d\-]+ [\d:,]+ '
112 # The mcu that is logging this is next.
113 r'- (?P<%s>\w+) - '
114 # Next, we have more log outputs before the actual line.
115 # Information about the file line, logging function etc.
116 # Anchor on EC3PO Console, LogConsoleOutput and dev/pts.
117 # NOTE: if the log format changes, this regex needs to be
118 # adjusted.
119 r'EC3PO\.Console[\s\-\w\d:.]+LogConsoleOutput - /dev/pts/\d+ - '
120 # Lastly, we get the MCU's console line.
121 r'(?P<%s>.+$)' % (MCU_GROUP, LINE_GROUP))
122 MCU_EXTRACTOR = re.compile(MCU_RE)
123
Otabek Kasimov545739c2020-08-20 00:24:21 -0700124 # Regex to detect timeout messages when USBC pigtail has timeout issue.
125 # e.g.: [475635.427072 PD TMOUT RX 1/1]
126 USBC_PIGTAIL_TIMEOUT_RE = r'\[[\d \.]{1,20}(PD TMOUT RX 1\/1)\]'
127
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800128 # Suffix to identify compressed logfiles.
129 COMPRESSION_SUFFIX = '.tbz2'
130
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700131 # A suffix to mark servod log directories that came from instance that
132 # ran during this servo_host, but are not the last one running e.g. when
133 # an instance (on purpose, or due to a bug) restarted in the middle of the
134 # run.
135 OLD_LOG_SUFFIX = 'old'
136
Otabek Kasimovc6f30412020-06-30 20:08:12 -0700137 # Mapping servo board with their vid-pid
138 SERVO_VID_PID = {
139 'servo_v4':'18d1:501b',
140 'ccd_cr50':'18d1:5014',
141 'servo_micro':'18d1:501a',
142 'servo_v3':['18d1:5004', '0403:6014'],
143 }
144
Otabek Kasimovcc9738e2020-02-14 16:17:15 -0800145 def _init_attributes(self):
146 self._servo_state = None
147 self.servo_port = None
148 self.servo_board = None
149 self.servo_model = None
150 self.servo_serial = None
Garry Wangcb06f3b2020-10-08 20:56:21 -0700151 self.servo_setup = None
Garry Wang000c6c02020-05-11 21:27:23 -0700152 # The flag that indicate if a servo is connected to a smart usbhub.
153 # TODO(xianuowang@) remove this flag once all usbhubs in the lab
154 # get replaced.
155 self.smart_usbhub = None
Otabek Kasimovcc9738e2020-02-14 16:17:15 -0800156 self._servo = None
Andrew McRaef0679932020-08-13 09:15:23 +1000157 self._tunnel_proxy = None
158 self._tunnel_proxy_lock = threading.Lock()
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700159 self._initial_instance_ts = None
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800160 # Flag to make sure that multiple calls to close do not result in the
161 # logic executing multiple times.
162 self._closed = False
Andrew McRaef0679932020-08-13 09:15:23 +1000163 # Per-thread local data
164 self._local = threading.local()
Fang Deng5d518f42013-08-02 14:04:32 -0700165
Garry Wangcb06f3b2020-10-08 20:56:21 -0700166 def _initialize(self,
167 servo_host='localhost',
168 servo_port=DEFAULT_PORT,
169 servo_board=None,
170 servo_model=None,
171 servo_serial=None,
172 servo_setup=None,
173 is_in_lab=None,
174 *args,
175 **dargs):
Fang Deng5d518f42013-08-02 14:04:32 -0700176 """Initialize a ServoHost instance.
177
178 A ServoHost instance represents a host that controls a servo.
179
180 @param servo_host: Name of the host where the servod process
181 is running.
Raul E Rangel52ca2e82018-07-03 14:10:14 -0600182 @param servo_port: Port the servod process is listening on. Defaults
183 to the SERVOD_PORT environment variable if set,
184 otherwise 9999.
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -0700185 @param servo_board: Board that the servo is connected to.
Nick Sanders2f3c9852018-10-24 12:10:24 -0700186 @param servo_model: Model that the servo is connected to.
Garry Wangcb06f3b2020-10-08 20:56:21 -0700187 @param servo_serial: Serial number of the servo device.
188 @param servo_setup: Type of servo setup, e.g. REGULAR or DUAL_V4.
Dan Shi4d478522014-02-14 13:46:32 -0800189 @param is_in_lab: True if the servo host is in Cros Lab. Default is set
190 to None, for which utils.host_is_in_lab_zone will be
191 called to check if the servo host is in Cros lab.
Fang Deng5d518f42013-08-02 14:04:32 -0700192
193 """
194 super(ServoHost, self)._initialize(hostname=servo_host,
Garry Wangebc015b2019-06-06 17:45:06 -0700195 is_in_lab=is_in_lab, *args, **dargs)
Otabek Kasimovcc9738e2020-02-14 16:17:15 -0800196 self._init_attributes()
Richard Barnette42f4db92018-08-23 15:05:15 -0700197 self.servo_port = int(servo_port)
Richard Barnettee519dcd2016-08-15 17:37:17 -0700198 self.servo_board = servo_board
Nick Sanders2f3c9852018-10-24 12:10:24 -0700199 self.servo_model = servo_model
Kevin Cheng643ce8a2016-09-15 15:42:12 -0700200 self.servo_serial = servo_serial
Garry Wangcb06f3b2020-10-08 20:56:21 -0700201 self.servo_setup = servo_setup
Wai-Hong Tam3a8a2552019-11-19 14:28:04 +0800202
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800203 # The location of the log files on the servo host for this instance.
204 self.remote_log_dir = '%s_%s' % (self.SERVOD_LOG_PREFIX,
205 self.servo_port)
Garry Wang79e9af62019-06-12 15:19:19 -0700206 # Path of the servo host lock file.
Derek Beckettf73baca2020-08-19 15:08:47 -0700207 self._lock_file = (self.TEMP_FILE_DIR + str(self.servo_port) +
208 self.LOCK_FILE_POSTFIX)
Garry Wang79e9af62019-06-12 15:19:19 -0700209 # File path to declare a reboot request.
Derek Beckettf73baca2020-08-19 15:08:47 -0700210 self._reboot_file = (self.TEMP_FILE_DIR + str(self.servo_port) +
211 self.REBOOT_FILE_POSTFIX)
Garry Wang79e9af62019-06-12 15:19:19 -0700212
213 # Lock the servo host if it's an in-lab labstation to prevent other
214 # task to reboot it until current task completes. We also wait and
215 # make sure the labstation is up here, in the case of the labstation is
216 # in the middle of reboot.
Garry Wang7c00b0f2019-06-25 17:28:17 -0700217 self._is_locked = False
Garry Wang42b4d862019-06-25 15:50:49 -0700218 if (self.wait_up(self.REBOOT_TIMEOUT) and self.is_in_lab()
219 and self.is_labstation()):
Garry Wang79e9af62019-06-12 15:19:19 -0700220 self._lock()
Garry Wang78ce64d2020-10-13 18:23:45 -0700221 try:
222 self.wait_ready()
223 except Exception as e:
224 logging.info(
225 'Unexpected error while ensure labstation'
226 ' readiness; %s', str(e))
Garry Wangebc015b2019-06-06 17:45:06 -0700227
Richard Barnette9a26ad62016-06-10 12:03:08 -0700228 self._repair_strategy = (
229 servo_repair.create_servo_repair_strategy())
Richard Barnettee519dcd2016-08-15 17:37:17 -0700230
Dana Goyetteafa62fd2020-03-16 13:45:27 -0700231 def __str__(self):
232 return "<%s '%s:%s'>" % (
233 type(self).__name__, self.hostname, self.servo_port)
234
Richard Barnette9a26ad62016-06-10 12:03:08 -0700235 def connect_servo(self):
Garry Wang8c8dc972020-06-09 13:41:51 -0700236 """ Initialize and setup servo for later use.
237 """
238 self.initilize_servo()
239 self.initialize_dut_for_servo()
240
Garry Wang8c8dc972020-06-09 13:41:51 -0700241 def initilize_servo(self):
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -0700242 """Establish a connection to the servod server on this host.
Richard Barnette9a26ad62016-06-10 12:03:08 -0700243
244 Initializes `self._servo` and then verifies that all network
245 connections are working. This will create an ssh tunnel if
246 it's required.
Garry Wang8c8dc972020-06-09 13:41:51 -0700247 """
248 self._servo = servo.Servo(servo_host=self,
249 servo_serial=self.servo_serial)
Richard Barnette9a26ad62016-06-10 12:03:08 -0700250
Garry Wang8c8dc972020-06-09 13:41:51 -0700251 def initialize_dut_for_servo(self):
252 """This method will do some setup for dut control, e.g. setup
253 main servo_v4 device, and also testing the connection between servo
254 and DUT. As a side effect of testing the connection, all signals on
255 the target servo are reset to default values, and the USB stick is
Richard Barnette9a26ad62016-06-10 12:03:08 -0700256 set to the neutral (off) position.
257 """
Garry Wang8c8dc972020-06-09 13:41:51 -0700258 if not self._servo:
259 raise hosts.AutoservVerifyError('Servo object needs to be'
260 ' initialized before initialize'
261 ' DUT.')
Richard Barnette9a26ad62016-06-10 12:03:08 -0700262 timeout, _ = retry.timeout(
Garry Wang8c8dc972020-06-09 13:41:51 -0700263 self._servo.initialize_dut,
264 timeout_sec=self.INITIALIZE_SERVO_TIMEOUT_SECS)
Richard Barnette9a26ad62016-06-10 12:03:08 -0700265 if timeout:
Garry Wang8c8dc972020-06-09 13:41:51 -0700266 raise hosts.AutoservVerifyError('Initialize dut for servo timed'
267 ' out.')
Richard Barnette9a26ad62016-06-10 12:03:08 -0700268
Richard Barnette9a26ad62016-06-10 12:03:08 -0700269 def disconnect_servo(self):
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -0700270 """Disconnect our servo if it exists.
Richard Barnette9a26ad62016-06-10 12:03:08 -0700271
272 If we've previously successfully connected to our servo,
273 disconnect any established ssh tunnel, and set `self._servo`
274 back to `None`.
275 """
276 if self._servo:
277 # N.B. This call is safe even without a tunnel:
278 # rpc_server_tracker.disconnect() silently ignores
279 # unknown ports.
280 self.rpc_server_tracker.disconnect(self.servo_port)
281 self._servo = None
Fang Deng5d518f42013-08-02 14:04:32 -0700282
Andrew McRaef0679932020-08-13 09:15:23 +1000283 def _maybe_create_servod_ssh_tunnel_proxy(self):
284 """Create a xmlrpc proxy for use with a ssh tunnel.
285 A lock is used to safely create a singleton proxy.
286 """
287 with self._tunnel_proxy_lock:
288 if self._tunnel_proxy is None:
289 self._tunnel_proxy = self.rpc_server_tracker.xmlrpc_connect(
290 None,
291 self.servo_port,
292 ready_test_name=self.SERVO_READY_METHOD,
293 timeout_seconds=60,
294 request_timeout_seconds=3600,
295 server_desc=str(self))
296
Andrew McRaef0679932020-08-13 09:15:23 +1000297 def get_servod_server_proxy(self):
298 """Return a proxy if it exists; otherwise, create a new one.
299 A proxy can either be a ssh tunnel based proxy, or a httplib
300 based proxy.
Fang Deng5d518f42013-08-02 14:04:32 -0700301
302 @returns: An xmlrpclib.ServerProxy that is connected to the servod
303 server on the host.
Fang Deng5d518f42013-08-02 14:04:32 -0700304 """
Garry Wang11b5e872020-03-11 15:14:08 -0700305 if (servo_constants.ENABLE_SSH_TUNNEL_FOR_SERVO
306 and not self.is_localhost()):
Andrew McRaef0679932020-08-13 09:15:23 +1000307 # Check for existing ssh tunnel proxy.
308 if self._tunnel_proxy is None:
309 self._maybe_create_servod_ssh_tunnel_proxy()
310 return self._tunnel_proxy
Richard Barnette9a26ad62016-06-10 12:03:08 -0700311 else:
Andrew McRaef0679932020-08-13 09:15:23 +1000312 # xmlrpc/httplib is not thread-safe, so each thread must have its
313 # own separate proxy connection.
314 if not hasattr(self._local, "_per_thread_proxy"):
315 remote = 'http://%s:%s' % (self.hostname, self.servo_port)
Derek Beckettf73baca2020-08-19 15:08:47 -0700316 self._local._per_thread_proxy = six.moves.xmlrpc_client.ServerProxy(remote)
Andrew McRaef0679932020-08-13 09:15:23 +1000317 return self._local._per_thread_proxy
Wai-Hong Tam3a8a2552019-11-19 14:28:04 +0800318
Richard Barnette1edbb162016-11-01 11:47:50 -0700319 def verify(self, silent=False):
320 """Update the servo host and verify it's in a good state.
321
322 @param silent If true, suppress logging in `status.log`.
323 """
Richard Barnetteabbdc252018-07-26 16:57:42 -0700324 message = 'Beginning verify for servo host %s port %s serial %s'
325 message %= (self.hostname, self.servo_port, self.servo_serial)
326 self.record('INFO', None, None, message)
Richard Barnette9a26ad62016-06-10 12:03:08 -0700327 try:
Richard Barnette1edbb162016-11-01 11:47:50 -0700328 self._repair_strategy.verify(self, silent)
Garry Wang11b5e872020-03-11 15:14:08 -0700329 self._servo_state = servo_constants.SERVO_STATE_WORKING
330 self.record('INFO', None, None,
331 'ServoHost verify set servo_state as WORKING')
Garry Wang63b8c382020-03-11 22:28:40 -0700332 except Exception as e:
Otabek Kasimov120b6fa2020-07-03 00:15:27 -0700333 if not self.is_localhost():
Otabek Kasimovc6f30412020-06-30 20:08:12 -0700334 self._servo_state = self.determine_servo_state()
335 self.record('INFO', None, None,
336 'ServoHost verify set servo_state as %s'
337 % self._servo_state)
Garry Wang63b8c382020-03-11 22:28:40 -0700338 if self._is_critical_error(e):
339 raise
Fang Deng5d518f42013-08-02 14:04:32 -0700340
Garry Wang2b5eef92020-08-21 16:23:35 -0700341 def _get_default_usbkey_mount_path(self):
342 return '/media/servo_usb/%s' % self.servo_port
Fang Deng5d518f42013-08-02 14:04:32 -0700343
Garry Wang7b0e1b72020-03-25 19:08:59 -0700344 def get_image_name_from_usbkey(self, usbkey_dev):
345 """Mount usb drive and check ChromeOS image name on it if there is
346 one. This method assumes the image_usbkey_direction is already set
347 to servo side.
348
Garry Wang4b980202020-09-24 17:00:17 -0700349 @param usbkey_dev: usbkey dev path(e.g. /dev/sdb).
Garry Wang7b0e1b72020-03-25 19:08:59 -0700350
351 @returns: image_name on the usbkey, e.g. nami-release/R82.10138.0.0,
352 or empty string if no test image detected, or unexpected
353 error occurred.
Garry Wang7b0e1b72020-03-25 19:08:59 -0700354 """
Garry Wang70e5d062020-04-03 18:01:05 -0700355 logging.info('Checking ChromeOS image name on usbkey.')
Garry Wang2b5eef92020-08-21 16:23:35 -0700356 mount_dst = self._get_default_usbkey_mount_path()
Garry Wang7b0e1b72020-03-25 19:08:59 -0700357 # Unmount if there is an existing stale mount.
Garry Wang2b5eef92020-08-21 16:23:35 -0700358 self._unmount_drive(mount_dst)
359 # ChromeOS root fs is in /dev/sdx3
360 mount_src = usbkey_dev + '3'
Garry Wang7b0e1b72020-03-25 19:08:59 -0700361 try:
Garry Wang2b5eef92020-08-21 16:23:35 -0700362 if not self._mount_drive(mount_src, mount_dst):
363 logging.debug('Unexpected error occurred on mount usb drive.')
Garry Wang7b0e1b72020-03-25 19:08:59 -0700364 return ''
Garry Wang70e5d062020-04-03 18:01:05 -0700365
366 release_content = self.run(
Garry Wang2b5eef92020-08-21 16:23:35 -0700367 'cat %s/etc/lsb-release' % mount_dst,
Garry Wang70e5d062020-04-03 18:01:05 -0700368 ignore_status=True).stdout.strip()
369
370 if not re.search(r'RELEASE_TRACK=.*test', release_content):
371 logging.info('The image on usbkey is not a test image')
372 return ''
373
374 return lsbrelease_utils.get_chromeos_release_builder_path(
375 lsb_release_content=release_content)
Garry Wang7b0e1b72020-03-25 19:08:59 -0700376 finally:
Garry Wang70e5d062020-04-03 18:01:05 -0700377 logging.debug('Image check compeleted, unmounting the usb drive.')
Garry Wang2b5eef92020-08-21 16:23:35 -0700378 self._unmount_drive(mount_dst)
Garry Wang7b0e1b72020-03-25 19:08:59 -0700379
Garry Wang2b5eef92020-08-21 16:23:35 -0700380 def _extract_firmware_image_from_usbkey(self, fw_dst):
381 """Extract firmware images from the usbkey on servo, this method
382 assumes there is already a ChromeOS test image staged on servo.
383
Garry Wang4b980202020-09-24 17:00:17 -0700384 @param fw_dst: the path that we'll copy firmware images to.
Garry Wang2b5eef92020-08-21 16:23:35 -0700385
386 @returns: a json format string of firmware manifest data.
387 """
388 usbkey_dev = self._probe_and_validate_usb_dev()
389 if not usbkey_dev:
390 raise hosts.AutoservRepairError('Unexpected error occurred when'
391 ' probe usbkey dev path, please check logs for detail.')
392
393 mount_dst = self._get_default_usbkey_mount_path()
394 # Unmount if there is an existing stale mount.
395 self._unmount_drive(mount_dst)
396 # ChromeOS root fs is in /dev/sdx3
397 mount_src = usbkey_dev + '3'
398 try:
399 if not self._mount_drive(mount_src, mount_dst):
400 raise hosts.AutoservRepairError('Failed to extract firmware'
401 ' image; Unable to mount %s.' % usbkey_dev,
402 'unable to mount usbkey')
403 updater_bin = os.path.join(mount_dst,
404 'usr/sbin/chromeos-firmwareupdate')
405 self.run('%s --unpack %s' % (updater_bin, fw_dst))
406 return self.run('%s --manifest' % updater_bin).stdout
407 finally:
408 self._unmount_drive(mount_dst)
409
410 def prepare_repair_firmware_image(self, fw_dst=None):
411 """Prepare firmware image on the servohost for auto repair process
412 to consume.
413
Garry Wang4b980202020-09-24 17:00:17 -0700414 @param fw_dst: the path that we want to store firmware image on
415 the servohost.
Garry Wang2b5eef92020-08-21 16:23:35 -0700416
417 @returns: A tuple that containes ec firmware image path and bios
418 firmware image path on the servohost, or None if type of
419 image is not available based on manifest and dut's model.
420 """
421 model = self.servo_model or self._dut_host_info.model
422 if not model:
423 raise hosts.AutoservRepairError(
424 'Could not determine DUT\'s model.',
425 'model infomation unknown')
426
427 if not fw_dst:
428 fw_dst = '/tmp/firmware_image/%s' % self.servo_port
429 # Cleanup and re-create dst path to have a fresh start.
430 self.run('rm -rf %s' % fw_dst)
431 self.run('mkdir -p %s' % fw_dst)
432
433 manifest = json.loads(self._extract_firmware_image_from_usbkey(fw_dst))
Garry Wang50b56c12020-09-24 17:26:52 -0700434 # For models that have packed $MODEL_signed variant, we want use the
435 # 'signed' variant once we get DVT devices, so try to read manifest
436 # from $MODEL_signed first.
437 build = manifest.get('%s_signed' % model) or manifest.get(model)
438 if not build:
Garry Wang2b5eef92020-08-21 16:23:35 -0700439 raise hosts.AutoservRepairError('Could not find firmware manifest'
440 ' for model:%s' % model, 'model manifest not found')
441 try:
Garry Wang50b56c12020-09-24 17:26:52 -0700442 ec_image = os.path.join(fw_dst, build['ec']['image'])
Garry Wang2b5eef92020-08-21 16:23:35 -0700443 except KeyError:
444 ec_image = None
445 try:
Garry Wang50b56c12020-09-24 17:26:52 -0700446 bios_image = os.path.join(fw_dst, build['host']['image'])
Garry Wang2b5eef92020-08-21 16:23:35 -0700447 except KeyError:
448 bios_image = None
449 if not ec_image and not bios_image:
450 raise hosts.AutoservRepairError('Could not find any firmware image'
451 ' for model:%s' % model, 'cannot find firmware image')
452 return ec_image, bios_image
Garry Wang7b0e1b72020-03-25 19:08:59 -0700453
Garry Wang4b980202020-09-24 17:00:17 -0700454 def flash_ap_firmware_via_servo(self, image):
455 """Flash AP firmware by use a provided image.
456
457 This is will be a short term enhanment for infra repair use, it use
458 'futility update' which will automatically determine various parameters
459 needed for flashrom, and will preserve the GBB, VPD, and HWID for
460 AP firmware update.
461 @TODO(xianuowang@) Remove this method once b/148403277 implemented.
462
463 @param image: the firmware image path on servohost.
464 """
465 cmd = 'futility update -i %s --servo_port=%s'
466 self.run(cmd % (image, self.servo_port), timeout=900)
467
Garry Wang70e5d062020-04-03 18:01:05 -0700468 def _probe_and_validate_usb_dev(self):
469 """This method probe the usb dev path by talking to servo, and then
470 validate the dev path is valid block device to servohost.
471 Possible output:
472 1. Encounter error during probe usb dev, returns empty string.
473 2. probe usb dev completed without error but cannot find usb dev,
474 raise AutoservRepairError.
475 3. probe usb dev find a usb dev path, but failed validation in this
476 method, raise AutoservRepairError.
Garry Wang7b0e1b72020-03-25 19:08:59 -0700477
Garry Wang70e5d062020-04-03 18:01:05 -0700478 @returns: A string of usb dev path(e.g. '/dev/sdb'), or empty string
479 if unexpected error occurred during probe.
480 @raises: AutoservRepairError if servo couldn't probe the usb dev path
481 (servo.probe_host_usb_dev() returns empty string), or the dev path is
482 not valid block device to servohost.
Garry Wang7b0e1b72020-03-25 19:08:59 -0700483 """
484 logging.info('Validating image usbkey on servo.')
Garry Wang7b0e1b72020-03-25 19:08:59 -0700485 try:
Garry Wang70e5d062020-04-03 18:01:05 -0700486 usb_dev = self._servo.probe_host_usb_dev()
Garry Wang7b0e1b72020-03-25 19:08:59 -0700487 except Exception as e:
488 # We don't want any unexpected or transient servo communicating
489 # failure block usb repair, so capture all errors here.
490 logging.error(e, exc_info=True)
491 logging.error('Unexpected error occurred on get usbkey dev path,'
492 ' skipping usbkey validation.')
493 return ''
494
Garry Wang70e5d062020-04-03 18:01:05 -0700495 if usb_dev:
496 # probe_host_usb_dev() sometimes return stale record,
497 # so we need to make sure the path exists in fdisk.
Otabek Kasimov77bff672020-10-08 15:52:03 -0700498 validate_cmd = 'fdisk -l %s' % usb_dev
Garry Wang11441182020-06-16 18:34:14 -0700499 try:
Otabek Kasimov77bff672020-10-08 15:52:03 -0700500 resp = self.run(validate_cmd, ignore_status=True, timeout=30)
Garry Wang11441182020-06-16 18:34:14 -0700501 if resp.exit_status == 0:
502 return usb_dev
Garry Wang11441182020-06-16 18:34:14 -0700503 logging.error('%s is reported from "image_usbkey_dev" control'
504 ' but not detected by fdisk!', usb_dev)
505 except error.AutoservRunError as e:
506 if 'Timeout encountered' in str(e):
507 logging.warning('Timeout encountered during fdisk run,'
508 ' skipping usbkey validation.')
509 return ''
510 raise
Garry Wang70e5d062020-04-03 18:01:05 -0700511
512 raise hosts.AutoservRepairError(
513 'No usbkey detected on servo, the usbkey may be either missing'
514 ' or broken. Please replace usbkey on the servo and retry.',
515 'missing usbkey')
516
Otabek Kasimov4ea636e2020-04-14 23:35:06 -0700517 def is_ec_supported(self):
Garry Wang9b8f2342020-04-17 16:34:09 -0700518 """Check if ec is supported on the servo_board"""
Otabek Kasimov4ea636e2020-04-14 23:35:06 -0700519 if self.servo_board:
520 try:
521 frm_config = config.Config(self.servo_board, self.servo_model)
522 return frm_config.chrome_ec
523 except Exception as e:
524 logging.error('Unexpected error when read from firmware'
525 ' configs; %s', str(e))
526 return False
527
Garry Wang70e5d062020-04-03 18:01:05 -0700528 def validate_image_usbkey(self):
529 """This method first validate if there is a recover usbkey on servo
530 that accessible to servohost, and second check if a ChromeOS image is
531 already on the usb drive and return the image_name so we can avoid
532 unnecessary download and flash to the recover usbkey on servo.
533
534 Please note that, there is special error handling logic here:
535 1. If unexpected error happens, we return empty string. So repair
536 actions will not get blocked.
537 2. If no working usbkey present on servo, but no errors, we'll raise
538 AutoservRepairError here.
539
540 @returns: image_name on the usbkey, e.g. nami-release/R82.10138.0.0,
541 or empty string if no test image detected, or unexpected
542 error occurred.
543 @raises: AutoservRepairError if the usbkey is not detected on servo.
544 """
545 usb_dev = self._probe_and_validate_usb_dev()
546 if usb_dev:
547 return self.get_image_name_from_usbkey(usb_dev)
548 else:
549 return ''
Garry Wang7b0e1b72020-03-25 19:08:59 -0700550
Richard Barnette1edbb162016-11-01 11:47:50 -0700551 def repair(self, silent=False):
552 """Attempt to repair servo host.
553
554 @param silent If true, suppress logging in `status.log`.
555 """
Richard Barnetteabbdc252018-07-26 16:57:42 -0700556 message = 'Beginning repair for servo host %s port %s serial %s'
557 message %= (self.hostname, self.servo_port, self.servo_serial)
558 self.record('INFO', None, None, message)
Richard Barnette9a26ad62016-06-10 12:03:08 -0700559 try:
Richard Barnette1edbb162016-11-01 11:47:50 -0700560 self._repair_strategy.repair(self, silent)
Garry Wang11b5e872020-03-11 15:14:08 -0700561 self._servo_state = servo_constants.SERVO_STATE_WORKING
562 self.record('INFO', None, None,
563 'ServoHost repair set servo_state as WORKING')
Garry Wang464ff1e2019-07-18 17:20:34 -0700564 # If target is a labstation then try to withdraw any existing
565 # reboot request created by this servo because it passed repair.
566 if self.is_labstation():
567 self.withdraw_reboot_request()
Garry Wang63b8c382020-03-11 22:28:40 -0700568 except Exception as e:
Otabek Kasimov120b6fa2020-07-03 00:15:27 -0700569 if not self.is_localhost():
Otabek Kasimovc6f30412020-06-30 20:08:12 -0700570 self._servo_state = self.determine_servo_state()
571 self.record('INFO', None, None,
572 'ServoHost repair set servo_state as %s'
573 % self._servo_state)
Garry Wang63b8c382020-03-11 22:28:40 -0700574 if self._is_critical_error(e):
575 self.disconnect_servo()
576 self.stop_servod()
577 raise
578
Garry Wang63b8c382020-03-11 22:28:40 -0700579 def _is_critical_error(self, error):
580 if (isinstance(error, hosts.AutoservVerifyDependencyError)
581 and not error.is_critical()):
582 logging.warning('Non-critical verify failure(s) detected during'
583 ' verify/repair servo, servo connection will'
Evan Benn2c41c262020-10-28 11:34:27 +1100584 ' still be up but may not be fully functional.'
585 ' Some repair actions and servo dependent'
Garry Wang63b8c382020-03-11 22:28:40 -0700586 ' tests may not run.')
587 return False
Evan Benn2c41c262020-10-28 11:34:27 +1100588 logging.info(
589 'Critical verify failure(s) detected during repair/verify '
590 'servo. Disconnecting servo and running `stop servod`, all'
591 ' repair actions and tests that depends on servo will not '
592 'run.')
Garry Wang63b8c382020-03-11 22:28:40 -0700593 return True
Fang Deng5d518f42013-08-02 14:04:32 -0700594
Dan Shi4d478522014-02-14 13:46:32 -0800595 def get_servo(self):
596 """Get the cached servo.Servo object.
Fang Deng5d518f42013-08-02 14:04:32 -0700597
Dan Shi4d478522014-02-14 13:46:32 -0800598 @return: a servo.Servo object.
Dana Goyette353d1d92019-06-27 10:43:59 -0700599 @rtype: autotest_lib.server.cros.servo.servo.Servo
Fang Deng5d518f42013-08-02 14:04:32 -0700600 """
Dan Shi4d478522014-02-14 13:46:32 -0800601 return self._servo
602
Garry Wang79e9af62019-06-12 15:19:19 -0700603 def request_reboot(self):
604 """Request servohost to be rebooted when it's safe to by touch a file.
605 """
606 logging.debug('Request to reboot servohost %s has been created by '
Garry Wang464ff1e2019-07-18 17:20:34 -0700607 'servo with port # %s', self.hostname, self.servo_port)
Garry Wang79e9af62019-06-12 15:19:19 -0700608 self.run('touch %s' % self._reboot_file, ignore_status=True)
609
Garry Wang464ff1e2019-07-18 17:20:34 -0700610 def withdraw_reboot_request(self):
611 """Withdraw a servohost reboot request if exists by remove the flag
612 file.
613 """
614 logging.debug('Withdrawing request to reboot servohost %s that created'
615 ' by servo with port # %s if exists.',
616 self.hostname, self.servo_port)
617 self.run('rm -f %s' % self._reboot_file, ignore_status=True)
618
Garry Wangc1288cf2019-12-17 14:58:00 -0800619 def start_servod(self, quick_startup=False):
620 """Start the servod process on servohost.
621 """
Garry Wang2ac15ee2019-12-30 19:03:02 -0800622 # Skip if running on the localhost.(crbug.com/1038168)
623 if self.is_localhost():
624 logging.debug("Servohost is a localhost, skipping start servod.")
625 return
626
627 cmd = 'start servod'
Garry Wangc1288cf2019-12-17 14:58:00 -0800628 if self.servo_board:
Garry Wang2ac15ee2019-12-30 19:03:02 -0800629 cmd += ' BOARD=%s' % self.servo_board
Garry Wangc1288cf2019-12-17 14:58:00 -0800630 if self.servo_model:
631 cmd += ' MODEL=%s' % self.servo_model
Garry Wangc1288cf2019-12-17 14:58:00 -0800632 else:
Garry Wang2ac15ee2019-12-30 19:03:02 -0800633 logging.warning('Board for DUT is unknown; starting servod'
634 ' assuming a pre-configured board.')
635
636 cmd += ' PORT=%d' % self.servo_port
637 if self.servo_serial:
638 cmd += ' SERIAL=%s' % self.servo_serial
Garry Wangd7367482020-02-27 13:52:40 -0800639
Garry Wangcb06f3b2020-10-08 20:56:21 -0700640 # Start servod with dual_v4 based on servo_setup.
641 if self.servo_setup == servo_constants.SERVO_SETUP_VALUE_DUAL_V4:
642 cmd += ' DUAL_V4=1'
Garry Wangd7367482020-02-27 13:52:40 -0800643
Garry Wangcb06f3b2020-10-08 20:56:21 -0700644 # Start servod with CONFIG=cr50.xml which required for some pools.
645 if self._require_cr50_servod_config():
646 cmd += ' CONFIG=cr50.xml'
Garry Wangb5cee3e2020-09-16 14:58:13 -0700647
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800648 # Remove the symbolic links from the logs. This helps ensure that
649 # a failed servod instantiation does not cause us to grab old logs
650 # by mistake.
651 self.remove_latest_log_symlinks()
Garry Wangcdd27b22020-01-13 14:59:11 -0800652 self.run(cmd, timeout=60)
Garry Wangc1288cf2019-12-17 14:58:00 -0800653
654 # There's a lag between when `start servod` completes and when
655 # the _ServodConnectionVerifier trigger can actually succeed.
656 # The call to time.sleep() below gives time to make sure that
657 # the trigger won't fail after we return.
658
659 # Normally servod on servo_v3 and labstation take ~10 seconds to ready,
660 # But in the rare case all servo on a labstation are in heavy use they
661 # may take ~30 seconds. So the timeout value will double these value,
662 # and we'll try quick start up when first time initialize servohost,
663 # and use standard start up timeout in repair.
664 if quick_startup:
Garry Wang11b5e872020-03-11 15:14:08 -0700665 timeout = servo_constants.SERVOD_QUICK_STARTUP_TIMEOUT
Garry Wangc1288cf2019-12-17 14:58:00 -0800666 else:
Garry Wang11b5e872020-03-11 15:14:08 -0700667 timeout = servo_constants.SERVOD_STARTUP_TIMEOUT
Garry Wangc1288cf2019-12-17 14:58:00 -0800668 logging.debug('Wait %s seconds for servod process fully up.', timeout)
669 time.sleep(timeout)
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700670 # Cache the initial instance timestamp to check against servod restarts
671 self._initial_instance_ts = self.get_instance_logs_ts()
Garry Wangc1288cf2019-12-17 14:58:00 -0800672
Garry Wangc1288cf2019-12-17 14:58:00 -0800673 def stop_servod(self):
674 """Stop the servod process on servohost.
675 """
Garry Wang2ac15ee2019-12-30 19:03:02 -0800676 # Skip if running on the localhost.(crbug.com/1038168)
677 if self.is_localhost():
678 logging.debug("Servohost is a localhost, skipping stop servod.")
679 return
680
Garry Wangc1288cf2019-12-17 14:58:00 -0800681 logging.debug('Stopping servod on port %s', self.servo_port)
Garry Wangcdd27b22020-01-13 14:59:11 -0800682 self.run('stop servod PORT=%d' % self.servo_port,
683 timeout=60, ignore_status=True)
Garry Wangc1288cf2019-12-17 14:58:00 -0800684 logging.debug('Wait %s seconds for servod process fully teardown.',
Garry Wang11b5e872020-03-11 15:14:08 -0700685 servo_constants.SERVOD_TEARDOWN_TIMEOUT)
686 time.sleep(servo_constants.SERVOD_TEARDOWN_TIMEOUT)
Garry Wangc1288cf2019-12-17 14:58:00 -0800687
Garry Wangc1288cf2019-12-17 14:58:00 -0800688 def restart_servod(self, quick_startup=False):
689 """Restart the servod process on servohost.
690 """
691 self.stop_servod()
692 self.start_servod(quick_startup)
693
Garry Wangffbd2162020-04-17 16:13:48 -0700694 def _process_servodtool_error(self, response):
695 """Helper function to handle non-zero servodtool response.
696 """
697 if re.search(servo_constants.ERROR_MESSAGE_USB_HUB_NOT_COMPATIBLE,
Garry Wangad245002020-05-15 15:20:23 -0700698 response.stdout):
Garry Wangffbd2162020-04-17 16:13:48 -0700699 logging.error('The servo is not plugged on a usb hub that supports'
700 ' power-cycle!')
Garry Wang000c6c02020-05-11 21:27:23 -0700701 # change the flag so we can update this label in later process.
702 self.smart_usbhub = False
Garry Wangffbd2162020-04-17 16:13:48 -0700703 return
704
705 if re.search(servo_constants.ERROR_MESSAGE_DEVICE_NOT_FOUND %
706 self.servo_serial, response.stdout):
707 logging.error('No servo with serial %s found!', self.servo_serial)
708 return
709
710 logging.error('Unexpected error occurred from usbhub control, please'
711 ' file a bug and inform chrome-fleet-software@ team!')
712
Garry Wangffbd2162020-04-17 16:13:48 -0700713 def _get_servo_usb_devnum(self):
714 """Helper function to collect current usb devnum of servo.
715 """
Otabek Kasimov09192682020-06-01 18:17:44 -0700716 # TODO remove try-except when fix crbug.com/1087964
717 try:
718 cmd = 'servodtool device -s %s usb-path' % self.servo_serial
719 resp = self.run(cmd, ignore_status=True, timeout=30)
720 except Exception as e:
721 # Here we catch only timeout errors.
722 # Other errors is filtered by ignore_status=True
723 logging.debug('Attempt to get servo usb-path failed due to '
724 'timeout; %s', e)
725 return ''
726
Garry Wangffbd2162020-04-17 16:13:48 -0700727 if resp.exit_status != 0:
728 self._process_servodtool_error(resp)
729 return ''
730 usb_path = resp.stdout.strip()
731 logging.info('Usb path of servo %s is %s', self.servo_serial, usb_path)
732
733 resp = self.run('cat %s/devnum' % usb_path,
734 ignore_status=True)
735 if resp.exit_status != 0:
736 self._process_servodtool_error(resp)
737 return ''
738 return resp.stdout.strip()
739
Garry Wang358aad42020-08-02 20:56:04 -0700740 def reboot_servo_v3_on_need(self):
741 """Check and reboot servo_v3 based on below conditions.
742 1. If there is an update pending on reboot.
743 2. Servo_v3 has been up for more than 96 hours.
744 """
745 if self.get_board() != 'beaglebone_servo':
746 logging.info('Servo reboot is only applicable for servo V3.')
Otabek Kasimove6df8102020-07-21 20:15:25 -0700747 return
748
Garry Wang358aad42020-08-02 20:56:04 -0700749 update_pending_reboot = (self._check_update_status() ==
750 self.UPDATE_STATE.PENDING_REBOOT)
751 uptime_hours = float(self.check_uptime())/3600
752 logging.info('Uptime of servo_v3: %s hour(s)', uptime_hours)
753 long_up_time = uptime_hours > 96
754
755 # Skip reboot if neither condition are met.
756 if not (update_pending_reboot or long_up_time):
Otabek Kasimove6df8102020-07-21 20:15:25 -0700757 return
758
Garry Wang358aad42020-08-02 20:56:04 -0700759 if update_pending_reboot:
760 message = 'Starting reboot servo_v3 because an update is pending.'
761 reboot_method = self._post_update_reboot
762 elif long_up_time:
763 message = 'Starting reboot servo_v3 because uptime > 96 hours.'
764 reboot_method = self._servo_host_reboot
765 self.record('INFO', None, None, message)
766 logging.info(message)
Otabek Kasimove6df8102020-07-21 20:15:25 -0700767 try:
Garry Wang358aad42020-08-02 20:56:04 -0700768 reboot_method()
Otabek Kasimove6df8102020-07-21 20:15:25 -0700769 message = 'Servo_v3 reboot completed successfully.'
770 except Exception as e:
771 logging.debug("Fail to reboot servo_v3; %s", e)
772 message = ('Servo_v3 reboot failed, please check debug log '
773 'for details.')
774 logging.info(message)
775 self.record('INFO', None, None, message)
Garry Wangffbd2162020-04-17 16:13:48 -0700776
777 def _reset_servo(self):
778 logging.info('Resetting servo through smart usbhub.')
Otabek Kasimov09192682020-06-01 18:17:44 -0700779 # TODO remove try-except when fix crbug.com/1087964
780 try:
781 resp = self.run('servodtool device -s %s power-cycle' %
782 self.servo_serial, ignore_status=True,
783 timeout=30)
784 if resp.exit_status != 0:
785 self._process_servodtool_error(resp)
786 return False
787 except Exception as e:
788 # Here we catch only timeout errors.
789 # Other errors is filtered by ignore_status=True
790 logging.debug('Attempt to reset servo failed due to timeout;'
791 ' %s', e)
Garry Wangffbd2162020-04-17 16:13:48 -0700792 return False
793
794 logging.debug('Wait %s seconds for servo to come back from reset.',
795 servo_constants.SERVO_RESET_TIMEOUT_SECONDS)
796 time.sleep(servo_constants.SERVO_RESET_TIMEOUT_SECONDS)
Garry Wang000c6c02020-05-11 21:27:23 -0700797 # change the flag so we can update this label in later process.
798 self.smart_usbhub = True
Garry Wangffbd2162020-04-17 16:13:48 -0700799 return True
800
Garry Wangffbd2162020-04-17 16:13:48 -0700801 def reset_servo(self):
802 """Reset(power-cycle) the servo via smart usbhub.
803 """
804 if not self.is_labstation():
805 logging.info('Servo reset is not applicable to servo_v3.')
806 return
807
808 pre_reset_devnum = self._get_servo_usb_devnum()
809 logging.info('Servo usb devnum before reset: %s', pre_reset_devnum)
810 result = self._reset_servo()
811 if not result:
Garry Wangfd5c8b62020-06-08 15:36:54 -0700812 message = ('Failed to reset servo with serial: %s. (Please ignore'
813 ' this error if the DUT is not connected to a smart'
814 ' usbhub).' % self.servo_serial)
Garry Wangffbd2162020-04-17 16:13:48 -0700815 logging.warning(message)
816 self.record('INFO', None, None, message)
817 return
818
819 post_reset_devnum = self._get_servo_usb_devnum()
820 logging.info('Servo usb devnum after reset: %s', post_reset_devnum)
821 if not (pre_reset_devnum and post_reset_devnum):
822 message = ('Servo reset completed but unable to verify'
823 ' devnum change!')
824 elif pre_reset_devnum != post_reset_devnum:
825 message = ('Reset servo with serial %s completed successfully!'
826 % self.servo_serial)
827 else:
828 message = 'Servo reset completed but devnum is still not changed!'
829 logging.info(message)
830 self.record('INFO', None, None, message)
831
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800832 def _extract_compressed_logs(self, logdir, relevant_files):
833 """Decompress servod logs in |logdir|.
834
835 @param logdir: directory containing compressed servod logs.
836 @param relevant_files: list of files in |logdir| to consider.
837
838 @returns: tuple, (tarfiles, files) where
839 tarfiles: list of the compressed filenames that have been
840 extracted and deleted
841 files: list of the uncompressed files that were generated
842 """
843 # For all tar-files, first extract them to the directory, and
844 # then let the common flow handle them.
845 tarfiles = [cf for cf in relevant_files if
846 cf.endswith(self.COMPRESSION_SUFFIX)]
847 files = []
848 for f in tarfiles:
849 norm_name = os.path.basename(f)[:-len(self.COMPRESSION_SUFFIX)]
850 with tarfile.open(f) as tf:
851 # Each tarfile has only one member, as
852 # that's the compressed log.
853 member = tf.members[0]
854 # Manipulate so that it only extracts the basename, and not
855 # the directories etc.
856 member.name = norm_name
857 files.append(os.path.join(logdir, member.name))
858 tf.extract(member, logdir)
859 # File has been extracted: remove the compressed file.
860 os.remove(f)
861 return tarfiles, files
862
863 def _extract_mcu_logs(self, log_subdir):
864 """Extract MCU (EC, Cr50, etc) console output from servod debug logs.
865
866 Using the MCU_EXTRACTOR regex (above) extract and split out MCU console
867 lines from the logs to generate invidiual console logs e.g. after
868 this method, you can find an ec.txt and servo_v4.txt in |log_dir| if
869 those MCUs had any console input/output.
870
871 @param log_subdir: directory with log.DEBUG.txt main servod debug logs.
872 """
873 # Extract the MCU for each one. The MCU logs are only in the .DEBUG
874 # files
875 mcu_lines_file = os.path.join(log_subdir, 'log.DEBUG.txt')
876 if not os.path.exists(mcu_lines_file):
877 logging.info('No DEBUG logs found to extract MCU logs from.')
878 return
879 mcu_files = {}
880 mcu_file_template = '%s.txt'
881 with open(mcu_lines_file, 'r') as f:
882 for line in f:
883 match = self.MCU_EXTRACTOR.match(line)
884 if match:
885 mcu = match.group(self.MCU_GROUP).lower()
886 line = match.group(self.LINE_GROUP)
887 if mcu not in mcu_files:
888 mcu_file = os.path.join(log_subdir,
889 mcu_file_template % mcu)
890 mcu_files[mcu] = open(mcu_file, 'a')
891 fd = mcu_files[mcu]
892 fd.write(line + '\n')
893 for f in mcu_files:
894 mcu_files[f].close()
895
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800896 def remove_latest_log_symlinks(self):
897 """Remove the conveninence symlinks 'latest' servod logs."""
898 symlink_wildcard = '%s/latest*' % self.remote_log_dir
899 cmd = 'rm ' + symlink_wildcard
900 self.run(cmd, stderr_tee=None, ignore_status=True)
901
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700902 def probe_servod_restart(self, instance_ts, outdir):
903 """Grab servod logs from previous instances if part of this session.
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800904
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700905 If since the last time this host called start_servod() servod crashed
906 and restarted, this helper finds those logs as well, and stores them
907 with the |OLD_LOG_SUFFIX| to investigate if necessary.
Prasad Vuppalapu5bd9da12020-03-31 01:46:47 +0000908
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700909 It also issues a panicinfo command to servo devices after the restart
910 to try and collect reboot information for debugging.
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800911
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700912 @param instance_ts: the log timestamp that the current instance uses
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800913 @param outdir: directory to create a subdirectory into to place the
914 servod logs into.
915 """
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700916 if self._initial_instance_ts is None:
917 logging.info('No log timestamp grabbed successfully on servod '
918 'startup. Cannot check device restarts. Ignoring.')
919 return
920 if instance_ts == self._initial_instance_ts:
921 logging.debug('Servod appears to have run without restarting')
922 return
923 # Servod seems to have restarted (at least once). |_initial_instance_ts|
924 # is the first timestamp, and instance_ts is the current timestamp. Find
925 # all timestamps in between them, and grab the logs for each.
926 tss = self._find_instance_timestamps_between(self._initial_instance_ts,
927 instance_ts)
928 logging.info('Servod has restarted %d times between the start and the '
929 'end of this servo_host.', len(tss))
930 logging.info('This might be an issue. Will extract all logs from each '
931 'instance.')
932 logging.info('Logs that are not the currently running (about to turn '
933 'down) instance are maked with a .%s in their folder.',
934 self.OLD_LOG_SUFFIX)
935 for ts in tss:
936 self.get_instance_logs(ts, outdir, old=True)
937 # Lastly, servod has restarted due to a potential issue. Try to get
938 # panic information from servo micro and servo v4 for the current logs.
939 # This can only happen if the |_servo| attribute is initialized.
940 if self._servo:
941 for mcu in ['servo_micro', 'servo_v4']:
942 ctrl = '%s_uart_cmd' % mcu
943 if self._servo.has_control(ctrl):
944 logging.info('Trying to retrieve %r panicinfo into logs',
945 mcu)
946 try:
947 self._servo.set_nocheck(ctrl, 'panicinfo')
948 except error.TestFail as e:
949 logging.error('Failed to generate panicinfo for %r '
950 'logs. %s', mcu, str(e))
951
952 def _find_instance_timestamps_between(self, start_ts, end_ts):
953 """Find all log timestamps between [start_ts, end_ts).
954
955 @param start_ts: str, earliest log timestamp of interest
956 @param end_ts: str, latest log timestamp of interest
957
958 @returns: list, all timestamps between start_ts and end_ts, end_ts
959 exclusive, on the servo_host. An empty list on errors
960 """
961 # Simply get all timestamp, and then sort and remove
962 cmd = 'ls %s' % self.remote_log_dir
963 res = self.run(cmd, stderr_tee=None, ignore_status=True)
964 if res.exit_status != 0:
965 # Here we failed to find anything.
966 logging.info('Failed to find remote servod logs. Ignoring.')
967 return []
968 logfiles = res.stdout.strip().split()
969 timestamps = set()
970 for logfile in logfiles:
971 ts_match = self.TS_EXTRACTOR.match(logfile)
972 if not ts_match:
973 # Simply ignore files that fail the check. It might be the
974 # 'latest' symlinks or random files.
975 continue
976 timestamps.add(ts_match.group(self.TS_GROUP))
977 # At this point we have all unique timestamps.
978 timestamps = sorted(timestamps)
979 for ts in [start_ts, end_ts]:
980 if ts not in timestamps:
981 logging.error('Timestamp %r not in servod logs. Cannot query '
982 'for timestamps in between %r and %r', ts,
983 start_ts, end_ts)
984 return []
985 return timestamps[timestamps.index(start_ts):timestamps.index(end_ts)]
986
987 def get_instance_logs_ts(self):
988 """Retrieve the currently running servod instance's log timestamp
989
990 @returns: str, timestamp for current instance, or None on failure
991 """
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800992 # First, extract the timestamp. This cmd gives the real filename of
993 # the latest aka current log file.
994 cmd = ('if [ -f %(dir)s/latest.DEBUG ];'
995 'then realpath %(dir)s/latest.DEBUG;'
996 'elif [ -f %(dir)s/latest ];'
997 'then realpath %(dir)s/latest;'
998 'else exit %(code)d;'
999 'fi' % {'dir': self.remote_log_dir,
1000 'code': self.NO_SYMLINKS_CODE})
1001 res = self.run(cmd, stderr_tee=None, ignore_status=True)
1002 if res.exit_status != 0:
1003 if res.exit_status == self.NO_SYMLINKS_CODE:
1004 logging.warning('servod log latest symlinks not found. '
1005 'This is likely due to an error starting up '
1006 'servod. Ignoring..')
1007 else:
1008 logging.warning('Failed to find servod logs on servo host.')
1009 logging.warning(res.stderr.strip())
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001010 return None
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001011 fname = os.path.basename(res.stdout.strip())
1012 # From the fname, ought to extract the timestamp using the TS_EXTRACTOR
Ruben Rodriguez Buchillone9aa2b02020-03-04 12:14:28 -08001013 ts_match = self.TS_EXTRACTOR.match(fname)
1014 if not ts_match:
1015 logging.warning('Failed to extract timestamp from servod log file '
1016 '%r. Skipping. The servo host is using outdated '
1017 'servod logging and needs to be updated.', fname)
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001018 return None
1019 return ts_match.group(self.TS_GROUP)
1020
1021 def get_instance_logs(self, instance_ts, outdir, old=False):
1022 """Collect all logs with |instance_ts| and dump into a dir in |outdir|
1023
1024 This method first collects all logs on the servo_host side pertaining
1025 to this servod instance (port, instatiation). It glues them together
1026 into combined log.[level].txt files and extracts all available MCU
1027 console I/O from the logs into individual files e.g. servo_v4.txt
1028
1029 All the output can be found in a directory inside |outdir| that
1030 this generates based on |LOG_DIR|, the servod port, and the instance
1031 timestamp on the servo_host side.
1032
1033 @param instance_ts: log timestamp to grab logfiles for
1034 @param outdir: directory to create a subdirectory into to place the
1035 servod logs into.
1036 @param old: bool, whether to append |OLD_LOG_SUFFIX| to output dir
1037 """
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001038 # Create the local results log dir.
1039 log_dir = os.path.join(outdir, '%s_%s.%s' % (self.LOG_DIR,
1040 str(self.servo_port),
1041 instance_ts))
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001042 if old:
Garry Wang22f2e842020-09-09 20:19:19 -07001043 log_dir = '%s.%s' % (log_dir, self.OLD_LOG_SUFFIX)
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001044 logging.info('Saving servod logs to %r.', log_dir)
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001045 os.mkdir(log_dir)
1046 # Now, get all files with that timestamp.
1047 cmd = 'find %s -maxdepth 1 -name "log.%s*"' % (self.remote_log_dir,
1048 instance_ts)
1049 res = self.run(cmd, stderr_tee=None, ignore_status=True)
1050 files = res.stdout.strip().split()
1051 try:
1052 self.get_file(files, log_dir, try_rsync=False)
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001053 if not os.listdir(log_dir):
1054 logging.info('No servod logs retrieved. Ignoring, and removing '
1055 '%r again.', log_dir)
1056 os.rmdir(log_dir)
1057 return
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001058 except error.AutoservRunError as e:
1059 result = e.result_obj
1060 if result.exit_status != 0:
1061 stderr = result.stderr.strip()
1062 logging.warning("Couldn't retrieve servod logs. Ignoring: %s",
1063 stderr or '\n%s' % result)
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001064 # Remove the log_dir as nothing was added to it.
1065 os.rmdir(log_dir)
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001066 return
1067 local_files = [os.path.join(log_dir, f) for f in os.listdir(log_dir)]
1068 # TODO(crrev.com/c/1793030): remove no-level case once CL is pushed
1069 for level_name in ('DEBUG', 'INFO', 'WARNING', ''):
1070 # Create the joint files for each loglevel. i.e log.DEBUG
1071 joint_file = self.JOINT_LOG_PREFIX
1072 if level_name:
1073 joint_file = '%s.%s' % (self.JOINT_LOG_PREFIX, level_name)
1074 # This helps with some online tools to avoid complaints about an
1075 # unknown filetype.
1076 joint_file = joint_file + '.txt'
1077 joint_path = os.path.join(log_dir, joint_file)
1078 files = [f for f in local_files if level_name in f]
1079 if not files:
1080 # TODO(crrev.com/c/1793030): remove no-level case once CL
1081 # is pushed
1082 continue
1083 # Extract compressed logs if any.
1084 compressed, extracted = self._extract_compressed_logs(log_dir,
1085 files)
1086 files = list(set(files) - set(compressed))
1087 files.extend(extracted)
1088 # Need to sort. As they all share the same timestamp, and
1089 # loglevel, the index itself is sufficient. The highest index
1090 # is the oldest file, therefore we need a descending sort.
1091 def sortkey(f, level=level_name):
1092 """Custom sortkey to sort based on rotation number int."""
1093 if f.endswith(level_name): return 0
1094 return int(f.split('.')[-1])
1095
1096 files.sort(reverse=True, key=sortkey)
1097 # Just rename the first file rather than building from scratch.
1098 os.rename(files[0], joint_path)
1099 with open(joint_path, 'a') as joint_f:
1100 for logfile in files[1:]:
1101 # Transfer the file to the joint file line by line.
1102 with open(logfile, 'r') as log_f:
1103 for line in log_f:
1104 joint_f.write(line)
1105 # File has been written over. Delete safely.
1106 os.remove(logfile)
1107 # Need to remove all files form |local_files| so we don't
1108 # analyze them again.
1109 local_files = list(set(local_files) - set(files) - set(compressed))
1110 # Lastly, extract MCU logs from the joint logs.
1111 self._extract_mcu_logs(log_dir)
1112
Garry Wang79e9af62019-06-12 15:19:19 -07001113 def _lock(self):
1114 """lock servohost by touching a file.
1115 """
1116 logging.debug('Locking servohost %s by touching %s file',
1117 self.hostname, self._lock_file)
1118 self.run('touch %s' % self._lock_file, ignore_status=True)
Garry Wang7c00b0f2019-06-25 17:28:17 -07001119 self._is_locked = True
Garry Wang79e9af62019-06-12 15:19:19 -07001120
Garry Wang79e9af62019-06-12 15:19:19 -07001121 def _unlock(self):
1122 """Unlock servohost by removing the lock file.
1123 """
1124 logging.debug('Unlocking servohost by removing %s file',
1125 self._lock_file)
1126 self.run('rm %s' % self._lock_file, ignore_status=True)
Garry Wang7c00b0f2019-06-25 17:28:17 -07001127 self._is_locked = False
Garry Wang79e9af62019-06-12 15:19:19 -07001128
Congbin Guoa1f9cba2018-07-03 11:36:59 -07001129 def close(self):
Congbin Guofc3b8962019-03-22 17:38:46 -07001130 """Close the associated servo and the host object."""
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001131 # NOTE: throughout this method there are multiple attempts to catch
1132 # all errors. This is WAI as log grabbing should not fail tests.
1133 # However, the goal is to catch and handle/process all errors, thus
1134 # we print the traceback and ask for a bug.
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001135 if self._closed:
1136 logging.debug('ServoHost is already closed.')
1137 return
Garry Wang22f2e842020-09-09 20:19:19 -07001138
1139 # Only attempt ssh related actions if servohost is sshable. We call
1140 # check_cached_up_status() first because it's lightweighted and return
1141 # much faster in the case servohost is down, however, we still want
1142 # to call is_up() later since check_cached_up_status() is ping based check
1143 # and not guarantee the servohost is sshable.
1144 servo_host_ready = self.check_cached_up_status() and self.is_up()
1145
1146 if servo_host_ready:
1147 instance_ts = self.get_instance_logs_ts()
1148 else:
1149 logging.info('Servohost is down, will skip servod log collecting.')
1150 instance_ts = None
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001151 # TODO(crbug.com/1011516): once enabled, remove the check against
1152 # localhost and instead check against log-rotiation enablement.
1153 logs_available = (instance_ts is not None and
1154 self.job and
1155 not self.is_localhost())
1156 if logs_available:
1157 # Probe whether there was a servod restart, and grab those old
1158 # logs as well.
1159 try:
1160 self.probe_servod_restart(instance_ts, self.job.resultdir)
1161 except (error.AutoservRunError, error.TestFail) as e:
1162 logging.info('Failed to grab servo logs due to: %s. '
1163 'This error is forgiven.', str(e))
1164 except Exception as e:
1165 logging.error('Unexpected error probing for old logs. %s. '
1166 'Forgiven. Please file a bug and fix or catch '
1167 'in log probing function', str(e),
1168 exc_info=True)
Congbin Guoa1f9cba2018-07-03 11:36:59 -07001169 if self._servo:
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001170 outdir = None if not self.job else self.job.resultdir
Congbin Guo2e5e2a22018-07-27 10:32:48 -07001171 # In some cases when we run as lab-tools, the job object is None.
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001172 self._servo.close(outdir)
1173
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001174 if logs_available:
1175 # Grab current (not old like above) logs after the servo instance
1176 # was closed out.
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001177 try:
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001178 self.get_instance_logs(instance_ts, self.job.resultdir)
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001179 except error.AutoservRunError as e:
1180 logging.info('Failed to grab servo logs due to: %s. '
1181 'This error is forgiven.', str(e))
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001182 except Exception as e:
1183 logging.error('Unexpected error grabbing servod logs. %s. '
1184 'Forgiven. Please file a bug and fix or catch '
1185 'in log grabbing function', str(e), exc_info=True)
Congbin Guoa1f9cba2018-07-03 11:36:59 -07001186
Garry Wang22f2e842020-09-09 20:19:19 -07001187 if self._is_locked and servo_host_ready:
Garry Wang7c00b0f2019-06-25 17:28:17 -07001188 # Remove the lock if the servohost has been locked.
Garry Wang79e9af62019-06-12 15:19:19 -07001189 try:
1190 self._unlock()
1191 except error.AutoservSSHTimeout:
1192 logging.error('Unlock servohost failed due to ssh timeout.'
1193 ' It may caused by servohost went down during'
1194 ' the task.')
Garry Wangc1288cf2019-12-17 14:58:00 -08001195 # We want always stop servod after task to minimum the impact of bad
1196 # servod process interfere other servods.(see crbug.com/1028665)
Garry Wang22f2e842020-09-09 20:19:19 -07001197 if servo_host_ready:
1198 try:
1199 self.stop_servod()
1200 except error.AutoservRunError as e:
1201 logging.info(
1202 "Failed to stop servod due to:\n%s\n"
1203 "This error is forgiven.", str(e))
Garry Wangc1288cf2019-12-17 14:58:00 -08001204
Congbin Guoa1f9cba2018-07-03 11:36:59 -07001205 super(ServoHost, self).close()
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001206 # Mark closed.
1207 self._closed = True
Congbin Guoa1f9cba2018-07-03 11:36:59 -07001208
Otabek Kasimovcc9738e2020-02-14 16:17:15 -08001209 def get_servo_state(self):
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001210 return self._servo_state
Otabek Kasimovcc9738e2020-02-14 16:17:15 -08001211
Otabek Kasimovc6f30412020-06-30 20:08:12 -07001212 def _get_host_metrics_data(self):
1213 return {'port': self.servo_port,
Otabek Kasimov0ea47362020-07-11 20:55:09 -07001214 'host': self.get_dut_hostname() or self.hostname,
Otabek Kasimovc6f30412020-06-30 20:08:12 -07001215 'board': self.servo_board or ''}
1216
1217 def _is_servo_device_connected(self, servo_type, serial):
1218 """Check if device is connected to the labstation.
1219
1220 Works for all servo devices connected to the labstation.
1221 For servo_v3 please use 'self._is_servo_board_present_on_servo_v3'
1222
1223 @param servo_type: The type of servo device. Expecting value can be
1224 servo_v4 or servo_micro.
1225 @param serial: The serial number of the device to detect it.
1226 """
1227 vid_pid = self.SERVO_VID_PID.get(servo_type)
1228 if not vid_pid or not serial:
1229 # device cannot detected without VID/PID or serial number
1230 return False
1231 logging.debug('Started to detect %s', servo_type)
1232 try:
1233 cmd = 'lsusb -v -d %s |grep iSerial |grep %s' % (vid_pid, serial)
1234 result = self.run(cmd, ignore_status=True, timeout=30)
1235 if result.exit_status == 0 and result.stdout.strip():
1236 logging.debug('The %s is plugged in to the host.', servo_type)
1237 return True
1238 logging.debug('%s device is not detected; %s', servo_type, result)
1239 return False
1240 except Exception as e:
1241 # can be triggered by timeout issue due running the script
1242 metrics.Counter(
1243 'chromeos/autotest/repair/servo_detection/timeout'
1244 ).increment(fields=self._get_host_metrics_data())
1245 logging.error('%s device is not detected; %s', servo_type, str(e))
1246 return None
1247
1248 def _is_servo_board_present_on_servo_v3(self):
1249 """Check if servo board is detected on servo_v3"""
1250 vid_pids = self.SERVO_VID_PID['servo_v3']
1251 if not vid_pids or len(vid_pids) == 0:
1252 # device cannot detected without VID/PID
1253 return False
1254 logging.debug('Started to detect servo board on servo_v3')
1255 not_detected = 'The servo board is not detected on servo_v3'
1256 try:
1257 cmd = 'lsusb | grep "%s"' % "\|".join(vid_pids)
1258 result = self.run(cmd, ignore_status=True, timeout=30)
1259 if result.exit_status == 0 and result.stdout.strip():
1260 logging.debug('The servo board is detected on servo_v3')
1261 return True
1262 logging.debug('%s; %s', not_detected, result)
1263 return False
1264 except Exception as e:
1265 # can be triggered by timeout issue due running the script
1266 metrics.Counter(
1267 'chromeos/autotest/repair/servo_detection/timeout'
1268 ).increment(fields=self._get_host_metrics_data())
1269 logging.error('%s; %s', not_detected, str(e))
1270 return None
1271
Otabek Kasimov120b6fa2020-07-03 00:15:27 -07001272 def _is_main_device_not_detected_on_servo_v4(self):
1273 """Check if servod cannot find main device on servo.
1274
1275 The check based on reading servod logs for servo_v4.
1276 """
1277 if not self._initial_instance_ts:
1278 # latest log not found
1279 return False
1280 logging.debug('latest log for servod created at %s',
1281 self._initial_instance_ts)
1282 try:
1283 log_created = calendar.timegm(time.strptime(
1284 self._initial_instance_ts,
1285 "%Y-%m-%d--%H-%M-%S.%f"))
1286 except ValueError as e:
1287 logging.debug('Cannot read time from log file name: %s',
1288 self._initial_instance_ts)
1289 return False
1290 min_time_created = calendar.timegm(time.gmtime())
1291 if min_time_created > log_created + 3600:
1292 # the log file is old we cannot use it
1293 logging.debug('log file was created more than hour ago, too old')
1294 return False
1295 logging.debug('latest log was created not longer then 1 hour ago')
1296
1297 # check if servod can detect main device by servo_v4
1298 message = 'ERROR - No servo micro or CCD detected for board'
1299 cmd = ('cat /var/log/servod_%s/log.%s.INFO |grep "%s"'
1300 % (self.servo_port, self._initial_instance_ts, message))
1301 result = self.run(cmd, ignore_status=True)
1302 if result.stdout.strip():
1303 logging.info('Servod cannot detect main device on the servo; '
1304 'Can be caused by bad hardware of servo or '
1305 'issue on the DUT side.')
1306 return True
1307 logging.debug('The main device is detected')
1308 return False
1309
Garry Wangb5cee3e2020-09-16 14:58:13 -07001310 def _require_cr50_servod_config(self):
1311 """Check whether we need start servod with CONFIG=cr50.xml"""
1312 dut_host_info = self.get_dut_host_info()
1313 if not dut_host_info:
1314 return False
1315 for pool in dut_host_info.pools:
1316 if pool.startswith(servo_constants.CR50_CONFIG_POOL_PREFIX):
1317 return True
1318 return False
1319
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001320 def get_verifier_state(self, tag):
Otabek Kasimov15963492020-06-23 21:10:51 -07001321 """Return the state of servo verifier.
1322
1323 @returns: bool or None
1324 """
1325 return self._repair_strategy.verifier_is_good(tag)
1326
1327 def determine_servo_state(self):
1328 """Determine servo state based on the failed verifier.
1329
1330 @returns: servo state value
1331 The state detecting based on first fail verifier or collecting of
1332 them.
1333 """
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001334 ssh = self.get_verifier_state('servo_ssh')
1335 disk_space = self.get_verifier_state('disk_space')
1336 start_servod = self.get_verifier_state('servod_job')
1337 create_servo = self.get_verifier_state('servod_connection')
1338 init_servo = self.get_verifier_state('servod_control')
1339 dut_connected = self.get_verifier_state('dut_connected')
1340 pwr_button = self.get_verifier_state('pwr_button')
1341 lid_open = self.get_verifier_state('lid_open')
1342 ec_board = self.get_verifier_state('ec_board')
1343 ccd_testlab = self.get_verifier_state('ccd_testlab')
Otabek Kasimov15963492020-06-23 21:10:51 -07001344
1345 if not ssh:
1346 return servo_constants.SERVO_STATE_NO_SSH
1347
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001348 if (start_servod == hosts.VERIFY_FAILED
1349 or create_servo == hosts.VERIFY_FAILED):
Otabek Kasimov066bdb82020-08-12 15:57:44 -07001350 # sometimes servo can start with out present servo
Otabek Kasimovc6f30412020-06-30 20:08:12 -07001351 if self.is_labstation():
1352 if not self.servo_serial:
1353 return servo_constants.SERVO_STATE_WRONG_CONFIG
1354 if self._is_servo_device_connected(
1355 'servo_v4',
1356 self.servo_serial) == False:
1357 return servo_constants.SERVO_STATE_NOT_CONNECTED
1358 elif self._is_servo_board_present_on_servo_v3() == False:
1359 return servo_constants.SERVO_STATE_NOT_CONNECTED
Otabek Kasimov066bdb82020-08-12 15:57:44 -07001360
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001361 if dut_connected == hosts.VERIFY_FAILED:
1362 if pwr_button == hosts.VERIFY_SUCCESS:
Otabek Kasimova7eb4dc2020-09-16 10:25:17 -07001363 # unexpected case
1364 metrics.Counter(
1365 'chromeos/autotest/repair/servo_unexpected/pwr_button'
1366 ).increment(fields=self._get_host_metrics_data())
1367 return servo_constants.SERVO_STATE_DUT_NOT_CONNECTED
1368
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001369 if start_servod == hosts.VERIFY_FAILED:
Otabek Kasimovc6f30412020-06-30 20:08:12 -07001370 return servo_constants.SERVO_STATE_SERVOD_ISSUE
1371
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001372 if create_servo == hosts.VERIFY_FAILED:
Otabek Kasimov120b6fa2020-07-03 00:15:27 -07001373 if (self.is_labstation()
1374 and self._is_main_device_not_detected_on_servo_v4()):
1375 servo_type = None
1376 if self.get_dut_host_info():
1377 servo_type = self.get_dut_host_info().get_label_value(
1378 servo_constants.SERVO_TYPE_LABEL_PREFIX)
1379 if servo_type and 'servo_micro' in servo_type:
1380 serial = self.get_servo_micro_serial_number()
1381 logging.debug('servo_micro serial: %s', serial)
1382 if self._is_servo_device_detected('servo_micro',
1383 serial):
1384 return servo_constants.SERVO_STATE_BAD_RIBBON_CABLE
1385 # Device can be not detected because of DUT
1386 # TODO (otabek) update after b/159755652 and b/159754985
1387 metrics.Counter(
1388 'chromeos/autotest/repair/servo_state/needs_replacement'
1389 ).increment(fields=self._get_host_metrics_data())
1390 elif not self.is_labstation():
1391 # Here need logic to check if flex cable is connected
1392 pass
1393
Otabek Kasimov15963492020-06-23 21:10:51 -07001394 # one of the reason why servo can not initialized
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001395 if ccd_testlab == hosts.VERIFY_FAILED:
Otabek Kasimov15963492020-06-23 21:10:51 -07001396 return servo_constants.SERVO_STATE_CCD_TESTLAB_ISSUE
1397
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001398 if (create_servo == hosts.VERIFY_FAILED
1399 or init_servo == hosts.VERIFY_FAILED):
Otabek Kasimov15963492020-06-23 21:10:51 -07001400 return servo_constants.SERVO_STATE_SERVOD_ISSUE
1401
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001402 if ec_board == hosts.VERIFY_FAILED:
Otabek Kasimov015c15c2020-08-20 00:40:42 -07001403 return servo_constants.SERVO_STATE_EC_BROKEN
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001404 if pwr_button == hosts.VERIFY_FAILED:
Otabek Kasimov15963492020-06-23 21:10:51 -07001405 return servo_constants.SERVO_STATE_BAD_RIBBON_CABLE
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001406 if lid_open == hosts.VERIFY_FAILED:
Otabek Kasimov15963492020-06-23 21:10:51 -07001407 return servo_constants.SERVO_STATE_LID_OPEN_FAILED
Otabek Kasimov15963492020-06-23 21:10:51 -07001408
Otabek Kasimov15963492020-06-23 21:10:51 -07001409 metrics.Counter(
1410 'chromeos/autotest/repair/unknown_servo_state'
Otabek Kasimovc6f30412020-06-30 20:08:12 -07001411 ).increment(fields=self._get_host_metrics_data())
Otabek Kasimov15963492020-06-23 21:10:51 -07001412 logging.info('We do not have special state for this failure yet :)')
1413 return servo_constants.SERVO_STATE_BROKEN
1414
Otabek Kasimovcc9738e2020-02-14 16:17:15 -08001415
Richard Barnetteea3e4602016-06-10 12:36:41 -07001416def make_servo_hostname(dut_hostname):
1417 """Given a DUT's hostname, return the hostname of its servo.
1418
1419 @param dut_hostname: hostname of a DUT.
1420
1421 @return hostname of the DUT's servo.
1422
1423 """
1424 host_parts = dut_hostname.split('.')
1425 host_parts[0] = host_parts[0] + '-servo'
1426 return '.'.join(host_parts)
1427
1428
1429def servo_host_is_up(servo_hostname):
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -07001430 """Given a servo host name, return if it's up or not.
Richard Barnetteea3e4602016-06-10 12:36:41 -07001431
1432 @param servo_hostname: hostname of the servo host.
1433
1434 @return True if it's up, False otherwise
1435 """
1436 # Technically, this duplicates the SSH ping done early in the servo
1437 # proxy initialization code. However, this ping ends in a couple
1438 # seconds when if fails, rather than the 60 seconds it takes to decide
1439 # that an SSH ping has timed out. Specifically, that timeout happens
1440 # when our servo DNS name resolves, but there is no host at that IP.
1441 logging.info('Pinging servo host at %s', servo_hostname)
1442 ping_config = ping_runner.PingConfig(
1443 servo_hostname, count=3,
1444 ignore_result=True, ignore_status=True)
1445 return ping_runner.PingRunner().ping(ping_config).received > 0
1446
1447
Richard Barnettee519dcd2016-08-15 17:37:17 -07001448def _map_afe_board_to_servo_board(afe_board):
1449 """Map a board we get from the AFE to a servo appropriate value.
1450
1451 Many boards are identical to other boards for servo's purposes.
1452 This function makes that mapping.
1453
1454 @param afe_board string board name received from AFE.
1455 @return board we expect servo to have.
1456
1457 """
1458 KNOWN_SUFFIXES = ['-freon', '_freon', '_moblab', '-cheets']
1459 BOARD_MAP = {'gizmo': 'panther'}
1460 mapped_board = afe_board
1461 if afe_board in BOARD_MAP:
1462 mapped_board = BOARD_MAP[afe_board]
1463 else:
1464 for suffix in KNOWN_SUFFIXES:
1465 if afe_board.endswith(suffix):
1466 mapped_board = afe_board[0:-len(suffix)]
1467 break
1468 if mapped_board != afe_board:
1469 logging.info('Mapping AFE board=%s to %s', afe_board, mapped_board)
1470 return mapped_board
1471
1472
Prathmesh Prabhub4810232018-09-07 13:24:08 -07001473def get_servo_args_for_host(dut_host):
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -07001474 """Return servo data associated with a given DUT.
Richard Barnetteea3e4602016-06-10 12:36:41 -07001475
Richard Barnetteea3e4602016-06-10 12:36:41 -07001476 @param dut_host Instance of `Host` on which to find the servo
1477 attributes.
Prathmesh Prabhuf605dd32018-08-28 17:09:04 -07001478 @return `servo_args` dict with host and an optional port.
Richard Barnetteea3e4602016-06-10 12:36:41 -07001479 """
Prathmesh Prabhucba44292018-08-28 17:44:45 -07001480 info = dut_host.host_info_store.get()
Derek Beckettf73baca2020-08-19 15:08:47 -07001481 servo_args = {k: v for k, v in six.iteritems(info.attributes)
Garry Wang11b5e872020-03-11 15:14:08 -07001482 if k in servo_constants.SERVO_ATTR_KEYS}
Richard Barnetteea3e4602016-06-10 12:36:41 -07001483
Garry Wang11b5e872020-03-11 15:14:08 -07001484 if servo_constants.SERVO_PORT_ATTR in servo_args:
Prathmesh Prabhucba44292018-08-28 17:44:45 -07001485 try:
Garry Wang11b5e872020-03-11 15:14:08 -07001486 servo_args[servo_constants.SERVO_PORT_ATTR] = int(
1487 servo_args[servo_constants.SERVO_PORT_ATTR])
Prathmesh Prabhucba44292018-08-28 17:44:45 -07001488 except ValueError:
1489 logging.error('servo port is not an int: %s',
Garry Wang11b5e872020-03-11 15:14:08 -07001490 servo_args[servo_constants.SERVO_PORT_ATTR])
Prathmesh Prabhucba44292018-08-28 17:44:45 -07001491 # Reset servo_args because we don't want to use an invalid port.
Garry Wang11b5e872020-03-11 15:14:08 -07001492 servo_args.pop(servo_constants.SERVO_HOST_ATTR, None)
Prathmesh Prabhucba44292018-08-28 17:44:45 -07001493
1494 if info.board:
Garry Wang11b5e872020-03-11 15:14:08 -07001495 servo_board = _map_afe_board_to_servo_board(info.board)
1496 servo_args[servo_constants.SERVO_BOARD_ATTR] = servo_board
Nick Sanders2f3c9852018-10-24 12:10:24 -07001497 if info.model:
Garry Wang11b5e872020-03-11 15:14:08 -07001498 servo_args[servo_constants.SERVO_MODEL_ATTR] = info.model
1499 return servo_args if servo_constants.SERVO_HOST_ATTR in servo_args else None
Richard Barnetteea3e4602016-06-10 12:36:41 -07001500
1501
Prathmesh Prabhuefb1b482018-08-28 17:15:05 -07001502def _tweak_args_for_ssp_moblab(servo_args):
Garry Wang11b5e872020-03-11 15:14:08 -07001503 if (servo_args[servo_constants.SERVO_HOST_ATTR]
1504 in ['localhost', '127.0.0.1']):
1505 servo_args[servo_constants.SERVO_HOST_ATTR] = _CONFIG.get_config_value(
Prathmesh Prabhuefb1b482018-08-28 17:15:05 -07001506 'SSP', 'host_container_ip', type=str, default=None)
1507
1508
Dan Shi023aae32016-05-25 11:13:01 -07001509def create_servo_host(dut, servo_args, try_lab_servo=False,
Gregory Nisbetde13e2a2019-12-09 22:44:00 -08001510 try_servo_repair=False, dut_host_info=None):
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -07001511 """Create a ServoHost object for a given DUT, if appropriate.
Dan Shi4d478522014-02-14 13:46:32 -08001512
Richard Barnette9a26ad62016-06-10 12:03:08 -07001513 This function attempts to create and verify or repair a `ServoHost`
1514 object for a servo connected to the given `dut`, subject to various
1515 constraints imposed by the parameters:
1516 * When the `servo_args` parameter is not `None`, a servo
1517 host must be created, and must be checked with `repair()`.
1518 * Otherwise, if a servo exists in the lab and `try_lab_servo` is
1519 true:
1520 * If `try_servo_repair` is true, then create a servo host and
1521 check it with `repair()`.
1522 * Otherwise, if the servo responds to `ping` then create a
1523 servo host and check it with `verify()`.
Fang Denge545abb2014-12-30 18:43:47 -08001524
Richard Barnette9a26ad62016-06-10 12:03:08 -07001525 In cases where `servo_args` was not `None`, repair failure
1526 exceptions are passed back to the caller; otherwise, exceptions
Richard Barnette07c2e1d2016-10-26 14:24:28 -07001527 are logged and then discarded. Note that this only happens in cases
1528 where we're called from a test (not special task) control file that
1529 has an explicit dependency on servo. In that case, we require that
1530 repair not write to `status.log`, so as to avoid polluting test
1531 results.
1532
1533 TODO(jrbarnette): The special handling for servo in test control
1534 files is a thorn in my flesh; I dearly hope to see it cut out before
1535 my retirement.
Richard Barnette9a26ad62016-06-10 12:03:08 -07001536
1537 Parameters for a servo host consist of a host name, port number, and
1538 DUT board, and are determined from one of these sources, in order of
1539 priority:
Richard Barnetteea3e4602016-06-10 12:36:41 -07001540 * Servo attributes from the `dut` parameter take precedence over
1541 all other sources of information.
1542 * If a DNS entry for the servo based on the DUT hostname exists in
1543 the CrOS lab network, that hostname is used with the default
Richard Barnette9a26ad62016-06-10 12:03:08 -07001544 port and the DUT's board.
Richard Barnetteea3e4602016-06-10 12:36:41 -07001545 * If no other options are found, the parameters will be taken
Richard Barnette9a26ad62016-06-10 12:03:08 -07001546 from the `servo_args` dict passed in from the caller.
Richard Barnetteea3e4602016-06-10 12:36:41 -07001547
1548 @param dut An instance of `Host` from which to take
1549 servo parameters (if available).
1550 @param servo_args A dictionary with servo parameters to use if
1551 they can't be found from `dut`. If this
1552 argument is supplied, unrepaired exceptions
1553 from `verify()` will be passed back to the
1554 caller.
1555 @param try_lab_servo If not true, servo host creation will be
1556 skipped unless otherwise required by the
1557 caller.
Richard Barnette9a26ad62016-06-10 12:03:08 -07001558 @param try_servo_repair If true, check a servo host with
1559 `repair()` instead of `verify()`.
Otabek Kasimov8475cce2020-07-14 12:11:31 -07001560 @param dut_host_info: A HostInfo object of the DUT that connected
1561 to this servo.
Dan Shi4d478522014-02-14 13:46:32 -08001562
1563 @returns: A ServoHost object or None. See comments above.
1564
1565 """
Richard Barnette07c2e1d2016-10-26 14:24:28 -07001566 servo_dependency = servo_args is not None
Richard Barnette07c2e1d2016-10-26 14:24:28 -07001567 if dut is not None and (try_lab_servo or servo_dependency):
Prathmesh Prabhub4810232018-09-07 13:24:08 -07001568 servo_args_override = get_servo_args_for_host(dut)
Richard Barnetteea3e4602016-06-10 12:36:41 -07001569 if servo_args_override is not None:
Prathmesh Prabhuefb1b482018-08-28 17:15:05 -07001570 if utils.in_moblab_ssp():
1571 _tweak_args_for_ssp_moblab(servo_args_override)
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001572 logging.debug(
1573 'Overriding provided servo_args (%s) with arguments'
1574 ' determined from the host (%s)',
1575 servo_args,
1576 servo_args_override,
1577 )
Richard Barnetteea3e4602016-06-10 12:36:41 -07001578 servo_args = servo_args_override
Prathmesh Prabhucba44292018-08-28 17:44:45 -07001579
Richard Barnetteea3e4602016-06-10 12:36:41 -07001580 if servo_args is None:
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001581 logging.debug('No servo_args provided, and failed to find overrides.')
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001582 if try_lab_servo or servo_dependency:
Otabek Kasimov646812c2020-06-23 20:01:36 -07001583 return None, servo_constants.SERVO_STATE_MISSING_CONFIG
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001584 else:
1585 # For regular test case which not required the servo
1586 return None, None
1587
Garry Wang11b5e872020-03-11 15:14:08 -07001588 servo_hostname = servo_args.get(servo_constants.SERVO_HOST_ATTR)
1589 servo_port = servo_args.get(servo_constants.SERVO_PORT_ATTR)
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001590 if not _is_servo_host_information_exist(servo_hostname, servo_port):
1591 logging.debug(
1592 'Servo connection info missed hostname: %s , port: %s',
1593 servo_hostname, servo_port)
Otabek Kasimov646812c2020-06-23 20:01:36 -07001594 return None, servo_constants.SERVO_STATE_MISSING_CONFIG
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001595 if not is_servo_host_information_valid(servo_hostname, servo_port):
1596 logging.debug(
1597 'Servo connection info is incorrect hostname: %s , port: %s',
1598 servo_hostname, servo_port)
Garry Wang11b5e872020-03-11 15:14:08 -07001599 return None, servo_constants.SERVO_STATE_WRONG_CONFIG
Richard Barnette07c2e1d2016-10-26 14:24:28 -07001600 if (not servo_dependency and not try_servo_repair and
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001601 not servo_host_is_up(servo_hostname)):
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001602 logging.debug('ServoHost is not up.')
Otabek Kasimov646812c2020-06-23 20:01:36 -07001603 return None, servo_constants.SERVO_STATE_NO_SSH
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001604
Garry Wangebc015b2019-06-06 17:45:06 -07001605 newhost = ServoHost(**servo_args)
Garry Wangffbd2162020-04-17 16:13:48 -07001606
Otabek Kasimove6df8102020-07-21 20:15:25 -07001607 # Reset or reboot servo device only during AdminRepair tasks.
1608 if try_servo_repair:
1609 if newhost._is_locked:
1610 # Reset servo if the servo is locked, as we check if the servohost
1611 # is up, if the servohost is labstation and if the servohost is in
1612 # lab inside the locking logic.
1613 newhost.reset_servo()
1614 else:
Garry Wang358aad42020-08-02 20:56:04 -07001615 try:
1616 newhost.reboot_servo_v3_on_need()
Garry Wang1f0d5332020-08-10 19:32:32 -07001617 except Exception as e:
1618 logging.info('[Non-critical] Unexpected error while trying to'
1619 ' reboot servo_v3, skipping the reboot; %s', e)
Otabek Kasimove6df8102020-07-21 20:15:25 -07001620
Otabek Kasimov2b50cdb2020-07-06 19:16:06 -07001621 if dut:
1622 newhost.set_dut_hostname(dut.hostname)
Otabek Kasimov9e90ae12020-08-14 03:01:19 -07001623 if dut_host_info:
1624 newhost.set_dut_host_info(dut_host_info)
Garry Wangffbd2162020-04-17 16:13:48 -07001625
Otabek Kasimov8475cce2020-07-14 12:11:31 -07001626 if try_lab_servo or try_servo_repair:
1627 try:
1628 logging.info("Check and update servo firmware.")
1629 servo_updater.update_servo_firmware(
1630 newhost,
1631 force_update=False)
1632 except Exception as e:
1633 logging.error("Servo device update error: %s", e)
1634
Garry Wangcdd27b22020-01-13 14:59:11 -08001635 try:
1636 newhost.restart_servod(quick_startup=True)
1637 except error.AutoservSSHTimeout:
1638 logging.warning("Restart servod failed due ssh connection "
1639 "to servohost timed out. This error is forgiven"
1640 " here, we will retry in servo repair process.")
1641 except error.AutoservRunError as e:
1642 logging.warning("Restart servod failed due to:\n%s\n"
1643 "This error is forgiven here, we will retry"
1644 " in servo repair process.", str(e))
Garry Wangebc015b2019-06-06 17:45:06 -07001645
Richard Barnette9a26ad62016-06-10 12:03:08 -07001646 # Note that the logic of repair() includes everything done
1647 # by verify(). It's sufficient to call one or the other;
1648 # we don't need both.
Richard Barnette07c2e1d2016-10-26 14:24:28 -07001649 if servo_dependency:
1650 newhost.repair(silent=True)
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001651 return newhost, newhost.get_servo_state()
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001652
1653 if try_servo_repair:
1654 try:
1655 newhost.repair()
1656 except Exception:
1657 logging.exception('servo repair failed for %s', newhost.hostname)
Richard Barnette9a26ad62016-06-10 12:03:08 -07001658 else:
1659 try:
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001660 newhost.verify()
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -07001661 except Exception:
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001662 logging.exception('servo verify failed for %s', newhost.hostname)
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001663 return newhost, newhost.get_servo_state()
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001664
1665
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001666def _is_servo_host_information_exist(hostname, port):
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001667 if hostname is None or len(hostname.strip()) == 0:
1668 return False
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001669 if port is None:
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001670 return False
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001671 if not type(port) is int:
1672 try:
1673 int(port)
1674 except ValueError:
1675 return False
1676
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001677 return True
1678
1679
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001680def is_servo_host_information_valid(hostname, port):
Garry Wang9b8f2342020-04-17 16:34:09 -07001681 """Check if provided servo attributes are valid.
1682
1683 @param hostname Hostname of the servohost.
1684 @param port servo port number.
1685
1686 @returns: A bool value to indicate if provided servo attribute valid.
1687 """
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001688 if not _is_servo_host_information_exist(hostname, port):
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001689 return False
1690 # checking range and correct of the port
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001691 port_int = int(port)
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001692 if port_int < 1 or port_int > 65000:
1693 return False
1694 # we expecting host contain only latters, digits and '-' or '_'
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001695 if not re.match('[a-zA-Z0-9-_\.]*$', hostname) or len(hostname) < 5:
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001696 return False
1697 return True